Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-26 Thread Qiang Ma
On Tue, 26 Mar 2024 23:51:45 -0400 Alex Deucher wrote: > On Tue, Mar 26, 2024 at 11:41 PM Qiang Ma > wrote: > > > > On Thu, 14 Mar 2024 14:40:40 + > > "Deucher, Alexander" wrote: > > > > > [Public] > > > > > > > -Original Message- > > > > From: Qiang Ma > > > > Sent:

Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 11:41 PM Qiang Ma wrote: > > On Thu, 14 Mar 2024 14:40:40 + > "Deucher, Alexander" wrote: > > > [Public] > > > > > -Original Message- > > > From: Qiang Ma > > > Sent: Wednesday, March 13, 2024 2:18 AM > > > To: Deucher, Alexander ; Koenig, > > > Christian ;

Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-26 Thread Qiang Ma
On Thu, 14 Mar 2024 14:40:40 + "Deucher, Alexander" wrote: > [Public] > > > -Original Message- > > From: Qiang Ma > > Sent: Wednesday, March 13, 2024 2:18 AM > > To: Deucher, Alexander ; Koenig, > > Christian ; Pan, Xinhui > > ; airl...@gmail.com; dan...@ffwll.ch; > > SHANMUGAM,

Re: [PATCH 07/11] drm/dp: Add drm_dp_uhbr_channel_coding_supported()

2024-03-26 Thread Manasi Navare
Reviewed-by: Manasi Navare Manasi On Tue, Mar 26, 2024 at 5:54 AM Nautiyal, Ankit K wrote: > > > On 3/21/2024 1:41 AM, Imre Deak wrote: > > Factor out a function to check for UHBR channel coding support used by a > > follow-up patch in the patchset. > > > > Cc: dri-devel@lists.freedesktop.org

Re: [PATCH v2] Fix duplicate C declaration warnings

2024-03-26 Thread Donald Hunter
Akira Yokosawa writes: > > That message of mine just pointed out that the Sphinx bug of false > duplicate C declaration warning first reported by Mauro (+CC'd) at: > https://github.com/sphinx-doc/sphinx/issues/8241 -- > "C domain issues when building the Linux Kernel documentation". > It had not

Re: [PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

2024-03-26 Thread Manasi Navare
Hi Imre, Thanks for the DSC fixes. Would the line buf depth calculation that was getting set to 0 impact DSC on all platforms or was this issue only specific to MTL and was getting set correctly with older platforms? We didnt notice any DSC issues/corruptions with ADL based systems. The actual

Re: [PATCH 0/9] enabled -Wformat-truncation for clang

2024-03-26 Thread Jakub Kicinski
On Tue, 26 Mar 2024 23:37:59 +0100 Arnd Bergmann wrote: > I hope that the patches can get picked up by platform maintainers > directly, so the final patch can go in later on. platform == subsystem? :)

Re: [RFC PATCH net-next v7 13/14] net: add devmem TCP documentation

2024-03-26 Thread Randy Dunlap
Hi, On 3/26/24 15:50, Mina Almasry wrote: > Add documentation outlining the usage and details of devmem TCP. > > Signed-off-by: Mina Almasry > > --- > > v7: > - Applied docs suggestions (Jakub). > > v2: > > - Missing spdx (simon) > - add to index.rst (simon) > > --- >

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 01:49, Abhinav Kumar wrote: > > > > On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > > Generate DRM/MSM headers on the fly during kernel build. This removes a > > need to push register changes to Mesa with the following manual > > synchronization step. Existing headers will

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 00:34, Abhinav Kumar wrote: > > > > On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > >>> Import the gen_headers.py script from Mesa, commit FIXME.

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-26 Thread Abhinav Kumar
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease reviews).

Re: [PATCH v6 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-26 Thread Andi Shyti
Hi Matt, On Tue, Mar 26, 2024 at 02:30:33PM -0700, Matt Roper wrote: > On Tue, Mar 26, 2024 at 07:42:34PM +0100, Andi Shyti wrote: > > On Tue, Mar 26, 2024 at 09:03:10AM -0700, Matt Roper wrote: > > > On Wed, Mar 13, 2024 at 09:19:50PM +0100, Andi Shyti wrote: > > > > + /* >

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Andrew Jeffery
On Tue, 2024-03-26 at 15:47 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-26 Thread Nathan Chancellor
On Tue, Mar 05, 2024 at 11:07:36AM +0200, Jani Nikula wrote: > Add kconfig to enable -Werror subsystem wide. This is useful for > development and CI to keep the subsystem warning free, while avoiding > issues outside of the subsystem that kernel wide CONFIG_WERROR=y might > hit. > > v2: Don't

[RFC PATCH net-next v7 04/14] netdev: support binding dma-buf to netdevice

2024-03-26 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a

[RFC PATCH net-next v7 11/14] tcp: RX path for devmem TCP

2024-03-26 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a

[RFC PATCH net-next v7 12/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-03-26 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry ---

[RFC PATCH net-next v7 09/14] net: support non paged skb frags

2024-03-26 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry --- v6: - Rebased on top of the merged netmem changes. Changes in v1: - Fix illegal_highdma() (Yunsheng). - Rework napi_pp_put_page()

[RFC PATCH net-next v7 07/14] page_pool: devmem support

2024-03-26 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long

[RFC PATCH net-next v7 10/14] net: add support for skbs with unreadable frags

2024-03-26 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[RFC PATCH net-next v7 14/14] selftests: add ncdevmem, netcat for devmem TCP

2024-03-26 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support,

[RFC PATCH net-next v7 13/14] net: add devmem TCP documentation

2024-03-26 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry --- v7: - Applied docs suggestions (Jakub). v2: - Missing spdx (simon) - add to index.rst (simon) --- Documentation/networking/devmem.rst | 256

[RFC PATCH net-next v7 03/14] net: netdev netlink api to bind dma-buf to a net device

2024-03-26 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v7: - Use flags: [ admin-perm ] instead of a CAP_NET_ADMIN check. Changes in v1: - Add rx-queue-type

[RFC PATCH net-next v7 08/14] memory-provider: dmabuf devmem memory provider

2024-03-26 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the

[RFC PATCH net-next v7 05/14] netdev: netdevice devmem allocator

2024-03-26 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[RFC PATCH net-next v7 06/14] page_pool: convert to use netmem

2024-03-26 Thread Mina Almasry
Abstrace the memory type from the page_pool so we can later add support for new memory types. Convert the page_pool to use the new netmem type abstraction, rather than use struct page directly. As of this patch the netmem type is a no-op abstraction: it's always a struct page underneath. All the

[RFC PATCH net-next v7 02/14] net: page_pool: create hooks for custom page providers

2024-03-26 Thread Mina Almasry
From: Jakub Kicinski The page providers which try to reuse the same pages will need to hold onto the ref, even if page gets released from the pool - as in releasing the page from the pp just transfers the "ownership" reference from pp to the provider, and provider will wait for other references

[RFC PATCH net-next v7 01/14] queue_api: define queue api

2024-03-26 Thread Mina Almasry
This API enables the net stack to reset the queues used for devmem TCP. Signed-off-by: Mina Almasry --- include/linux/netdevice.h | 3 +++ include/net/netdev_queues.h | 27 +++ 2 files changed, 30 insertions(+) diff --git a/include/linux/netdevice.h

[RFC PATCH net-next v7 00/14] Device Memory TCP

2024-03-26 Thread Mina Almasry
RFC v7: === Major Changes: -- This revision largely rebases on top of net-next and addresses the feedback RFCv6 received from folks, namely Jakub, Yunsheng, Arnd, David, & Pavel. The series remains in RFC because the queue-API ndos defined in this series are not yet implemented.

Re: [PATCH 1/9] fbdev: shmobile: fix snprintf truncation

2024-03-26 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Tue, Mar 26, 2024 at 11:38:00PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The name of the overlay does not fit into the fixed-length field: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always > be truncated;

[PATCH 1/9] fbdev: shmobile: fix snprintf truncation

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann The name of the overlay does not fit into the fixed-length field: drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 Make it short enough by changing the string. Fixes:

[PATCH 0/9] enabled -Wformat-truncation for clang

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann With randconfig build testing, I found only eight files that produce warnings with clang when -Wformat-truncation is enabled. This means we can just turn it on by default rather than only enabling it for "make W=1". Unfortunately, gcc produces a lot more warnings when the

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Abhinav Kumar
On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote: On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote: On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation.

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote: > > > > On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > > Import the gen_headers.py script from Mesa, commit FIXME. This script > > will be used to generate MSM register files on the fly during > > compilation. > > > > Signed-off-by: Dmitry

Re: [PATCH v4 01/16] drm/msm/mdp5: add writeback block bases

2024-03-26 Thread Abhinav Kumar
On 3/26/2024 2:52 PM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote: On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch.

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Abhinav Kumar
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_header.py | 957

Re: [PATCH v4 01/16] drm/msm/mdp5: add writeback block bases

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote: > > > > On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: > > In order to stop patching the mdp5 headers, import definitions for the > > writeback blocks. This part is extracted from the old Rob's patch. > > > > Co-developed-by: Rob Clark > >

Re: [PATCH v4 03/16] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-26 Thread Abhinav Kumar
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v4 02/16] drm/msm/hdmi: drop qfprom.xml.h

2024-03-26 Thread Abhinav Kumar
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov

Re: [PATCH v4 01/16] drm/msm/mdp5: add writeback block bases

2024-03-26 Thread Abhinav Kumar
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov ---

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
On Tue, Mar 26, 2024 at 8:56 PM Abhinav Kumar wrote: > > Alright, in that case, Miguel can you please repost this with the Fixes > tags and in a patch form. Done at https://lore.kernel.org/lkml/20240326212324.185832-1-oj...@kernel.org/ Thanks all! Cheers, Miguel

Re: [PATCH v6 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-26 Thread Matt Roper
On Tue, Mar 26, 2024 at 07:42:34PM +0100, Andi Shyti wrote: > Hi Matt, > > On Tue, Mar 26, 2024 at 09:03:10AM -0700, Matt Roper wrote: > > On Wed, Mar 13, 2024 at 09:19:50PM +0100, Andi Shyti wrote: > > > + /* > > > + * Do not create the command streamer for CCS

[PATCH] drm/msm: fix the `CRASHDUMP_READ` target of `a6xx_get_shader_block()`

2024-03-26 Thread Miguel Ojeda
Clang 14 in an (essentially) defconfig arm64 build for next-20240326 reports [1]: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] The variable `out` in these functions is meant to compute the `target

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Arnd Bergmann
On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: > On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> From: Arnd Bergmann >> index 475e1e8c1d35..0786eb0da391 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -50,7 +50,7 @@ >> * the macros

Re: [PATCH 3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

2024-03-26 Thread Konrad Dybcio
On 26.03.2024 9:02 PM, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Fixes: 494dec9b6f54 ("arm64: dts: qcom:

Re: [PATCH 2/4] arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells

2024-03-26 Thread Konrad Dybcio
On 26.03.2024 9:02 PM, Dmitry Baryshkov wrote: > The property #stream-id-cells is legacy, it is not documented as valid > for the GPU. Drop it now. > > Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio

Re: [PATCH 2/5] dt-bindings: display: Add GameForce Chi Panel

2024-03-26 Thread Rob Herring
On Mon, 25 Mar 2024 08:49:56 -0500, Chris Morgan wrote: > From: Chris Morgan > > The GameForce Chi panel is a panel specific to the GameForce Chi > handheld device that measures 3.5" diagonally with a resolution of > 640x480. > > Signed-off-by: Chris Morgan > --- >

Re: [PATCH 1/5] dt-bindings: vendor-prefix: Add prefix for GameForce

2024-03-26 Thread Rob Herring
On Mon, 25 Mar 2024 08:49:55 -0500, Chris Morgan wrote: > From: Chris Morgan > > GameForce is a company that produces handheld game consoles. > > https://gameforce.fun/ > > Signed-off-by: Chris Morgan > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed,

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Jani Nikula
On Tue, 26 Mar 2024, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default > and we have

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-26 Thread Mina Almasry
On Sun, Mar 24, 2024 at 4:37 PM Christoph Hellwig wrote: > > On Fri, Mar 22, 2024 at 10:54:54AM -0700, Mina Almasry wrote: > > Sorry I don't mean to argue but as David mentioned, there are some > > plans in the works and ones not in the works to extend this to other > > memory types. David

Re: [RFC PATCH net-next v6 00/15] Device Memory TCP

2024-03-26 Thread Mina Almasry
On Tue, Mar 26, 2024 at 5:47 AM Yunsheng Lin wrote: > > On 2024/3/26 8:28, Mina Almasry wrote: > > On Tue, Mar 5, 2024 at 11:38 AM Mina Almasry wrote: > >> > >> On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote: > >>> > >>> On 2024/3/5 10:01, Mina Almasry wrote: > >>> > >>> ... > >>> > >

Re: [PATCH] drm: DRM_WERROR should depend on DRM

2024-03-26 Thread Jani Nikula
On Tue, 26 Mar 2024, Geert Uytterhoeven wrote: > There is no point in asking the user about enforcing the DRM compiler > warning policy when configuring a kernel without DRM support. > > Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR") > Signed-off-by: Geert Uytterhoeven D'oh! My bad.

[RFC PATCH 1/1] dt-bindings: display/msm: gpu: Split Adreno schemas into separate files

2024-03-26 Thread Adam Skladowski
Split shared schema into per-gen and group adrenos by clocks used. Signed-off-by: Adam Skladowski --- .../devicetree/bindings/display/msm/gpu.yaml | 317 ++ .../bindings/display/msm/qcom,adreno-306.yaml | 115 +++ .../bindings/display/msm/qcom,adreno-330.yaml | 111 ++

[RFC PATCH 0/1] Split Adreno schemas

2024-03-26 Thread Adam Skladowski
Following recommendation from Dmitry Baryshkov this series split schema into separate schemas per gpu family, as i don't really understand much of yamls and dt-schema i decided to send this as RFC and if there are any changes suggested i will be glad if these can be explained to me in ELI5 format.

[PATCH 4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes

2024-03-26 Thread Dmitry Baryshkov
DisplayPort nodes must declare the dp_p1 register space in addition to dp_p0. Add corresponding resource to DisplayPort DT nodes. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-26 Thread Dmitry Baryshkov
As Qualcomm SM8150 got support for the DisplayPort, add displayport@ node as a valid child to the MDSS node. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

2024-03-26 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Dmitry

[PATCH 2/4] arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells

2024-03-26 Thread Dmitry Baryshkov
The property #stream-id-cells is legacy, it is not documented as valid for the GPU. Drop it now. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 0/4] arm64: dts: fix several display-related schema warnings

2024-03-26 Thread Dmitry Baryshkov
: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 change-id: 20240326-fd-fix-schema-b91f94a95135 Best regards, -- Dmitry Baryshkov

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Abhinav Kumar
On 3/26/2024 12:47 PM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote: On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote: On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 20:05, Miguel

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Connor Abbott
On Tue, Mar 26, 2024 at 7:47 PM Dmitry Baryshkov wrote: > > On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote: > > > > > > > > On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: > > > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar > > > wrote: > > >> > > >> > > >> > > >> On 3/26/2024 11:19 AM, Dmitry

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote: > > > > On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: > > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: > >>> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda > >>> wrote:

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Abhinav Kumar
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote: On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda wrote: Hi, In today's next, I got: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6:

Re: [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

2024-03-26 Thread Heiko Stübner
Am Dienstag, 26. März 2024, 18:50:37 CET schrieb Krzysztof Kozlowski: > On 26/03/2024 18:50, Krzysztof Kozlowski wrote: > > On 26/03/2024 18:28, Heiko Stuebner wrote: > >> The #sound-dai-cells DT property is required to describe link between > >> the HDMI IP block and the SoC's audio subsystem. >

Re: [PATCH v4 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-26 Thread Bjorn Andersson
On Sun, Mar 24, 2024 at 08:56:52PM +0200, Abel Vesa wrote: > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set based on the presence of the panel node in DT. > > Reviewed-by: Dmitry Baryshkov >

Re: [PATCH v4 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-26 Thread Bjorn Andersson
On Sun, Mar 24, 2024 at 08:56:51PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP doesn't have > a panel described in DT,

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote: > > > > On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: > > On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda > > wrote: > >> > >> Hi, > >> > >> In today's next, I got: > >> > >> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable >

Re: [PATCH v6 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-26 Thread Andi Shyti
Hi Matt, On Tue, Mar 26, 2024 at 09:03:10AM -0700, Matt Roper wrote: > On Wed, Mar 13, 2024 at 09:19:50PM +0100, Andi Shyti wrote: > > + /* > > +* Do not create the command streamer for CCS slices > > +* beyond the first. All the workload

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
On Tue, Mar 26, 2024 at 7:31 PM Abhinav Kumar wrote: > > This should be fixed with https://patchwork.freedesktop.org/patch/581853/. Ah, so in that case the `CRASHDUMP_READ` target should really be constant, unlike in other cases in that file? > We can pickup that one with a Fixes tag applied.

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Abhinav Kumar
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda wrote: Hi, In today's next, I got: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] `out` seems to be there since

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda wrote: > > Hi, > > In today's next, I got: > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable > 'out' set but not used [-Werror,-Wunused-but-set-variable] > > `out` seems to be there since commit 64d6255650d4 ("drm/msm: More >

Re: Build regressions/improvements in v6.9-rc1

2024-03-26 Thread Sam Ravnborg
Hi all. > + error: arch/sparc/kernel/process_32.o: relocation truncated to fit: > R_SPARC_WDISP22 against `.text': => (.fixup+0xc), (.fixup+0x4) > + error: arch/sparc/kernel/signal_32.o: relocation truncated to fit: > R_SPARC_WDISP22 against `.text': => (.fixup+0x18), (.fixup+0x8), >

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-26 Thread Matthew Auld
On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages

drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable 'count' set but not used

2024-03-26 Thread Miguel Ojeda
Hi, In today's next, I got: drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable] `count` seems to be there since commit f64122c1f6ad ("drm: add new QXL driver. (v1.4)"). Untested diff below -- if you want a formal patch, please

drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
Hi, In today's next, I got: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] `out` seems to be there since commit 64d6255650d4 ("drm/msm: More fully implement devcoredump for a7xx"). Untested diff below assuming

Re: Library and interfaces for GPU offloading

2024-03-26 Thread Werner Sembach
Am 25.03.24 um 11:41 schrieb Werner Sembach: Hello everyone, currently GPU offloading on Linux is handled via environment variables. Which is a subpar experience for desktop files and might not be possible when using launchers (i.e. Steam, Lutris, Heroic, etc.) that have no explicit support

Re: [PATCH 0/2] drm/fourcc.h: Add libcamera to Open Source Waiver

2024-03-26 Thread Kieran Bingham
Quoting Jacopo Mondi (2024-03-14 10:12:47) > Hello > > gentle nudge for > > *) libcamera: are we ok being listed here ? I think it's fine ... Acked-by: Kieran Bingham > *) DRM/KMS: is it ok splitting the list of projects in the way I've >done ? > > Thanks >j > > On Wed, Feb 28,

Re: [PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The dp_audio read and write operations uses members in struct dp_catalog > for passing arguments and return values. This adds unnecessary > complexity to the implementation, as it turns out after detangling the >

Re: [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

2024-03-26 Thread Krzysztof Kozlowski
On 26/03/2024 18:50, Krzysztof Kozlowski wrote: > On 26/03/2024 18:28, Heiko Stuebner wrote: >> The #sound-dai-cells DT property is required to describe link between >> the HDMI IP block and the SoC's audio subsystem. >> >> Signed-off-by: Heiko Stuebner >> --- >>

Re: [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

2024-03-26 Thread Krzysztof Kozlowski
On 26/03/2024 18:28, Heiko Stuebner wrote: > The #sound-dai-cells DT property is required to describe link between > the HDMI IP block and the SoC's audio subsystem. > > Signed-off-by: Heiko Stuebner > --- > .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 3 +++ > 1 file

Re: [PATCH v9 3/3] drm/tests: Add a test case for drm buddy clear allocation

2024-03-26 Thread Matthew Auld
On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: Add a new test case for the drm buddy clear and dirty allocation. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/tests/drm_buddy_test.c | 127 + 1 file changed, 127

Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump

2024-03-26 Thread Khatri, Sunil
On 3/26/2024 10:23 PM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote: dump the bios binary in the devcoredump. Signed-off-by: Sunil Khatri --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ 1 file changed, 20 insertions(+) diff --git

Re: [PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from > the calling function through members of struct dp_catalog. > > No state is maintained other than across this call, so switch to > function

[PATCH] drm: DRM_DEBUG_MODESET_LOCK should depend on DRM

2024-03-26 Thread Geert Uytterhoeven
There is no point in asking the user about enabling DRM debug tracing when configuring a kernel without DRM support. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/Kconfig

[PATCH] drm/amdgpu: add IP's FW information to devcoredump

2024-03-26 Thread Sunil Khatri
Add FW information of all the IP's in the devcoredump. Signed-off-by: Sunil Khatri --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 122 ++ 1 file changed, 122 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c

[PATCH] drm: DRM_WERROR should depend on DRM

2024-03-26 Thread Geert Uytterhoeven
There is no point in asking the user about enforcing the DRM compiler warning policy when configuring a kernel without DRM support. Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The dp_aux write operations takes the data to be operated on through a > member of struct dp_catalog, rather than as an argument to the function. > > No state is maintained other than across the calling of the

Re: [PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The "desc" member of struct dp_panel is zero-initialized during > allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() > never returning true. This returned boolean value is passed around but >

Re: [PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The members of struct dp_debug are no longer used, so the only purpose > of this struct is as a type of the return value of dp_debug_get(), to > signal success/error. > > Drop the struct in favor of signalling the

[PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

2024-03-26 Thread Heiko Stuebner
The #sound-dai-cells DT property is required to describe link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 3/6] drm/msm/dp: Remove unused defines and members

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > Throughout the Qualcomm Displayport driver a number of defines and > struct members has become unused, but lingers in the code. Remove these. > > Signed-off-by: Bjorn Andersson > --- >

[PULL] drm-xe-fixes

2024-03-26 Thread Lucas De Marchi
Hi Dave and Sima, Please pull the drm-xe-fixes for this week targeting v6.9-rc2. drm-xe-fixes-2024-03-26: - Fix build on mips - Fix wrong bound checks - Fix use of msec rather than jiffies - Remove dead code The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-26 Thread Werner Sembach
Hi all, Am 26.03.24 um 16:39 schrieb Benjamin Tissoires: On Mar 26 2024, Werner Sembach wrote: Hi all, Am 25.03.24 um 19:30 schrieb Hans de Goede: [snip] If the kernel already handles the custom protocol into generic HID, the work for userspace is not too hard because they can deal with a

Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote: > > dump the bios binary in the devcoredump. > > Signed-off-by: Sunil Khatri > --- > .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ > 1 file changed, 20 insertions(+) > > diff --git

[PATCH 4/4] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges

2024-03-26 Thread Luca Ceresoli
This driver implements the point of a DRM pipeline where a connector allows removal of all the following bridges up to the panel. The DRM subsystem currently allows hotplug of the monitor but not preceding components. However there are embedded devices where the "tail" of the DRM pipeline,

[PATCH 3/4] drm/encoder: add drm_encoder_cleanup_from()

2024-03-26 Thread Luca Ceresoli
Supporting hardware whose final part of the DRM pipeline can be physically removed requires the ability to detach all bridges from a given point to the end of the pipeline. Introduce a variant of drm_encoder_cleanup() for this. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/drm_encoder.c |

[PATCH 1/4] dt-bindings: display: bridge: add the Hot-plug MIPI DSI connector

2024-03-26 Thread Luca Ceresoli
Add bindings for a physical, hot-pluggable connector allowing the far end of a MIPI DSI bus to be connected and disconnected at runtime. Signed-off-by: Luca Ceresoli --- .../bridge/hotplug-video-connector-dsi.yaml| 87 ++ MAINTAINERS

[PATCH 2/4] drm/bridge: add bridge notifier to be notified of bridge addition and removal

2024-03-26 Thread Luca Ceresoli
From: Paul Kocialkowski In preparation for allowing bridges to be added to and removed from a DRM card without destroying the whole card, add a DRM bridge notifier. Notified events are addition and removal to/from the global bridge list. Co-developed-by: Luca Ceresoli Signed-off-by: Luca

[PATCH 0/4] drm: add support for hot-pluggable bridges

2024-03-26 Thread Luca Ceresoli
Hello, DRM natively supports pipelines whose display can be removed, but all the components preceding it (all the display controller and any bridges) are assumed to be fixed and cannot be plugged, removed or modified at runtime. This series adds support for DRM pipelines having a removable part

RE: [PATCH v6 0/3] Disable automatic load CCS load balancing

2024-03-26 Thread Mrozek, Michal
On Wed, Mar 13, 2024 at 09:19:48PM +0100, Andi Shyti wrote: > Hi, > > this series does basically two things: > > 1. Disables automatic load balancing as adviced by the hardware >workaround. > > 2. Assigns all the CCS slices to one single user engine. The user >will then be able to query

  1   2   3   >