Re: [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests

2017-04-13 Thread Chris Wilson
On Thu, Apr 13, 2017 at 10:52:17PM +0300, Dan Carpenter wrote: > i915_gem_request_alloc() uses error pointers. It never returns NULLs. > > Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission") > Signed-off-by: Dan Carpenter Reviewed-by: Chris

Re: [PATCH] drm: Fix get_property logic fumble

2017-04-13 Thread Andres Rodriguez
On 2017-04-10 08:40 AM, Maarten Lankhorst wrote: Op 10-04-17 om 13:54 schreef Daniel Vetter: Yet again I've proven that I can't negate conditions :( Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl") Cc: Maarten Lankhorst Cc:

drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1950-gdf0abb111336)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1950-gdf0abb111336) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1950-gdf0abb111336/ Full Build Summary:

[Bug 100675] No signal on DisplayPort [drm:radeon_dp_link_train [radeon]] *ERROR* displayport link status failed

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100675 Bug ID: 100675 Summary: No signal on DisplayPort [drm:radeon_dp_link_train [radeon]] *ERROR* displayport link status failed Product: DRI Version: unspecified Hardware:

Re: [PATCH] drm/i915: uninitialized value on error path

2017-04-13 Thread Chris Wilson
On Thu, Apr 13, 2017 at 10:53:11PM +0300, Dan Carpenter wrote: > "ret" isn't initialized on this error path. It doesn't really cause > any problems unless it's randomly set to -EDEADLK which is not likely. > > Signed-off-by: Dan Carpenter > > diff --git

drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1952-g0a54b7fee9ec)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1952-g0a54b7fee9ec) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1952-g0a54b7fee9ec/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc6-1952-g0a54b7fee9ec

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #3 from Andres Rodriguez --- Reverting the following commit fixes this branch for me: eb8eb02 drm: Drop modeset_lock_all from the getproperty ioctl Let me check if I can make a quick fix for it. -- You are

Re: [Intel-gfx] [PATCH 06/15] drm: Drop modeset_lock_all from the getproperty ioctl

2017-04-13 Thread Chris Wilson
On Thu, Apr 13, 2017 at 04:03:16PM -0400, Alex Deucher wrote: > On Mon, Apr 3, 2017 at 4:32 AM, Daniel Vetter wrote: > > Properties, i.e. the struct drm_property specifying the type and value > > range of a property, not the instantiation on a given object, are > >

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #4 from Alex Deucher --- Should be fixed by: commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82 Author: Daniel Vetter Date: Mon Apr 10 13:54:45 2017 +0200 drm: Fix get_property

[PATCH] drm/i915: uninitialized value on error path

2017-04-13 Thread Dan Carpenter
"ret" isn't initialized on this error path. It doesn't really cause any problems unless it's randomly set to -EDEADLK which is not likely. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index

Re: [PATCH] drm/i915: uninitialized value on error path

2017-04-13 Thread Dan Carpenter
True. I'll resend. regards, dan carpenter ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 06/15] drm: Drop modeset_lock_all from the getproperty ioctl

2017-04-13 Thread Alex Deucher
On Mon, Apr 3, 2017 at 4:32 AM, Daniel Vetter wrote: > Properties, i.e. the struct drm_property specifying the type and value > range of a property, not the instantiation on a given object, are > invariant over the lifetime of a driver. > > Hence no locking at all is

[PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests

2017-04-13 Thread Dan Carpenter
i915_gem_request_alloc() uses error pointers. It never returns NULLs. Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/selftests/mock_request.c

Re: [PATCH] drm/doc: Fix missing @ctx documentation

2017-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2017 at 09:43:07AM +0200, Neil Armstrong wrote: > On 04/13/2017 09:40 AM, Daniel Vetter wrote: > > Forgot to add this :( > > > > Fixes: 1931529448bc ("drm: Add acquire ctx parameter to ->plane_disable") > > Cc: Harry Wentland > > Signed-off-by: Daniel

Re: [PATCH 5/9] drm/exynos/decon5433: kill BIT_IRQS_ENABLED flag

2017-04-13 Thread Inki Dae
2017년 04월 05일 16:28에 Andrzej Hajda 이(가) 쓴 글: > Since DECON uses enable_irq/disable_irq to full control IRQs, > there is no point in having flags to trace it separately. > As a bonus condition for software trigger becomes always true, > so it can be removed. > > Signed-off-by: Andrzej Hajda

Re: [Nouveau] [PATCH v3 10/10] drm/nouveau: Enable stereoscopic 3D output over HDMI

2017-04-13 Thread Ben Skeggs
On 04/13/2017 01:22 AM, Alastair Bridgewater wrote: On Tue, Apr 11, 2017 at 1:32 PM, Ilia Mirkin > wrote: On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater >

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 --- Comment #4 from taij...@posteo.de --- Created attachment 130826 --> https://bugs.freedesktop.org/attachment.cgi?id=130826=edit relevant dmesg output I have a similar problem on my new notebook. System: Arch Linux - Kernel 4.11-rc6 Intel

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-13 Thread Pekka Paalanen
On Tue, 11 Apr 2017 13:23:53 +0200 Gerd Hoffmann wrote: > Hi, > > > > Just let know what you need tested, I should be able to turn it around > > > within a couple of days. > > > > That's part of my problem. I don't really know what should be tested. > > What do people do

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Hans Verkuil
On 04/13/2017 10:43 AM, Tomi Valkeinen wrote: > On 12/04/17 17:04, Hans Verkuil wrote: > >>> So is some other driver supporting this already? Or is the omap4 the >>> first platform you're trying this on? >> >> No, there are quite a few CEC drivers by now, but typically the CEC block is >> a

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Tomi Valkeinen
On 13/04/17 12:12, Hans Verkuil wrote: >> Is there anything else CEC needs to access or control (besides the CEC >> IP itself)? > > The CEC framework needs to be informed about the physical address contained > in the EDID (part of the CEA-861 block). And when the HPD goes down it needs > to be

Re: [PATCH] drm/bridge: sii902x: Add missing \n to the end of some dev_err messages

2017-04-13 Thread Andrzej Hajda
On 13.04.2017 10:20, Andrzej Hajda wrote: > On 11.04.2017 04:22, Liu Ying wrote: >> Trivial fix. >> Some dev_err messages in this driver are missing \n, so add them. >> >> Signed-off-by: Liu Ying > Reviewed-by: Andrzej Hajda > > -- > Regards > Andrzej

Re: [PATCH] drm/doc: Fix missing @ctx documentation

2017-04-13 Thread Neil Armstrong
On 04/13/2017 09:40 AM, Daniel Vetter wrote: > Forgot to add this :( > > Fixes: 1931529448bc ("drm: Add acquire ctx parameter to ->plane_disable") > Cc: Harry Wentland > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_plane_helper.c | 1

[PATCH] drm/doc: Fix missing @ctx documentation

2017-04-13 Thread Daniel Vetter
Forgot to add this :( Fixes: 1931529448bc ("drm: Add acquire ctx parameter to ->plane_disable") Cc: Harry Wentland Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_plane_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering.

2017-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2017 at 12:12:02PM -0700, Eric Anholt wrote: > This is needed for proper synchronization with display on another DRM > device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the > new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2 > desktop tests on

Re: [PATCH] drm/exynos/dsi: fix bridge_node DT parsing

2017-04-13 Thread Inki Dae
2017년 04월 12일 16:22에 Andrzej Hajda 이(가) 쓴 글: > DSIM uses MIC bridge which is between DECON and DSIM, so the driver > should expect bridge node on input side. Confirmed and merged. Thanks, Inki Dae > > Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") > Signed-off-by:

Re: [PATCH] drm/bridge: sii902x: Add missing \n to the end of some dev_err messages

2017-04-13 Thread Andrzej Hajda
On 11.04.2017 04:22, Liu Ying wrote: > Trivial fix. > Some dev_err messages in this driver are missing \n, so add them. > > Signed-off-by: Liu Ying Reviewed-by: Andrzej Hajda -- Regards Andrzej ___ dri-devel

Re: [PATCH 5/9] drm/exynos/decon5433: kill BIT_IRQS_ENABLED flag

2017-04-13 Thread Andrzej Hajda
On 13.04.2017 10:33, Inki Dae wrote: > > 2017년 04월 05일 16:28에 Andrzej Hajda 이(가) 쓴 글: >> Since DECON uses enable_irq/disable_irq to full control IRQs, >> there is no point in having flags to trace it separately. >> As a bonus condition for software trigger becomes always true, >> so it can be

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 --- Comment #5 from taij...@posteo.de --- Created attachment 130827 --> https://bugs.freedesktop.org/attachment.cgi?id=130827=edit lshw output reference in comment 4 -- You are receiving this mail because: You are the assignee for the

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 --- Comment #6 from taij...@posteo.de --- Created attachment 130828 --> https://bugs.freedesktop.org/attachment.cgi?id=130828=edit lspci output referenced above -- You are receiving this mail because: You are the assignee for the

[PATCH v4.1 01/9] drm/atomic: Handle aspect ratio and scaling mode in core, v2.

2017-04-13 Thread Maarten Lankhorst
This is required to for i915 to convert connector properties to atomic. Changes since v1: - Add docbook info. (danvet) - Change picture_aspect_ratio to enum hdmi_picture_aspect. Signed-off-by: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org Acked-by:

[drm:drm-syncobj-sem 3/8] drivers/dma-buf/sync_file.c:36:1-3: WARNING: PTR_ERR_OR_ZERO can be used

2017-04-13 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj-sem head: faf022804be516663a33f620536b006a56d59ee4 commit: 8281fe367426f82485f68767c5c8c7106685e9a9 [3/8] sync_file: split out fence_file base class from sync_file. coccinelle warnings: (new ones prefixed by >>) >>

[PATCH] sync_file: fix ptr_ret.cocci warnings

2017-04-13 Thread kbuild test robot
drivers/dma-buf/sync_file.c:36:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu --- sync_file.c |4 +--- 1 file changed, 1

drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1953-g4079da1bee73)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1953-g4079da1bee73) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1953-g4079da1bee73/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc6-1953-g4079da1bee73

[PATCH 17/22] mmc: sdhci: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion, except due to the lack of error path we have to WARN if the memory in the SGL is not mappable. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/sdhci.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-)

[PATCH 19/22] mmc: tmio: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to sg_map helper. A couple paths will WARN if the memory does not end up being mappable. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/tmio_mmc.h | 12 ++-- drivers/mmc/host/tmio_mmc_dma.c | 5 +

Re: [Nouveau] [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Karol Herbst
Hi Oscar, this is a cover letter, there should be no patch attached to it, but a stat of the following patches and an explenation what the series is doing. 2017-04-13 11:07 GMT+02:00 Oscar Salvador : > Hi again, > > I've split the patches as Karol Herbst suggested.

[Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #16 from Michel Dänzer --- The patch just disables DRI3 for VDPAU, so it cannot be applied anywhere as is. It would have to be guarded by an environment variable. -- You are receiving this mail because: You are

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #6 from Alex Deucher --- (In reply to Andy Furniss from comment #5) > (In reply to Alex Deucher from comment #4) > > Should be fixed by: > > > > commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82 > > Author:

drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1952-g0a54b7fee9ec)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1952-g0a54b7fee9ec) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1952-g0a54b7fee9ec/ Full Build Summary:

[PATCH 06/22] crypto: hifn_795x: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but

[PATCH 05/22] drm/i915: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a single straightforward conversion from kmap to sg_map. Signed-off-by: Logan Gunthorpe --- drivers/gpu/drm/i915/i915_gem.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c

[PATCH 18/22] mmc: spi: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/mmc_spi.c | 26

[PATCH 04/22] target: Make use of the new sg_map function at 16 call sites

2017-04-13 Thread Logan Gunthorpe
Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with

[PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c

drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1953-g4079da1bee73)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip boot: 19 boots: 2 failed, 17 passed (v4.11-rc6-1953-g4079da1bee73) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1953-g4079da1bee73/ Full Build Summary:

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #5 from Andy Furniss --- (In reply to Alex Deucher from comment #4) > Should be fixed by: > > commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82 > Author: Daniel Vetter > Date: Mon Apr

[PATCH 12/22] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper in 4 call sites

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42 +- drivers/scsi/pmcraid.c | 19

[PATCH 07/22] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion to the new function in two crypto drivers. Signed-off-by: Logan Gunthorpe --- crypto/shash.c| 9 ++--- drivers/crypto/caam/caamalg.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 14/22] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe --- drivers/scsi/arcmsr/arcmsr_hba.c | 16 drivers/scsi/ips.c | 8 drivers/scsi/megaraid.c | 9 +++-- 3 files changed, 23

[PATCH 01/22] scatterlist: Introduce sg_map helper functions

2017-04-13 Thread Logan Gunthorpe
This patch introduces functions which kmap the pages inside an sgl. Two variants are provided: one if an offset is required and one if the offset is zero. These functions replace a common pattern of kmap(sg_page(sg)) that is used in about 50 places within the kernel. The motivation for this work

[PATCH 02/22] nvmet: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a straight forward conversion in two places. Should kmap fail, the code will return an INVALD_DATA error in the completion. Signed-off-by: Logan Gunthorpe --- drivers/nvme/target/fabrics-cmd.c | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[PATCH 00/22] Introduce common scatterlist map function

2017-04-13 Thread Logan Gunthorpe
Hi Everyone, As part of my effort to enable P2P DMA transactions with PCI cards, we've identified the need to be able to safely put IO memory into scatterlists (and eventually other spots). This probably involves a conversion from struct page to pfn_t but that migration is a ways off and those

[PATCH 13/22] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 13 +

[PATCH 15/22] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

2017-04-13 Thread Logan Gunthorpe
These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe ---

[PATCH 09/22] dm-crypt: Make use of the new sg_map helper in 4 call sites

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe --- drivers/md/dm-crypt.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/md/dm-crypt.c

[PATCH 22/22] memstick: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion, but we have to WARN if unmappable memory finds its way into the sgl. Signed-off-by: Logan Gunthorpe --- drivers/memstick/host/jmb38x_ms.c | 23 ++- drivers/memstick/host/tifm_ms.c | 22 +- 2 files

[PATCH 21/22] mmc: tifm_sd: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of

[PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to the new helper, except due to the lack of error path, we have to warn if unmapable memory is ever present in the sgl. Signed-off-by: Logan Gunthorpe --- drivers/block/xen-blkfront.c | 33 +++-- 1 file changed, 27

[PATCH 03/22] libiscsi: Make use of new the sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We also propogate a possible kmap error down and create a new ISCSI_TCP_INTERNAL_ERR error type for this. Signed-off-by: Logan Gunthorpe

Re: [Nouveau] [PATCH 1/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Karol Herbst
2017-04-13 11:08 GMT+02:00 Oscar Salvador : > This patch introduces the structure "struct hwmon_ops" and sets up the > ".visible" operation. > Is also a preparation for the next patch where all work is being done. > > ---

[PATCH 08/22] crypto: chcr: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
The get_page in this area looks *highly* suspect due to there being no corresponding put_page. However, I've left that as is to avoid breaking things. I've also removed the KMAP_ATOMIC_ARGS check as it appears to be dead code that dates back to when it was first committed... Signed-off-by: Logan

Re: [Nouveau] [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Karol Herbst
Also your series got a little messed up, there are two 1/4 patches, and both are different. 2017-04-13 11:07 GMT+02:00 Oscar Salvador : > Hi again, > > I've split the patches as Karol Herbst suggested. > I hope now it's fine. > > This series of patches introduce the

[PATCH 20/22] mmc: sdricoh_cs: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c index

[PATCH 11/22] RDS: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion except there's no error path, so we WARN if the sg_map fails. Signed-off-by: Logan Gunthorpe --- net/rds/ib_recv.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index

Re: [PATCH] drm/doc: Interlink color manager docs better

2017-04-13 Thread Lionel Landwerlin
I have a tiny suggestion down there. Regardless this is : Reviewed-by: Lionel Landwerlin On 12/04/17 08:20, Daniel Vetter wrote: Motivated by a request from Eric. Cc: Eric Anholt Cc: Lionel Landwerlin

Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering.

2017-04-13 Thread Eric Anholt
Daniel Vetter writes: > On Wed, Apr 12, 2017 at 12:12:02PM -0700, Eric Anholt wrote: >> This is needed for proper synchronization with display on another DRM >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the >> new igt vc4_dmabuf_poll testcase, and

Re: [drm-tip:drm-tip 1/7] drivers/gpu/drm/nouveau/nvkm/engine/device/base.c:2347:1: error: redefinition of 'nv137_chipset'

2017-04-13 Thread Jani Nikula
On Thu, 13 Apr 2017, kbuild test robot wrote: > tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip > head: f1faf571d9530365a34fe33a3efa3fb224661692 > commit: 15b670ebb1bb7309b60c23b3fa1479d31cd79122 [1/7] Merge remote-tracking > branch

KMS question

2017-04-13 Thread Boszormenyi Zoltan
Hi, how can I disable the behaviour in the KMS drivers that enables all outputs at once? It is very annoying that on a POS machine with an 1024x768 LVDS and a 800x480 secondary monitor (both built-in) the KMS driver wakes up both. Then the framebuffer console and plymouth use both screens,

Re: [PATCH] drm: fix spelling mistake: "committing"

2017-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2017 at 05:27:22PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DRM_DEBUG_ATOMIC debug message > > Signed-off-by: Colin Ian King Applied for 4.13 (4.12 feature cutoff is already

Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

2017-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2017 at 12:12:01PM -0700, Eric Anholt wrote: > If we follow the typical pattern of the base class being the first > member, we can use the default dma_fence_free function. > > Signed-off-by: Eric Anholt On 3&4: Reviewed-by: Daniel Vetter

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Tomi Valkeinen
On 12/04/17 17:04, Hans Verkuil wrote: >> So is some other driver supporting this already? Or is the omap4 the >> first platform you're trying this on? > > No, there are quite a few CEC drivers by now, but typically the CEC block is > a totally independent IP block with its own power, irq, etc.

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 45 warnings (v4.11-rc6-1945-g6184edce6665)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 45 warnings (v4.11-rc6-1945-g6184edce6665) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1945-g6184edce6665/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc6-1945-g6184edce6665 Git Commit:

[Bug 87738] [OpenCL] Please add Image support

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87738 --- Comment #1 from Antonio Ospite --- Hi, I still get this when running darktable with mesa 17: [opencl_init] discarding device 0 `AMD REDWOOD (DRM 2.48.0 / 4.9.0-2-amd64, LLVM 4.0.0)' due to missing image support. Is it the

Re: KMS question

2017-04-13 Thread Alex Deucher
On Thu, Apr 13, 2017 at 9:03 AM, Boszormenyi Zoltan wrote: > Hi, > > how can I disable the behaviour in the KMS drivers > that enables all outputs at once? > > It is very annoying that on a POS machine with an > 1024x768 LVDS and a 800x480 secondary monitor (both built-in) > the

drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1950-gf1faf571d953)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1950-gf1faf571d953) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1950-gf1faf571d953/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc6-1950-gf1faf571d953

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #2 from Alex Deucher --- (In reply to Andy Furniss from comment #1) > Created attachment 130830 [details] > dmesg with lots of warnings on startx (older kernel) This was fixed here:

Re: [PATCH 0/5] omapdrm: fences and zpos

2017-04-13 Thread Laurent Pinchart
Hi Tomi, On Wednesday 05 Apr 2017 09:52:36 Tomi Valkeinen wrote: > On 03/01/17 14:06, Tomi Valkeinen wrote: > > I got this with your series. AM5 EVM, dual display, I run "kmstest --flip" > > and then exit by pressing enter, which is when I see the warning. It > > happens only sometimes, but

Re: [PATCH] drm: Document code of conduct

2017-04-13 Thread Gabriel Krisman Bertazi
Daniel Vetter writes: > freedesktop.org has adopted a formal code of conduct: > > https://www.fooishbar.org/blog/fdo-contributor-covenant/ > https://www.freedesktop.org/wiki/CodeOfConduct/ > > Besides formalizing things a bit more I don't think this changes > anything for

[PATCH 2/3] drm/panel: s6e3ha2: Add support for S6eHEA2 edge panel on TM2e board

2017-04-13 Thread Hoegeun Kwon
This patch considers edge type of panel on TM2e board and The panel has 1600x2560 resolution in 5.65" physical panel in the TM2e device. This identify panel type with compatibility string, also invoke display mode that matches the type. So add the check code for default compatibility and edge

[PATCH 0/3] Add support for the S6E3HA2 edge panel on TM2e board

2017-04-13 Thread Hoegeun Kwon
The purpose of this patch is add support for S6E3HA2 edge AMOLED panel on the TM2e board. The panel has 1600x2560 resolution in 5.65" physical panel in the TM2e device. The S6E3HA2 edge panel(5.65") is simliar to the previous S6E3HA2 panel(5.7"), but resolution and some command message are

[PATCH 1/3] dt-bindings: Add support for samsung s6e3ha2 edge panel binding

2017-04-13 Thread Hoegeun Kwon
The Samsung s6e3ha2 edge is a 5.65" 1600x2560 AMOLED panel connected using MIPI-DSI interfaces. Signed-off-by: Hoegeun Kwon --- .../bindings/display/panel/samsung,s6e3ha2-e.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644

[PATCH 3/3] arm64: dts: exynos: Add support for S6E3HA2 edge panel device on TM2e board

2017-04-13 Thread Hoegeun Kwon
This patch add the panel device tree node for S6E3HA2 edge display controller to TM2e dts. Signed-off-by: Hoegeun Kwon --- arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-04-13 Thread Jeffy Chen
After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. We're using an unplugged state to prevent something like that, so let's reuse it here. Also drop drm_unplug_dev, because it would be unused after other changes. Verified on rk3399

[PATCH 2/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Oscar Salvador
Here is where most of the work is being done. We are replacing the old API with the new one, that means changing the functions layout and remove unnecessary code. We also set up the other operations: .read .write .read_string --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13

[RFC v3 09/14] vb2: dma-contig: Move vb2_dc_get_base_sgt() up

2017-04-13 Thread Sakari Ailus
Just move the function up. It'll be soon needed earlier than previously. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-dma-contig.c

[PATCH 1/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Oscar Salvador
This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. Is also a preparation for the next patch where all work is being done. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:22:29.070573187 +0200 +++

[RFC v3 02/14] vb2: Move buffer cache synchronisation to prepare from queue

2017-04-13 Thread Sakari Ailus
The buffer cache should be synchronised in buffer preparation, not when the buffer is queued to the device. Fix this. Mmap buffers do not need cache synchronisation since they are always coherent. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[RFC v3 13/14] vb2: Don't sync cache for a buffer if so requested

2017-04-13 Thread Sakari Ailus
From: Samu Onkalo The user may request to the driver (vb2) to skip the cache maintenance operations in case the buffer does not need cache synchronisation, e.g. in cases where the buffer is passed between hardware blocks without it being touched by the CPU. Also document

[PATCH 4/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Oscar Salvador
This patch replaces symbolic permissions with the numeric ones and adds me to the authors too. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13 10:18:37.471129756 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-13 10:19:58.182025638 +0200 @@ -1,5 +1,6 @@

[RFC v3 10/14] vb2: dma-contig: Fix DMA attribute and cache management

2017-04-13 Thread Sakari Ailus
Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA attrs") added support for driver specific DMA attributes to videobuf2-dma-contig but it had several issues in it. In particular, - cache operations were only performed on USERPTR buffers, - DMA attributes were set only for MMAP

[RFC v3 11/14] vb2: dma-contig: Add WARN_ON_ONCE() to check for potential bugs

2017-04-13 Thread Sakari Ailus
The scatterlist should always be present when the cache would need to be flushed. Each buffer type has its own means to provide that. Add WARN_ON_ONCE() to check the scatterist exists. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil ---

[RFC v3 01/14] vb2: Rename confusingly named internal buffer preparation functions

2017-04-13 Thread Sakari Ailus
Rename __qbuf_*() functions which are specific to a buffer type as __prepare_*() which matches with what they do. The naming was there for historical reasons; the purpose of the functions was changed without renaming them. Signed-off-by: Sakari Ailus Acked-by: Hans

[RFC v3 07/14] vb2: dma-contig: Remove redundant sgt_base field

2017-04-13 Thread Sakari Ailus
The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used by USERPTR. Unify the two, leaving dma_sgt. MMAP buffers do not need cache flushing since they have been allocated using dma_alloc_coherent().

[PATCH 3/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Oscar Salvador
This patch creates special group attributes for special attrs like "*auto_point*". We check if we need them, and if we do, we set them up in special_groups structure, that then we pass to hwmon_device_register_with_info. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13

[RFC v3 05/14] vb2: Anticipate queue specific DMA attributes for USERPTR buffers

2017-04-13 Thread Sakari Ailus
The DMA attributes were available for the memop implementation for MMAP buffers but not for USERPTR buffers. Do the same for USERPTR. This patch makes no functional changes. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 3 ++-

[RFC v3 03/14] vb2: Move cache synchronisation from buffer done to dqbuf handler

2017-04-13 Thread Sakari Ailus
The cache synchronisation may be a time consuming operation and thus not best performed in an interrupt which is a typical context for vb2_buffer_done() calls. This may consume up to tens of ms on some machines, depending on the buffer size. Signed-off-by: Sakari Ailus

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 --- Comment #1 from Andy Furniss --- Created attachment 130830 --> https://bugs.freedesktop.org/attachment.cgi?id=130830=edit dmesg with lots of warnings on startx (older kernel) -- You are receiving this mail because:

[Bug 100673] Tonga agd5f drm-next-4.12-wip xorg segfault on startx

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100673 Bug ID: 100673 Summary: Tonga agd5f drm-next-4.12-wip xorg segfault on startx Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW

drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1949-g74e7a6859913)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 20 failed, 187 passed, 20 errors, 45 warnings (v4.11-rc6-1949-g74e7a6859913) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1949-g74e7a6859913/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc6-1949-g74e7a6859913

drm-tip/drm-tip boot: 117 boots: 4 failed, 112 passed with 1 offline (v4.11-rc6-1945-g6184edce6665)

2017-04-13 Thread kernelci . org bot
drm-tip/drm-tip boot: 117 boots: 4 failed, 112 passed with 1 offline (v4.11-rc6-1945-g6184edce6665) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc6-1945-g6184edce6665/ Full Build Summary:

  1   2   >