On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> Thank you for the patch.
>
> On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> > No implementation, no callers.
>
> The issue here isn't that the function is declared, but that it's not
> defined.
>
> Requests for the verification of AKE_Send_H_prime.
>
> ME will calculate the H and comparing it with received H_Prime.
> The result will be returned as status.
>
> Here AKE_Send_H_prime is a HDCP2.2 Authentication msg.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
>
> On Success, ME FW will start a HDCP2.2 session for the port and provides the
> content for HDCP2.2 AKE_Init message.
>
> v2: Rebased.
> v3:
> cldev is add as a separate parameter [Tomas]
> Redundant comment and typecast are removed [Tomas]
> v4:
> %zd is used for size [Alexander]
>
>
> Provides Pairing info to ME to store.
>
> Pairing is a process to fast track the subsequent authentication with the same
> HDCP sink.
>
> On Success, received HDCP pairing info is stored in non-volatile memory of ME.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
>
On Thu, Feb 21, 2019 at 02:06:23PM +0100, Gerd Hoffmann wrote:
> On Thu, Feb 21, 2019 at 01:20:11PM +0100, Daniel Vetter wrote:
> > On Thu, Feb 21, 2019 at 12:35:34PM +0100, Gerd Hoffmann wrote:
> > > Problem: qxl switches from native mode back into vga compatibility mode
> > > when it notices
On Thu, Feb 21, 2019 at 4:11 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > I was thinking of checking whether pdev is a VGA class device and whether
> > it decodes vga access, and in that case automatically calling
>
> How can I figure that? Ok, class is easy, but decode? pci.h offers
> functions to
Am 21.02.19 um 07:47 schrieb Thomas Hellstrom:
> On Wed, 2019-02-20 at 19:23 +, Kuehling, Felix wrote:
>> On 2019-02-20 1:41 a.m., Thomas Hellstrom wrote:
>>> On Tue, 2019-02-19 at 17:06 +, Kuehling, Felix wrote:
On 2019-02-18 3:39 p.m., Thomas Hellstrom wrote:
> On Mon,
On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote:
> On Thu, 21 Feb 2019, Gerd Hoffmann wrote:
> > It'll be useful for other drivers too, so move it to drm_fb_helper.c
> > (and rename it of course). Also add docs.
> >
> > Signed-off-by: Gerd Hoffmann
> > ---
> >
> Requests for verification for receiver certification and also the preparation
> for
> next AKE auth message with km.
>
> On Success ME FW validate the HDCP2.2 receivers certificate and do the
> revocation check on the receiver ID. AKE_Stored_Km will be prepared if the
> receiver is already
> > +int drm_fb_helper_kick_out_vgacon(void);
> > +
>
> Don't you need a dummy version as well for this one, like how it's done
> for the other functions, to cover the case when DRM_FBDEV_EMULATION is
> not selected?
Good question.
I guess it makes sense to kick out vgacon even with
Hi Laurent,
On 21/02/2019 10:31, Laurent Pinchart wrote:
> From: Kieran Bingham
>
> This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to
> the DU continuously")
>
> The DU output mode does not rely on frames being supplied on the WPF as
> its pipeline is supplied from DRM.
Hi Laurent,
On 21/02/2019 10:32, Laurent Pinchart wrote:
> One-shot entries are used as an alternative to committing a complete new
> display list when a couple of registers need to be written for one frame
> and then reset to another value for all subsequent frames. This will be
> used to
> Request to ME to verify the LPrime received from HDCP sink.
>
> On Success, ME FW will verify the received Lprime by calculating and
> comparing with L.
>
> This represents the completion of Locality Check.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
> Redundant
>
> ME FW contributes a vital role in HDCP2.2 authentication.
> HDCP2.2 driver needs to communicate to ME FW for each step of the
> HDCP2.2 authentication.
>
> ME FW prepare and HDCP2.2 authentication parameters and encrypt them as
> per spec. With such parameter Driver prepares HDCP2.2 auth
Hey
Op 21-02-2019 om 12:14 schreef james qian wang (Arm Technology China):
> The writeback job will not be added to writeback queue if the state is
> check only or check failed, to avoid leak, need to cleanup writeback job
> in connector_destroy_state if the job existed.
>
> Signed-off-by: James
> Request the ME to terminate the HDCP2.2 session for a port.
>
> On Success, ME FW will mark the intel port as Deauthenticated and terminate
> the wired HDCP2.2 Tx session started due to the cmd
> WIRED_INITIATE_HDCP2_SESSION.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter
>
> Request to ME to configure a port as authenticated.
>
> On Success, ME FW will mark the port as authenticated and provides HDCP
> cipher with the encryption keys.
>
> Enabling the Authentication can be requested once all stages of
> HDCP2.2 authentication is completed by interacting with ME
On Thu, 21 Feb 2019, Gerd Hoffmann wrote:
> On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote:
>> On Thu, 21 Feb 2019, Gerd Hoffmann wrote:
>> > It'll be useful for other drivers too, so move it to drm_fb_helper.c
>> > (and rename it of course). Also add docs.
>> >
>> > Signed-off-by:
> Requests for the verification of AKE_Send_H_prime.
>
> ME will calculate the H and comparing it with received H_Prime.
> The result will be returned as status.
>
> Here AKE_Send_H_prime is a HDCP2.2 Authentication msg.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
>
On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote:
> Hi Laurent,
>
> On Thu, Feb 21, 2019 at 12:02:57PM +0200, Laurent Pinchart wrote:
> > Hi Brian,
> >
> > On Thu, Feb 21, 2019 at 09:50:19AM +, Brian Starkey wrote:
> > > On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart
https://bugs.freedesktop.org/show_bug.cgi?id=109714
Adam Jackson changed:
What|Removed |Added
Resolution|--- |NOTABUG
Status|NEW
>
> Request to ME to verify the M_Prime received from the HDCP sink.
>
> ME FW will calculate the M and compare with M_prime received as part of
> RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg.
>
> On successful completion of this stage, downstream propagation of the stream
>
On Thu, Feb 21, 2019 at 02:23:10PM +0200, Laurent Pinchart wrote:
> On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote:
[snip]
> >
> > I used a pre-existing internal tool which does exactly that.
>
> Any hope of sharing the sources ?
>
Not in a timescale or form which would be
> Requests ME to start the second stage of HDCP2.2 authentication, called
> Locality Check.
>
> On Success, ME FW will provide LC_Init message to send to hdcp sink.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
> Redundant comments and cast are removed [Tomas]
> v4:
>
Den 21.02.2019 12.35, skrev Gerd Hoffmann:
> It'll be useful for other drivers too, so move it to drm_fb_helper.c
> (and rename it of course). Also add docs.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/drm/drm_fb_helper.h | 2 ++
> drivers/gpu/drm/drm_fb_helper.c | 39
> ack
>
> Request ME to verify the downstream topology information received.
>
> ME FW will validate the Repeaters receiver id list and downstream topology.
>
> On Success ME FW will provide the Least Significant 128bits of VPrime, which
> forms the repeater ack.
>
> v2: Rebased.
> v3:
>
https://bugs.freedesktop.org/show_bug.cgi?id=109692
--- Comment #8 from Tom St Denis ---
Just a follow up. If you "chmod +s" umr as a non-root user then even if you
sudo it it won't have permissions to read the debugfs files.
Make sure you "sudo chmod +s" the binary or simply just "sudo umr".
On Thu, Feb 21, 2019 at 01:39:33PM +0100, Gerd Hoffmann wrote:
> > > +/**
> > > + * drm_fb_helper_kick_out_vgacon - deactivate vgacon driver.
> > > + *
> > > + * Deactivate vgacon driver so it stops accessing vga io ports.
> > > + * Should be called after
> > > + *
>
> Request to ME to prepare the encrypted session key.
>
> On Success, ME provides Encrypted session key. Function populates the
> HDCP2.2 authentication msg SKE_Send_Eks.
>
> v2: Rebased.
> v3:
> cldev is passed as first parameter [Tomas]
> Redundant comments and cast are removed [Tomas]
Hi,
> I was thinking of checking whether pdev is a VGA class device and whether
> it decodes vga access, and in that case automatically calling
How can I figure that? Ok, class is easy, but decode? pci.h offers
functions to set vga decode but not to get that info ...
thanks,
Gerd
On Wed, Feb 20, 2019 at 01:03:37PM -0800, Eric Anholt wrote:
> The debugfs_regset32 is nice to use for reducing boilerplate in
> dumping a bunch of regs in debugfs, but we also want to be able to
> print to dmesg them at runtime for driver debugging. drm_printer lets
> us format debugfs and the
Hi Daniel,
Thank you for the patch.
On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> No implementation, no callers.
The issue here isn't that the function is declared, but that it's not
defined. Jobs are leaked when atomic commit fails (or when using test
commits). I'm working
https://bugzilla.kernel.org/show_bug.cgi?id=201795
--- Comment #14 from thomas.lassdiesonner...@gmx.de ---
Still there with 4.20.10
@tempel.jul...@gmail.com
I do not need a workaround thx. All works fine with 4.14.101 LTS Kernel. I just
wanted to report this regression and hope for a fix in
Hi Brian,
On Mon, Feb 18, 2019 at 12:22:58PM +, Brian Starkey wrote:
> On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch series implements display writeback support for the R-Car
> > Gen3 platforms in the VSP1 driver.
> >
> > DRM/KMS provides a
On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart
wrote:
> Hi Daniel,
>
> Thank you for the patch.
>
> On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> > No implementation, no callers.
>
> The issue here isn't that the function is declared, but that it's not
> defined. Jobs are
After the commit 0926f0af54d6 ("meson,configure: include config.h
automatically"), there is build error for autotools because
config.h is not included. Fix the error by adding "-include
config.h" to CPPFLAGS instead of CFLAGS from configure.ac.
Reference:
On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote:
> When running RISC-V QEMU with the Bochs device attached via PCIe the
> probe of the Bochs device fails with:
> [drm:bochs_hw_init] *ERROR* ID mismatch
>
> This was introduced by this commit:
> 7780eb9ce8 bochs: convert to
On Thu, Feb 21, 2019 at 12:35:34PM +0100, Gerd Hoffmann wrote:
> Problem: qxl switches from native mode back into vga compatibility mode
> when it notices someone is accessing vga registers. And vgacon does
> exactly that before fbcon takes over. So make sure we kick out vgacon
> early enough
>
> Defines the HDCP specific ME FW interfaces such as Request CMDs, payload
> structure for CMDs and their response status codes.
>
> This patch defines payload size(Excluding the Header)for each WIRED
> HDCP2.2 CMDs.
>
> v2: Rebased.
> v3:
> Extra comments are removed.
> v4:
>
https://bugs.freedesktop.org/show_bug.cgi?id=109719
Martin Peres changed:
What|Removed |Added
Summary|Collect pstore data and |[igt_runner] Collect pstore
Hi Brian,
On Thu, Feb 21, 2019 at 09:50:19AM +, Brian Starkey wrote:
> On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart wrote:
> > On Mon, Feb 18, 2019 at 12:22:58PM +, Brian Starkey wrote:
> >> On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote:
> >>> Hello,
> >>>
Hi Daniel,
On Thu, Feb 21, 2019 at 10:30:24AM +0100, Daniel Vetter wrote:
> On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart
> wrote:
> > Hi Daniel,
> >
> > Thank you for the patch.
> >
> > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> >> No implementation, no callers.
> >
> >
https://bugs.freedesktop.org/show_bug.cgi?id=109692
--- Comment #7 from Tom St Denis ---
Hi from Reddit!
I don't see the attached umr output in the bugzilla report. Though it looks
like Andrey (who is on my team) is looking at it.
It looks like an unhandled (or just bad) VM fault is locking
On Mon, Feb 18, 2019 at 08:54:59AM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
> drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
> variable 'bo_old' set but not used
https://bugs.freedesktop.org/show_bug.cgi?id=108965
--- Comment #1 from CI Bug Log ---
A CI Bug Log filter associated to this bug has been updated:
{- VEGA M: igt@amdgpu_amd_basic@userptr - dmesg-warn - general protection
fault: [#1] PREEMPT SMP PTI -}
{+ VEGA M:
https://bugs.freedesktop.org/show_bug.cgi?id=108965
--- Comment #2 from Petri Latvala ---
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2468/fi-kbl-8809g/igt@amdgpu_amd_ba...@semaphore.html
--
You are receiving this mail because:
You are the assignee for the
When configuring partitions for memory-to-memory pipelines, the WPF
accesses data of the current partition through pipe->partition.
Writeback support will require full configuration of the WPF while not
providing a valid pipe->partition. Rework the configuration code to fall
back to the full image
Add support for the writeback feature of the WPF, to enable capturing
frames at the WPF output for display pipelines. To enable writeback the
vsp1_rwpf structure mem field must be set to the address of the
writeback buffer and the writeback field set to true before the WPF
.configure_stream() and
Display list fragments have been renamed to bodies. Replace one last
occurrence of the word fragment in the documentation.
Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hello everybody,
This patch series implements display writeback support for the R-Car
Gen3 platforms in the VSP1 and DU drivers.
Patches 01/19 to 11/19 prepare the VSP1 driver for writeback support
with all the necessary plumbing, including extensions of the API between
the VSP1 and DU drivers.
The rcar_du_crtc structure index field contains the CRTC hardware index,
not the hardware and software index. Update the documentation
accordingly.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The code that initializes the RPF format-related fields for display
pipelines will also be useful for the WPF to implement writeback
support. Split it from vsp1_du_atomic_update() to a new
vsp1_du_pipeline_set_rwpf_format() function.
Signed-off-by: Laurent Pinchart
---
The VSP-DL instances have two LIFs, and thus two copies of the
VI6_DISP_IRQ_ENB, VI6_DISP_IRQ_STA and VI6_WPF_WRBCK_CTRL registers. Fix
the corresponding macros accordingly.
Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_drm.c | 4 ++--
Forgot to CC Eric, sorry about that.
On Thu, Feb 21, 2019 at 12:32:05PM +0200, Laurent Pinchart wrote:
> The drm_writeback_queue_job() function takes ownership of the passed job
> and requires the caller to manually set the connector state
> writeback_job pointer to NULL. To simplify drivers and
https://bugs.freedesktop.org/show_bug.cgi?id=109712
Bug ID: 109712
Summary: S2idle is not working on AMD Gigabyte platform
Product: Mesa
Version: 18.2
Hardware: x86-64 (AMD64)
OS: other
Status: NEW
Hi Ira,
On Wed, Feb 20, 2019 at 11:01 AM wrote:
>
> From: Ira Weiny
>
> To facilitate additional options to get_user_pages_fast() change the
> singular write parameter to be gup_flags.
>
> This patch does not change any functionality. New functionality will
> follow in subsequent patches.
>
>
hi,
i had added one more irq control for temperature control check in adv7511,
if i call irq_proces as similar to hpd it does not work, initially if(
adv7511->alert_status == connector_status_connected) no irq works.
On 2/18/19 2:25 PM, Frank Rowand wrote:
> On 2/15/19 2:56 AM, Brendan Higgins wrote:
>> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote:
>>>
>>> On 2/14/19 4:56 PM, Brendan Higgins wrote:
On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand
wrote:
>
> On 12/5/18 3:54 PM, Brendan
On Fri, Feb 15, 2019 at 8:06 AM Souptick Joarder wrote:
>
> Previouly drivers have their own way of mapping range of
> kernel pages/memory into user vma and this was done by
> invoking vm_insert_page() within a loop.
>
> As this pattern is common across different drivers, it can
> be generalized
Den 19.02.2019 19.13, skrev Andy Shevchenko:
> Fix adddress -> address typo.
>
> Signed-off-by: Andy Shevchenko
> ---
Applied, thanks.
Noralf.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
unlikely has already included in IS_ERR(), so just
remove redundant likely/unlikely annotation.
Signed-off-by: Chengguang Xu
---
drivers/gpu/drm/i915/i915_gem.c| 4 ++--
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c| 2 +-
3 files
On 2/20/19 12:44 PM, Frank Rowand wrote:
> On 2/18/19 2:25 PM, Frank Rowand wrote:
>> On 2/15/19 2:56 AM, Brendan Higgins wrote:
>>> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote:
On 2/14/19 4:56 PM, Brendan Higgins wrote:
> On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand
>
unlikely has already included in IS_ERR(), so just
remove redundant unlikely annotation.
Signed-off-by: Chengguang Xu
---
drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=109714
Bug ID: 109714
Summary: Unable to Compile R200 driver: "Options 'r200' are not
allowed..."
Product: Mesa
Version: 18.3
Hardware: Other
OS: Linux (All)
When running RISC-V QEMU with the Bochs device attached via PCIe the
probe of the Bochs device fails with:
[drm:bochs_hw_init] *ERROR* ID mismatch
This was introduced by this commit:
7780eb9ce8 bochs: convert to drm_dev_register
To fix the error we ensure that pci_enable_device() is
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free':
drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning:
variable 'drm' set but not used [-Wunused-but-set-variable]
struct nouveau_drm *drm;
^
Hi Ira
Martin and I looked at your patch and agree that it doesn't change
functionality for Orangefs.
Reviewed-by: Mike Marshall
On Wed, Feb 20, 2019 at 12:32 AM wrote:
>
> From: Ira Weiny
>
> To facilitate additional options to get_user_pages_fast() change the
> singular write parameter
Dear Stephen,
> + unsigned char mux_flags;
>
> Why isn't it an unsigned long? Isn't this supposed to match the
> frameworks version of the clk flags?
> it is unsigned char mux_flags ,becasuse struct clk_mux {
u8 flags;
}
it is matched when use " mux->flags =
> > + /* unbind vgacon to make sure it doesn't touch our vga registers */
> > + console_lock();
> > + ret = do_take_over_console(_con, 0, MAX_NR_CONSOLES - 1, true);
> > + console_unlock();
>
> Still seems very late, in i915 we kick out vgacon as pretty much the first
> thing in driver
> -Original Message-
> From: Michael D Labriola [mailto:michael.d.labri...@gmail.com]
> Sent: 19 February 2019 23:08
> To: dri-devel@lists.freedesktop.org; Alex Deucher
> ; Christian Koenig ;
> Chunming Zhou ; amd-...@lists.freedesktop.org; Monk
> Liu
> Cc: Juergen Gross ; Christoph
https://bugs.freedesktop.org/show_bug.cgi?id=109719
Bug ID: 109719
Summary: Collect pstore data and attach it to dmesg output when
resuming or reporting
Product: DRI
Version: XOrg git
Hardware: Other
OS:
On Thu, Feb 21, 2019 at 01:20:11PM +0100, Daniel Vetter wrote:
> On Thu, Feb 21, 2019 at 12:35:34PM +0100, Gerd Hoffmann wrote:
> > Problem: qxl switches from native mode back into vga compatibility mode
> > when it notices someone is accessing vga registers. And vgacon does
> > exactly that
Hi Laurent,
On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart wrote:
> Hi Brian,
>
> On Mon, Feb 18, 2019 at 12:22:58PM +, Brian Starkey wrote:
> > On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote:
> > > Hello,
> > >
> > > This patch series implements display
Forgot to CC Rob, sorry about that.
On Thu, Feb 21, 2019 at 12:32:08PM +0200, Laurent Pinchart wrote:
> The msm_atomic_state_clear() and msm_atomic_state_free() functions are
> declared but never defined. Remove their prototypes.
>
> Signed-off-by: Laurent Pinchart
> ---
>
Den 08.02.2019 15.01, skrev Noralf Trønnes:
> This series makes drm_dev_unplug() compatible with the upcoming
> devm_drm_dev_init(), fixes a double drm_dev_unregister() situation and
> simplifies the drm_device ref handling wrt to the last fd closed after
> unregister.
>
> The first version of
Quoting Chengguang Xu (2019-02-21 02:08:19)
> unlikely has already included in IS_ERR(), so just
> remove redundant likely/unlikely annotation.
>
> Signed-off-by: Chengguang Xu
Reviewed-by: Chris Wilson
-Chris
___
dri-devel mailing list
On Thu, Feb 21, 2019 at 12:35:33PM +0100, Gerd Hoffmann wrote:
> It'll be useful for other drivers too, so move it to drm_fb_helper.c
> (and rename it of course). Also add docs.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/drm/drm_fb_helper.h | 2 ++
> drivers/gpu/drm/drm_fb_helper.c
On Wed, Feb 20, 2019 at 03:36:40PM +0100, Gerd Hoffmann wrote:
> Problem: qxl switches from native mode back into vga compatibility mode
> when it notices someone is accessing vga registers. And vgacon does
> exactly that before fbcon takes over.
>
> Before qxl switched to the generic fbdev
The drm_writeback_queue_job() function takes ownership of the passed job
and requires the caller to manually set the connector state
writeback_job pointer to NULL. To simplify drivers and avoid errors
(such as the missing NULL set in the vc4 driver), pass the connector
state pointer to the
Writeback jobs are allocated when the WRITEBACK_FB_ID is set, and
deleted when the jobs complete. This results in both a memory leak of
the job and a leak of the framebuffer if the atomic commit returns
before the job is queued for processing, for instance if the atomic
check fails or if the
To prepare for addition of more flags to the display list, replace the
'internal' flag field by a bitmask 'flags' field.
Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
---
Changes since v4:
- Fix check for the completed flag in vsp1_du_pipeline_frame_end()
---
The rcar_du_vsp_plane_prepare_fb() and rcar_du_vsp_plane_cleanup_fb()
functions implement the DRM plane .prepare_fb() and .cleanup_fb()
operations. They map and unmap the framebuffer to/from the VSP
internally, which will be useful to implement writeback support. Split
the mapping and unmapping
The VSP1 driver will need to pass extra flags to the DU through the
frame completion API. Replace the completed bool flag by a bitmask to
support this.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 ++--
drivers/media/platform/vsp1/vsp1_drm.c | 4 ++--
As writeback jobs contain a framebuffer, drivers may need to prepare and
cleanup them the same way they can prepare and cleanup framebuffers for
planes. Add two new optional connector helper operations,
.prepare_writeback_job() and .cleanup_writeback_job() to support this.
The job prepare
Extend the vsp1_du_atomic_flush() API with writeback support by adding
format, pitch and memory addresses of the writeback framebuffer.
Writeback completion is reported through the existing frame completion
callback with a new VSP1_DU_STATUS_WRITEBACK status flag.
Signed-off-by: Laurent Pinchart
One-shot entries are used as an alternative to committing a complete new
display list when a couple of registers need to be written for one frame
and then reset to another value for all subsequent frames. This will be
used to implement writeback support that will need to enable writeback
for the
The mapping between DRM and V4L2 fourcc's is stored in two separate
tables in rcar_du_vsp.c. In order to make it reusable to implement
writeback support, move it to the rcar_du_format_info structure.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 25 +++
The msm_atomic_state_clear() and msm_atomic_state_free() functions are
declared but never defined. Remove their prototypes.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/msm/msm_drv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.h
Implement writeback support for R-Car Gen3 by exposing writeback
connectors. Behind the scene the calls are forwarded to the VSP
backend.
Using writeback connectors will allow implemented writeback support for
R-Car Gen2 with a consistent API if desired.
Signed-off-by: Laurent Pinchart
---
The vsp1_video_complete_buffer() function completes the current buffer
and returns a pointer to the next buffer. Split the code that completes
the buffer to a separate function for later reuse, and rename
vsp1_video_complete_buffer() to vsp1_video_complete_next_buffer().
Signed-off-by: Laurent
From: Kieran Bingham
This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to
the DU continuously")
The DU output mode does not rely on frames being supplied on the WPF as
its pipeline is supplied from DRM. For the upcoming WPF writeback
functionality, we will choose to enable
https://bugs.freedesktop.org/show_bug.cgi?id=109712
--- Comment #1 from shahul ---
Comment on attachment 143427
--> https://bugs.freedesktop.org/attachment.cgi?id=143427
suspend/resume error log in s2idle
>
>[ 852.851628] smpboot: CPU 1 is now offline
>[ 852.876714] smpboot: CPU 2 is now
tree: git://people.freedesktop.org/~agd5f/linux.git amd-18.50
head: e4440937836a9d6a260bb43e87989b8cdd3c2f2c
commit: e4440937836a9d6a260bb43e87989b8cdd3c2f2c [1/1] drm/amdgpu: don't clamp
debugfs register access to the BAR size
reproduce:
# apt-get install sparse
git checkout
It'll be useful for other drivers too, so move it to drm_fb_helper.c
(and rename it of course). Also add docs.
Signed-off-by: Gerd Hoffmann
---
include/drm/drm_fb_helper.h | 2 ++
drivers/gpu/drm/drm_fb_helper.c | 39 +++
drivers/gpu/drm/i915/i915_drv.c
Problem: qxl switches from native mode back into vga compatibility mode
when it notices someone is accessing vga registers. And vgacon does
exactly that before fbcon takes over. So make sure we kick out vgacon
early enough that it wouldn't disturb us.
Signed-off-by: Gerd Hoffmann
---
v2: move the i915 code to drm_fb_helper and use that instead of
reinventing the wheel.
Gerd Hoffmann (2):
drm: move i915_kick_out_vgacon to drm_fb_helper
drm/qxl: kick out vgacon
include/drm/drm_fb_helper.h | 2 ++
drivers/gpu/drm/drm_fb_helper.c | 39
>
> Mei hdcp driver is designed as component slave for the I915 component
> master.
>
> v2: Rebased.
> v3:
> Notifier chain is adopted for cldev state update [Tomas]
> v4:
> Made static dummy functions as inline in mei_hdcp.h
> API for polling client device status
> IS_ENABLED used in
Hi Brian,
On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote:
> On Thu, Feb 21, 2019 at 12:02:57PM +0200, Laurent Pinchart wrote:
> > On Thu, Feb 21, 2019 at 09:50:19AM +, Brian Starkey wrote:
> >> On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart wrote:
> >>> On Mon, Feb
On Tue, Feb 19, 2019 at 02:33:04PM -0800, Dylan Baker wrote:
> Quoting Emil Velikov (2019-02-19 08:51:18)
> > On Tue, 19 Feb 2019 at 15:36, Dylan Baker wrote:
> > >
> > > Quoting Daniel Vetter (2019-02-19 07:20:12)
> > > > On Tue, Feb 19, 2019 at 3:02 PM Eric Engestrom
> > > > wrote:
> > > > >
Hi Brian,
On Thu, Feb 21, 2019 at 09:34:10AM +, Brian Starkey wrote:
> On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote:
> > Hi Daniel,
> >
> > Thank you for the patch.
> >
> > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> >> No implementation, no callers.
1 - 100 of 183 matches
Mail list logo
