Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Brian J. Johnson
On 11/04/2015 02:08 PM, Laszlo Ersek wrote: On 11/04/15 17:55, Kinney, Michael D wrote: Laszlo, BaseXApicX2ApicLib is intended to be used by platforms that support more >=256 CPUs. If the current system configuration is < 256 CPUs, then the platform will typically stay in APIC mode. If >=

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Paolo Bonzini
On 04/11/2015 21:08, Laszlo Ersek wrote: > On 11/04/15 17:55, Kinney, Michael D wrote: >> Laszlo, >> >> BaseXApicX2ApicLib is intended to be used by platforms that support more >> >=256 CPUs. >> >> If the current system configuration is < 256 CPUs, then the platform will >> typically stay in

[edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-04 Thread liang yan
Hello, Laszlo, (1)I am trying to add ivshmem device(PCI device with big memory) to my aarch64 vm. So far, I could find device information from vm. But it seems vm did not create correct resource file for this device. Do you have any idea that this happens? I used the upstream EDK2 to build

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
Laszlo, Yes. They are compatible. And I do recommend switching to BaseXApicX2ApicLib unconditionally. Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Wednesday, November 04, 2015 12:09 PM >To: Kinney, Michael D;

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-04 Thread Kinney, Michael D
Laszlo, For the EFI_PEI_COMMUNICATION_PPI, is there a reason you are not using UefiCpuPkg\PiSmmCommunication\PiSmmCommunicationPei.inf to produce that PPI? Thanks, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, November 03, 2015 1:01 PM >To:

Re: [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-04 Thread Laszlo Ersek
On 11/04/15 23:22, liang yan wrote: > Hello, Laszlo, > > (1)I am trying to add ivshmem device(PCI device with big memory) to my > aarch64 vm. > So far, I could find device information from vm. But it seems vm did not > create > correct resource file for this device. Do you have any idea that this

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-04 Thread Kinney, Michael D
Liming, Why do you a different method than WORKSPACE to display the PACKAGES_PATH and EDK_TOOLS_BIN environment variables? Thanks, Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Tuesday, November 03, 2015 5:15 PM

Re: [edk2] [PATCH v2] NetworkPkg:Enable Http Boot over Ipv6 stack

2015-11-04 Thread Fu, Siyuan
Hi, Lin If you are using IPv6 address in URL you should enclose the IP address within square brackets ("[" and "]"), like http://[2000::1]:3260/boot.efi Please refer to RFC3986 http://tools.ietf.org/html/rfc3986#section-3.2.2 Siyuan -Original Message- From:

Re: [edk2] [Patch] BaseTools: Don't require ECP pkg in WORKSPACE when PACKAGES_PATH is set

2015-11-04 Thread Kinney, Michael D
Reviewed-by: Michael Kinney >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Tuesday, November 03, 2015 3:52 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Don't require ECP pkg

Re: [edk2] [PATCH v4 06/41] OvmfPkg: PlatformPei: account for TSEG size with PcdSmmSmramRequire set

2015-11-04 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, November 03, 2015 1:01 PM >To: edk2-de...@ml01.01.org >Cc: Kinney, Michael D >Subject: [PATCH v4 06/41] OvmfPkg: PlatformPei: account

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-11-04 Thread Ni, Ruiyu
The latest platform recovery patch I sent out was only two commits in local. I split the two to eleven to avoid you complain again:) Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Thursday, November 5, 2015 1:13

[edk2] 主旨： Re: [PATCH v2] NetworkPkg:Enable Http Boot over Ipv6 stack

2015-11-04 Thread Gary Lin
>>> "Fu, Siyuan" 2015/11/5 上午 8:44 >>> > Hi, Lin > > If you are using IPv6 address in URL you should enclose the IP address within > square brackets ("[" and "]"), like > http://[2000::1]:3260/boot.efi > Please refer to RFC3986 >

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Laszlo Ersek
On 11/04/15 16:19, Ard Biesheuvel wrote: > On 4 November 2015 at 13:17, Cohen, Eugene wrote: >>> The set/way operations are really only suitable for managing the caches >>> themselves >> >> This makes sense to me and I agree that the majority of developers should >> only be

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Ard Biesheuvel
On 4 November 2015 at 13:17, Cohen, Eugene wrote: >> The set/way operations are really only suitable for managing the caches >> themselves > > This makes sense to me and I agree that the majority of developers should > only be dealing with managing buffers and should only use the

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Mark Rutland
On Wed, Nov 04, 2015 at 12:17:16PM +, Cohen, Eugene wrote: > > The set/way operations are really only suitable for managing the caches > > themselves > > This makes sense to me and I agree that the majority of developers > should only be dealing with managing buffers and should only use the

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Cohen, Eugene
> The set/way operations are really only suitable for managing the caches > themselves This makes sense to me and I agree that the majority of developers should only be dealing with managing buffers and should only use the VA/address-range interface. > there are examples of architecturally

Re: [edk2] [PATCH v3 2/2] ShellPkg/UefiDpLib: Support dumping cumulative data

2015-11-04 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Tuesday, November 03, 2015 5:01 PM > To: Cinnamon Shia ; edk2-devel@lists.01.org > Subject: Re:

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix a DP cumulative data issue

2015-11-04 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Tuesday, November 03, 2015 5:01 PM > To: Cinnamon Shia ; edk2-devel@lists.01.org > Subject: Re:

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Mark Rutland
On Wed, Nov 04, 2015 at 04:24:20PM +0100, Laszlo Ersek wrote: > On 11/04/15 16:19, Ard Biesheuvel wrote: [...] > > The problem remains that VA and set/way ops are completely different > > things. Each by-VA operation handles all copies of the same cacheline > > throughout the cache hierarchy at

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
Laszlo, BaseXApicX2ApicLib is intended to be used by platforms that support more >=256 CPUs. If the current system configuration is < 256 CPUs, then the platform will typically stay in APIC mode. If >= 256 CPUs are detected, then X2 APIC mode can be enabled using the following API. VOID

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Andrew Fish
> On Nov 4, 2015, at 7:41 AM, Mark Rutland wrote: > > On Wed, Nov 04, 2015 at 04:24:20PM +0100, Laszlo Ersek wrote: >> On 11/04/15 16:19, Ard Biesheuvel wrote: > > [...] > >>> The problem remains that VA and set/way ops are completely different >>> things. Each by-VA

Re: [edk2] C Coding Standards Specification disappeared

2015-11-04 Thread Bruce Cran
On 11/4/15 9:44 AM, Jarlstrom, Laurie wrote: The Previous C Coding Standards Guide is currently being updated. A new revision will be posted shortly. Could someone post that information on the website please? By 'website' I guess I mean both the sourceforge _and_ github wikis, since for

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-11-04 Thread Leif Lindholm
Hi Ray, On Tue, Nov 03, 2015 at 02:27:29PM +, Ni, Ruiyu wrote: > Leif, > I saw your feedbacks as your opinion if you create patches. I don't > think your opinion is the *only* right solution. Oh, certainly. I was only expecting some sort of response before the patches were committed again.

Re: [edk2] C Coding Standards Specification disappeared

2015-11-04 Thread Jarlstrom, Laurie
Here is a link to a Draft to the 2.1 version : https://sourceforge.net/projects/edk2/files/Specifications/CCS_2_1_Draft.pdf/download thanks, Laurie   laurie.jarlst...@intel.com Intel SSG/STO/EBP (503) 712-9395 -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent:

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuDxe: Place APs into protected mode when ExitBootService

2015-11-04 Thread Paolo Bonzini
On 26/10/2015 23:31, Laszlo Ersek wrote: > > If QEMU could evaluate the AP state and not send an SMI to an AP in > > Wait-forSIPI, then updating SMIs to broadcast to all AP should work > > for SeaBios and OVMF. Yup, this has to be fixed in both QEMU and KVM (separately). I'm not 100% sure of

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuDxe: Place APs into protected mode when ExitBootService

2015-11-04 Thread Paolo Bonzini
On 27/10/2015 03:12, Fan, Jeff wrote: > Yes. On physical hw, Aps will not response SMI if Aps received SMI in > WFSI state. But Aps will have one pending SMI and will enter into SMM > once Aps receive Startup IPI. Interesting... so if the BIOS doesn't do SMBASE relocation, an INIT-SMI-SIPI

Re: [edk2] [PATCH 10/10] ArmPlatformPkg: do not invalidate the entire data cache at startup

2015-11-04 Thread Ard Biesheuvel
On 3 November 2015 at 11:16, Ard Biesheuvel wrote: > Drop the call to ArmInvalidateDataCache () from the PrePi and PrePeiCore > startup sequences. This kind of data cache maintenance should not be > performed at the UEFI firmware level. > > Contributed-under: TianoCore

Re: [edk2] [PATCH v4 13/41] OvmfPkg: LockBox: -D SMM_REQUIRE excludes our fake lockbox

2015-11-04 Thread Paolo Bonzini
On 03/11/2015 22:00, Laszlo Ersek wrote: > When the user builds OVMF with -D SMM_REQUIRE, our LockBox implementation > must not be used, since it doesn't actually protect data in the LockBox > from the runtime guest OS. Add an according assert to > LockBoxLibInitialize(). > > Furthermore, since

Re: [edk2] [PATCH v4 12/41] OvmfPkg: AcpiS3SaveDxe: don't fake LockBox protocol if SMM_REQUIRE

2015-11-04 Thread Paolo Bonzini
On 03/11/2015 22:00, Laszlo Ersek wrote: > In SVN r15306 (git commit d4ba06df), "OvmfPkg: S3 Resume: fake LockBox > protocol for BootScriptExecutorDxe", we installed a fake LockBox protocol > in OVMF's AcpiS3SaveDxe clone. While our other AcpiS3SaveDxe > customizations remain valid (or

Re: [edk2] [PATCH v4 35/41] OvmfPkg: port CpuS3DataDxe to X64

2015-11-04 Thread Paolo Bonzini
On 03/11/2015 22:01, Laszlo Ersek wrote: > From: Paolo Bonzini > > The descriptor format is different and the assembly source is > converted to nasm, but otherwise there is no difference. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paolo

Re: [edk2] [PATCH v2] NetworkPkg:Enable Http Boot over Ipv6 stack

2015-11-04 Thread Gary Ching-Pang Lin
On Tue, Nov 03, 2015 at 04:13:27PM +0800, Zhang Lubo wrote: > v2: > *Rewrite the logic of setting ipv6 gateway in httpboot driver and update some > comment. > > Fix a potential bug which can cause assert when setting ipv6 Gateway. If > there is no > router in network environment, it will fail

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Laszlo Ersek
On 11/04/15 09:48, Paolo Bonzini wrote: > > > On 03/11/2015 22:00, Laszlo Ersek wrote: >> + >> +!if $(SMM_REQUIRE) == TRUE >> + LocalApicLib|UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf >> +!else >>LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf >> +!endif >> +

Re: [edk2] [PATCH v4 13/41] OvmfPkg: LockBox: -D SMM_REQUIRE excludes our fake lockbox

2015-11-04 Thread Laszlo Ersek
On 11/04/15 09:52, Paolo Bonzini wrote: > > > On 03/11/2015 22:00, Laszlo Ersek wrote: >> When the user builds OVMF with -D SMM_REQUIRE, our LockBox implementation >> must not be used, since it doesn't actually protect data in the LockBox >> from the runtime guest OS. Add an according assert to

Re: [edk2] [PATCH v4 35/41] OvmfPkg: port CpuS3DataDxe to X64

2015-11-04 Thread Laszlo Ersek
On 11/04/15 09:54, Paolo Bonzini wrote: > > > On 03/11/2015 22:01, Laszlo Ersek wrote: >> From: Paolo Bonzini >> >> The descriptor format is different and the assembly source is >> converted to nasm, but otherwise there is no difference. >> >> Contributed-under: TianoCore