Re: [edk2] [Patch] BaseTools: generate alignment when the FV content come from the filesystem

2016-03-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, March 23, 2016 5:58 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: generate alignment when

Re: [edk2] [PATCH 2/2] SecurityPkg/SecureBootConfigDxe: Remove type casting from the ChooseFile handlers

2016-03-23 Thread Bi, Dandan
Hi Laszlo, Please help to commit these patches. Thanks! Thanks, Dandan -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Thursday, March 24, 2016 11:29 AM To: Bi, Dandan Cc: edk2-de...@ml01.01.org; Laszlo Ersek Subject: Re: [edk2]

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Heyi Guo [mailto:heyi@linaro.org] >Sent: Thursday, March 24, 2016 9:09 AM >To: Ryan Harkin ; Laszlo Ersek >Cc: Ni, Ruiyu ; Tian, Feng ;

Re: [edk2] [Patch] MdeModulePkg/Bds: Fix VS2012 build failure.

2016-03-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, March 24, 2016 10:34 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Tian, Feng Subject: [Patch] MdeModulePkg/Bds: Fix VS2012 build

Re: [edk2] [PATCH v2 1/1] MdePkg: Move SMBIOS data into the IndustryStandard header.

2016-03-23 Thread Zeng, Star
On 2016/3/23 10:37, Zeng, Star wrote: On 2016/3/22 22:53, Marvin Häuser wrote: As the SMBIOS table types belong to the SMBIOS standard, they were moved from the SMBIOS Protocol header into the SMBIOS IndustryStandard header without the EFI_-prefix. Defines with the EFI_-prefix have been kept in

[edk2] [Patch] MdeModulePkg/Bds: Fix VS2012 build failure.

2016-03-23 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Wednesday, March 23, 2016 4:53 PM >To: Ni, Ruiyu >Cc: Tian, Feng ; Ard Biesheuvel >;

Re: [edk2] [PATCH] BaseTools: use unsigned chars on ARM architectures

2016-03-23 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, March 17, 2016 9:23 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming ; Ard Biesheuvel

Re: [edk2] [Patch] NetworkPkg: Fix HII related problem in HTTP boot driver.

2016-03-23 Thread Wu, Jiaxin
Looks good to me. Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Wednesday, March 23, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Dong,

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Heyi Guo
Hi folks, Please see my thoughts below: On 03/24/2016 12:26 AM, Ryan Harkin wrote: On 23 March 2016 at 16:24, Ryan Harkin wrote: On 23 March 2016 at 08:53, Laszlo Ersek wrote: On 03/23/16 09:33, Ni, Ruiyu wrote: Laszlo, Since the patch below lets

Re: [edk2] [Patch] NetworkPkg: Fix HII related problem in HTTP boot driver.

2016-03-23 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Wednesday, March 23, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin; Dong, Eric > Subject: [edk2] [Patch]

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

2016-03-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Thursday, March 24, 2016 8:44 AM To: Alcantara, Paulo ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

2016-03-23 Thread Zeng, Star
Reviewed-by: Star Zeng On 2016/3/24 1:25, Alcantara, Paulo wrote: Forgot to add another S-b, sorry. Please add it: Signed-off-by: Juliano Ciocari Thanks, Paulo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

[edk2] UEFI Device PXE Boot fron MS Server

2016-03-23 Thread Jim Slaughter
Hello, I need to do a PXE boot :: UEFI Device Booting (Intel based) <--->  Microsoft Server. Is this possible? Does documentation exist? I need to size this task so what are the steps from high level? Any tips? Thanks. Jim S. ___ edk2-devel mailing

Re: [edk2] CrytoPkg: GCC build failing after update to openssl-1.0.2g

2016-03-23 Thread David Van Arnem
On 03/23/2016 02:58 PM, Ard Biesheuvel wrote: On 23 March 2016 at 21:39, David Van Arnem wrote: Hi all, I pulled the UDK2015 branch from the Tianocore github repository today and merged it into my local master branch so I have a stable release to base my work off of.

Re: [edk2] CrytoPkg: GCC build failing after update to openssl-1.0.2g

2016-03-23 Thread David Van Arnem
On 03/23/2016 02:39 PM, David Van Arnem wrote: Hi all, I pulled the UDK2015 branch from the Tianocore github repository today and merged it into my local master branch so I have a stable release to base my work off of. Then, I 1. did a clean and rebuild of BaseTools, 2. downloaded

Re: [edk2] CrytoPkg: GCC build failing after update to openssl-1.0.2g

2016-03-23 Thread Ard Biesheuvel
On 23 March 2016 at 21:39, David Van Arnem wrote: > Hi all, > > I pulled the UDK2015 branch from the Tianocore github repository today and > merged it into my local master branch so I have a stable release to base my > work off of. Then, I > > 1. did a clean and rebuild of

[edk2] CrytoPkg: GCC build failing after update to openssl-1.0.2g

2016-03-23 Thread David Van Arnem
Hi all, I pulled the UDK2015 branch from the Tianocore github repository today and merged it into my local master branch so I have a stable release to base my work off of. Then, I 1. did a clean and rebuild of BaseTools, 2. downloaded openssl-1.0.2g, patched it, and installed using

[edk2] Is EsrtDxe broken?

2016-03-23 Thread Felix Poludov
EsrtDxe publishes EsrtManagement protocol. It has (among others) SyncEsrtFmp() and LockEsrtRepository() functions. Here is the description of the functions from the protocol header file: SyncEsrtFmp(): This function syn up Cached ESRT with data from FMP instances Function should be called

Re: [edk2] EmulatorPkg build && run mode

2016-03-23 Thread Jordan Justen
On 2016-03-23 07:07:57, 王石磊 wrote: >Hello EDK build Team: >Well I now require help in building the EmulatorPkg on X64 >architecture. According to the "README" file under EmulatorPKg Dir, I can >build and run (./build.sh && ./build.sh run) EmulatorPkg , everythis is >

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

2016-03-23 Thread Alcantara, Paulo
Forgot to add another S-b, sorry. Please add it: Signed-off-by: Juliano Ciocari Thanks, Paulo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Alcantara, Paulo Sent: quarta-feira, 23 de março de 2016 14:20 To:

[edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

2016-03-23 Thread Alcantara, Paulo
s/Configutation/Configuration/ Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskHiiStrings.uni | 2 +- 1

Re: [edk2] [wave 2 PATCH 0/3] OvmfPkg: enable 64-bit PCI MMIO

2016-03-23 Thread Laszlo Ersek
On 03/22/16 07:10, Jordan Justen wrote: > o/ #2 > > Reviewed-by: Jordan Justen Many thanks. After version 2 of wave 1, I pushed this (= wave 2) as well, commit range 8f35eb92c419..4f5eff819309. Only wave 3 remains. I won't be poking you for reviews until next week!

Re: [edk2] [wave 1 PATCH v2 0/6] OvmfPkg: AcpiPlatformDxe: enable PCI IO and MMIO while fetching QEMU tables

2016-03-23 Thread Laszlo Ersek
On 03/23/16 16:43, Jordan Justen wrote: > Series Reviewed-by: Jordan Justen Thanks an awful lot for the reviews; pushed as 36e8e6992d0c..8f35eb92c419. Cheers! Laszlo > On 2016-03-23 07:46:04, Laszlo Ersek wrote: >> Version 2 of >>

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Laszlo Ersek
On 03/23/16 17:26, Ryan Harkin wrote: > On 23 March 2016 at 16:24, Ryan Harkin wrote: >> On 23 March 2016 at 08:53, Laszlo Ersek wrote: >>> On 03/23/16 09:33, Ni, Ruiyu wrote: Laszlo, Since the patch below lets SerialDxe driver use the new

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ryan Harkin
On 23 March 2016 at 16:24, Ryan Harkin wrote: > On 23 March 2016 at 08:53, Laszlo Ersek wrote: >> On 03/23/16 09:33, Ni, Ruiyu wrote: >>> Laszlo, >>> Since the patch below lets SerialDxe driver use the new introduced >>> PCD

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ryan Harkin
On 23 March 2016 at 08:53, Laszlo Ersek wrote: > On 03/23/16 09:33, Ni, Ruiyu wrote: >> Laszlo, >> Since the patch below lets SerialDxe driver use the new introduced >> PCD gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth. >> Would you mind to revert the check in @

Re: [edk2] [wave 1 PATCH v2 0/6] OvmfPkg: AcpiPlatformDxe: enable PCI IO and MMIO while fetching QEMU tables

2016-03-23 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2016-03-23 07:46:04, Laszlo Ersek wrote: > Version 2 of > . > > In this version, BDS notifies AcpiPlatformDxe by signaling an event > group, rather than by

Re: [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'.

2016-03-23 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, March 22, 2016 1:36 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent >

Re: [edk2] EmulatorPkg build && run mode

2016-03-23 Thread Andrew Fish
> On Mar 23, 2016, at 7:07 AM, 王石磊 wrote: > > Hello EDK build Team: > Well I now require help in building the EmulatorPkg on X64 > architecture. According to the "README" file under EmulatorPKg Dir, I can > build and run (./build.sh && ./build.sh run) EmulatorPkg ,

[edk2] [PATCH v2] OptionRomPkg: Ax88772b: support for multiple dongles and chips

2016-03-23 Thread Shivamurthy Shastri
Driver code is modified to support multiple ethernet dongles, which uses similar ASIX chips. Also, it can be used for multiple ASIX chips with similar register map. Enabled support for Apple Ethernet Adapter Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shivamurthy

Re: [edk2] [wave 1 PATCH v2 4/6] ArmVirtPkg: PlatformIntelBdsLib: signal gRootBridgesConnectedEventGroupGuid

2016-03-23 Thread Ard Biesheuvel
On 23 March 2016 at 15:46, Laszlo Ersek wrote: > The explanation is in the patch titled > > OvmfPkg: introduce gRootBridgesConnectedEventGroupGuid > > At this point, this signal doesn't do anything yet. > > Cc: Ard Biesheuvel > Cc: Jordan Justen

[edk2] [wave 1 PATCH v2 5/6] OvmfPkg: AcpiPlatformDxe: when PCI is enabled, wait for Platform BDS's cue

2016-03-23 Thread Laszlo Ersek
This patch doesn't change the behavior of AcpiPlatformDxe when PcdPciDisableBusEnumeration is TRUE -- that is, when the driver runs on Xen (OvmfPkg and ArmVirtPkg both), or when the driver runs on QEMU as part of ArmVirtPkg but no PCI host bridge was found by VirtFdtDxe. In these cases the driver

[edk2] [wave 1 PATCH v2 1/6] OvmfPkg: OvmfPkg.dec: add horizontal whitespace under Guids and Protocols

2016-03-23 Thread Laszlo Ersek
We'll need more room in the next patch. No functional changes. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - new in v2 OvmfPkg/OvmfPkg.dec | 18 +- 1

[edk2] [wave 1 PATCH v2 4/6] ArmVirtPkg: PlatformIntelBdsLib: signal gRootBridgesConnectedEventGroupGuid

2016-03-23 Thread Laszlo Ersek
The explanation is in the patch titled OvmfPkg: introduce gRootBridgesConnectedEventGroupGuid At this point, this signal doesn't do anything yet. Cc: Ard Biesheuvel Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement

[edk2] [wave 1 PATCH v2 3/6] OvmfPkg: PlatformBdsLib: signal gRootBridgesConnectedEventGroupGuid

2016-03-23 Thread Laszlo Ersek
The explanation is in the patch titled OvmfPkg: introduce gRootBridgesConnectedEventGroupGuid At this point, this signal doesn't do anything yet. Cc: Ard Biesheuvel Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement

[edk2] [wave 1 PATCH v2 6/6] OvmfPkg: AcpiPlatformDxe: enable PCI IO and MMIO while fetching QEMU tables

2016-03-23 Thread Laszlo Ersek
Now that the previous patches ensure that we can access all PCI devices in AcpiPlatformDxe, we can enable IO and MMIO decoding for all of them while we contact QEMU for the ACPI tables. See more details in the patch titled: OvmfPkg: introduce gRootBridgesConnectedEventGroupGuid In particular,

[edk2] [wave 1 PATCH v2 2/6] OvmfPkg: introduce gRootBridgesConnectedEventGroupGuid

2016-03-23 Thread Laszlo Ersek
QEMU's ACPI table generator can only create meaningful _CRS objects -- apertures -- for the root buses if all of the PCI devices behind those buses are actively decoding their IO and MMIO resources, at the time of the firmware fetching the "etc/table-loader" fw_cfg file. This is not a QEMU error;

Re: [edk2] [PATCH 0/6] introduce EfiEventGroupSignal(), rebase ArmVirtPkg and OvmfPkg

2016-03-23 Thread Laszlo Ersek
On 03/23/16 10:55, Gao, Liming wrote: > Laszlo: > I agree new API EfiEventGroupSignal() is useful. Your change is good to me. > Reviewed-by: Liming Gao Thank you! I pushed this series with feedback labels from Ard, Jordan and Liming: 3570e3324835..36e8e6992d0c. Should

[edk2] [Patch] BaseTools: generate alignment when the FV content come from the filesystem

2016-03-23 Thread Yonghong Zhu
when the FV contents come from the filesystem instead of from a named FDF section, the build tool missed to generate alignment for this FV. The fix is get the alignment value from FV header and use this value to generate alignment. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Heyi Guo
Hi Ruiyu, Many thanks for your review. For questions 2#, I tested equation #1 with copy-paste on serial terminal, and found it still missing some characters when the FIFO was almost full (i.e. near the end of input). I think it is because time event is not real-time interrupt; it may be

[edk2] [Patch] BaseTools: Add two new sections for PCD in the build report

2016-03-23 Thread Yonghong Zhu
Build Spec updated to add two new sections for PCD in the build report. 1.Conditional directives section:If the DSC or FDF file contains conditional directive statements. 2.Unused PCDs section: If the DSC or FDF file define values for PCDs that are not used by any module and are not used in

Re: [edk2] Error while loading a symbol file (No Debug Directory)

2016-03-23 Thread Ard Biesheuvel
On 22 March 2016 at 19:19, Vladimir Olovyannikov wrote: > Sorry for the spam, > Sending to the proper list now > > -Original Message- > From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] > Sent: Tuesday, March 22, 2016 11:15 AM >

Re: [edk2] [Patch v2] BaseTools: not include the undefined macro in response file

2016-03-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, March 23, 2016 3:05 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch v2] BaseTools: not include the

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
Thanks for the understanding. I will post the patch to revert the change. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Wednesday, March 23, 2016 4:53 PM >To: Ni, Ruiyu >Cc: Tian, Feng

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Laszlo Ersek
On 03/23/16 09:33, Ni, Ruiyu wrote: > Laszlo, > Since the patch below lets SerialDxe driver use the new introduced > PCD gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth. > Would you mind to revert the check in @ 31ae446b > --> MdeModulePkg: TerminalDxe: select the UART's default receive

Re: [edk2] ld -z being used linking PE (not ELF) binaries?

2016-03-23 Thread Ard Biesheuvel
(+ Jordan, Liming) On 23 March 2016 at 01:11, Charles Duffy wrote: > Howdy -- > > I'm running an edk2 build with TOOL_CHAIN_TAG=UNIXGCC. > > This eventually fails as follows: > > Building ... >

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
Laszlo, Since the patch below lets SerialDxe driver use the new introduced PCD gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth. Would you mind to revert the check in @ 31ae446b --> MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth? Regards, Ray >-Original

Re: [edk2] [PATCH] Ax88772b: support for multiple dongles and chips

2016-03-23 Thread Ni, Ruiyu
I have no concern about the logic. Just some comments about the coding style. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shivamurthy Shastri >Sent: Wednesday, February 10, 2016 10:10 PM >To: edk2-devel@lists.01.org >Cc:

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Ni, Ruiyu
Heyi, I have comments in below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo >Sent: Thursday, March 17, 2016 10:37 PM >To: edk2-devel@lists.01.org >Cc: Heyi Guo ; Tian, Feng ;

Re: [edk2] [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for ChooseFile handler

2016-03-23 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 22, 2016 11:37 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for > ChooseFile handler >

[edk2] [Patch] NetworkPkg: Fix HII related problem in HTTP boot driver.

2016-03-23 Thread Fu Siyuan
According to UEFI spec, HII_Config_Access.RouteConfig() should return success if the required configuration has been processed. Current HTTP boot driver may return error code in some situation, which failed the UEFI SCT test. This patch fix this issue by removing the returned error status code and

Re: [edk2] [Patch] MdeModulePkg/PciBus: Should reserve enough bus number for HPC

2016-03-23 Thread Fan, Jeff
Reviewed-off-by: Jeff Fan -Original Message- From: Ni, Ruiyu Sent: Wednesday, March 23, 2016 2:16 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff Subject: [Patch] MdeModulePkg/PciBus: Should reserve enough bus number for HPC When there is no bridge before

[edk2] [Patch v2] BaseTools: not include the undefined macro in response file

2016-03-23 Thread Yonghong Zhu
In last Nmake patch, when we generate the response file, we would replace all the Macros in the make file. Once there have undefined macro used, the tool direct report error. In this patch, we use following solution to resolve the failure. 1. Add all the defined macros into AutoGenObject macro

[edk2] [Patch] MdeModulePkg/PciBus: Should reserve enough bus number for HPC

2016-03-23 Thread Ruiyu Ni
When there is no bridge before the HPC (hot plug controller), the issue cannot be seen. But when there are bridges before the HPC, the PciBus will only use the value (= + ) as the sub-ordinary bus number for HPC. The correct sub-ordinary bus number should be: + (by earlier bridges) + .