[edk2] [Patch] Vlv2TbltDevicePkg:Signal End of Dxe Event.

2016-08-31 Thread lushifex
According to PI spec,DxeSmmReadyToLock protocol is published immediately after signaling of the End of Dxe Event. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 10 +-

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

2016-08-31 Thread Jin, Eric
For the TRUSTED RECEIVE commands of the ATA8-ACS command, in the ATA8-ACS spec, the total data length shall be 512 bytes. Pad bytes are appended as needed to meet this requirement. Pad bytes shall have a value of 00h. For the SECURITY PROTOCOL IN commands of the SPC-4 command, In the SPC-4

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

2016-08-31 Thread Tian, Feng
I checked the ATA spec, it says the transfer length of "Trust-Send" ATA cmd should be 512. But for NVMe and other SCSI device, I didn't see any length limitation on "Security Protocol In" cmd with security protocol field 0 and security protocol specific field 0. It seems user could pass in

[edk2] [PATCH v2 09/10] MdeModulePkg NvmExpressDxe: Fix 'Event' won't be signaled for Admin cmds

2016-08-31 Thread Hao Wu
This commit fixes the issue that the caller event passed to EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.PassThru() will not be signaled for NVME Admin commands. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH v2 06/10] MdeModulePkg NvmExpressDxe: Add check on the attributes of NVME controller

2016-08-31 Thread Hao Wu
According to UEFI spec, an EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL with neither EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_LOGICAL nor EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_PHYSICAL set in the Attributes field is an illegal configuration. This commit adds this check in the PassThru API to follow the spec.

[edk2] [PATCH v2 01/10] MdeModulePkg NvmExpressDxe: Avoid crashing 'Mode' during OpenProtocol

2016-08-31 Thread Hao Wu
The gBS->OpenProtocol() calls to open EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL in NvmExpress.c will crash the data in 'Mode' field of 'Private->Passthru'. The third parameter of gBS->OpenProtocol() is an output parameter that stores the address where a pointer to the corresponding Protocol Interface.

[edk2] [PATCH v2 07/10] MdeModulePkg NvmExpressDxe: Add check for command packet in PassThru

2016-08-31 Thread Hao Wu
This commit adds serveral checks for the 'Packet' parameter passed to the EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.PassThru() API: The check for the 'TransferLength' field in EFI_NVM_EXPRESS_PASS_THRU_COMMAND_PACKET to make sure the value will not exceed the maximum data transfer size allowed by a

[edk2] [PATCH v2 10/10] MdeModulePkg NvmExpressDxe: Set the non-blocking I/O feature support bit

2016-08-31 Thread Hao Wu
Since current codes in NvmExpressDxe already support the non-blocking I/O feature for EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL interface, the relative bit in the 'Attributes' field of EFI_NVM_EXPRESS_PASS_THRU_MODE should be set to reflect this. Cc: Feng Tian Contributed-under:

[edk2] [PATCH v2 03/10] MdeModulePkg NvmExpressDxe: Refine GetNameSpace API to follow spec

2016-08-31 Thread Hao Wu
According to the UEFI spec, EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.GetNamespace() should return EFI_NOT_FOUND when the input DevicePath is a device path node type that the NVM Express Pass Thru driver supports, but there is not a valid translation from DevicePath to a namespace ID. Current code will

[edk2] [PATCH v2 05/10] MdeModulePkg NvmExpressDxe: Add buffer alignment check in PassThru API

2016-08-31 Thread Hao Wu
According to the UEFI spec, the 'TransferBuffer' and 'MetadataBuffer' used in a data transfer should be aligned on the boundary specified by the IoAlign field in the EFI_NVM_EXPRESS_PASS_THRU_MODE structure. This commit adds this check to follow the spec. Cc: Feng Tian

[edk2] [PATCH v2 04/10] MdeModulePkg NvmExpressDxe: Refine GetNextNamespace API to follow spec

2016-08-31 Thread Hao Wu
According to the UEFI spec, EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.GetNextNamespace() should return EFI_NOT_FOUND when the value pointed to by NamespaceId is the namespace ID of the last namespace on the NVM Express controller. This commit modifies the check for NamespaceId to follow this rule. Cc:

[edk2] [PATCH v2 08/10] MdeModulePkg NvmExpressDxe: Add NamespaceId validity check in PassThru

2016-08-31 Thread Hao Wu
According to the UEFI spec, EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.PassThru() should return EFI_INVALID_PARAMETER if the input 'NamespaceId' is invalid for the NVM Express controller. This commit adds check in PassThru() to follow this rule. Cc: Feng Tian Contributed-under:

[edk2] [PATCH v2 00/10] Fix some bugs in NvmExpressDxe driver

2016-08-31 Thread Hao Wu
Compared with V1 of the series, the following changes are made: 1. Add NamespaceId validity check in EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.PassThru(). 2. Fixes the issue that the caller event passed to EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.PassThru() will not be signaled for NVME Admin

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Wang, Sunny (HPS SW)
Got it. Thanks for confirming this and working on the replacement. Regards, Sunny Wang -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, September 01, 2016 10:20 AM To: Wang, Sunny (HPS SW) ; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Gao, Liming
Sunny: Yes. This is the replacement of Eric patch. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wang, Sunny (HPS SW) > Sent: Thursday, September 01, 2016 10:18 AM > To: Gao, Liming ;

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add NominalSpeed in Type 27 to black list

2016-08-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, September 1, 2016 10:01 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add >

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Wang, Sunny (HPS SW)
Hi Liming, Except Ray's comment, others Look good to me. Reviewed-by: Sunny Wang Hi Ray and Eric, It looks like this code change is used for replacing the one which we offline discussed to fix the duplicated Boot Manager menu issue, isn't it? - [edk2] [Patch]

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Gao, Liming
Ok. Got your comments. This patch just ignores BootManagerMenu from LoadFile. Next patch will rename BootMenuApp to BootManagerMenu. I will update them. Thanks Liming > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, September 01, 2016 10:02 AM > To: Gao, Liming

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenuApp

2016-08-31 Thread Ni, Ruiyu
Liming, Please use the term "BootManagerMenu" instead of "BootMenuApp", to avoid confusion when reading from future developers. BmIsBootMenuAppFilePath --> BmIsBootManagerMenuFilePath With the above change, Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- >

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Ni, Ruiyu
Liming, Please use the term "BootManagerMenu" instead of "BootMenuApp", to avoid confusion when reading from future developers. // Ignore BootMenuApp. its boot option will be created by BmRegisterBootManagerMenu(). --> // Ignore BootManagerMenu, which will be auto-created by

[edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add NominalSpeed in Type 27 to black list

2016-08-31 Thread Star Zeng
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../SmbiosMeasurementDxe/SmbiosMeasurementDxe.c| 31 ++ 1 file changed, 20 insertions(+), 11 deletions(-) diff --git

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Wednesday, August 31, 2016 1:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 31, 2016 6:09 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: RE: [edk2] [patch] ShellPkg: Add

Re: [edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

2016-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 31, 2016 1:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [patch] ShellPkg: Add the check of parameter

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-31 Thread Fan, Jeff
Laszlo, UefiCpuPkg/PiSmmCpuDxeSmm driver and UefiCpuPkg/Library/SmmCpuFeatuersLib have no such requirement on gEfiVariableArchProtocolGuid to access HII type PCD. In fact, our platform SmmCpuFeaturesLib instance (linked by PiSmmCpuDxeSmm) is trying to read HII type PCD. The correct solution

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Bi, Dandan
Our codes have already checked for "too few " case, and it will print " Too few arguments" in this situation. Thanks, Dandan -Original Message- From: Carsey, Jaben Sent: Thursday, September 1, 2016 12:12 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] UnicodeError: UTF-16 stream does not start with BOM error when update from UDK2015 to latest Github trunk

2016-08-31 Thread Gao, Liming
Matthew: The temp way is to convert all uni files to UTF16 format. You can use edk2 trunk BaseTools\Scripts\ConvertUni.py to convert uni file format. Thanks Liming > -Original Message- > From: Foster, Matthew I > Sent: Thursday, September 01, 2016 3:04 AM > To: Gao, Liming

Re: [edk2] Crc32

2016-08-31 Thread valerij zaporogeci
>> I was thinking that all the difference in the Tianocore impl. from the >> pure crc is appending 32 1's at the beginning of the (input) message >> and then negating the Crc itself in the end. Thank you, Michael and Andrew for your help. I figured out what causes the difference. Apart from

Re: [edk2] UnicodeError: UTF-16 stream does not start with BOM error when update from UDK2015 to latest Github trunk

2016-08-31 Thread Foster, Matthew I
Is there a way to work-around this error without having to upgrade to the newest BaseTools? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Monday, February 29, 2016 11:08 PM To: wang xiaofeng ;

[edk2] [PATCH v2 5/6] ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support

2016-08-31 Thread Ard Biesheuvel
If the pci-host-ecam-generic DT node describes a 64-bit MMIO region, account for it in the PCI_ROOT_BRIDGE description that we return to the generic PciHostBridgeDxe implementation, which will be able to allocate BARs from it without any further changes. Contributed-under: TianoCore Contribution

[edk2] [PATCH v2 4/6] ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe

2016-08-31 Thread Ard Biesheuvel
Wire up the FdtPciHostBridgeLib introduced in the previous patch to the generic PciHostBridgeDxe implementation, and drop the special ArmVirtPkg version. The former's dependency on gEfiCpuIo2ProtocolGuid is satisfied by adding ArmPciCpuIo2Dxe.inf as well, and adding the PCD

[edk2] [PATCH v2 3/6] ArmVirtPkg: implement FdtPciHostBridgeLib

2016-08-31 Thread Ard Biesheuvel
Implement PciHostBridgeLib for DT platforms that expose a PCI root bridge via a pci-host-ecam-generic DT node. The DT parsing logic is copied from the PciHostBridgeDxe implementation in ArmVirtPkg, with the one notable difference that we don't set the various legacy PCI attributes for IDE and VGA

[edk2] [PATCH v2 0/6] ArmVirtQemu: move to generic PciHostBridgeDxe

2016-08-31 Thread Ard Biesheuvel
Now that Laszlo's virtio-gpu-pci series has removed the last remaining obstacle, we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg, and move to the generic one. On AArch64, this will allow us to perform DMA above 4GB without bounce buffering, and use 64-bit MMIO BARs

[edk2] [PATCH v2 1/6] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property

2016-08-31 Thread Ard Biesheuvel
Setting the linux,pci-probe-only was intended to align OSes booting via DT with OSes booting via ACPI in the way they honor the PCI configuration performed by the firmware. However, ACPI on arm64 does not currently honor the firmware's PCI configuration, and the linux,pci-probe-only completely

[edk2] [PATCH v2 2/6] ArmVirtPkg/FdtPciPcdProducerLib: add handling of PcdPciIoTranslation

2016-08-31 Thread Ard Biesheuvel
Add handling of the PcdPciIoTranslation PCD, so that modules that include this library via NULL resolution are guaranteed that it will be set before they reference it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Ref:

Re: [edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

2016-08-31 Thread Carsey, Jaben
Seems like a good check. Reviewed-by: Jaben Carsey > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Wednesday, August 31, 2016 7:24 AM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu

Re: [edk2] Crc32

2016-08-31 Thread valerij zaporogeci
yes. it does as you said. very confusing in fact. 2016-08-31 6:54 GMT+03:00, Michael Zimmermann : > it doesn't. it just seems that if the crc text field is not empty it > calculates the crc of the crc, so you have to hit the "Reset CRC" button > before reprocessing the

Re: [edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

2016-08-31 Thread Shah, Tapan
Reviewed-by: Tapan Shah -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 31, 2016 12:27 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Jaben Carsey

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Shah, Tapan
Reviewed-by: Tapan Shah -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 31, 2016 12:27 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Jaben Carsey

Re: [edk2] [PATCH 5/5] ArmVirtPkg: remove now unused PciHostBridgeDxe

2016-08-31 Thread Laszlo Ersek
On 08/22/16 08:35, Ard Biesheuvel wrote: > This code is now no longer used, so remove it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c | 1458 - >

Re: [edk2] [PATCH 4/5] ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support

2016-08-31 Thread Laszlo Ersek
On 08/22/16 08:35, Ard Biesheuvel wrote: > If the pci-host-ecam-generic DT node describes a 64-bit MMIO region, > account for it in the PCI_ROOT_BRIDGE description that we return to > the generic PciHostBridgeDxe implementation, which will be able to > allocate BARs from it without any further

Re: [edk2] [PATCH 2/5] ArmVirtPkg: implement FdtPciHostBridgeLib

2016-08-31 Thread Laszlo Ersek
On 08/24/16 17:19, Ard Biesheuvel wrote: > On 24 August 2016 at 17:01, Laszlo Ersek wrote: >> On 08/22/16 02:35, Ard Biesheuvel wrote: >>> + PcdSet64 (PcdPciIoTranslation, IoTranslation); >> >> I agree this is necessary, but it's not in the right place, plus as-is, >> it is

Re: [edk2] [PATCH 0/3] ArmPkg: introduce IsZeroGuid() and IsZeroBuffer()

2016-08-31 Thread Leif Lindholm
On Wed, Aug 31, 2016 at 10:07:30AM +0100, Ard Biesheuvel wrote: > The BaseMemoryLib API has recently been extended with IsZeroGuid() and > IsZeroBuffer(), so copy the generic implementations into the ArmPkg version > of this library. Maybe this is a good point at which to move these into MdePkg,

Re: [edk2] [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

2016-08-31 Thread Evan Lloyd
>-Original Message- >From: Sudeep Holla [mailto:sudeep.ho...@arm.com] >Sent: 25 August 2016 18:09 >To: edk2-devel@lists.01.org; Linaro UEFI; Evan Lloyd; Leif Lindholm >Cc: Sudeep Holla; ard.biesheu...@linaro.org >Subject: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher >

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Ard Biesheuvel
On 31 August 2016 at 10:52, Michael Zimmermann wrote: >>Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and >> "Tested-by" > mean tested? > Yes you're right, sorry. I guess I just had too much hope in reviewers > actually testing the changes :D >

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Michael Zimmermann
>Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and "Tested-by" > mean tested? Yes you're right, sorry. I guess I just had too much hope in reviewers actually testing the changes :D On Wed, Aug 31, 2016 at 11:47 AM, Evan Lloyd wrote: > >-Original

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Evan Lloyd
>-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Zimmermann >Sent: 31 August 2016 05:33 >To: Leif Lindholm >Cc: edk2-devel@lists.01.org; Cohen, Eugene; Laszlo Ersek; >ard.biesheu...@linaro.org >Subject: Re: [edk2] [PATCH 22/26]

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Ard Biesheuvel
On 31 August 2016 at 10:43, Michael Zimmermann wrote: > ArmVirtQemuKernel uses ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S which is not > affected by this bug. > Ah, of course. It does highlight why having so many copies of essentially the same code is a bad idea, but it is

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Michael Zimmermann
ArmVirtQemuKernel uses ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S which is not affected by this bug. as it turns out, only BeagleBoardPkg uses the generic PrePi code. On Wed, Aug 31, 2016 at 11:14 AM, Ard Biesheuvel wrote: > On 31 August 2016 at 05:33, Michael

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

2016-08-31 Thread Ard Biesheuvel
On 31 August 2016 at 05:33, Michael Zimmermann wrote: > reviewed should mean tested ;) > Apologies for the breakage. As it turns out, ArmVirtQemuKernel does work even with this bug, probably due to the fact that its PcdCoreCount == 1 (or simply that it uses the UniCore

[edk2] [PATCH 0/3] ArmPkg: introduce IsZeroGuid() and IsZeroBuffer()

2016-08-31 Thread Ard Biesheuvel
The BaseMemoryLib API has recently been extended with IsZeroGuid() and IsZeroBuffer(), so copy the generic implementations into the ArmPkg version of this library. Ard Biesheuvel (3): ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib ArmPkg/BaseMemoryLibStm: implement new

[edk2] [PATCH 1/3] ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib

2016-08-31 Thread Ard Biesheuvel
The BaseMemoryLibVstm implementation of BaseMemoryLib is ARM only, uses the NEON register file despite the fact that the UEFI spec does not allow it, and is currently not used anywhere. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 3/3] ArmPkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function

2016-08-31 Thread Ard Biesheuvel
BaseMemoryLib has recently been extended with an API function IsZeroBuffer(), so copy the default implementation into BaseMemoryLibStm as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 2/3] ArmPkg/BaseMemoryLibStm: implement new IsZeroGuid() API function

2016-08-31 Thread Ard Biesheuvel
BaseMemoryLib has recently been extended with an API function IsZeroGuid(), so copy the default implementation into BaseMemoryLibStm as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v5 3/4] MdeModulePkg/EbcDxe AARCH64: use tail call for EBC to native thunk

2016-08-31 Thread Ard Biesheuvel
Instead of pessimistically copying at least 64 bytes from the VM stack to the native stack, and popping off the register arguments again before doing the native call, try to avoid touching the stack completely if the VM stack frame is <= 64 bytes. Also, if the stack frame does exceed 64 bytes,

[edk2] [PATCH v5 4/4] MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry point thunks

2016-08-31 Thread Ard Biesheuvel
The prototypes of EbcInterpret() and ExecuteEbcImageEntryPoint() are private to the AARCH64 implementation of EbcDxe, so we can shuffle the arguments around a bit and make the assembler thunking glue a lot simpler. For ExecuteEbcImageEntryPoint(), this involves passing the EntryPoint argument as

[edk2] [PATCH v5 1/4] MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file

2016-08-31 Thread Ard Biesheuvel
Change to consistent // style comments. Also, remove bogus global definitions for external functions, and move the real exports to the top of the file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

[edk2] [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements

2016-08-31 Thread Ard Biesheuvel
This is v5 of my proposed changes to the AARCH64 implementation of EbcDxe contributed by Jeff Brasen, which has recently been merged into Tianocore. Changes since v5: - added Leif's ack (#3) - cc MdeModulePkg maintainers Changes since v3: - fix typo in comment (#1) - clarify comments around

[edk2] [Patch] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenuApp

2016-08-31 Thread Liming Gao
Rename local function name BootMenuApp to BootManagerMenuApp to align to other public function name. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c |

[edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Liming Gao
BootManagerMenuApp boot option is handled by EfiBootManagerGetBootManagerMenu. Don't need to handle it again when parse LoadFile protocol. Cc: Ruiyu Ni Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

Re: [edk2] [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex

2016-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, August 26, 2016 5:41 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Zeng, Star