Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

Agree all. From: Mudusuru, Giri P Sent: Tuesday, October 25, 2016 11:43 AM To: Yao, Jiewen ; Dong, Guo ; edk2-devel@lists.01.org Cc: Ma, Maurice Subject: RE: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

We can add full description with note that only skip NotifyPhase Post PCI enumeration is implemented. 1) Change "BIT0~15 is for function:" to "BIT[15:0] is for function:" and "BIT16~32 is for sub-function:" to "BIT[32:16] is for sub-function:" for consistency 2) Suggest to rename fix below

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Ni, Ruiyu Sent: Tuesday, October 25, 2016 10:18 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [PATCH v2 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID

[edk2] [PATCH v2 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- .../Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [edk2] [Patch] AppPkg: Update email and URL.

Hi Jaben, I have two comment: 1. The copyright year need update. 2. The PACKAGE_URL is not same in several pyconfig.h, is this our expected ? Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent:

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

Thanks Guo. Can we add full description for the PCD? # BIT0~15 is for function: # BIT0 - Mask TempRamInit # BIT1 - Mask MemoryInit # BIT2 - Mask TempRamExit # BIT3 - Mask SiliconInit # BIT4 - Mask NotifyPhase # BIT16~32 is for sub-function: # BIT16 - Mask NotifyPhase

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

Hi Laszlo, Sorry for the delay. I was traveling last week. I did see this and I have been thinking about it. I think it does make sense to add this new macro for libraries of type BASE. I am surprised we did not run into an issue before that would have required the introduction of this macro

[edk2] [PATCH] CorebootPayloadPkg DSC: Add build option to disable deprecated APIs

Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated. As a result replaced PcdSet32 with PcdSet32S accordingly to make the build pass. [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Prince Agyeman

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

Mike, Liming, On 10/21/16 23:27, Laszlo Ersek wrote: > ASSERT_EFI_ERROR() cannot be used in BASE type modules because > - the replacement text calls EFI_ERROR(), > - EFI_ERROR() is defined in "MdePkg/Include/Uefi/UefiBaseType.h", > - the inclusion of "UefiBaseType.h" is not required for BASE type

Re: [edk2] [PATCH 17/19] ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()

On 10/24/16 20:47, Jordan Justen wrote: > On 2016-10-24 00:58:46, Ard Biesheuvel wrote: >> On 21 October 2016 at 22:27, Laszlo Ersek wrote: >>> AsciiStrCat() is deprecated / disabled under the >>> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. >>> >>> The "Str" variable

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

Series Reviewed-by: Jordan Justen On 2016-10-21 14:27:18, Laszlo Ersek wrote: > This series intends to solve the following BZs: > > -- OvmfPkg: Add > the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in

Re: [edk2] [PATCH 17/19] ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()

On 2016-10-24 00:58:46, Ard Biesheuvel wrote: > On 21 October 2016 at 22:27, Laszlo Ersek wrote: > > AsciiStrCat() is deprecated / disabled under the > > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > > > The "Str" variable serves no particular purpose in the

[edk2] [PATCH 7/9] EmbeddedPkg/EfiFileLib: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/EfiFileLib/EfiFileLib.c | 42 +++- 1 file

[edk2] [PATCH 3/9] EmbeddedPkg: add missing modules

Add modules that live under EmbeddedPkg but were missing from the [Components] section of the package .dsc file Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dsc | 9 + 1 file changed, 9

[edk2] [PATCH 6/9] EmbeddedPkg/Ebl: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Ebl/Command.c | 2 +- EmbeddedPkg/Ebl/Dir.c | 4 ++--

[edk2] [PATCH 9/9] EmbeddedPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 8/9] EmbeddedPkg/MmcDxe: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Universal/MmcDxe/Diagnostics.c | 2 +- 1 file changed, 1

[edk2] [PATCH 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c | 3 ++-

[edk2] [PATCH 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size

The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, so add an intermediate UINTN cast to make this code build again on 32 bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 2/9] EmbeddedPkg: remove unused PrePiHobListPointerLib

Remove this unused version: all existing platforms use the one under ArmPlatformPkg instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dec | 1 -

[edk2] [PATCH 1/9] EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname handling

The fastboot TCP connection setup routine retrieves a hostname from a UEFI variable 'hostname' that is scoped under a GUID gEfiHostnameVariableGuid whose definition is missing from the code. Since the hostname is only printed and then discarded, let's just drop the whole thing. Contributed-under:

[edk2] [PATCH 0/9] EmbeddedPkg: eliminate calls to deprecated functions

This series prepares EmbeddedPkg for building with the preprocess symbol DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components to EmbeddedPkg (#3), fixing broken code or code that relies on deprecated functionality (#1 - #2, #4 - #8), and finally adds

Re: [edk2] [PATCH] ShellPkg: handle '-t or -terse' and '-s' flags for 'ver' command properly

Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Monday, October 24, 2016 9:57 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > >

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

Thanks all for these comments. I have sent an updated patch, please help review. Thanks, Guo From: Mudusuru, Giri P Sent: Sunday, October 23, 2016 6:53 AM To: Yao, Jiewen ; Dong, Guo ; edk2-devel@lists.01.org Cc: Ma, Maurice ;

[edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

PciEnumerationComplete might be signaled to FSP in Coreboot. So FSP wrapper driver don't need send it again. Add a PCD to control if a FSP API could be skipped from FspWrapperNotifyDxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong

[edk2] [PATCH] ShellPkg: handle '-t or -terse' and '-s' flags for 'ver' command properly

'-t or -terse' and '-s' flags are multiple exclusive So when both flags are used together, command should report an error message. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tapan Shah --- ShellPkg/Library/UefiShellLevel3CommandsLib/Ver.c | 24

[edk2] [Patch] AppPkg: Update email and URL.

CC: Daryl McDaniel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey --- AppPkg/Applications/Python/Ia32/pyconfig.h | 4 ++-- AppPkg/Applications/Python/Ipf/pyconfig.h| 4 ++--

Re: [edk2] [PATCH] ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

On 24 October 2016 at 16:36, Ryan Harkin wrote: > On 24 October 2016 at 14:05, Laszlo Ersek wrote: >> On 10/24/16 15:01, Ard Biesheuvel wrote: >>> While most compilers happily allow arithmetic on void pointer, >>> the RVCT compiler does not, and throws

Re: [edk2] [PATCH] ARMPkg: Unified the GIC base address variables as 64-bit width

On 24 October 2016 at 12:47, Ryan Harkin wrote: > On 24 October 2016 at 04:04, Dennis Chen wrote: >> Since ACPI spec defines the GIC base addresses (CPU interface, >> Distributor and Redistributor*GICv3 only*) as 64-bit, so we should >> define these

[edk2] [PATCH 6/6] ArmPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

Remove calls to deprecated string functions like AsciiStrCpy() and UnicodeStrToAsciiStr() Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Application/LinuxLoader/Arm/LinuxAtag.c | 2 +-

[edk2] [PATCH 4/6] ArmPkg/SemihostFs: eliminate calls to deprecated string functions

Remove calls to deprecated string functions like AsciiStrCpy() and UnicodeStrToAsciiStr() Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 20 1 file changed,

[edk2] [PATCH 0/6] ArmPkg: eliminate calls to deprecated functions

This series prepares ArmPkg for building with the preprocess symbol DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components to ArmPkg (#1), fixing broken code or code that relies on deprecated functionality (#2 - #5), and finally adds -DDISABLE_NEW_DEPRECATED_INTERFACES to the CC

[edk2] [PATCH 5/6] ArmPkg/BdsLib: eliminate calls to deprecated string functions

Remove calls to deprecated string functions like AsciiStrCpy() and UnicodeStrToAsciiStr() Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/BdsLib/BdsFilePath.c | 8 +--- 1 file changed, 5 insertions(+), 3

[edk2] [PATCH 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include

Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros that RVCT does not use or require, given it has its own AsmMacroIoLib.inc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 1/6] ArmPkg: add missing components

ArmPkg.dsc was a bit out of date, and some modules added over the past years had not been added to its [Components] section yet. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dsc | 11 +++ 1 file

Re: [edk2] [PATCH] ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

On 24 October 2016 at 14:05, Laszlo Ersek wrote: > On 10/24/16 15:01, Ard Biesheuvel wrote: >> While most compilers happily allow arithmetic on void pointer, >> the RVCT compiler does not, and throws the following warning for >> NorFlashDxe: >> >>

Re: [edk2] [PATCH 0/2] BeagleBoardPkg ArmPkg: get rid of BaseMemoryLibStm

On 24 October 2016 at 15:35, Ard Biesheuvel wrote: > On 21 September 2016 at 09:28, Ard Biesheuvel > wrote: >> Replace the last remaining reference to BaseMemoryLibStm (#1) and then >> remove it altogether (#2) >> > > And another one: ping?

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PrePi: avoid global variable write to mSystemMemoryEnd

On Mon, Oct 24, 2016 at 09:57:23AM +0100, Ard Biesheuvel wrote: > The global variable mSystemMemoryEnd is initialized by PrePi only if > it has not been initialized by ArmPlatformPeiBootAction(). This allows > platforms executing under, e.g., ARM Trusted Firmware to dynamically > reserve a window

Re: [edk2] [PATCH 0/2] BeagleBoardPkg ArmPkg: get rid of BaseMemoryLibStm

On 21 September 2016 at 09:28, Ard Biesheuvel wrote: > Replace the last remaining reference to BaseMemoryLibStm (#1) and then > remove it altogether (#2) > And another one: ping? > Ard Biesheuvel (2): > BeagleBoardPkg: remove dependency on ArmPkg/BaseMemoryLibStm >

Re: [edk2] [PATCH] ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

On 10/24/16 15:01, Ard Biesheuvel wrote: > While most compilers happily allow arithmetic on void pointer, > the RVCT compiler does not, and throws the following warning for > NorFlashDxe: > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c(894,48) : > error #1254-D: arithmetic on pointer to

[edk2] [PATCH] ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

While most compilers happily allow arithmetic on void pointer, the RVCT compiler does not, and throws the following warning for NorFlashDxe: ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c(894,48) : error #1254-D: arithmetic on pointer to void or function type Since the expression in

Re: [edk2] [PATCH 0/2] Add --reconfig option to edksetup.sh

Thanks, pushed as 44f79425589ef58cc10e58e1d1d882e02871158d..c112e371ce0aa40204fc9a1674cd2e0df0d743c8 On 24 October 2016 at 03:53, Gao, Liming wrote: > Reviewed-by: Liming Gao > >> -Original Message- >> From: Leif Lindholm

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PrePi: avoid global variable write to mSystemMemoryEnd

On 24 October 2016 at 13:05, Ryan Harkin wrote: > On 24 October 2016 at 09:57, Ard Biesheuvel wrote: >> The global variable mSystemMemoryEnd is initialized by PrePi only if >> it has not been initialized by ArmPlatformPeiBootAction(). This

Re: [edk2] [PATCH 18/19] ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with AsciiStrCatS()

On 10/24/16 09:57, Ard Biesheuvel wrote: > On 21 October 2016 at 22:27, Laszlo Ersek wrote: >> AsciiStrCat() is deprecated / disabled under the >> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. >> >> The caller of CpsrString() is required to pass in "ReturnStr" with 32

Re: [edk2] [PATCH 08/19] OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls

On 10/24/16 06:45, Gary Lin wrote: > On Fri, Oct 21, 2016 at 11:27:26PM +0200, Laszlo Ersek wrote: >> These are deprecated / disabled under the >> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. >> >> Introduce a variable called PcdStatus, and use it to assert the success of >> these

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 10/24/16 10:04, Ard Biesheuvel wrote: > On 21 October 2016 at 22:27, Laszlo Ersek wrote: >> This series intends to solve the following BZs: >> >> -- OvmfPkg: Add >> the build option "/D

Re: [edk2] [PATCH] ARMPkg: Unified the GIC base address variables as 64-bit width

On 24 October 2016 at 04:04, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > define these corresponding base address variables as 64-bit instead of > 32-bit. This patch

Re: [edk2] [PATCH 1/2] ArmVirtPkg/PrePi: remove mSystemMemoryEnd

On 10/24/16 10:57, Ard Biesheuvel wrote: > Recording the top of SEC visible system memory in a global variable is > not necessary, and violates the constraints of the SEC/PEI environment, > given that it may execute from NOR flash. So remove it. > > Contributed-under: TianoCore Contribution

Re: [edk2] [RESEND][EDK2][USB IF]Mismatch between EDK2 and a USB vendor

Hello Feng, Thank you for working on it. When do you think you can prepare the patch? I just want to know it to make our BIOS release plan. By the way, the USB vendor haven't received from USB.org yet. Kind regards, Yosuke Katayama -Original Message- From: Tian, Feng

Re: [edk2] [PATCH] MdeModulePkg PeiCore: Make sure FvInfo has FFS2 format if Ffs2Guid FvFormat

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Monday, October 24, 2016 5:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Sean Brogan > Subject:

Re: [edk2] [PATCH] MdePkg PeiServicesLib: Make sure FvInfo has FFS2 format if FvFormat == NULL

You are right, platform may install the FvInfo(2) ppi directly without calling PeiServicesInstallFvInfo(2)Ppi, for example, edk2\Vlv2TbltDevicePkg\FvInfoPei\FvInfoPei.c. Just sent out another patch to cover it, please help review that. Thanks, Star -Original Message- From: Gao, Liming

[edk2] [PATCH] MdeModulePkg PeiCore: Make sure FvInfo has FFS2 format if Ffs2Guid FvFormat

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=160 Cc: Liming Gao Cc: Sean Brogan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Core/Pei/FwVol/FwVol.c | 14

Re: [edk2] [PATCH] MdePkg PeiServicesLib: Make sure FvInfo has FFS2 format if FvFormat == NULL

Star: Besides this patch, I think PeiCore also requires to add this check to make sure FvInfo and FvImage match each other, because PPI may directly be installed from PEI module, not from this library API. Thanks Liming > -Original Message- > From: edk2-devel

[edk2] [PATCH 2/2] ArmPlatformPkg/PrePi: avoid global variable write to mSystemMemoryEnd

The global variable mSystemMemoryEnd is initialized by PrePi only if it has not been initialized by ArmPlatformPeiBootAction(). This allows platforms executing under, e.g., ARM Trusted Firmware to dynamically reserve a window at the top of memory that will be used by the secure firmware. However,

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > This series intends to solve the following BZs: > > -- OvmfPkg: Add > the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC > files > >

Re: [edk2] [PATCH 12/19] ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 06/19] OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 11/19] ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 13/19] ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 15/19] ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 14/19] ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 16/19] ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > These are deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > Introduce a variable called PcdStatus, and use it to assert the success of > these operations (there is no reason for them to

Re: [edk2] [PATCH 17/19] ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > AsciiStrCat() is deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > The "Str" variable serves no particular purpose in the MRegList() and > ThumbMRegList() functions; replace it with the

Re: [edk2] [PATCH 18/19] ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with AsciiStrCatS()

On 21 October 2016 at 22:27, Laszlo Ersek wrote: > AsciiStrCat() is deprecated / disabled under the > DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. > > The caller of CpsrString() is required to pass in "ReturnStr" with 32 > CHAR8 elements. (DefaultExceptionHandler()