Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-23 Thread Heyi Guo
Hi Brian, 在 11/9/2017 12:00 AM, Brian J. Johnson 写道: On 11/08/2017 07:34 AM, Heyi Guo wrote: On 11/08/2017 05:07 PM, Gerd Hoffmann wrote: On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a terminal tool can recognize F10, it still

[edk2] [RFC] Add EFI lock when creating new gauge record

2017-11-23 Thread Heyi Guo
Hi folks, We got occasional system exceptions after enabling performance measuring feature in edk2. After debugging, we found there is potential memory overflow in DXE/DXE_CORE PerformanceLib when PERF_START is reentered, and reentrance is possible since we are supporting something like USB

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Minnowboard3 Next Pre-production.

2017-11-23 Thread zwei4
Add code for Minnowboard3 Next pre-production board. Build Command: BuildBios /vs13 /MX /A Broxton Release. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 CC: mike...@intel.com CC: mang@intel.com --- BuildBIOS.bat

Re: [edk2] SCT forum help

2017-11-23 Thread Jin, Eric
Hi Amit Kumar, Please send email to u...@uefi.org for the UEFI SCT discussion. BTW, please make sure to provide more detail, such as the log, and your concern. I don't see any attachment in your before email - [edk2] [NVMe SCT] Mistakes in nvmepassthru sct test case.. Best Regards Eric

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 4/4] Board Specific Code.

2017-11-23 Thread zwei4
Add VBT for Minnowboard3 Next pre-production board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../Board/MinnowBoard3Next/Vbt/VbtBxtMipi.bin| Bin 0 -> 5632 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 2/4] Board Specific Code.

2017-11-23 Thread zwei4
Add BoardInitPostMem lib for Minnowboard3 Next pre-product board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../MinnowBoard3Next/BoardInitPostMem/BoardGpios.c | 251 +++ .../MinnowBoard3Next/BoardInitPostMem/BoardGpios.h |

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 3/4] Board Specific Code.

2017-11-23 Thread zwei4
Add BoardInitPreMem lib for Minnowboard3 Next pre-production board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../MinnowBoard3Next/BoardInitPreMem/BoardInit.c | 190 + .../MinnowBoard3Next/BoardInitPreMem/BoardInit.h | 29

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/4] Board Specific Code.

2017-11-23 Thread zwei4
Add BoardInitDxe lib for Minnowboard3 Next pre-product board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../MinnowBoard3Next/BoardInitDxe/BoardInitDxe.c | 68 ++ .../MinnowBoard3Next/BoardInitDxe/BoardInitDxe.h

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

2017-11-23 Thread Ni, Ruiyu
Maybe win10 does some optimization in S4 path. Sent from a small-screen device 在 2017年11月24日,上午8:01,Paolo Bonzini > 写道: On 23/11/2017 14:08, Laszlo Ersek wrote: On 11/23/17 03:20, Ni, Ruiyu wrote: I cannot explain precisely why the S4 resume

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

2017-11-23 Thread Paolo Bonzini
On 23/11/2017 14:08, Laszlo Ersek wrote: > On 11/23/17 03:20, Ni, Ruiyu wrote: >> I cannot explain precisely why the S4 resume fails. >> I can just guess: Windows might have some assumptions on the BM bit. > Can we make this configurable on the platform level somehow? > > On one hand, I certainly

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

2017-11-23 Thread Ni, Ruiyu
Sent from a small-screen device 在 2017年11月24日,上午1:19,Laszlo Ersek > 写道: On 11/23/17 15:58, Ni, Ruiyu wrote: Laszlo, A S3 flag PCD was added to optimize boot flow. Let's say, setting the flag to false is to remove some unnecessary code. setting to

Re: [edk2] [PATCH 3/5] MdeModulePkg/UefiBootManagerLib: report EDKII_OS_LOADER_DETAIL status code

2017-11-23 Thread Ni, Ruiyu
Sent from a small-screen device 在 2017年11月24日,上午1:08,Laszlo Ersek > 写道: On 11/23/17 15:53, Ni, Ruiyu wrote: Comments below. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 23, 2017 10:03 PM To: Ni,

Re: [edk2] [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-23 Thread Fan Jeff
Andrew, I agreed msft x64 compiler would not use ebp to save stack frame. In my part, I am trying to make use of exception data section to calculate the stack frame. I just used Paulo’s gcc x64 case to show my question on return address display issue. It maybe not a good example:) It’better

Re: [edk2] [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-23 Thread Andrew Fish
> On Nov 23, 2017, at 6:27 AM, Fan Jeff > wrote: > > Hi Paulo, > > > > I’d like to clarify my question. > > The following call trace information is abstracted from your x64 dump > contents. > > Call trace: > > 0 0x7DBCD580 @

Re: [edk2] [PATCH 3/5] MdeModulePkg/UefiBootManagerLib: report EDKII_OS_LOADER_DETAIL status code

2017-11-23 Thread Laszlo Ersek
On 11/23/17 15:53, Ni, Ruiyu wrote: > Comments below. > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, November 23, 2017 10:03 PM >> To: Ni, Ruiyu ; edk2-devel-01 >> Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 00/14] ArmVirtPkg: get rid of ArmPlatformLib

2017-11-23 Thread Ard Biesheuvel
On 22 November 2017 at 10:07, Ard Biesheuvel wrote: > ArmPlatformLib is a mixed bag of platform specific hooks, some of which > are called from early startup code, and some of which are called from C > code, to get the boot mode, memory layout etc. > > This library

[edk2] SCT forum help

2017-11-23 Thread Amit kumar
HI Can somebody tell me the mail chain where i can discuss sct spec and test cases related issue ? Best Regards Amit Kumar ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v8 0/2] Fix multiple entries of RT_CODE in memory map

2017-11-23 Thread Laszlo Ersek
On 11/23/17 03:12, Jian J Wang wrote: >> v8: >>Remove merge code but keep code to remain MemoryMapStart > >> v7: >>Merge memory map after filtering paging attributes > >> v6: >>Add ExecuteDisable feature check to include/exclude EFI_MEMORY_XP > >> v5: >>Coding style clean-up >

Re: [edk2] [PATCH v2 13/14] ArmVirtPkg/ArmVirtMemoryInitPeiLib: move to ArmVirtMemInfoLib

2017-11-23 Thread Laszlo Ersek
On 11/22/17 11:07, Ard Biesheuvel wrote: > Move to the new ArmVirtMemInfoLib library to retrieve DRAM information > from the platform, so that we can phase out ArmPlatformLib going forward. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 12/14] ArmVirtPkg: create QemuVirtMemInfoLib version for ArmVirtQemu

2017-11-23 Thread Laszlo Ersek
On 11/22/17 11:07, Ard Biesheuvel wrote: > The QemuVirtMemInfoLib ArmVirtMemInfoLib implementation created for > ArmVirtQemuKernel does exactly what we need for ArmVirtQemu, the only > difference being that the latter is PrePeiCore based, and so it uses > a different method to ensure that

Re: [edk2] [NVMe SCT] Mistakes in nvmepassthru sct test case.

2017-11-23 Thread Amit kumar
Forgot to mention. UEFI SCT II Case Spec 2.5 page 910 and UEFI SCT II Case Spec 2.6 A page 855. > On Nov 23, 2017, at 9:36 PM, Amit kumar wrote: > > Hi , > I think there is something wrong with SCT nvmepassthru test case mentioned on > page 910 UEFI SCT II Case Spec.

Re: [edk2] [PATCH v2 11/14] ArmVirtPkg/ArmVirtQemu: add ArmVirtMemInfoLib implementation

2017-11-23 Thread Laszlo Ersek
On 11/22/17 11:07, Ard Biesheuvel wrote: > Create a new ArmVirtMemInfoLib for ArmVirtQemuKernel by cloning the > existing ArmPlatformGetVirtualMemoryMap () for this platform, > (ArmQemuRelocatablePlatformLib *not* ArmVirtPlatformLib), and cleaning > it up: > - remove support for uncached DRAM

[edk2] [Patch 0/2] BaseTools: Update C tools GNUMakefile to support parallel make

2017-11-23 Thread Liming Gao
GNU make supports -j N to trig multiple job at the same time. It can reduce make time. This serial can get 60% improvement on BaseTools C tool clean build with make -j 4. Liming Gao (2): BaseTools: Update C tools top GNUMakefile with the clear dependency BaseTools: Update C tools top

[edk2] [NVMe SCT] Mistakes in nvmepassthru sct test case.

2017-11-23 Thread Amit kumar
Hi , I think there is something wrong with SCT nvmepassthru test case mentioned on page 910 UEFI SCT II Case Spec. for which i have attached the screen shot. The assertion and test description looks contradictory. Also it fails if passthru doesnt support NON-BLOCKING mode. Best Regards Amit

[edk2] [Patch 1/2] BaseTools: Update C tools top GNUMakefile with the clear dependency

2017-11-23 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=786 After GNUmakefile dependency is fixed up, it can make with -j N to enable multiple thread build in base tools C source and save build time. In my linux host machine, make -j 4 to compile BaseTools and save ~60% time. Contributed-under: TianoCore

[edk2] [Patch 2/2] BaseTools: Update C tools top GNUMakefile to adjust tool order

2017-11-23 Thread Liming Gao
Place the tool that takes much build time at the first. This can improve build performance when make -j N used. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/GNUmakefile | 6 +++--- 1 file changed, 3 insertions(+),

Re: [edk2] [PATCH v2 09/14] ArmVirtPkg: introduce ArmVirtMemInfoLib library class

2017-11-23 Thread Laszlo Ersek
On 11/22/17 11:07, Ard Biesheuvel wrote: > As part of the effort to get rid of ArmPlatformLib (which incorporates > far too many duties in a single library), introduce ArmVirtMemInfoLib > which will be invoked by our ArmVirtMemoryInitPeiLib implementation to > get a description of the virtual

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

2017-11-23 Thread Ni, Ruiyu
Laszlo, A S3 flag PCD was added to optimize boot flow. Let's say, setting the flag to false is to remove some unnecessary code. setting to true is also fine. But in this case, setting S4 flag to false is to add some incompatible code. It's a bit different. If you check the two patches to revert

[edk2] 答复: 答复: [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-23 Thread Fan Jeff
Hi Paulo, I’d like to clarify my question. The following call trace information is abstracted from your x64 dump contents. Call trace: 0 0x7DBCD580 @ 0x7DBCD000+0x57F (0x7EEC8DDC) in PartitionDxe.dll 1 0x7DBD41BE @ 0x7DBCD000+0x71BD (0x7EEC8DFC) in PartitionDxe.dll I guess you used

Re: [edk2] [PATCH 3/5] MdeModulePkg/UefiBootManagerLib: report EDKII_OS_LOADER_DETAIL status code

2017-11-23 Thread Laszlo Ersek
Hello Ray, (CC Mark Doran for the last part of my email) On 11/23/17 06:21, Ni, Ruiyu wrote: > Laszlo, > When booting a boot option, UefiBootManagerBoot() sets a Boot variable > and saves to BootCurrent variable. > So all the details (except the EDKII_OS_LOADER_DETAIL.Status) can be

Re: [edk2] [PATCH 1/5] MdeModulePkg/BdsDxe: fall back to a Boot Manager Menu loop before hanging

2017-11-23 Thread Laszlo Ersek
On 11/23/17 04:43, Ni, Ruiyu wrote: > Thanks for the patch. It follows the idea described in: > https://lists.01.org/pipermail/edk2-devel/2017-April/010294.html. > > Reviewed-by: Ruiyu Ni Thank you, Ray! I might commit this first patch in isolation (to close #513) while we

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

2017-11-23 Thread Laszlo Ersek
On 11/23/17 03:20, Ni, Ruiyu wrote: > I cannot explain precisely why the S4 resume fails. > I can just guess: Windows might have some assumptions on the BM bit. Can we make this configurable on the platform level somehow? On one hand, I certainly don't want to break Windows 10, even in case this

Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers

2017-11-23 Thread Ard Biesheuvel
On 23 November 2017 at 12:55, Wu, Hao A wrote: >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Thursday, November 23, 2017 6:11 PM >> To: Wu, Hao A >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindh...@linaro.org; Kinney,

Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers

2017-11-23 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 23, 2017 6:11 PM > To: Wu, Hao A > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindh...@linaro.org; Kinney, > Michael D; Gao, Liming; Tian, Feng; Dong, Eric > Subject: Re: [RFC PATCH

Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-23 Thread Leif Lindholm
On Fri, Nov 17, 2017 at 05:42:30PM +, Ard Biesheuvel wrote: > On 17 November 2017 at 16:10, Leif Lindholm wrote: > > And use a local variable Pin, initialized to > > FixedPcdGet32 (PcdClearSettingsGpioPin) - 1? > > (You could then also have an assert verifying

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

2017-11-23 Thread Ard Biesheuvel
On 23 November 2017 at 10:21, Gao, Liming wrote: > OK. I see the change to add DEF(GCC_DLINK2_FLAGS_COMMON) into ASLDLINK_FLAGS. > > Reviewed-by: Liming Gao > Thanks all Pushed as 14ca435fb6c059eaeb7fe6eedbe4738ffaf336d0 >>-Original Message-

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

2017-11-23 Thread Gao, Liming
OK. I see the change to add DEF(GCC_DLINK2_FLAGS_COMMON) into ASLDLINK_FLAGS. Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, November 23, 2017 6:19 PM >To: Gao, Liming

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

2017-11-23 Thread Ard Biesheuvel
On 23 November 2017 at 10:16, Gao, Liming wrote: > Ard: > Have you own GCC linker script? Is it not in BaseTools? > No it is just GccBase.lds like we use for PE/COFF binaries, but this patch uses it for .aslc files as well. >>-Original Message- >>From: Ard

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

2017-11-23 Thread Gao, Liming
Ard: Have you own GCC linker script? Is it not in BaseTools? Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Wednesday, November 22, 2017 12:11 AM >To: edk2-devel@lists.01.org; leif.lindh...@linaro.org >Cc: m...@semihalf.com; Zhu,

Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers

2017-11-23 Thread Ard Biesheuvel
On 13 November 2017 at 03:37, Wu, Hao A wrote: >> -Original Message- >> From: Zeng, Star >> Sent: Monday, November 13, 2017 11:32 AM >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org; >> leif.lindh...@linaro.org; Kinney, Michael D >> Cc: Gao, Liming; Tian,

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Section Auth

2017-11-23 Thread xianhu2x
Add DxeImageAuthenticationStatusLib to SecurityStub driver and verify the driver before dispatch Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: xianhu2x --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgIA32.dsc |

Re: [edk2] SCT Test crashes After HTTPS boot success.

2017-11-23 Thread Wu, Jiaxin
For #1, I have response as below: That's because you set ValidateBootImageThruNet to yes in EfiCompliant.ini file but the SetupMode in your platform is 1, which means the platform doesn't support to validate a boot image. You need set the SetupMode to zero if you want to pass the