[edk2] [PATCH] UefiCpuPkg: Fix comment typo for MtrrLibApplyFixedMtrrs function

Fix comment typo for MtrrLibApplyFixedMtrrs function Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +- 1 file changed, 1

Re: [edk2] [PATCH 5/7] ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory

Hi Vladimir How re-allocation or say drivers are dispatched on your system. Could you check addresses, where FV is kept and where this is getting dispatched Thx Udit > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Vladimir Olovyannikov

Re: [edk2] [PATCH] UefiCpuPkg: Update AESNI support checking logic

Reviewed-by: Eric Dong -Original Message- From: Song, BinX Sent: Monday, December 25, 2017 11:11 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; ler...@redhat.com Subject: [PATCH] UefiCpuPkg: Update AESNI support checking logic With correct

Re: [edk2] [PATCH] UefiCpuPkg: Delete redundant PcdGetSize PcdCpuFeaturesSupport

Reviewed-by: Eric Dong -Original Message- From: Song, BinX Sent: Thursday, December 21, 2017 8:01 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; ler...@redhat.com Subject: [PATCH] UefiCpuPkg: Delete redundant PcdGetSize PcdCpuFeaturesSupport

[edk2] [Patch] BaseTools: Fix Sku inherit issue.

The final Pcd value should only be override by its parents. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Feng Bob C Reviewed-by: Liming Gao --- BaseTools/Source/Python/Common/Misc.py| 2 ++

[edk2] [Patch] BaseTools: Remove 'COMMON' in PCD SkuInfoList

'COMMON' is an alias of 'DEFAULT' for internal code, it should be removed before generating Pcd DataBase. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [Patch] BaseTools: Support PCD flexible values format

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, December 27, 2017 1:24 PM >To: edk2-devel@lists.01.org >Cc: Feng, YunhuaX >Subject: [edk2]

[edk2] [Patch] BaseTools: Support PCD flexible values format

https://bugzilla.tianocore.org/show_bug.cgi?id=541 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 39

Re: [edk2] [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL pointer reference

Could you add more information about this patch between 14b351e2ed8586f144dd3cd2e0a25082c1a32837? With that, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, December 27, 2017 10:31 AM To: edk2-devel@lists.01.org Cc: Zeng,

Re: [edk2] [Patch] MdeModulePkg Variable: Update expression to directly use boolean type value

The title seems too long. How about updating the title to be "MdeModulePkg Variable: Use boolean type value instead of expression" With the update, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

[edk2] [Patch] MdeModulePkg Variable: Update expression to directly use boolean type value

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

Re: [edk2] [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Monday, December 25, 2017 1:30 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Karunakar P ; Wu, Jiaxin

Re: [edk2] [Patch 3/3] NetworkPkg/TcpDxe: Check TCP payload for release version.

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Tuesday, December 26, 2017 2:50 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wang, Fan ; Wu, Jiaxin

Re: [edk2] [Patch 3/3] NetworkPkg/TcpDxe: Check TCP payload for release version.

Hi, Jiaxin I think it's better to return a Boolean type than int 0-1 value in TcpTrimSegment(). Other part of good to me. Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 26, 2017 2:50 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.

Thanks, Siyuan I will refine the commit log before apply the patch. > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, December 27, 2017 11:01 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Karunakar P

Re: [edk2] [Patch] BaseTools: Add Platform Override Build Options for PcdValueInit

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Tuesday, December 26, 2017 4:53 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Add Platform Override Build

[edk2] [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL pointer reference

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [edk2] [Patch 0/2] NetworkPkg/HttpDxe: Fix some issues in HttpDxe

Series reviewed by Wang, Fan . Best Regards Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, December 26, 2017 2:35 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wang, Fan

Re: [edk2] [PATCH 5/7] ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory

> -Original Message- > From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] > Sent: Tuesday, December 26, 2017 5:59 PM > To: 'Ard Biesheuvel' > Cc: 'edk2-devel@lists.01.org'; 'Leif Lindholm' > Subject: RE: [edk2] [PATCH 5/7] ArmPlatformPkg/MemoryInitPeiLib: don't >

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g

Hi, Ard, Could you kindly help to produce one extra patch to fix and validate this ARM & AARCH64 build? Thanks. Best Regards & Thanks, LONG, Qin From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, December 27, 2017 3:25 AM To: Ye, Ting Cc: Long, Qin

Re: [edk2] [Patch 0/2] NetworkPkg/HttpDxe: Fix some issues in HttpDxe

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Tuesday, December 26, 2017 2:35 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan

Re: [edk2] [PATCH 0/4] Coding style clean-up

Hi Mike, Since this patch has been checked in trunk, do you think it should be reverted? In addition, instead of using exception list for the ECC tool, I think it'd be better to update ECC tool to use keyword match to check if a field name is public spec defined one. Otherwise, if there's new

Re: [edk2] [PATCH 5/7] ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory

Hi Ard, Meenakshi, I am having a problem I cannot explain the reason for, with this commit on an ARM64 platform. ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory Now that PrePi no longer exposes its internal code via special HOBs, we can remove the special handling

Re: [edk2] [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute

Liming: I've never used VS to compile edk2 but to me it looks like it doesn't like what NORETURN is expanding to ('__declspec(noreturn)'). If that is the case it's a generic bug because this patch set did not add the NORETURN macro. On Tue, Dec 26, 2017 at 5:51 PM, Gao, Liming

Re: [edk2] [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute

Michael: I suggest to add comments for each definition although there is redundant. Besides, after I apply these three patches, and build MdePkg.dsc with VS2015x86. It will report below error. Could you help look it? "C:\Program Files (x86)\Microsoft Visual Studio

[edk2] [Patch 0/2] BaseTools: Add Flexible PCD Value support

https://bugzilla.tianocore.org/show_bug.cgi?id=541 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng Signed-off-by: Yonghong Zhu Yonghong Zhu (2): BaseTools: Support PCD flexible values format BaseTools: Add

[edk2] [Patch 1/2] BaseTools: Support PCD flexible values format

https://bugzilla.tianocore.org/show_bug.cgi?id=541 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 39

Re: [edk2] [Patch] BaseTools: Update Python Makefile to include the new added python files

Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 11:14 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Feng, Bob C Subject: [Patch] BaseTools: Update Python Makefile to

Re: [edk2] [Patch] BaseTools: Update Python Makefile to include the new added python files

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 11:14 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Feng, Bob C Subject: [Patch]

[edk2] [Patch] BaseTools: Update Python Makefile to include the new added python files

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng --- BaseTools/Source/Python/Makefile | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [Patch] BaseTools: Fix Pcd value override issue caused by SKU inherit

Pcd default value in DEC should only be assigned once. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 46 ++- 1 file changed,

Re: [edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Add the check for the memory allocation return

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 4:36 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg HiiDataBaseDxe: Add the check for the memory allocation

Re: [edk2] [PATCH v2] MdeModulePkg Variable: Update Pointer Minus with UINTN type

On 26 December 2017 at 09:00, Zeng, Star wrote: > Reviewed-by: Star Zeng > > > Thanks, > Star > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Tuesday, December 26, 2017 4:59 PM >

Re: [edk2] [PATCH v2] MdeModulePkg Variable: Update Pointer Minus with UINTN type

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, December 26, 2017 4:59 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH

[edk2] [PATCH v2] MdeModulePkg Variable: Update Pointer Minus with UINTN type

In V2, reduce unnecessary () in the expression. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [Patch] BaseTools: Add Platform Override Build Options for PcdValueInit

Add Platform's CC_FLAGS /D option for PcdValueInit generation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DscBuildData.py | 77 +-- 1 file changed, 73 insertions(+), 4

Re: [edk2] [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type

On 26 December 2017 at 08:46, Gao, Liming wrote: > Ard: > Here is the simpler version. Convert pointer to UINTN, then subtract them > to get the size, last convert it to UINT32. > > AuthVarStorage->Size = (UINT32)((UINTN) AuthStartPtr - (UINTN) > AuthVarStorage); > That

Re: [edk2] [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type

Ard: Here is the simpler version. Convert pointer to UINTN, then subtract them to get the size, last convert it to UINT32. AuthVarStorage->Size = (UINT32)((UINTN) AuthStartPtr - (UINTN) AuthVarStorage); Thanks Liming >-Original Message- >From: Ard Biesheuvel

Re: [edk2] [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type

On 26 December 2017 at 08:36, Liming Gao wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Star Zeng Could you please add an explanation why this is necessary? Do we really need 5

[edk2] [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Add the check for the memory allocation return

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [edk2] [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value

Sorry. I will remove it. >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, December 26, 2017 4:04 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Feng, Bob C ; Zhu, Yonghong > >Subject: RE: [Patch] BaseTools:

Re: [edk2] [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value

Please remove the " Signed-off-by" info in Cc. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 3:59 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Feng, Bob