Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine

2018-01-26 Thread You, Benjamin
Hi Arthur, I agree with your suggestion that Payload interpret BytesPerScanLine and Horizontal Resolution properly such that a 1366 display can be handled well. The functioning will depend on Coreboot interpreting properly too. However fixing the Payload will not cause any regression anyway. I

Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

2018-01-26 Thread Huangming (Mark)
On 2018/1/23 18:23, Leif Lindholm wrote: > On Thu, Jan 18, 2018 at 11:01:42PM +0800, Ming Huang wrote: >> OsBootLib can create OS option after upgrade firmware. > > I will respond more strongly that Ard did: > > I have seen functionality like this implemented in publicly available > systems -

Re: [edk2] [Patch] BaseTools: Enhance parse performance by optimize ValueExpressionEx

2018-01-26 Thread Andrew Fish
Any data on the performance improvement? Thanks, Andrew Fish > On Jan 26, 2018, at 8:28 AM, Yonghong Zhu wrote: > > From: Yunhua Feng > > Optimize ValueExpressionEx function to enhance meta-data file parse > performance. > > Cc: Liming Gao

Re: [edk2] [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

2018-01-26 Thread Leif Lindholm
On Fri, Jan 26, 2018 at 05:35:38PM +, Ard Biesheuvel wrote: > >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common] > >> >gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > >> > > >> >

Re: [edk2] [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

2018-01-26 Thread Ard Biesheuvel
On 26 January 2018 at 17:34, Leif Lindholm wrote: > On Fri, Jan 26, 2018 at 05:31:25PM +, Ard Biesheuvel wrote: >> On 26 January 2018 at 17:30, Leif Lindholm wrote: >> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid

Re: [edk2] [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

2018-01-26 Thread Leif Lindholm
On Fri, Jan 26, 2018 at 05:31:25PM +, Ard Biesheuvel wrote: > On 26 January 2018 at 17:30, Leif Lindholm wrote: > > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of > > the unfortunate ARM-specific variant of PcdFirmwareVendor. > > > > However,

Re: [edk2] [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

2018-01-26 Thread Ard Biesheuvel
On 26 January 2018 at 17:30, Leif Lindholm wrote: > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of > the unfortunate ARM-specific variant of PcdFirmwareVendor. > > However, BeagleBoard was still using it, so the change broke the build. > Fix this

[edk2] [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

2018-01-26 Thread Leif Lindholm
Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of the unfortunate ARM-specific variant of PcdFirmwareVendor. However, BeagleBoard was still using it, so the change broke the build. Fix this by moving BeagleBoard to use the MdeModulePkg one instead. Contributed-under:

[edk2] [PATCH] Platform/ARM/VExpress: refine the check for DVI support

2018-01-26 Thread Thomas Abraham
The base models could have different values for the revision ID field in the System ID register. Base models do not have support for DVI and so the revision ID field should also be masked out when checking for the presence of DVI support. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch] BaseTools: Enhance parse performance by optimize ValueExpressionEx

2018-01-26 Thread Yonghong Zhu
From: Yunhua Feng Optimize ValueExpressionEx function to enhance meta-data file parse performance. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng

Re: [edk2] [patch] UefiCpuPkg/S3Resume: Add more perf enrty for S3 phase

2018-01-26 Thread Laszlo Ersek
On 01/26/18 07:02, Gao, Liming wrote: > Laszlo: > Here is PERF macro PERF_START_EX(Handle, Token, Module, TimeStamp, > Identifier). > > Handle is the image handle or device handle. PerfLib can base on Handle to > get its FILE guid. > Token is the measured token name. > Module is the

Re: [edk2] [PATCH 0/2] User UnicodeCollation in StrinCmp

2018-01-26 Thread Carsey, Jaben
for series. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, January 26, 2018 1:51 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] User

Re: [edk2] [PATCH v5 0/6] Add ARM support for VS2017

2018-01-26 Thread Ard Biesheuvel
On 26 January 2018 at 15:05, Gao, Liming wrote: > After the change in ArmPkg is reviewed, I will help push this patch serial. > That change is Reviewed-by: Ard Biesheuvel Thanks. >> -Original Message- >> From: Pete Batard

Re: [edk2] [PATCH v5 0/6] Add ARM support for VS2017

2018-01-26 Thread Gao, Liming
After the change in ArmPkg is reviewed, I will help push this patch serial. > -Original Message- > From: Pete Batard [mailto:p...@akeo.ie] > Sent: Thursday, January 25, 2018 7:32 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: ard.biesheu...@linaro.org;

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Make sure AP uses correct StartupApSignal

2018-01-26 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Ni, Ruiyu Sent: Thursday, January 25, 2018 3:37 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Chiu, Chasel Subject: [PATCH] UefiCpuPkg/MpInitLib: Make sure AP uses correct

[edk2] [PATCH 1/2] ShellPkg/CommandLib: Locate proper UnicodeCollation instance

2018-01-26 Thread Ruiyu Ni
Original code locates the first UnicodeCollation instance in DXE Core protocol database. It's not correct considering multiple UnicodeCollation instances exist in system. The patch changes logic to find the one that matches the current system language. Contributed-under: TianoCore Contribution

[edk2] [PATCH 2/2] ShellPkg/Level2Command: Use UnicodeCollation in StrinCmp

2018-01-26 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 4 +- ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 4 +-

[edk2] [PATCH 0/2] User UnicodeCollation in StrinCmp

2018-01-26 Thread Ruiyu Ni
Ruiyu Ni (2): ShellPkg/CommandLib: Locate proper UnicodeCollation instance ShellPkg/Level2Command: Use UnicodeCollation in StrinCmp .../UefiShellCommandLib/UefiShellCommandLib.c | 76 ++ .../UefiShellCommandLib/UefiShellCommandLib.h | 3 +-

Re: [edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: remove all code to flush TLB for APs

2018-01-26 Thread Wang, Jian J
Right. I'll update the comments. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Friday, January 26, 2018 5:14 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric

Re: [edk2] [PATCH 1/2] UefiCpuPkg/MpInitLib: force flushing TLB for AP in mwait loop mode

2018-01-26 Thread Ni, Ruiyu
On 1/26/2018 5:03 PM, Jian J Wang wrote: The reason doing this is that we found that calling StartupAllAps() to flush TLB for all APs in CpuDxe driver after changing page attributes will spend a lot of time to complete. If there are many page attributes update requests, the whole system

Re: [edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: remove all code to flush TLB for APs

2018-01-26 Thread Ni, Ruiyu
On 1/26/2018 5:03 PM, Jian J Wang wrote: The reason doing this is that we found that calling StartupAllAps() to flush TLB for all APs in CpuDxe driver after changing page attributes will spend a lot of time to complete. If there are many page attributes update requests, the whole system

[edk2] [PATCH 1/2] ShellPkg/CommandLib: Locate proper UnicodeCollation instance

2018-01-26 Thread Ruiyu Ni
Original code locates the first UnicodeCollation instance in DXE Core protocol database. It's not correct considering multiple UnicodeCollation instances exist in system. The patch changes logic to find the one that matches the current system language. Contributed-under: TianoCore Contribution

[edk2] [PATCH 2/2] ShellPkg/Level2Command: Use UnicodeCollation in StrinCmp

2018-01-26 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 4 +- ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 4 +-

[edk2] [PATCH 0/2] User UnicodeCollation in StrinCmp

2018-01-26 Thread Ruiyu Ni
Ruiyu Ni (2): ShellPkg/CommandLib: Locate proper UnicodeCollation instance ShellPkg/Level2Command: Use UnicodeCollation in StrinCmp .../UefiShellCommandLib/UefiShellCommandLib.c | 76 ++ .../UefiShellCommandLib/UefiShellCommandLib.h | 3 +-

[edk2] [PATCH 0/2] Fix bad performance in changing page attributes

2018-01-26 Thread Jian J Wang
There's a great performance down if we enable heap guard features. This feature will frequently update page attribute to set/unset guard pages, which is done by CpuArchProtocol.SetMemoryAttributes. In the implementation of this method (in CpuDxe), it will call MpProtocol.StartupAllAps() to flush

[edk2] [PATCH 1/2] UefiCpuPkg/MpInitLib: force flushing TLB for AP in mwait loop mode

2018-01-26 Thread Jian J Wang
The reason doing this is that we found that calling StartupAllAps() to flush TLB for all APs in CpuDxe driver after changing page attributes will spend a lot of time to complete. If there are many page attributes update requests, the whole system performance will be slowed down explicitly,

[edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: remove all code to flush TLB for APs

2018-01-26 Thread Jian J Wang
The reason doing this is that we found that calling StartupAllAps() to flush TLB for all APs in CpuDxe driver after changing page attributes will spend a lot of time to complete. If there are many page attributes update requests, the whole system performance will be slowed down explicitly,

Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine

2018-01-26 Thread You, Benjamin
Hi Arthur, > -Original Message- > From: Arthur Heymans [mailto:art...@aheymans.xyz] > Sent: Thursday, January 25, 2018 5:03 PM > To: You, Benjamin > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine > >

[edk2] [PATCH edk2-non-osi v2 7/7] Hisilicon/D05: Update binary of trusted-firmware

2018-01-26 Thread Heyi Guo
1 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214. 2 Upgrade trusted firmware to 1.4 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D05/bl1.bin | Bin

[edk2] [PATCH edk2-non-osi v2 6/7] Hisilicon/D03: Update binary of trusted-firmware

2018-01-26 Thread Heyi Guo
1 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214. 2 Upgrade trusted firmware to 1.4 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/bl1.bin | Bin

[edk2] [PATCH edk2-non-osi v2 5/7] Hisilicon D03/D05: Update NativeOhci binary

2018-01-26 Thread Heyi Guo
Update NativeOhci bianry for changing DmaLib to CoherentDmaLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/Drivers/OhciDxe/NativeOhci.efi | Bin 21664 -> 22336

[edk2] [PATCH edk2-non-osi v2 2/7] Hisilicon D0x: Fix network interface order issue

2018-01-26 Thread Heyi Guo
1. Rebuild SnpPV600Dxe binary for switching DmaLib to CoherentDmaLib. 2. Fixed bug:Confusing Ethernet port sequence. Move the most right Ethernet port (when looking from the front of the chassis) to the first one in BootManage for PXE boot. https://bugs.linaro.org/show_bug.cgi?id=2657 Note: This

[edk2] [PATCH edk2-non-osi v2 3/7] Hisilicon D0x: Delete SnpPlatform

2018-01-26 Thread Heyi Guo
An open-source version coming to edk2-platforms replaces this version. This patch is related to "Open SnpPlatform source code" and "Change DmaLib to CoherentDmaLib". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-non-osi v2 1/7] Hisilicon D03/D05: Delete SasPlatform

2018-01-26 Thread Heyi Guo
From: Jason Zhang An open-source version coming to edk2-platfroms replaces this version. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi

[edk2] [PATCH edk2-non-osi v2 4/7] Hisilicon D03/D05: Update SasDriverDxe binary

2018-01-26 Thread Heyi Guo
Update SasDriverDxe binary for changing DmaLib to CoherentDmaLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/Drivers/Sas/SasDriverDxe.efi | Bin 98112 -> 100224

[edk2] [PATCH edk2-non-osi v2 0/7] Improve D0x platforms and bug fix

2018-01-26 Thread Heyi Guo
The major features of this patchset: 1 Upgrade trusted firmware to 1.4 2 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214 3 Delete some binary for open-source version 4 Update binary follow changing DmaLib to CoherentDmaLib Code can also be found in github:

[edk2] [PATCH edk2-platforms v2 15/15] Hisilicon D03/D05: Update firmware version to 18.02

2018-01-26 Thread Ming Huang
Replace the old string with short one. The old one is too long that can not be show integrallty in Setup nemu. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v2 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM

2018-01-26 Thread Ming Huang
Add PXM method for Pcie device, HNS device and SAS device. Add STA method for HNS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: hensonwang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v2 12/15] Hisilicon/D03: Replace SP805Watchdog by WatchdogTimer driver.

2018-01-26 Thread Ming Huang
In SCT test,we find SP805 watchdog driver can't reset when timeout so we use another driver in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: GongChengYa

[edk2] [PATCH edk2-platforms v2 11/15] Hisilicon/D05: Replace SP805Watchdog by WatchdogTimer driver.

2018-01-26 Thread Ming Huang
In SCT test,we find SP805 watchdog driver can't reset when timeout so we use another driver in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: GongChengYa

[edk2] [PATCH edk2-platforms v2 13/15] Hisilicon/D05/ACPI: Add ITS PXM

2018-01-26 Thread Ming Huang
Add ITS affinity structure in SRAT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++

[edk2] [PATCH edk2-platforms v2 10/15] Hisilicon/PCIe: Disable PCIe ASPM

2018-01-26 Thread Ming Huang
From: Yan Zhang In order to replace command line parameter pcie_aspm=off, BIOS needs to disable Pcie Aspm support during Pcie initilization. D03 and D05 do not support PCIe ASPM, so we disable it in BIOS. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v2 09/15] Hisilicon/Smbios: Indicate use of ProcessorFamily2 in type 4 table

2018-01-26 Thread Ming Huang
modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, indicator to obtain the processor family from the Processor Family 2 field. ProcessorFamily2 is already specified as ProcessorFamilyARM in the existing table. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v2 07/15] Hisilicon D03/D05: Open SnpPlatform source code

2018-01-26 Thread Ming Huang
From: Jason Zhang 1. This driver install a protocol for SnpPV600Dxe driver. The protocol indicate which ethernet port to use and port sequence. 2. Fixed bug:Confusing Ethernet port sequence. Move the most right Ethernet port (when looking from the front of the

[edk2] [PATCH edk2-platforms v2 08/15] Hilisicon: Change DmaLib to CoherentDmaLib

2018-01-26 Thread Ming Huang
Unify all D0x(include D06 in further) to cache coherent DmaLib. This can improve boot speed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Yue Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v2 01/15] Hisilicon/D05: Move Madt definition to head file

2018-01-26 Thread Ming Huang
Move definition of Madt struct to head file, so PPTT driver can include it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Hi1616/D05AcpiTables/Hi1616Platform.h | 30

[edk2] [PATCH edk2-platforms v2 05/15] Hisilicon D03/D05: Add capsule upgrade support

2018-01-26 Thread Ming Huang
From: Jason Zhang This module support updating the boot CPU firmware only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms v2 04/15] Hisilicon/D0x: Break BMC SetBoot option out into separate library

2018-01-26 Thread Ming Huang
Modify the feature of BMC set boot option as switching generic BDS. Break BMC SetBoot option out into BmcConfigBootLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v2 03/15] Hisilicon/D0x/BDS: Switch to Generic BDS driver

2018-01-26 Thread Ming Huang
Hisilicon-specific PlatformBootManagerLib added. It is convenient to add specific feature, like BMC control boot option. Remove Intel BDS from dsc file because it is out of use. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang

[edk2] [PATCH edk2-platforms v2 00/15] Improve D0x platforms and bug fix

2018-01-26 Thread Ming Huang
The major features of this patchset include adding PPTT support, switching to Generic BDS driver, adding capsule upgrade support, open-source version for SnpPlatform and SasPlatform changing DmaLib to CoherentDmaLib(this one is omissive in v1). Code can also be found in github: