Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* pcd max size from component section

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:58 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the bug for VOID* pcd max

Re: [edk2] [Patch] BaseTools: Fix size override issue for Void* Patchable pcd

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:58 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix size override issue for Void*

Re: [edk2] [Patch] BaseTools: Fix a bug for VOID* type Fixatbuild Pcd in Library

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:57 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix a bug for VOID* type

Re: [edk2] [Patch] BaseTools: Fix two cases that use GUID CName as PCD Value

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, March 28, 2018 8:43 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix two cases that use GUID

Re: [edk2] [Patch] BaseTools: Pcds in [Components] are not display correct in the report

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcds in [Components] are not

Re: [edk2] [Patch] BaseTools: Pcd not used info should not in Module PCD section

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcd not used info should not in

[edk2] [PATCH] BaseTools: Parse PCD GUID name in FILE statement issue

From: Yunhua Feng FDF format as below: FILE APPLICATION = PCD(PcdToken.PcdCName) { } when parse PCD, need get all PCDs from Platform and Packages, use self.BuildObject[self.Platform, Arch] get some modules is wrong. so use self.BuildObject[self.Platform, Arch,

Re: [edk2] [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO

Thanks! Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Wednesday, April 4, 2018 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Chiu, Chasel ; Chan, Amy

Re: [edk2] [RFC 1/4] FmpDevicePkg: Add package, library classes, and PCDs

Since PcdFmpDeviceBuildTimeLowestSupportedVersion is defined to support only FixedAtBuild and PatchableInModule, it is definitely for build time. Do we really need "BuildTime" keyword in the PCD name PcdFmpDeviceBuildTimeLowestSupportedVersion? Thanks, Star -Original Message- From:

Re: [edk2] [RFC 0/4] Add FmpDevicePkg

Curious about which tool to generate the FMP_PAYLOAD_HEADER? BaseTools needs to be updated? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, April 5, 2018 8:29 AM To: Yao, Jiewen

Re: [edk2] [PATCH v1 0/3] BaseTools: refactor and cleanup

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, April 05, 2018 4:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/3]

Re: [edk2] [PATCH v1 2/2] BaseTools: Remove unneeded files

Hi Jaben, 1. the BaseTools/Source/Python/Makefile also need remove those .py files, otherwise it would cause freeze binary failure. 2. EdkIIWorkspaceBuild.py use some function in those .py files, but in fact the EdkIIWorkspaceBuild.py also can be removed, so how about in your V2 patch also

Re: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

The patches are good to me. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 6:34 AM To: edk2-devel@lists.01.org

Re: [edk2] [PATCH v1 00/10] BaseTools: refactor code

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 5:03 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 00/10]

Re: [edk2] [Patch 3/9] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping

Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Kinney, Michael D Sent: Thursday, April 5, 2018 4:26 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Wei, David

Re: [edk2] [Patch 7/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Kinney, Michael D Sent: Thursday, April 5, 2018 4:26 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang

Re: [edk2] [PATCH v1 00/18] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

Thank you for this great work. Comment below: 1) I don't have comment for ArmPkg update (0001~0005, 0015) - I expect Arm expert will help on that. :-) 2) BaseTool (0016), reviewed-by: jiewen@intel.com 3) StandaloneMmPkg 3.1) 0007 - I think we need add ExHeader check and alignment