Re: [edk2] [PATCH] BaseTools: Fix regression issue by 1eb72acddd61

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, April 27, 2018 12:29 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX

[edk2] [PATCH] BaseTools: Fix regression issue by 1eb72acddd61

From: Yunhua Feng Fix regression issue by 1eb72acddd61 secRe not replace by secReGeneral Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng

Re: [edk2] [PATCH v1 0/2] MdePkg: IORT Specification updates

Thanks for your update. Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sami > Mujawar > Sent: Thursday, April 26, 2018 11:41 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH edk2-platforms] Silicon/Socionext/SynQuacer: update PHY reference clock rate

On 19 April 2018 at 17:38, Leif Lindholm wrote: > On Mon, Apr 16, 2018 at 01:00:58PM +0200, Ard Biesheuvel wrote: >> As reported by Kojima-san, the PHY reference clock value we use in our >> ACPI and DT descriptions is out of sync with the hardware. Replace >> 125 MHz

Re: [edk2] [PATCH v1] Platform/ARM: Fix platform timer offset in GTDT

On 24 April 2018 at 16:19, Sami Mujawar wrote: > The FVP_PLATFORM_TIMER_COUNT is the sum of the memory > mapped platform timers and the watchdog timers. > > The watchdog timers can be disabled by setting the > FVP_WATCHDOG_COUNT (defined by PcdWatchdogCount) > to zero. > >

Re: [edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

On 26 April 2018 at 12:47, Leif Lindholm wrote: > On Thu, Apr 26, 2018 at 09:47:17AM +, Sami Mujawar wrote: >> Hi Ard, >> >> I do not have the setup currently to test ArmVExpress-CTA15-A7. However, I >> think it will need this change as well. >> Please ignore this

[edk2] [PATCH v2 18/27] BaseTools: Replace PCD type strings with predefined constant

v2 - fix YongHong's comment. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 +--

[edk2] [PATCH v2 19/27] BaseTools: Replace Binary File type strings with predefined constant

BINARY_FILE_TYPE_FW was 'FW' BINARY_FILE_TYPE_GUID was 'GUID' BINARY_FILE_TYPE_PREEFORM was 'PREEFORM' BINARY_FILE_TYPE_UEFI_APP was 'UEFI_APP' BINARY_FILE_TYPE_UNI_UI was 'UNI_UI' BINARY_FILE_TYPE_UNI_VER was 'UNI_VER' BINARY_FILE_TYPE_LIB was 'LIB' BINARY_FILE_TYPE_PE32 was 'PE32'

[edk2] [PATCH v2 13/27] BaseTools: replace string constants used for module types

replace raw strings in the code (note: except UPT) with constants. SUP_MODULE_BASE was 'BASE' SUP_MODULE_SEC was 'SEC' SUP_MODULE_PEI_CORE was 'PEI_CORE' SUP_MODULE_PEIM was 'PEIM' SUP_MODULE_DXE_CORE was 'DXE_CORE' SUP_MODULE_DXE_DRIVER was 'DXE_DRIVER' SUP_MODULE_DXE_RUNTIME_DRIVER was

[edk2] [PATCH v2 21/27] BaseTools: replace string with predefined constant

v2 - add missing namespace. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Ecc/Check.py | 2 +- 1 file changed, 1

[edk2] [PATCH v2 16/27] BaseTools: Replace EDK Component strings with predefined constant

EDK_COMPONENT_TYPE_LIBRARY was 'LIBRARY' EDK_COMPONENT_TYPE_SECURITY_CORE was 'SECURITY_CORE' EDK_COMPONENT_TYPE_COMBINED_PEIM_DRIVER was 'COMBINED_PEIM_DRIVER' EDK_COMPONENT_TYPE_PIC_PEIM was 'PIC_PEIM' EDK_COMPONENT_TYPE_RELOCATABLE_PEIM was 'RELOCATABLE_PEIM' EDK_COMPONENT_TYPE_BS_DRIVER was

Re: [edk2] [PATCH v1 2/2] MdePkg: IORT Specification Rev D updates

On 26 April 2018 at 17:41, Sami Mujawar wrote: > Updated IORT structure definitions to conform to the IO Remapping > Table, Platform Design Document, Revision D, March 2018. > > The following structures have been updated: > 1. SMMUv3 - fix on proximity node. > 2. PMCG -

[edk2] [PATCH v1 2/2] MdePkg: IORT Specification Rev D updates

Updated IORT structure definitions to conform to the IO Remapping Table, Platform Design Document, Revision D, March 2018. The following structures have been updated: 1. SMMUv3 - fix on proximity node. 2. PMCG - added page 1 support. 3. Root complex node - added DMA mask (memory address

[edk2] [PATCH v1 1/2] MdePkg: SMMUv3 updates for IORT table definitions

Updated the IORT SMMUv3 Node structure and flags to match the IO Remapping Table, Platform Design Document, Revision C dated 15 MAY 2017. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd

[edk2] [PATCH v1 0/2] MdePkg: IORT Specification updates

The IORT specification was updated soon after the patch "MdePkg: SMMUv3 updates for IORT table definitions" (included again in this series) was submitted. In response to query regarding the changes for the latest revision (See https://lists.01.org/pipermail/edk2-devel/2018-March/023295.html);

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

Thanks. Maybe we should also do more test on different FIT table (correct format, or wrong format), to check the robustness of the code. For example, don't use ASSERT to check FIT table content, because it might not in Initial Boot Block (IBB) region. Thank you Yao Jiewen > -Original

Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743

Can you also update the comment to match the code please. I think that the comment is wrong and your code is correct, but now they are opposite. The comment says skip (return in context) for no binary files, but the new code will skip for modules with binary files... -Jaben > -Original

Re: [edk2] [PATCH v1 09/18] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.

Same comment as previous 2. Maybe to separate ARM specific function from generic function. Thank you > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Achin > Gupta > Sent: Wednesday, April 25, 2018 7:34 AM > To: Supreeth Venkatesh

Re: [edk2] [PATCH v1 10/18] StandaloneMmPkg/HobLib: Add AARCH64 Specific HOB Library for management mode.

Maybe we can use same layout as MmMemLib. It seems only HobConstructor() is Arm specific. Other functions are quite generic. Thank you > -Original Message- > From: Achin Gupta [mailto:achin.gu...@arm.com] > Sent: Wednesday, April 25, 2018 7:50 AM > To: Supreeth Venkatesh

Re: [edk2] [PATCH v1 08/18] StandaloneMmPkg/MemLib: AARCH64 Specific instance of memory check library.

You are right. I propose to add Arm and X86 specific folder - just include PA calculation. We can leave the generic function in common folder. The final layout can be: StandaloneMmPkg/Library/MmMemLib/MmMemLib.c StandaloneMmPkg/Library/MmMemLib/MmMemLib.inf

[edk2] [PATCH v1] Platforms/ARM: Enable acpiview support

Acpiview is a program that allows examination of ACPI table contents from the UEFI Shell. Enable acpiview support as this can help with investigations, especially at that stage where the tables are not enabling an OS to boot. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 3/3] Platform/ARM: Fix NOR Flash dependency for CTA15A7

The correct load order for the NOR Flash driver and Runtime Variables to work is as below: 1. Arm CPU Architecture Protocol Dxe 2. NOR Flash Dxe 3. Runtime Variable Dxe NvVarStoreFormattedLib was recently introduced to resolve the dependency order and more details can be seen at

Re: [edk2] [PATCH v2] OvmfPkg/QemuVideoDxe: round up FrameBufferSize to full page

On 04/26/18 09:02, Gerd Hoffmann wrote: > Guests do the same, because the framebuffer is mapped somewhere, which > obviously works with page granularity only. > > When not rounding up to full page size we get messages like this one > (linux kernel): > > efifb: framebuffer at 0x8000,

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: remove OpenSSL version number from OpenSSL-HOWTO.txt

On 04/26/18 02:47, Long, Qin wrote: > Yes, this was not refreshed at last upgrade. And I agree it's better to > remove this statement. > > Reviewed-by: Long Qin > Thank you, commit e31fe995b81b. Laszlo ___ edk2-devel mailing

Re: [edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

On Thu, Apr 26, 2018 at 09:47:17AM +, Sami Mujawar wrote: > Hi Ard, > > I do not have the setup currently to test ArmVExpress-CTA15-A7. However, I > think it will need this change as well. > Please ignore this patchset, I will send another one shortly. No need to resubmit the whole set -

Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

On 04/26/18 05:12, Haojian Zhuang wrote: > On 26 April 2018 at 00:10, Laszlo Ersek wrote: >> (4) In both patches, in both of the CreatePlatformBootOptionFromPath() >> and CreatePlatformBootOptionFromGuid() helper functions, the >> "DevicePath" variable is leaked when >>

Re: [edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

Hi Ard, I do not have the setup currently to test ArmVExpress-CTA15-A7. However, I think it will need this change as well. Please ignore this patchset, I will send another one shortly. Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 26

Re: [edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

On 26 April 2018 at 11:32, Sami Mujawar wrote: > These patches fix the "Firmware Volume for Variable Store is > corrupted" issue which is seen when the Flash is erased or > not formatted. > > Sami Mujawar (2): > Platform/ARM: Fix NOR Flash dependency for Juno >

[edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

These patches fix the "Firmware Volume for Variable Store is corrupted" issue which is seen when the Flash is erased or not formatted. Sami Mujawar (2): Platform/ARM: Fix NOR Flash dependency for Juno Platform/ARM: Fix NOR Flash dependency for FVP Platform/ARM/JunoPkg/ArmJuno.dsc

[edk2] [PATCH 2/2] Platform/ARM: Fix NOR Flash dependency for FVP

The correct load order for the NOR Flash driver and Runtime Variables to work is as below: 1. Arm CPU Architecture Protocol Dxe 2. NOR Flash Dxe 3. Runtime Variable Dxe NvVarStoreFormattedLib was recently introduced to resolve the dependency order and more details can be seen at

[edk2] [PATCH 1/2] Platform/ARM: Fix NOR Flash dependency for Juno

The correct load order for the NOR Flash driver and Runtime Variables to work is as below: 1. Arm CPU Architecture Protocol Dxe 2. NOR Flash Dxe 3. Runtime Variable Dxe NvVarStoreFormattedLib was recently introduced to resolve the dependency order and more details can be seen at

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

Ray, Some minor comments below. 1. How MSG_USB_DP and HW_PCCARD_DP be handled? We see they are checked in original IsHotPlugDevice()? 2. gEfiUsbIoProtocolGuid needs be stated in ConPlatformDxe.inf? 3. The comment " If it is not a hot-plug device, append the device path to " in

[edk2] [PATCH v2] OvmfPkg/QemuVideoDxe: round up FrameBufferSize to full page

Guests do the same, because the framebuffer is mapped somewhere, which obviously works with page granularity only. When not rounding up to full page size we get messages like this one (linux kernel): efifb: framebuffer at 0x8000, using 1876k, total 1875k

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

> -Original Message- > From: edk2-devel On Behalf Of Laszlo > Ersek > Sent: Wednesday, April 25, 2018 10:16 PM > To: Ni, Ruiyu > Cc: Wu, Hao A ; Kinney, Michael D > ;

Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, April 25, 2018 11:09 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

On 25 April 2018 at 19:26, Julien Grall wrote: > Hi Ard, > > Thank you for the series, I confirm it fixes EDK2 boot in Xen guest. > > Tested-by: Julien Grall > Acked-by: Julien Grall > Pushed as 1eb72acddd61..ef42ef7e6dd7

[edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

This patch is to fix the issue reported from https://bugzilla.tianocore.org/show_bug.cgi?id=925. DataSize variable was not assigned the value if ShellOpenFileByName returns error. In the such a case, it should not be used to FreePages. Instead, DataSize can be used to record the file size once