[edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-05-31 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Chasel Chiu Cc: Hao A Wu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 214 +++ MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 23 ++- 2 files changed, 235 insertions(+), 2

[edk2] [PATCH 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby devices

2018-05-31 Thread Ruiyu Ni
The patch adds support to certain devices that support PUIS (Power up in Standby). For those devices that supports SET_FEATURE spin up, SW needs to send SET_FEATURE subcommand to spin up the devices. For those devices that doesn't support SET_FEATURE spin up, SW needs to send read sectors command

[edk2] [PATCH 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-05-31 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Chasel Chiu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 48 ++ .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c| 19 -

[edk2] [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-05-31 Thread Ruiyu Ni
The patch adds AtaAtapiPolicy protocol which is produced by platform and consumed by AtaAtapiPassThruDxe driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h | 59 ++

[edk2] [PATCH 0/4] Support PUIS and DEVSLP feature

2018-05-31 Thread Ruiyu Ni
Ruiyu Ni (4): MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby devices MdeModulePkg: Add AtaAtapiPolicy protocol definition MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Enable ACPI via cmd register

2018-05-31 Thread You, Benjamin
Hi Matt, Sure. I will prepare a patch for this. Thanks, - ben > From: Matt Delco [mailto:de...@google.com] > Sent: Friday, June 1, 2018 10:13 AM > To: You, Benjamin > Cc: edk2-devel@lists.01.org; Ma, Maurice ; Agyeman, > Prince > Subject: Re: [PATCH] CorebootModulePkg/CbSupportDxe: Enable

[edk2] [PATCH v8 edk-platforms 2/6] Platform/HiKey960: do basic initialization

2018-05-31 Thread Haojian Zhuang
Do some basic initliazation on peripherals, such as pins and regulators. The hardcoding code is taken from non-open reference code. Can't fix it for lack of documents. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Enable ACPI via cmd register

2018-05-31 Thread Matt Delco
Normally I would provide a patch, but I'm not sure I'd add correctly add the checks that were proposed for CbParseFadtInfo(). I'd also have to go through an company-internal review process regarding edk2's contributor license agreement (I incorrectly assumed this had already been done when I

Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Enable ACPI via cmd register

2018-05-31 Thread You, Benjamin
Hi, Matt, Thanks. Would you like to provide an updated patch? Thanks, - ben > From: Matt Delco [mailto:de...@google.com] > Sent: Friday, June 1, 2018 5:55 AM > To: You, Benjamin > Cc: edk2-devel@lists.01.org; Ma, Maurice ; Agyeman, > Prince > Subject: Re: [PATCH]

Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

2018-05-31 Thread Ni, Ruiyu
Can you check which keyboard driver are you using? The keyboard driver is expected to translate "SHIFT" + "3" to "#" (without Shift state). I know that some keyboard driver doesn't do that correctly. E.g.: SHIFT + "3" is translated to "#" but the SHIFT state is not masked off. [Sorry I thought I

Re: [edk2] [Patch 1/5] Build Spec: Add !error statement support

2018-05-31 Thread Zhu, Yonghong
Hi Laszlo, I didn't add Bugzilla info for !error bug. When I commit this patch, I will add this Bugzilla info. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, May 31, 2018 6:27 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org

Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Enable ACPI via cmd register

2018-05-31 Thread Matt Delco
Hi, I commented out the body of OnReadyToBoot() and the result is as expected (i.e., ACPI events are still received, presumably because the OS enabled ACPI for itself). On Wed, May 30, 2018 at 7:52 PM, You, Benjamin wrote: > Hi, Matt, > > The original SCI_EN setting code was added to cover

Re: [edk2] [PATCH edk2-platforms v1] Platform/ARM: Declare FVP Generic Timer Frame #1 as Non-secure

2018-05-31 Thread Leif Lindholm
On Wed, May 23, 2018 at 02:51:34PM +0100, AlexeiFedorov wrote: > From: Alexei Fedorov > > Programming Reference for Base FVPs describes 2 Generic Memory-mapped > Timer frames with Non-secure access permitted to frame #1. > However ACPI GTDT lists both timer frames #0 and #1 with > Secure Timer

Re: [edk2] [PATCH edk2-platforms 0/2] enable FPDT table for SynQuacer

2018-05-31 Thread Leif Lindholm
On Thu, May 31, 2018 at 12:46:32PM +0200, Ard Biesheuvel wrote: > Enable some of the status code reporting infrastructure in patch #1 so > we can include the FPDT DXE driver in patch #2 which produces the FPDT > diagnostic table which tells us how much time was spent in the firmware, > in the OS

Re: [edk2] [PATCH v7 edk-platforms 2/6] Platform/HiKey960: do basic initialization

2018-05-31 Thread Leif Lindholm
Oh, and please resubmit only this patch. The rest are good to go, but I'll bring them in together. / Leif On Thu, May 31, 2018 at 10:01:51PM +0100, Leif Lindholm wrote: > This fixes the headers, but ignores the most important bit of feedback > on v6: > > On Thu, May 31, 2018 at 11:10:06AM

Re: [edk2] [PATCH v7 edk-platforms 2/6] Platform/HiKey960: do basic initialization

2018-05-31 Thread Leif Lindholm
This fixes the headers, but ignores the most important bit of feedback on v6: On Thu, May 31, 2018 at 11:10:06AM +0800, Haojian Zhuang wrote: > Do some basic initliazation on peripherals, such as pins and > regulators. > > The hardcoding code is taken from non-open reference code. > Can't fix it

Re: [edk2] [PATCH v7 edk-platforms 5/6] Platform/HiKey: do basic initialization on hikey

2018-05-31 Thread Leif Lindholm
On Thu, May 31, 2018 at 11:10:09AM +0800, Haojian Zhuang wrote: > Do some basic initialization on HiKey platform, such as pin > setting, regulators and making peripherals out of reset mode. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [RFC 1/1] BaseTools/Capsule: Add Capsule Generation Tools

2018-05-31 Thread Kinney, Michael D
Liming, The C code was in the original content from MS_UEFI. It may be possible to update GenFds to use the new python modules. I have not investigated this yet. Mike > -Original Message- > From: Gao, Liming > Sent: Thursday, May 31, 2018 7:26 AM > To: Kinney, Michael D ; >

[edk2] Uefi capsule to update IHV device FW

2018-05-31 Thread Ameer Mahagneh
Hi, we are trying to use uefi capsule to update IHV device FW. we found a lot of wiki's that explain how to generate Uefi FW capsule and in the EDK it explained well. but how can we generate a capsule of a IHV device FW? unfortunately we found an empty github explanation, does anyone know where

Re: [edk2] [PATCH v2] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-05-31 Thread Ard Biesheuvel
On 31 May 2018 at 21:47, Meenakshi Aggarwal wrote: > This patch add function EfiTimeToWday() which returns > day of the week. > It is needed by our upcoming patches in edk2-platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > Signed-off-by:

Re: [edk2] [RFC 1/1] BaseTools/Capsule: Add Capsule Generation Tools

2018-05-31 Thread Gao, Liming
Mike: Which C tool is converted? Does it support all capsule generation functionality in GenFv tool? And, GenFds has the logic to generate FMP capsule. Can they share same logic? Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 30, 2018 6:57 AM

[edk2] [PATCH v2] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-05-31 Thread Meenakshi Aggarwal
This patch add function EfiTimeToWday() which returns day of the week. It is needed by our upcoming patches in edk2-platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal Signed-off-by: Vabhav Sharma --- EmbeddedPkg/Include/Library/TimeBaseLib.h

Re: [edk2] [PATCH] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-05-31 Thread Meenakshi Aggarwal
Yes, we need this patch for edk2-platform changes [Leif suggested to move the changes in edk2 as function was a generic one]. Will send V2. Thanks, Meenakshi -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, May 31, 2018 6:38 PM To: Meenakshi

Re: [edk2] [PATCH] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-05-31 Thread Ard Biesheuvel
On 31 May 2018 at 19:02, Meenakshi Aggarwal wrote: > This patch add function EfiTimeToWday() which returns > day of the week. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > Signed-off-by: Vabhav Please use your full name in the S-o-b line

Re: [edk2] [Patch v3 1/2] MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support

2018-05-31 Thread Ard Biesheuvel
On 29 May 2018 at 18:17, Michael D Kinney wrote: > From: "Kinney, Michael D" > > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Based on content from the following branch/commits: > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport > > * Change Update_Image_Progress() to

[edk2] reg: ISCSI Aborted attempt entry in IBFT Table

2018-05-31 Thread Sivaraman Nainar
Hello all: Here is the issue which requires clarification. Issue Synopsis: When there are more than one iSCSI target configured and Ibft table published with the connected and aborted attempt details, all the targets are not seen in ESXi and SLES OS. But in Windows it can see the targets

[edk2] [PATCH] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-05-31 Thread Meenakshi Aggarwal
This patch add function EfiTimeToWday() which returns day of the week. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal Signed-off-by: Vabhav --- EmbeddedPkg/Include/Library/TimeBaseLib.h | 8 ++ EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c |

Re: [edk2] [RFC v3 0/4] Add FmpDevicePkg

2018-05-31 Thread Ard Biesheuvel
On 30 May 2018 at 17:15, Kinney, Michael D wrote: > Hi Add, > > The FmpDevicePkg is a different way to produce > FMP and the recommendation will be to use this > one instead of the existing one. The concept > is to provide a simpler way to produce an FMP > with a library instance and a few PCD

Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-31 Thread Ard Biesheuvel
On 29 May 2018 at 16:31, Kinney, Michael D wrote: > Ard, > > I broke the series up into multiple series. > > I can send out the 4th one this morning so > you can see the one that uses it. It is a > repeat of content that was shared in a single > series earlier. I deferred it so we can get > all

Re: [edk2] [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances

2018-05-31 Thread Ard Biesheuvel
(+ Leif) On 25 May 2018 at 08:15, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Based on content from the following branch/commits: > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport > > Add DisplayUpdateProgressLib instances for text consoles >

Re: [edk2] [PATCH edk2-platforms 1/3] Silicon/SynQuacerPciHostBridgeLib: add workaround for PCIe MMIO64

2018-05-31 Thread Ard Biesheuvel
On 31 May 2018 at 11:46, Leif Lindholm wrote: > On Thu, May 31, 2018 at 11:17:47AM +0200, Ard Biesheuvel wrote: >> On 31 May 2018 at 11:11, Leif Lindholm wrote: >> > On Wed, May 30, 2018 at 08:19:27PM +0200, Ard Biesheuvel wrote: >> >> From: Masahisa KOJIMA >> >> >> >> The current revision of

Re: [edk2] [PATCH edk2-platforms 0/4] SynQuacer updates

2018-05-31 Thread Ard Biesheuvel
On 31 May 2018 at 11:04, Leif Lindholm wrote: > On Wed, May 23, 2018 at 04:14:40PM +0200, Ard Biesheuvel wrote: >> Patch #4 fixes a bug that breaks the DEBUG build. Remaining patches >> are general improvements. >> >> Ard Biesheuvel (4): >> Platform/DeveloperBox: add 96boards/Socionext logo >>

[edk2] [PATCH edk2-platforms 2/2] Platform/DeveloperBox: enable FPDT table

2018-05-31 Thread Ard Biesheuvel
Enable runtime generation of the ACPI FPDT table, which contains some performance data regarding how much time was spent in the various boot phases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++

[edk2] [PATCH edk2-platforms 0/2] enable FPDT table for SynQuacer

2018-05-31 Thread Ard Biesheuvel
Enable some of the status code reporting infrastructure in patch #1 so we can include the FPDT DXE driver in patch #2 which produces the FPDT diagnostic table which tells us how much time was spent in the firmware, in the OS loader, and in ExitBootServices(). Ard Biesheuvel (2):

[edk2] [PATCH edk2-platforms 1/2] Platform/DeveloperBox: wire up status code reporting for DXE phase

2018-05-31 Thread Ard Biesheuvel
Wire up minimal support for status code reporting in the DXE phase, to the extent required for supporting the FPDT ACPI table, which we will enable in a subsequent patch. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [Patch 1/5] Build Spec: Add !error statement support

2018-05-31 Thread Laszlo Ersek
Hello Yonghong, On 05/31/18 02:56, Yonghong Zhu wrote: > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 8_pre-build_autogen_stage/82_auto-generation_process.md | 6 ++ > README.md

Re: [edk2] [PATCH edk2-platforms 1/3] Silicon/SynQuacerPciHostBridgeLib: add workaround for PCIe MMIO64

2018-05-31 Thread Leif Lindholm
On Thu, May 31, 2018 at 11:17:47AM +0200, Ard Biesheuvel wrote: > On 31 May 2018 at 11:11, Leif Lindholm wrote: > > On Wed, May 30, 2018 at 08:19:27PM +0200, Ard Biesheuvel wrote: > >> From: Masahisa KOJIMA > >> > >> The current revision of SC2A11 contains PCIe bus issue. > >> In MRd

Re: [edk2] [Patch v3 1/2] MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support

2018-05-31 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael D Kinney Sent: Wednesday, May 30, 2018 12:18 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Yao, Jiewen ; Dong, Eric ; Zeng, Star Subject: [edk2] [Patch v3

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size

2018-05-31 Thread Laszlo Ersek
On 05/31/18 08:43, Guo, Mang wrote: > Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 > version. Because this version OS needs larger SMM stack size to set variable. > Changed SMM stack size from 0x2000 to 0x4000 to fix this issue. > >

Re: [edk2] [PATCH edk2-platforms 1/3] Silicon/SynQuacerPciHostBridgeLib: add workaround for PCIe MMIO64

2018-05-31 Thread Ard Biesheuvel
On 31 May 2018 at 11:11, Leif Lindholm wrote: > On Wed, May 30, 2018 at 08:19:27PM +0200, Ard Biesheuvel wrote: >> From: Masahisa KOJIMA >> >> The current revision of SC2A11 contains PCIe bus issue. >> In MRd transaction, 1st/Last DW BE fields are not correctly set >> by hardware. >> >> As a

Re: [edk2] [PATCH edk2-platforms 3/3] Silicon/SynQuacer/AcpiTables: add NETSEC/eMMC SMMU to the IORT

2018-05-31 Thread Leif Lindholm
On Wed, May 30, 2018 at 08:19:29PM +0200, Ard Biesheuvel wrote: > Add a description of the SMMU that sits in front of the NETSEC and > eMMC controllers to the IORT table so that ACPI based OSes can > utilize it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard

Re: [edk2] [PATCH edk2-platforms 2/3] Silicon/Socionext/SynQuacer/Stage2Tables: add north SMMU level 3 table

2018-05-31 Thread Leif Lindholm
On Wed, May 30, 2018 at 08:19:28PM +0200, Ard Biesheuvel wrote: > Extend the static stage 2 page tables with a set of level 3 tables that > describe the ECAM space in a manner that allows the north SMMU to be used > to make the ECAM space appear sane to the CPUs. > > It is up to the secure

Re: [edk2] [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion

2018-05-31 Thread Zeng, Star
It could be reused by platform SystemFirmwareDescriptor, for example. Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf So, I agree this patch, Reviewed-by: Star Zeng .

Re: [edk2] [PATCH edk2-platforms 1/3] Silicon/SynQuacerPciHostBridgeLib: add workaround for PCIe MMIO64

2018-05-31 Thread Leif Lindholm
On Wed, May 30, 2018 at 08:19:27PM +0200, Ard Biesheuvel wrote: > From: Masahisa KOJIMA > > The current revision of SC2A11 contains PCIe bus issue. > In MRd transaction, 1st/Last DW BE fields are not correctly set > by hardware. > > As a workaround, set TH bit and specify MSG_CODE in iATU. >

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size

2018-05-31 Thread Guo, Mang
Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. Changed SMM stack size from 0x2000 to 0x4000 to fix this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=964 Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-platforms 0/4] SynQuacer updates

2018-05-31 Thread Leif Lindholm
On Wed, May 23, 2018 at 04:14:40PM +0200, Ard Biesheuvel wrote: > Patch #4 fixes a bug that breaks the DEBUG build. Remaining patches > are general improvements. > > Ard Biesheuvel (4): > Platform/DeveloperBox: add 96boards/Socionext logo > Platform/DeveloperBox: add PCI serial driver >

[edk2] [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion

2018-05-31 Thread Ard Biesheuvel
Add a PCD that holds the lowest supported version number, so that we can allow the platform to configure this at build time. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- As discussed a while ago:

Re: [edk2] [PATCH edk2-platforms 0/4] SynQuacer updates

2018-05-31 Thread Ard Biesheuvel
On 23 May 2018 at 16:14, Ard Biesheuvel wrote: > Patch #4 fixes a bug that breaks the DEBUG build. Remaining patches > are general improvements. > > Ard Biesheuvel (4): > Platform/DeveloperBox: add 96boards/Socionext logo > Platform/DeveloperBox: add PCI serial driver >

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size

2018-05-31 Thread Wei, David
Please also change the size for 32-bit BIOS. Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Guo, Mang Sent: Thursday, May 31, 2018 2:44 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Yuan, Xuemin

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

2018-05-31 Thread Guo, Mang
Hi Mike, Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. SMM stack size was changed from 0x2000 to 0x4000 to fix this issue. Updated the patch to provide a complete description of the change in

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size

2018-05-31 Thread Guo, Mang
Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. Changed SMM stack size from 0x2000 to 0x4000 to fix this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=964 Cc: Wei David Cc: Xuemin Yuan

Re: [edk2] [RFC PATCH edk2-platforms 0/6] expand capsule to include SCP firmware

2018-05-31 Thread Ard Biesheuvel
On 16 March 2018 at 17:13, Ard Biesheuvel wrote: > Now that the NOR flash layout has been updated to split the actual SCP > firmware from the startup code and the builtin flasher, we can add the > SCP image to the capsule update to make it field upgradeable. > > This involves some rather nasty