On 6/25/2018 6:38 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=973
HUB descriptor has variable length.
But the code uses stack (HubDesc in UsbHubInit) with fixed length
sizeof(EFI_USB_HUB_DESCRIPTOR) to hold HUB descriptor data.
It uses hard code length value (32 that
New added checkers includes:
1. Too many invalid parameters
2. Too few parameter
3. Invalid number parameter for -n and -t flag
4. Conflict parameter of -A and -R.
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
Hi Gary,
The V4 patches are good to me. I will push this series in recent days if no
other comment from community.
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Monday, June 25, 2018 6:31 PM
To: edk2-devel@lists.0
Chris:
Here is the example usage. You can add below [BuildOptions] in your platform
DSC. Then, it will use override ASL path and flag.
[BuildOptions]
*_*_*_ASL_PATH == C:\Asl\asl.exe
*_*_*_ASL_FLAGS== /MsftInternal
*_*_*_ASL_OUTFLAGS
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Tuesday, June 26, 2018 7:18 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong
Subject: [PATCH v1 1/1] BaseTools: AutoGen - Remove unused variables.
There are 2 variables th
On Mon, Jun 25, 2018 at 06:31:23PM +0800, Gary Lin wrote:
> v4 changes:
v4 is rebased to 3b03b5e990f8bb347dfdb91926d8ef015d0b607e
> - Remove the range() patch since it needs python-future
> - Remove the patch to unify long and int since it caused error in
> windows.
> - Split the absolut
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Monday, June 25, 2018 8:48 AM
To: edk2-devel@lists.01.org
Cc: Feng, YunhuaX ; Gao, Liming
Subject: [edk2] [Patch] BaseTo
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, June 26, 2018 8:57 AM
To: edk2-devel@lists.01.org
Cc: Chen, Pai-chingX ; c...@ml01.01.org
Subject: [edk2] [PATCH]
From: "Chen, Pai-Ching"
Change-Id: I147ad470d5840c6fee1086f629991f8a9f9d9056
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen, Pai-Ching
---
.../Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/ini.py| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
> Sent: Tuesday, June 26, 2018 2:15 AM
> To: edk2-devel@lists.01.org
> Cc: gar...@hpe.com; joseph.shiffl...@hpe.com; Ni, Ruiyu; Wu, Hao A; Thomas
> Palmer
> Subject: [PATCH
There are 2 variables that we populate, but never use.
remove them entirely.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 10 --
1 file changed, 10 deletions(-)
diff
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, June 25, 2018 12:10 PM
> To: Chris Co
> Cc: Ard Biesheuvel ; edk2-devel@lists.01.org;
> Charles Garcia-Tobin
> Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL
> Toolchain support
>
> On Mon, Jun 25, 2018 at
On Mon, Jun 25, 2018 at 06:21:27PM +, Chris Co wrote:
> > >-Original Message-
> > >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> > >Sent: Monday, June 25, 2018 3:34 PM
> > >To: Gao, Liming
> > >Cc: Chris Co ; edk2-devel@lists.01.org;
> > >Leif Lindholm ; Charles Garcia-Tobi
> -Original Message-
> From: Gao, Liming
> Sent: Monday, June 25, 2018 1:15 AM
> To: Ard Biesheuvel
> Cc: Chris Co ; edk2-devel@lists.01.org; Leif
> Lindholm ; Charles Garcia-Tobin to...@arm.com>
> Subject: RE: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL
> Toolchain suppo
A single byte was allocate for a CHAR16 NUL terminator when instead
two bytes should have been used.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Palmer
---
Nt32Pkg/WinNtBusDriverDxe/WinNtBusDriver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -
Reviewed-by: Bret Barkelew
- Bret
From: Star Zeng
Sent: Monday, June 25, 2018 3:38:13 AM
To: edk2-devel@lists.01.org
Cc: Star Zeng; Jiewen Yao; Ruiyu Ni; Bret Barkelew
Subject: [PATCH 2/2] MdeModulePkg UsbBusPei: Fix wrong buffer length used to
read hub des
Reviewed-by: Bret Barkelew
- Bret
From: Star Zeng
Sent: Monday, June 25, 2018 3:38:12 AM
To: edk2-devel@lists.01.org
Cc: Star Zeng; Jiewen Yao; Ruiyu Ni; Bret Barkelew
Subject: [PATCH 1/2] MdeModulePkg UsbBusDxe: Fix wrong buffer length used to
read hub des
On 06/25/18 18:01, Laszlo Ersek wrote:
> Hello Ray,
>
> On 06/25/18 04:54, Ruiyu Ni wrote:
>> Today's MpInitLib PEI implementation directly calls
>> PeiServices->GetHobList() from AP which may cause racing issue.
>>
>> This patch fixes this issue by storing the CpuMpData to memory
>> preceding IDT
Hello Ray,
On 06/25/18 04:54, Ruiyu Ni wrote:
> Today's MpInitLib PEI implementation directly calls
> PeiServices->GetHobList() from AP which may cause racing issue.
>
> This patch fixes this issue by storing the CpuMpData to memory
> preceding IDT. Pointer to PeiServices pointer is stored there,
On 06/25/18 01:07, Kinney, Michael D wrote:
> Hello,
>
> This is a proposal for periodic stable tags on edk2 repositories.
>
> The goal is to produce a stable tag for edk2 repositories every 3 months
> with the initial proposed dates of 8/10/2018 and 11/16/2018. Each release
> is preceded by a 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=973
Cc: Jiewen Yao
Cc: Ruiyu Ni
Cc: Bret Barkelew
Star Zeng (2):
MdeModulePkg UsbBusDxe: Fix wrong buffer length used to read hub desc
MdeModulePkg UsbBusPei: Fix wrong buffer length used to read hub desc
MdeModulePkg/Bus/Usb/UsbBusDxe/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=973
Bug 973 just mentions UsbBusDxe, but UsbBusPei has similar issue.
HUB descriptor has variable length.
But the code uses stack (HubDescriptor in PeiDoHubConfig) with fixed
length sizeof(EFI_USB_HUB_DESCRIPTOR) to hold HUB descriptor data.
It
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=973
HUB descriptor has variable length.
But the code uses stack (HubDesc in UsbHubInit) with fixed length
sizeof(EFI_USB_HUB_DESCRIPTOR) to hold HUB descriptor data.
It uses hard code length value (32 that is greater than
sizeof(EFI_USB_HUB_DESCR
Replace StringIO.StringIO with io.BytesIO to be compatible with python3.
This commit also removes "import StringIO" from those python scripts
that don't really use it.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/
Based on "futurize -f lib2to3.fixes.fix_idioms"
* Change some type comparisons to isinstance() calls:
type(x) == T -> isinstance(x, T)
type(x) is T -> isinstance(x, T)
type(x) != T -> not isinstance(x, T)
type(x) is not T -> not isinstance(x, T)
* Change "while 1:" into "while Tru
"types.TypeType" is now an alias of the built-in "type" and is not
compatible with python 3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Tests/TestTools.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Make "raise" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/gcc/mingw-gcc-build.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/gcc/mingw-gcc-build
Change the octal literals according to PEP3127
https://www.python.org/dev/peps/pep-3127/
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/LongFilePathOs.py | 2 +-
BaseTools/Source/Python/UPT/Core
v4 changes:
- Remove the range() patch since it needs python-future
- Remove the patch to unify long and int since it caused error in
windows.
- Split the absolute import patches and will introduce them later
v3 changes:
- Rebase to the current git HEAD (2e1083038d9aa74fcaa2db8158fdee7
Convert "except ... ," to "except ... as" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_except"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins
Replace "has_key()" with "in" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_has_key"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/
Replace "<>" with "!=" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
BaseTools/Source/Python/AutoGen/BuildEngine.
According to PEP3113, tuple parameter is removed in python 3.
(PEP3113: https://www.python.org/dev/peps/pep-3113/)
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/VpdInfoFile.py | 3 ++-
1 file c
"if mis not None:" => "if m is not None:"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Jaben Carsey
Cc: Yonghong Zhu
Cc: Liming Gao
Reviewed-by: Jaben Carsey
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/ini.py | 2
+-
1 file
StandardError has been removed from python 3.
Replace it with Exception.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/UPT/UPT.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Ba
Refactor print statements to be compatible with python 3.
Based on "futurize -f libfuturize.fixes.fix_print_with_import"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +-
BaseTools/Source/Python/AutoGen/GenC.py| 4 +
BaseTools/Source/Python/GenFds/FdfParser.py| 81 --
.../Sou
Enable Structure pcd value assigned by FixedPcd
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
.../Source/Python/Workspace/MetaFileParser.py | 23 +++---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/BaseT
Ard:
The commit log message says that the Microsoft ASL compiler is necessary to
expose Windows-specific Pin Function Config Descriptors on Windows IoT devices.
Besides, there is no ways to configure tool chain with the parameter in build
command. But, tool chain ASL path and flag can be ove
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Friday, June 22, 2018 4:56 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Zeng, Star ;
>Kinney, Michael D
>Subject: [patch V2 0/9] Add new Perf macros
>
>Add a group of new Perf macros in performance library for per
Ruiyu Ni (2):
MdeModulePkg/BmpSupportLib: Correct debug message
MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth against 0
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
--
2.16.1.windows.1
___
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Michael D Kinney
Cc: Star Zeng
---
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupport
The patch adds check logic to make sure that for a input BMP file,
the width or height is not 0; for a input GOP blt buffer, the width
or height is not 0. Otherwise, UNSUPPORTED status is returned.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
Cc:
(+ Charles)
On 25 June 2018 at 03:38, Gao, Liming wrote:
> Chris:
>GCC 4.9 targeting arm-none-eabi. This GCC4.9 should run in Windows OS. So,
> could you give some info where windows GCC49 is from.
>
OK, so first of all, could you elaborate on why we need a different
ASL compiler? We have s
44 matches
Mail list logo
