Re: [edk2] [Patch V2] BaseTools: Fix parsing multiple nest !include issue

When I commit this patch, I will change it to use TAB_INCLUDE. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, June 29, 2018 4:48 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: RE: [edk2] [Patch V2]

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: handle ultimate boot failure

Thanks, Laszlo. Hi Ray, After looking into , I just realized that I think too deep about the purpose of adding the EfiBootManagerUnableToBoot (). EfiBootManagerUnableToBoot () is added for solving the problem that user don't want to see

Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL Toolchain support

> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, June 26, 2018 10:08 PM > To: Chris Co > Cc: Gao, Liming ; Leif Lindholm > ; edk2-devel@lists.01.org; Charles Garcia-Tobin > > Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL > Toolchain support > >

[edk2] [PATCH edk2-platforms v1 0/1]Readme: Add instructions to build in a Windows Environment

REF: https://github.com/christopherco/edk2-platforms/tree/win_build_doc_v1 These instructions detail how to setup a Windows build environment and build for ARM platforms using the GCC cross-compiler toolchain. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co

[edk2] [PATCH edk2-platforms v1 1/1] Readme: Add instructions to build in a Windows Environment

These instructions detail how to setup a Windows build environment and build for ARM platforms using the GCC cross-compiler toolchain. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Readme.md

[edk2] [Patch V2] UefiCpuPkg/MpInitLib: Remove redundant parameter.

Parameter StartCount duplicates with RunningCount. After this change, RunningCount means the running AP count. V2 changes: Remove volatile for RunningCount. Done Test: 1.PI SCT Test 2.Boot OS / S3 Cc: Ruiyu Ni Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH 0/2] Variable: Make sure no more than one Variable HOB

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Thursday, June 28, 2018 6:22 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: [edk2] [PATCH 0/2] Variable: Make sure no more than one Variable

Re: [edk2] [Patch V2] FDF Spec: support varstore template generation with a [FV] section

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, June 28, 2018 2:22 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Shaw, Kevin W >; Gao, Liming >Subject: [edk2] [Patch V2] FDF

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

My understading: Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.inf is DXE counterpart of Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmm.inf, to produce EfiFirmwareVolumeBlock2?ProtocolGuid based on gEfiSmmFirmwareVolumeBlockProtocolGuid by SMM comm. Platform can choose FvbSmmDxe + FvbSmm, or

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter.

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 28, 2018 11:37 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant > parameter. > > Hi Eric, > > On

Re: [edk2] [PATCH] MdeModulePkg SataControllerDxe: Calculate ChannelCount based on PI value

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Thursday, June 28, 2018 6:14 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Chan, Amy; Hsueh, Hong-chihX; Yao, Jiewen; Sami Mujawar; Ni, > Ruiyu; Wu, Hao A > Subject: [PATCH] MdeModulePkg

Re: [edk2] [Patch V2] BaseTools: Fix parsing multiple nest !include issue

If you change the raw string ("!INCLUDE) to use the one defined in DataType.py (TAB_INCLUDE), then I like it. Note that you will need to lower() instead of upper() to support this change. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel

[edk2] [PATCH v2 1/1] BaseTools/Trim: Normalize filepaths to fix comparisons on Windows

When using Linaro GCC5+ arm-eabi toolchain on Windows, the generated DSDT.iii contains a canonicalized ("\.\" removed and lower case) filepath for the preprocessed DSDT.i file in the first line. Trim.exe is called on DSDT.iii to generate DSDT., which does a line for line comparison of

[edk2] [PATCH v2 0/1] BaseTools/Trim: Normalize filepaths to fix comparisons on Windows

REF: https://github.com/christopherco/edk2/tree/trim_gcc_v2 v1: https://lists.01.org/pipermail/edk2-devel/2018-June/026562.html new in v2: Use os module to normalize filepaths instead of direct string manipulation Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [staging/dynamictables PATCH v1 4/5] DynamicTablesPkg: Fix macro to prevent side effect

Hi Leif, I agree it will be good to update the code to use ALIGN_VALUE(x,4). I can see 2 options to fix this: - Resubmit a v2 patchset with this change. OR - I can submit a separate patch (on top of the current patchset) for this change. Can you let me know which one is preferred, please?

Re: [edk2] [staging/dynamictables PATCH v1 4/5] DynamicTablesPkg: Fix macro to prevent side effect

On Wed, Jun 27, 2018 at 05:47:45PM +0100, Sami Mujawar wrote: > The ALIGN32 macro had undesired side effects when used with binary > operators and was generating compilation errors. > > Added brackets to fix this issue. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

On Wed, Jun 27, 2018 at 04:58:04PM +, Evan Lloyd wrote: > > Signed-off-by: Evan Lloyd Should I take this one (and the one on the other accompanying set) as Reviewed-by? / Leif > > -Original Message- > > From: Sami Mujawar > > Sent: 27 June 2018 17:49 > > To:

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter.

Hi Eric, On 06/28/18 13:29, Eric Dong wrote: > Parameter StartCount duplicates with RunningCount. After this change, > RunningCount means the running AP count. > > Done Tests: > 1.PI SCT Test > 2.Boot OS / S3 > > Cc: Ruiyu Ni > Cc: Jeff Fan > Cc: Laszlo Ersek > Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: handle ultimate boot failure

On 06/28/18 11:02, Wang, Sunny (HPS SW) wrote: > Hi Ray, > > Does the ultimate boot failure include the case where the system > doesn't have "BootManagerMenu" application? If so, I think we should > move EfiBootManagerUnableBoot() call out of BdsBootManagerMenuLoop(). > The

Re: [edk2] [edk2 ] MS signed EFI Shell

On 06/28/18 12:09, vikash kumar wrote: > Hi all, > > From where I can download Microsoft's signed efi shell (Shellx64.efi)? You can't. The UEFI shell is a powerful tool that can do just about anything; in particular what it does is dicated by the shell scripts that it runs, and it might

Re: [edk2] [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix comparison

I understand this issue now. I agree this enhancement to compare the full path. Thanks Liming > -Original Message- > From: Evan Lloyd [mailto:evan.ll...@arm.com] > Sent: Thursday, June 28, 2018 6:35 PM > To: Chris Co ; edk2-devel@lists.01.org; Gao, > Liming > Cc: Leif Lindholm ; Sami

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

On 06/28/2018 07:57 AM, Laszlo Ersek wrote: [...] --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c @@ -847,7 +847,7 @@ MarkMemoryRangeForRuntimeAccess (    );    Status = gDS->AddMemorySpace ( -

Re: [edk2] [PATCH] MdeModulePkg PeiCore: Not assume PpiDescriptor and Ppi in same range

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Thursday, June 28, 2018 4:56 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Huang, Qing > Subject: [PATCH] MdeModulePkg PeiCore: Not assume PpiDescriptor and Ppi in > same range > > Current

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

On 06/28/18 14:57, Laszlo Ersek wrote: > On 06/27/18 19:49, Brijesh Singh wrote: >> >> >> On 06/27/2018 11:59 AM, Laszlo Ersek wrote: >>> On 06/27/18 18:34, Brijesh Singh wrote: On 06/27/2018 07:54 AM, Laszlo Ersek wrote: > On 06/26/18 21:46, Brijesh Singh wrote: >>> >> After that,

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

On 06/28/18 08:25, Zeng, Star wrote: > My understanding is MMIO is not managed by UEFI memory services, but GCD > services. > PI spec says " If the memory range specified by BaseAddress and Length is of > type EfiGcdMemoryTypeSystemMemory or EfiGcdMemoryTypeMoreReliable, then the > memory range

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

On 06/28/18 08:16, Zeng, Star wrote: > 1) My understanding is Variable Driver is managing the variable region in > flash although the flash read/write/erase operations are done in flash > driver. Current Variable Driver needs the address (to variable region) be > converted to virtual address

Re: [edk2] [PATCH v1 0/2] MdePkg: IORT Specification updates

Sorry for late. Push them at 27e983.. 1e2bf5 > -Original Message- > From: Sami Mujawar [mailto:sami.muja...@arm.com] > Sent: Thursday, June 28, 2018 3:54 AM > To: Gao, Liming ; edk2-devel@lists.01.org; Kinney, > Michael D > Cc: Stephanie Hughes-Fitt ; > ard.biesheu...@linaro.org;

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

On 06/27/18 19:49, Brijesh Singh wrote: > > > On 06/27/2018 11:59 AM, Laszlo Ersek wrote: >> On 06/27/18 18:34, Brijesh Singh wrote: >>> On 06/27/2018 07:54 AM, Laszlo Ersek wrote: On 06/26/18 21:46, Brijesh Singh wrote: >> > After that, any access > to the flash will end up going

[edk2] [Patch 1/2] UefiCpuPkg/MpInitLib: Not use disabled AP.

Based on PI spec description, disabled APs should not been include in the StartupAllAPs task. Current implementation always change AP state to CpuStateReady in WakeUpAP function which also let Disabled APs to do the task. This patch reduce the CPU state to only three state: Idle, busy and

[edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter.

Parameter StartCount duplicates with RunningCount. After this change, RunningCount means the running AP count. Done Tests: 1.PI SCT Test 2.Boot OS / S3 Cc: Ruiyu Ni Cc: Jeff Fan Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

Re: [edk2] [PATCH edk2-platforms v1 4/6] Hisilicon/D05: Add PlatformMiscDxe driver

On 28 June 2018 at 04:26, Ming wrote: > > > 在 2018/6/27 15:33, Ard Biesheuvel 写道: >> On 27 June 2018 at 09:04, Ming Huang wrote: >>> Fix the issue of onboard Nic not work kerenl with AMD GPU and >>> NVME SSD in board. The GPU don't support 64 MSI, so need to >>> allocate INTx, but the default

Re: [edk2] [RFC] EDK II stable tag releases

> -Original Message- > From: edk2-devel On Behalf Of Laszlo > Ersek > Sent: 25 June 2018 16:23 > To: Kinney, Michael D ; edk2- > de...@lists.01.org > Subject: Re: [edk2] [RFC] EDK II stable tag releases > > On 06/25/18 01:07, Kinney, Michael D wrote: > > Hello, > > > > This is a

Re: [edk2] [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix comparison

Hi Chris. > -Original Message- > From: Chris Co > Sent: 27 June 2018 21:03 > To: Evan Lloyd ; edk2-devel@lists.01.org; Liming Gao > > Cc: Leif Lindholm ; Sami Mujawar > > Subject: RE: [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix > comparison > > > -Original

[edk2] [PATCH 0/2] Variable: Make sure no more than one Variable HOB

Star Zeng (2): MdeModulePkg Variable: Abstract GetHobVariableStore function MdeModulePkg Variable: Make sure no more than one Variable HOB MdeModulePkg/Universal/Variable/Pei/Variable.c | 64 --- .../Universal/Variable/RuntimeDxe/Variable.c | 117 +++-- 2

[edk2] [PATCH 2/2] MdeModulePkg Variable: Make sure no more than one Variable HOB

VariableHob may be built in PcdPeim (by PcdNvStoreDefaultValueBuffer) or some platform module (by some tool). The two solutions should not be co-exist. Cc: Liming Gao Cc: Jiewen Yao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

[edk2] [PATCH 1/2] MdeModulePkg Variable: Abstract GetHobVariableStore function

Move getting HOB variable store code logic to a separated GetHobVariableStore function. Cc: Liming Gao Cc: Jiewen Yao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/Variable/Pei/Variable.c | 40 +++---

[edk2] [PATCH] MdeModulePkg SataControllerDxe: Calculate ChannelCount based on PI value

Current code calculates ChannelCount based on CAP(NP) value. It only works when the ports implemented number are <= CAP(NP), for example, platform has CAP(NP) = 5 (means 6 ports) and ports implemented are 0, 1, 2, 3, 4 and 5. But we have some platform that has CAP(NP) = 1 (means 2 ports) and

[edk2] [edk2 ] MS signed EFI Shell

Hi all, >From where I can download Microsoft's signed efi shell (Shellx64.efi)? Thanks in advance Vikash ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: handle ultimate boot failure

Hi Ray, Does the ultimate boot failure include the case where the system doesn't have "BootManagerMenu" application? If so, I think we should move EfiBootManagerUnableBoot() call out of BdsBootManagerMenuLoop(). The BdsBootManagerMenuLoop() is only called when system has BootManagerMenu

[edk2] [PATCH] MdeModulePkg PeiCore: Not assume PpiDescriptor and Ppi in same range

Current code assumes PpiDescriptor and Ppi are in same range (heap/stack/hole). This patch removes the assumption. Descriptor needs to be converted first. It is also handled by this patch. Cc: Liming Gao Cc: Qing Huang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: handle ultimate boot failure

When no boot option could be launched including platform recovery options and options pointing to applications built into firmware volumes, a platform callback registered through EfiBootManagerRegisterUnableBootHandler() is called. If there is no platform callback registered, default behavior is

Re: [edk2] [Patch] MdeModulePkg: Update IP4 driver to check for NULL pointer before using.

Reviewed-by: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, June 27, 2018 9:19 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [Patch] MdeModulePkg: Update IP4 driver to check for NULL > pointer before using. > > Cc: Ye Ting > Cc: Wu

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Fix the bug when parsing HTTP(S) message body.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, June 27, 2018 3:47 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [Patch] NetworkPkg/HttpDxe: Fix the bug when parsing HTTP(S) > message body. > >

[edk2] [Patch V2] BaseTools: Fix parsing multiple nest !include issue

From: Yunhua Feng Fix the bug !include file in Components subsection meet syntax error. Case example: DSC components: !include Test1.txt Test1.txt: TestPkg/TestDriver.inf { PcdToken.PcdTest1 | "A" !include Test2.txt } Test2.txt: !include Test3.txt Test3.txt: PcdToken.PcdTest2

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

My understanding is MMIO is not managed by UEFI memory services, but GCD services. PI spec says " If the memory range specified by BaseAddress and Length is of type EfiGcdMemoryTypeSystemMemory or EfiGcdMemoryTypeMoreReliable, then the memory range may be automatically *allocated* for use by

[edk2] [Patch V2] FDF Spec: support varstore template generation with a [FV] section

Add format to support varstore template generation with a dedicated [FV] section. Code bug: https://bugzilla.tianocore.org/show_bug.cgi?id=932 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

1) My understanding is Variable Driver is managing the variable region in flash although the flash read/write/erase operations are done in flash driver. Current Variable Driver needs the address (to variable region) be converted to virtual address for runtime, and it does not assume flash