The redundant functions which are never called have been
removed. They are InternalShellProtocolDebugPrintMessage,
UpdateFileName,RemoveFileTag and IsValidCommandName.
https://bugzilla.tianocore.org/show_bug.cgi?id=1066
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution
Hi Leif,
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, August 7, 2018 5:50 AM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Michael D Kinney
> ; Ard Biesheuvel
> Subject: Re: [PATCH edk2-platforms 1/4] Platform/Solidrun: Add
> Hummingboard SmBios
>
> I'll start trickling
_FILE_ parameter is an ASCII string. Current implementation used
as unicode string instead of ascii string. This patch fixed this
issue.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1081
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed_off_by: Eric Dong
---
在 8/3/2018 9:28 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:00PM +0800, Ming Huang wrote:
>> From: shaochangliang
>>
>> Because I2C Port5 salve device connect under 95545 device,
>
> salve -> slave
> What is 95545?
>
95545 should be 9545, a I2C extender.
>> it will cost more time
I agree with Laszlo.
Back to this patch series, the changes are made in drivers, but not in library.
The internal useless functions removed in core drivers should be not consumed
by platform code.
It is consumer's bug if there is real case. :)
Thanks,
Star
-Original Message-
From:
For HeapGuard.c part,
Reviewed-by: Jian J Wang
mailto:jian.j.w...@intel.com>>
Regards,
Jian
From: Ni, Ruiyu
Sent: Thursday, August 09, 2018 11:12 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star ; Wang,
Jian J
Subject: RE: [edk2] [PATCH 17/26] MdeModulePkg
Ruiyu Ni (2):
ShellPkg/redirection: Insert \xFEFF after converting ASCII to Unicode
ShellPkg/redirection: Insert \xFEFF for ENV variable redirection
ShellPkg/Application/Shell/FileHandleWrappers.c | 80 ++---
1 file changed, 58 insertions(+), 22 deletions(-)
--
When "
Cc: Jaben Carsey
---
ShellPkg/Application/Shell/FileHandleWrappers.c | 46 +
1 file changed, 31 insertions(+), 15 deletions(-)
diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.c
b/ShellPkg/Application/Shell/FileHandleWrappers.c
index
For HeapGuard.c part,
Reviewed-by: Jian J Wang
mailto:jian.j.w...@intel.com>>
Regards,
Jian
From: Ni, Ruiyu
Sent: Thursday, August 09, 2018 11:10 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star ; Wang,
Jian J
Subject: RE: [edk2] [PATCH 16/26] MdeModulePkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1080
Per Shell spec 2.2 chapter 3.4.4.2, Unicode file tag should be
inserted in the output from the input redirected variable, to ensure
it looks like a UCS-2 encode file.
The patch fixes this issue.
Contributed-under: TianoCore Contribution
Leif,
Do not worry, it is still in review progress.
Yes, we will make sure the patches do not get pushed until after the 201808
stable tag has been made.
Thanks,
Star
-Original Message-
From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
Sent: Wednesday, August 8, 2018 10:55 PM
To:
I agree with Laszlo. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 9, 2018 2:07 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 02/26] MdeModulePkg
> (3) The "UefiCpuPkg/Include/AcpiCpuData.h" header states that
> ACPI_CPU_DATA (the structure itself) "must be allocated below 4GB from
> memory of type EfiACPIMemoryNVS".
>
> If we have determined that this is no longer necessary, then:
> - we should first update the documentation in
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, August 9, 2018 5:29 AM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib:
> Combine implementation.
>
> On 08/08/18 09:40, Eric Dong wrote:
> > V1
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant
> functions
>
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove
> redundant functions
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a
> redundant function
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a
> redundant
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant
> functions
>
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 15/26] MdeModulePkg UsbBusPei: Remove
> redundant functions
>
+ Wang Jian.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove
> redundant functions
>
> The
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant
> functions
>
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove
> redundant functions
>
Copying Wang Jian.
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Zeng, Star
> Subject: [edk2] [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant
> functions
>
>
Since it's required by PL011 SerialPortLib.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc
Hi Shenglei,
The code updates are good. I have two minor comments.
1. Please update copyright year to 2018 in some files. For example:
Copyright (c) 2017
->
Copyright (c) 2017 - 2018
2. Make the new line aligned with old line. For example: the "## CONSUMES" is
not aligned.
Since PL011UartClockLib is required by PL011 SerialPortLib.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
Fix build failure by appending PL011UartClockLib
Haojian Zhuang (2):
Platform/HiKey960: add PL011UartClockLib
Platform/HiKey: add PL011UartClockLib
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
2 files changed, 2 insertions(+)
Cc: Leif
We met a case on GCC toolchain for increment build. the case is user
build Helloworld first, then rename the source file Helloworld.c to
Helloworld_new.c and also update the file name to Helloworld_new.c in
.inf file's [sources] section. finally, he rebuild it again.
It cause build failure due to
在 8/3/2018 9:42 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:03PM +0800, Ming Huang wrote:
>> From: Heyi Guo
>>
>> This driver fetches information from MADT, so it is adaptable for
>> partial good and 1P/2P, since MADT is updated for different
>> configurations by certain mechanism.
在 8/3/2018 9:32 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:02PM +0800, Ming Huang wrote:
>> From: Yang XinYi
>>
>> Add Setup Item "EnableGOP" for D06, This Item only takes
>> effect on SM750
>
> What is SM750? Please add more detail to commit message.
>
SM750 is a VGA device on
On 08/08/18 09:40, Eric Dong wrote:
> V1 changes:
>> Current code logic can't confirm CpuS3DataDxe driver start before
>> CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid.
>> Add implementation for AllocateAcpiCpuData function to remove this
>> assumption.
>
> V2 changes:
>>
On 08/07/18 14:23, Laszlo Ersek wrote:
> On 08/07/18 07:27, Gao, Liming wrote:
>> Laszlo:
>> I mean to keep the minimal change in PCCT. I don't prevent the necessary
>> change in PCCT code. Per your comments, this change in PCCT is necessary. If
>> so, I am OK to this patch.
>>
>>
Hi Andrew.
Thanks for the clarification!
Rafael
Em qua, 8 de ago de 2018 às 16:14, Andrew Fish escreveu:
>
> On Aug 8, 2018, at 10:31 AM, Rafael Machado <
> rafaelrodrigues.mach...@gmail.com> wrote:
>
> Hi everyone
>
> One question that was not answered and that could help us, is about
>
> On Aug 8, 2018, at 10:31 AM, Rafael Machado
> wrote:
>
> Hi everyone
>
> One question that was not answered and that could help us, is about skipping
> the MemoryTypeInfo variable usage.
> Is there any way to do this skip at a UEFI App ?
> Simple erasing the MemoryTypeInfo var seems a
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are AhciCheckDeviceStatus and AhciPortReset.
There's more. In total:
AhciCheckDeviceStatus, AhciPortReset, DRDYReady, DRDYReady2,
WaitForBSYClear2, AtaSoftReset.
With the commit message update:
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are EnableResetReminderFeature,DisableResetRemin-
> derFeature and DisableResetRequired.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Please don't split the function names with hyphens.
Hi everyone
One question that was not answered and that could help us, is about
skipping the MemoryTypeInfo variable usage.
Is there any way to do this skip at a UEFI App ?
Simple erasing the MemoryTypeInfo var seems a little to violent from our
perspective. What do you think?
Seems the system
On 08/08/18 18:05, Carsey, Jaben wrote:
> I have a question:
> How do we know that no platforms use these functions
We don't.
> given that not all of everyone's platforms are stored in the same place?
The general idea in open source development is that, when a contributor
modifies central /
Hello Eric,
On 08/08/18 09:40, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadToLock point,
> so the memory type no need to be ACPI NVS type, also the address not
> limit to below 4G.
> This change remove the limit of ACPI NVS memory type and below 4G.
>
> Pass OS
I have a question:
How do we know that no platforms use these functions given that not all of
everyone's platforms are stored in the same place?
I agree with Leif on timing; I really like cleanup.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
Hello Yunhua,
On 08/08/18 08:54, Feng, YunhuaX wrote:
> Modify class OrderedListDict, remove cmp and use hashlib instead of
> md5
>
> Yunhua Feng (3):
> BaseTools: Modify class OrderedListDict
> BaseTools: remove cmp due to deprecated in python3
> BaseTools: Use hashlib instead of md5
>
>
Eric, Star,
On Wed, Aug 08, 2018 at 04:46:46PM +0800, shenglei wrote:
> A lot of redundant functions which are never calld have been removed.I
> manually
> search these fuctions in source files to make sure that they are not used
> elsewhere.
> Also the MdeModulePkg was built to ensure that.
在 8/3/2018 9:30 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:01PM +0800, Ming Huang wrote:
>> From: shaochangliang
>>
>> Use I2C 400KB speed for config CDR
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: shaochangliang
>> Signed-off-by: Ming Huang
>>
在 8/8/2018 6:01 PM, Leif Lindholm 写道:
> On Wed, Aug 08, 2018 at 03:37:23PM +0800, Ming wrote:
>>
>>
>> 在 8/3/2018 2:10 AM, Leif Lindholm 写道:
>>> On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote:
From: Yan Zhang
Debug serial port init driver is added to initilize debug
Hi Eric,
On 08/08/18 09:40, Eric Dong wrote:
> V1 changes:
>> Current code logic can't confirm CpuS3DataDxe driver start before
>> CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid.
>> Add implementation for AllocateAcpiCpuData function to remove this
>> assumption.
>
> V2
在 8/3/2018 9:24 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:59PM +0800, Ming Huang wrote:
>> The hunt of waiting TX/TX finish is used by ten times,
>> so move there hunts to a function CheckI2CTimeOut.
>
> I approve of this change, but the subject is inaccurate.
>
> Please change
在 8/3/2018 6:40 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:58PM +0800, Ming Huang wrote:
>> From: shaochangliang
>>
>> I2C may enable failed in D06, so retry I2C enable while
>> enable failed.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by:
Hello,
I sent an RFC for review on EDK II stable tags.
https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html
There were no objections and we would like to move forward
with the an EDK II Stable Tag release. The original goal was
8/10/2018. I have seen a request to move the stable
Reviewed-by: Jim Dailey
-Original Message-
From: Ruiyu Ni [mailto:ruiyu...@intel.com]
Sent: Wednesday, August 8, 2018 12:04 AM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey; Dailey, Jim
Subject: [PATCH v2] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive
compare
REF:
On Wed, Aug 08, 2018 at 08:22:27PM +0800, Ming wrote:
> 在 8/3/2018 6:37 PM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote:
> >> From: Sun Yuanchen
> >>
> >> ARM_ACPI_HEADER is used by a unify module in other Pkg,
> >
> > What other Pkg?
>
> HwPkg
Then please
On Wed, Aug 08, 2018 at 07:44:36PM +0800, Ming wrote:
>
>
> 在 8/8/2018 5:59 PM, Leif Lindholm 写道:
> > On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote:
> >> 在 8/3/2018 1:36 AM, Leif Lindholm 写道:
> >>> On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote:
> This patch is relative
在 8/3/2018 6:37 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote:
>> From: Sun Yuanchen
>>
>> ARM_ACPI_HEADER is used by a unify module in other Pkg,
>
> What other Pkg?
>
HwPkg
>> so move some macro to PlatformArch.h for unify D0x.
>>
>> Contributed-under:
在 8/3/2018 6:24 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:55PM +0800, Ming Huang wrote:
>> From: Yang XinYi
>>
>> This library is added for oem setup menu item.
>
> Please add some detail about what settings are made available here.
>
Add it in v2.
>> Contributed-under:
Hi Jiewen
Thanks for highlighting this.
Just checked and we just add the Reserved/Acpi/Runtime types.
Seems the guess that this would be related to the MemoryTypeInfo var is not
the correct way to follow.
We'll keep working on it, maybe asking more questions to the community in
future.
Thank
在 8/8/2018 5:59 PM, Leif Lindholm 写道:
> On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote:
>> 在 8/3/2018 1:36 AM, Leif Lindholm 写道:
>>> On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote:
This patch is relative to D06 SasDxe driver. The SasDxe set a
variable to notice this
The function description comments should be not related to this patch.
I am ok with or without updating the comments in this patch.
Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, August 8, 2018 7:06 PM
To: Wang,
On 08/08/18 09:04, Wang, Jian J wrote:
> Hi Ruiyu,
>
> In function description comments, the @retval doesn't match the changes in
> this patch.
>
> With those changes,
> Reviewed-by: Jian J Wang
Same from my side,
Acked-by: Laszlo Ersek
Thanks!
Laszlo
>> -Original Message-
>>
On Wed, Aug 08, 2018 at 03:37:23PM +0800, Ming wrote:
>
>
> 在 8/3/2018 2:10 AM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote:
> >> From: Yan Zhang
> >>
> >> Debug serial port init driver is added to initilize debug
> >> serial port.
> >
> > What is special
On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote:
> 在 8/3/2018 1:36 AM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote:
> >> This patch is relative to D06 SasDxe driver. The SasDxe set a
> >> variable to notice this libray. Here Wait for all disk ready
> >>
在 8/3/2018 6:28 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:56PM +0800, Ming Huang wrote:
>> From: Sun Yuanchen
>>
>> according as watchdog design on D06, watchdog should be
>> stoped befor boot a option.
>
> stopped before
>
>>
>> Contributed-under: TianoCore Contribution Agreement
On Wed, Aug 08, 2018 at 11:49:41AM +0800, Ming wrote:
> > 在 8/3/2018 1:22 AM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote:
> >> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
> >> use for several modules like PciHostBridgeLib and Smbios.
>
On Wed, Aug 08, 2018 at 04:02:56PM +0800, Ming wrote:
> >> diff --git
> >> a/Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c
> >>
> >> b/Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c
> >> new file mode 100644
> >> index
在 8/3/2018 1:36 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote:
>> This patch is relative to D06 SasDxe driver. The SasDxe set a
>> variable to notice this libray. Here Wait for all disk ready
>> for 30S at most.
>>
>> Contributed-under: TianoCore Contribution
On Tue, Aug 07, 2018 at 10:25:26PM +0800, Ming Huang wrote:
> D02 is no need to maintain now, so remove D02 platform binary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
Pushed as b9d09208.
Thanks!
/
Leif
On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1. Remove D02 platform;
> 2. Fix a D03 issue about switch generic PciHostBridge;
>
> Code can also be found in github:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rm-D02
The function IsDevicePathExist that is never called
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Universal/SetupBrowserDxe/IfrParse.c | 33
The function EmmcPeimUnlinkMemBlock that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 24
The function GetStorageWidth that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Universal/HiiDatabaseDxe/ConfigRouting.c | 47
The functions that are never called have been removed.
They are SockRcvdErr,SockGroup and TcpPawsOK.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The function UnicodeFiFoGetKeyCount that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Universal/Console/TerminalDxe/Terminal.h | 12
The function Ip4Config2OnDhcp4Event that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Universal/Network/Ip4Dxe/Ip4Config2Impl.c| 16
The functions that are never called have been removed.
They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord,
SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry,
SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck,
The function IScsiFindTcbByITT that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Universal/Network/IScsiDxe/IScsiProto.c | 31
The function DisableKeyboard that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c| 26
The functions that are never called have been removed.
They are PeiHubSetHubFeature,IsPortConnectChange and
PeiUsbClearDeviceFeature.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
The function SdPeimUnlinkMemBlock that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24
The functions that are never called have been removed.
They are ClearGuardMapBit,SetGuardMapBit,IsHeadGuard,
IsTailGuard and CoreEfiNotAvailableYetArg0.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
The functions that are never called have been removed.
They are UsbHubCtrlSetHubFeature,UsbHubCtrlResetTT,UsbHcReset,
UsbHcAsyncIsochronousTransfer,UsbHcGetState,UsbHcSetState and
UsbHcIsochronousTransfer.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
The functions that are never called have been removed.
They are UfsPeimUnlinkMemBlock,UfsPeimRequestSense,
UfsPeimInquiry,UfsRwAttributes,UfsClearFlag,UfsReadFlag
and UfsFindAvailableSlotInTmrl
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under:
The functions that are never called have been removed.
They are PeiUsbSetConfiguration,PeiUsbSetDeviceAddress,
IsPortConnect,IsPortConnectChange,IsPortLowSpeedDeviceAttached
and PeiUsbGetDescriptor.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
The functions that are never called have been removed.
They are UfsClearFlag and UfsFindAvailableSlotInTmrl.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are XhcPeiReadDoorBellReg and UsbHcUnlinkMemBlock.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are XhcReadDoorBellReg and XhcWriteOpReg16.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are IoMmuFreeBuffer,DelinkMemoryBlock,IsMemoryBlockEmptied
,IsTDLinkPtrQHOrTD,GetCurrentFrameNumber,GetQHHorizontalLinkPtr
and GetQHHorizontalValidorInvalid.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric
A lot of redundant functions which are never calld have been removed.I manually
search these fuctions in source files to make sure that they are not used
elsewhere.
Also the MdeModulePkg was built to ensure that.
shenglei (26):
MdeModulePkg CapsuleApp: Remove a redundant function
The functions that are never called have been removed.
They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are AhciCheckDeviceStatus and AhciPortReset.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are SdCardGetCsd and SdCardGetScr.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are ReadNvmeAdminSubmissionQueueBaseAddress,
ReadNvmeAdminCompletionQueueBaseAddress and ReadNvmeAdminQueueAttributes
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore
The functions that are never called have been removed.
They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
The functions that are never called have been removed.
They are EnableResetReminderFeature,DisableResetRemin-
derFeature and DisableResetRequired.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
The function DumpImageAuthentication that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Application/CapsuleApp/CapsuleDump.c | 31
On Tue, Aug 07, 2018 at 10:52:59PM +0200, Ard Biesheuvel wrote:
> On 7 August 2018 at 22:51, Leif Lindholm wrote:
> > edk2 commit 1010873becc5,
> > ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the
> > d0x build, since they use their own PlatformBootManagerLib, which did
On Wed, Aug 08, 2018 at 09:58:41AM +0800, Ming wrote:
>
>
> 在 8/6/2018 6:21 PM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:28:16PM +0800, Ming Huang wrote:
> >> Add initial binary for D06.
> >> Build commit infomation:
> >> edk2: e73f499
> >> edk2-platforms: 7f223e6
> >> HwPkg: e0bf35e
>
在 8/3/2018 12:56 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:48PM +0800, Ming Huang wrote:
>> Add M41T83RealTimeClockLib for RTC.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang
>> Signed-off-by: Heyi Guo
>> ---
>>
From: hchen30
1. Complete the full path for import statement. Use "EccMain" to
replace "Ecc" for the absolute path support.
2. Fix some issues on configuration file.
3. Fix an issue of RaiseError not working in EdkLogger.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
V1 changes:
> Current code logic can't confirm CpuS3DataDxe driver start before
> CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid.
> Add implementation for AllocateAcpiCpuData function to remove this
> assumption.
V2 changes:
> Because CpuS3Data memory will be copy to smram
1 - 100 of 113 matches
Mail list logo
