Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support

Reviewed-by: Guo Mang mailto:mang@intel.com>> From: Steele, Kelly Sent: Saturday, September 22, 2018 2:29 AM To: edk2-devel@lists.01.org Cc: Wei, David; Guo, Mang Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support >From

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Flag after GPIO init

Reviewed-by: David Wei mailto:david@intel.com>> I am OK with this patch. Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Steele, Kelly Sent: Saturday, September 22, 2018 2:28 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang Subject: [PATCH]

Re: [edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Set PcdPciePort3Enable

Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Guo, Mang Sent: Wednesday, September 26, 2018 4:36 PM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [Patch][edk2-platforms/devel-IntelAtomProcessorE3900]

Re: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

On 9/26/2018 6:15 PM, Tomas Pilar (tpilar) wrote: This fixes unused const variable compilation error with gcc 7.3. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar --- ShellPkg/Application/Shell/Shell.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg Variable: Fix comment typo 'end' to 'start'

On 9/27/2018 9:49 AM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1214 This patch only updates comment and function description, so has no functionality impact. This patch fixes comment typo 'end' to 'start' in GetStartPointer. GetStartPointer for PEI and DXE has

[edk2] [PATCH] MdeModulePkg Variable: Fix comment typo 'end' to 'start'

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1214 This patch only updates comment and function description, so has no functionality impact. This patch fixes comment typo 'end' to 'start' in GetStartPointer. GetStartPointer for PEI and DXE has aligned function description, but

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files

Hi Kelly, We recently added UP2_BOARD macro and MINNOW3_MODULE_BOARD in DSC file as workaround. That's because UP2_BOARD does not have official BOARD_ID designed, we cannot dynamically detect board ID to select boot path. MINNOW3_MODULE_BOARD is added to avoid build failure which is caused

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

Yes. This idea also came to my mind last night, then no need introduce PeCoffEmulatorDxe and no platform change is needed. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Thursday, September 27, 2018 1:32 AM To: Ard Biesheuvel ; Zeng, Star ; Kinney, Michael D Cc:

Re: [edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Support UPD offset auto assignment

Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, September 26, 2018 7:29 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Zhu, Yonghong ; Chiu, > Chasel > Subject: [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Support UPD offset auto

Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines

Good to know. Thanks! > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Patrick Georgi > Sent: Wednesday, September 26, 2018 11:59 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to

Re: [edk2] [PATCH] GenCfgOpt.py: remove tailing space from output file

Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, September 26, 2018 7:58 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Zhu, Yonghong ; Chiu, > Chasel > Subject: [PATCH] GenCfgOpt.py: remove tailing space from output

Re: [edk2] [PATCH v3 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images

Hi Ard, Similar to my PciBusDxe feedback, it would be better if the image supported information was determined by calling LoadImage() and checking for an EFI_UNSUPPORTED return value. This also has the advantage of reducing the number of components that need to be aware of any new protocols

Re: [edk2] [PATCH v3 3/7] MdeModulePkg/PciBusDxe: invoke PE/COFF emulator for foreign option ROMs

Hi Ard, I am wondering if we can simplify the PciBusDxe driver and remove the image type supported check and instead depend on LoadImage(). LoadImage() will return EFI_UNSUPPORTED if the image type is not supported. Thanks, Mike > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

Ard, I think it depends on the license behind the click through. The fact that there is another .h file with the same content under a BSD license is good data point. However, that other .h file does not reference the spec with the click through license, so it is not clear where the define

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

Laszlo, Thanks for filing the BZ. Converting inline assembly to NASM source files is a really good direction to improve the readability and maintainability of the code by consolidating to one assembly source format. Thanks, Mike > -Original Message- > From: Laszlo Ersek

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

Hi Ard, I think this registration protocol would be a new protocol in the MdeModulePkg and the protocol would be produced by the DXE Core. The emulation drivers, including EBC would consume this protocol to register their services. This removes the need for the DXE Core to do a Register

Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines

I'm fine with discarding 1/3 and 3/3. 2/3 was already merged by Chasel Chui (commit 9062ab47870ea728307e32cdd939586a4ec67fc6), so from my point of view, that patch set is taken care of. Thanks, Patrick Am Mi., 26. Sep. 2018 um 05:13 Uhr schrieb Yao, Jiewen : > Hi Patrick > Do you agree that we

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files

Hi David, Yes this PCD information is board specific. That is why it is wrapped in a board specific define. I would move it into the board specific folder, but it is FixedAtBuild so it cannot go into the code. Did you want me to add a PcdsFixedAtBuild.dsc into the board specific folder and

Re: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tomas Pilar (tpilar) > Sent: Wednesday, September 26, 2018 3:16 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] ShellPkg: Remove unused

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform ID

Reviewed-by: David Wei mailto:david@intel.com>> Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Steele, Kelly Sent: Saturday, September 22, 2018 2:27 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform

Re: [edk2] [PATCH] BaseTools:Fix issue caused by 84a52d4d030185a44f2d8736142c6f0b19c6e9b1

Reviewed-by: Liming Gao > -Original Message- > From: Zhao, ZhiqiangX > Sent: Wednesday, September 26, 2018 6:30 PM > To: edk2-devel@lists.01.org > Cc: Zhao, ZhiqiangX ; Gao, Liming > ; Zhu, Yonghong ; > Feng, Bob C > Subject: [PATCH] BaseTools:Fix issue caused by >

[edk2] [Patch] BaseTools Python: Migrate Python27 to Python36

Hi All, Now we are working on bugzilla 55 (https://bugzilla.tianocore.org/show_bug.cgi?id=55) to migrate BaseTools python tool from Python27 to Python36. After this migration, the BaseTools will only support Python 3. And for now, user need

Re: [edk2] Tianocore and TPM2 pcr values

OK. So no issue in UEFI payload, right? Thank you Yao Jiewen From: Jorge Fernandez Monteagudo [mailto:jorg...@cirsa.com] Sent: Wednesday, September 26, 2018 5:06 PM To: Yao, Jiewen ; Zhang, Chao B ; edk2-devel@lists.01.org Subject: Re: Tianocore and TPM2 pcr values > You still cannot get the

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

On 09/26/18 11:34, Ni, Ruiyu wrote: > On 9/26/2018 5:05 PM, Laszlo Ersek wrote: >> Hi, >> >> On 09/25/18 21:48, Laszlo Ersek wrote: >>> Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code >>> for >>> me, from the XADD inline assembly added to "X64/GccInline.c" in commit >>>

[edk2] [PATCH] GenCfgOpt.py: remove tailing space from output file

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1212 UPD header files generated by GenCfgOpt.py may have tailing white space from some of the UPD description in DSC, especially when python script automatically switching lines for long description string. This patch will always remove tailing

[edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Support UPD offset auto assignment

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1211 For reducing maintenance effort, the UPD offset can be automatic assigned by GenCfgOpt.py following by alignment requirements. The usage model as below: . If UPD offset in DSC file are all '*', GenCfgOpt.py will assign offset for all UPD

[edk2] [PATCH] BaseTools:Fix issue caused by 84a52d4d030185a44f2d8736142c6f0b19c6e9b1

The commit 84a52d4d030185a44f2d8736142c6f0b19c6e9b1 will introduce the new issue "Invalid offset value for Dynamic Vpd PCD". This patch will fix the new issue, add 'DEFAULT' sku in to the AvailableSkuIdSet variable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX

[edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

This fixes unused const variable compilation error with gcc 7.3. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar --- ShellPkg/Application/Shell/Shell.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ShellPkg/Application/Shell/Shell.c

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

On Wed, 26 Sep 2018 at 12:07, Zeng, Star wrote: > > A little late feedback. Just an idea. > > Do you think whether it can make the consumer simpler like below or not? > > Add a new API RegisterInterfaces in the protocol and add a wrapper driver > PeCoffEmulatorDxe. > The emulators can call

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

Thanks, I'll respin. On 26/09/18 05:54, Ni, Ruiyu wrote: > On 9/25/2018 10:50 PM, Carsey, Jaben wrote: >> I would prefer we just delete this. >> >> Ray, >> What do you think? >> > Not sure I sent it or not. > I also prefer to delete it. Git history can help in future if we need it > again.

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

A little late feedback. Just an idea. Do you think whether it can make the consumer simpler like below or not? Add a new API RegisterInterfaces in the protocol and add a wrapper driver PeCoffEmulatorDxe. The emulators can call RegisterInterfaces, and consumer will call other APIs simply,

[edk2] [PATCH] BaseTools: Convert string value of void* pcd in command line to array.

For void* type pcd in command line, if its value is string, then convert the string value to array format. For example, build --pcd gUefiOvmfPkgTokenSpaceGuid.PcdTest="c", convert the pcd value from "c" to "{0x63,0x00}". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

Good news. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, September 26, 2018 4:01 PM To: Zeng, Star Cc: Ni, Ruiyu ; Tian, Feng ; Wang, Fei1 ; Grzegorz Jaszczyk ; edk2-devel@lists.01.org; Nadav Haklai ; Gao,

[edk2] [PATCH] MdeModulePkg/RegularExpressionDxe: modify inf to pass vs 2012 build

add /wd4703 for passing VS 2012 build.This equals /wd4701 in VS2015. Cc: Liming Gao Change-Id: I06ff88b11246491ccc83b2231d4070c2acd7331a Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf |

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

On 9/26/2018 5:05 PM, Laszlo Ersek wrote: Hi, On 09/25/18 21:48, Laszlo Ersek wrote: Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for me, from the XADD inline assembly added to "X64/GccInline.c" in commit 17634d026f96: 4383 : UINT32 EFIAPI

Re: [edk2] Tianocore and TPM2 pcr values

> You still cannot get the right PCR hardware value? Sorry, what do you mean? I think the only remaining thing is extending the tianocore payload from the coreboot once is loaded in order to detect changes in the payload but it's related to coreboot no edk2...

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

Hi, On 09/25/18 21:48, Laszlo Ersek wrote: > Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for > me, from the XADD inline assembly added to "X64/GccInline.c" in commit > 17634d026f96: > >> 4383 : >> UINT32 >> EFIAPI >> InternalSyncIncrement ( >> IN

Re: [edk2] Tianocore and TPM2 pcr values

OK. That means the PCR is extended successfully. You still cannot get the right PCR hardware value? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jorge Fernandez Monteagudo > Sent: Wednesday, September 26, 2018 4:54 PM > To: Yao, Jiewen

Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack pointer

Laszlo, You mean to add a specific interface to get stack pointer, right? I think it work for me too. But I guess there might be discussions before on such thing. Since it's not there, there might be some reasons not to do it. Mike and Liming, do you have any comments on this? Regards, Jian

Re: [edk2] Tianocore and TPM2 pcr values

I've added the Tcg2GetEventLog at the end of OnReadyToBoot from Tcg2Dxe.c and I can see: TPM2 Tcg2Dxe Measure Data when ReadyToBoot Tcg2GetEventLog ... (0x2) Tcg2GetEventLog (EventLogLocation - 8F3D2000) Tcg2GetEventLog (EventLogLastEntry - 8F3D27AE) Tcg2GetEventLog (EventLogTruncated - 0)

Re: [edk2] reg: Clarification on PXE Boot with Client and Server in Different Sub nets

Hi, Siva I think PXE boot should work if the relay agent is configured correctly to forward DHCP packets to our client, with the proper gateway address. Are you encounter any problem with such use case? BestRegards Fu Siyuan > -Original Message- > From: edk2-devel

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Set PcdPciePort3Enable

Use system setup variable to set PcdPciePort3Enable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../Board/AuroraGlacier/BoardInitPostMem/BoardInit.c | 5 + .../Board/AuroraGlacier/BoardInitPostMem/BoardInitPostMem.inf | 1 +

Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack pointer

On 09/26/18 04:18, Wang, Jian J wrote: > Hi, > > Since the patch will introduce "#if defined(...)" macro in code, which > violates > edk2 coding style, it's suggested to add exception to static checker. > > I'll wait for one or two days in case there's other suggestions. If no > objection >

[edk2] reg: Clarification on PXE Boot with Client and Server in Different Sub nets

Hello, Can you clarify if PXE boot supported to work with Client and PXE / DHCP Server running in different subnet? When the DHCP server running with Relay agent to manage different subnets will PXE boot work? -Siva ___ edk2-devel mailing list

Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

On Wed, 26 Sep 2018 at 02:36, Zeng, Star wrote: > > Just pushed it at e5cd809087e5710e019d2766fab13c59a2e2ac28. > Really thanks. > FYI this patch fixes the issue with my PCIe Renesas uPD70201 XHCI controller as well. > -Original Message- > From: Zeng, Star > Sent: Wednesday, September

Re: [edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chasel, Chiu > Sent: Wednesday, September 26, 2018 1:25 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > > Subject: [edk2] [PATCH]

Re: [edk2] Tianocore and TPM2 pcr values

That means the TPM2 device works well. We have code to dump the final event log at Tcg2GetEventLog(). // Dump Event Log for debug purpose if ((EventLogLocation != NULL) && (EventLogLastEntry != NULL)) { DumpEventLog (EventLogFormat, *EventLogLocation, *EventLogLastEntry,

Re: [edk2] Tianocore and TPM2 pcr values

Yes, from log I see: Loading driver at 0x0008F3F2000 EntryPoint=0x0008F3F2240 Tcg2Dxe.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 8F410C18 ProtectUefiImageCommon - 0x8F4107C0 - 0x8F3F2000 - 0xD800 PROGRESS CODE: V03040002 I0 InterfaceId - 0x

Re: [edk2] Tianocore and TPM2 pcr values

ProtectUefiImageCommon is not related. Below code is the Tcg2Dxe entrypoint, I expect you can see some message there: DriverEntry() if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), ) || CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), )){ DEBUG

Re: [edk2] Tianocore and TPM2 pcr values

Hi Yao > Yes, it is always good to enable serial port debug. There are lots of debug > message in Tcg2Dxe driver. We can know what is wrong. >From the log I've been able to see that "measure" messages start once >Tcg2Dxe.efi. From the beggining I can only see "ProtectUefiImageCommon"

Re: [edk2] Tianocore and TPM2 pcr values

Hi Jorge Yes, it is always good to enable serial port debug. There are lots of debug message in Tcg2Dxe driver. We can know what is wrong. In pure UEFI BIOS, the PEI driver extends to PCR0, and DXE image measurement lib extend to PCR2, PCR4, PCR5. The DXE driver extends variable to PCR1/7, and