Hello,
Today we enter a freeze for commits that add/remove
files or directories in edk2/master. This is in
preparation for the commits that change the edk2 repo
to a BSD+Patent License on April 9. Commits that make
changes to existing files are acceptable during this
transition. Once the
> On Apr 2, 2019, at 8:18 PM, Dong, Eric wrote:
>
> Hi Andrew,
>
> I double confirmed in SDM, CR2 is not included in SMRAM State Save Map. Do
> you means we should add this info in the commit message?
>
Eric,
Sorry I was confused by the commit message. I thought the state save was
Hi Andrew,
I double confirmed in SDM, CR2 is not included in SMRAM State Save Map. Do you
means we should add this info in the commit message?
Thanks
Eric
From: af...@apple.com [mailto:af...@apple.com]
Sent: Tuesday, April 2, 2019 1:01 AM
To: Laszlo Ersek
Cc: Vanguput, Narendra K ; edk2-devel
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, April 3, 2019 10:46 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: [Patch v2] UefiCpuPkg/MpInitLib: Fix MemTest86 failure.
>
> V2 changes:
> Update the commit message and comments in the code.
>
If user does not use multiple thread genfds, there will be no problem.
-Original Message-
From: Gao, Liming
Sent: Wednesday, April 3, 2019 10:49 AM
To: Feng, Bob C
Cc: edk2-devel@lists.01.org
Subject: RE: [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function
Bob:
Thanks
Bob:
Thanks for your updating. If user only update BaseTools, and don't update
Conf\build_rule.txt. What problem will happen?
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, April 3, 2019 10:17 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
V2 changes:
Update the commit message and comments in the code.
When waking vector buffer allocated by CpuDxe is tested by MemTest86
in MP mode, an error is reported because the same range of memory is
modified by both CpuDxe driver and MemTest86.
The waking vector buffer is not expected to be
The clean build performance data is good.
This change updates build rule generation for C source files on MSFT tool
chain. It is a base tool behavior change. If it doesn't depend on build rule,
could you drop the change in build rule.txt. MP flag will be moved to
tools_def.txt.
Thanks
> -Original Message-
> From: edk2-devel On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, April 2, 2019 4:49 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Cetola, Stephano ; Kinney, Michael D
> ; Gao, Liming ; Carsey,
> Jaben
> Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg
https://bugzilla.tianocore.org/show_bug.cgi?id=1450
In the Multiple thread Genfds feature, build tool generates
GenSec, GenFFS command in Makefile.
The Non-Hii Driver does not generate .offset file for uni string offset,
but the build tool has not knowledge about this in autogen phase. So
in this
BZ for remove additional copy action.
https://bugzilla.tianocore.org/show_bug.cgi?id=1673
-Original Message-
From: Gao, Liming
Sent: Friday, March 29, 2019 10:09 PM
To: Feng, Bob C ; edk2-devel@lists.01.org
Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function
Liming,
I add the performance data on the BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=1672
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Friday, March 29, 2019 10:20 PM
To: Feng, Bob C ; edk2-devel@lists.01.org
Cc: Fan, ZhijuX
Subject: RE: [Patch] BaseTools:Enable the
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1680
Consider modules with .inc source files as Binary Modules
and do not Skip by hash.
Re-order hashing operations so we don't do redundant hashes.
Respect artifact location within directory structure.
Re-use libraries, since they have already
We need to keep the following options available as parameters to the script:
- release/debug
- silent mode
- capsule
- performance
- FSP build options
Add these as script parameters.
Please also describe the parameter and JSON usage in the Readme.md.
JSON File
- These can override
1. Format the patch with the cover letter attached to the whole patch set with
the Blurb and CC list included in the cover letter.
2. Since this is rather large and a new design, can you please describe the
design in more detail?
3. Use camel case for all filenames
4. Add copyright headers to
Hi Leif,
1) I will update commit message for the Licence.txt
change to explain why the diff appears larger
than it should. The links you provided do not
provide a preferred ASCII text format. The
differences are due line break choices.
2) I will update the Copyright in the new
Reviewed-by: Ankit Sinha
-Original Message-
From: Kubacki, Michael A
Sent: Monday, April 1, 2019 7:47 PM
To: edk2-devel@lists.01.org
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Chiu, Chasel ; Gao,
Liming ; Kinney, Michael D
Subject: [edk2-platforms/devel-MinPlatform][PATCH v4 3/3]
Reviewed-by: Supreeth Venkatesh
Thanks,
Supreeth
-Original Message-
From: Eric Jin
Sent: Tuesday, April 2, 2019 10:17 AM
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch 1/1] SctPkg/UEFI: Remove redefined macro
Remove the macros which are already defined
On 4/2/19 5:16 PM, Eric Jin wrote:
> Remove the macros which are already defined in
> MdePkg/Include/Uefi/UefiInternalFormRepersentation.h
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
> ---
>
Hi Bret,
On 4/2/19 7:50 AM, Zhichao Gao wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677
>
> For some pointer and UINT64 data, the debug code print with '%x'.
> Which would loss the upper 32bit data. So update '%x' to '%lx'
> for these data.
Some are
Remove the macros which are already defined in
MdePkg/Include/Uefi/UefiInternalFormRepersentation.h
Cc: Supreeth Venkatesh
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/UEFI/Protocol/HiiDef.h | 44
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1628
Current FbGop driver might bind to the wrong PCI device
if a system has multiple PCI display devices. The original
idea was to reuse the generic GraphicsOutputDxe to address
this issue. However, after exploring different approaches
discussed
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, April 02, 2019 2:44 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Liming
> Subject: [PATCH] ShellPkg: Clarify the description of acpiview option '-s'
> Importance: High
>
>
Refactor the existing ArmPlatformPkg NOR flash driver to be usable
as a StandaloneMM library. Some of the functionality not required
in StandaloneMM, such as the block layer, is removed. This allows
storing of EFI variables on NOR flash which is accessible only via
the MM STANDALONE mode software
On 04/02/19 13:50, Ryszard Knop wrote:
> On Tue, 2019-04-02 at 13:45 +0200, Laszlo Ersek wrote:
>> On 04/02/19 13:29, Ryszard Knop wrote:
>>> On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote:
Hi Laszlo,
On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
> On
On 4/2/2019 6:38 AM, Ryszard Knop wrote:
Hi Stephano,
On https://edk2.groups.io/ the default group opened right away is
/g/devel, which is fine, but there isn't any indication of other groups
being available. It'd be useful to add links to other groups in the
description, for people not having
On Tue, 2019-04-02 at 13:45 +0200, Laszlo Ersek wrote:
> On 04/02/19 13:29, Ryszard Knop wrote:
> > On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote:
> > > Hi Laszlo,
> > >
> > > On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
> > > > On 04/02/19 07:38, Bi, Dandan wrote:
> > >
On 04/02/19 13:29, Ryszard Knop wrote:
> On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote:
>> Hi Laszlo,
>>
>> On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
>>> On 04/02/19 07:38, Bi, Dandan wrote:
Hi All,
ShellBinPkg is the remaining binary package in Edk2
Hi Stephano,
On https://edk2.groups.io/ the default group opened right away is
/g/devel, which is fine, but there isn't any indication of other groups
being available. It'd be useful to add links to other groups in the
description, for people not having your introductory mail linking other
groups
On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote:
> Hi Laszlo,
>
> On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
> > On 04/02/19 07:38, Bi, Dandan wrote:
> > > Hi All,
> > >
> > > ShellBinPkg is the remaining binary package in Edk2 repo. We
> > > plan
> > > to delete
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1153
The '-s' option of 'acpiview' do not support multiply invcation options.
So clarify it for users.
Modify the help decription for UefiShellAcpiViewCommandLib which the
description is equal or over 80 column. If the line include equal or over
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, April 2, 2019 4:41 PM
> To: Gao, Zhichao
> Cc: edk2-devel@lists.01.org; Bret Barkelew ;
> Wang, Jian J ; Gao, Liming ;
> Michael Turner ; Ni, Ray
> ; Sean Brogan ; Zeng, Star
> ; Cetola, Stephano
>
Hi Laszlo,
On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
> On 04/02/19 07:38, Bi, Dandan wrote:
> > Hi All,
> >
> > ShellBinPkg is the remaining binary package in Edk2 repo. We plan
> > to delete ShellBinPkg from edk2/master, and keep source ShellPkg
> > only in edk2 repo.
> >
On 04/02/19 07:38, Bi, Dandan wrote:
> Hi All,
>
> ShellBinPkg is the remaining binary package in Edk2 repo. We plan to delete
> ShellBinPkg from edk2/master, and keep source ShellPkg only in edk2 repo.
> Before the deletion, I will update the existing consumers in Edk2 and
> Edk2Platforms to
On 04/02/19 07:49, Zhichao Gao wrote:
> Add two event guids.
> And signal them immediately before and after the ReadyToBoot signal Event.
>
> Bret Barkelew (2):
> MdeModulePkg: Add event guids
> MdeModulePkg/UefiBootManagerlib: Add two event signals
>
>
On 04/02/19 03:45, Heyi Guo wrote:
> Hi Laszlo,
>
> Thanks for your time of reviewing and sorry for code style issues. I
> accept most of comments, with some questions for below ones:
>
> (7) coding style -- please use empty // lines before and after the
> comment line that you have right now.
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
>
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch v2 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify
> PcdCpuFeaturesSupport.
>
> PcdCpuFeaturesSupport used to
Minor comments:
1. Please add "CONST" before AndFeatureBitMask to declare that it won't be
changed in the routine.
SupportedMaskAnd (
IN UINT8 *SupportedFeatureMask,
IN CONST UINT8 *AndFeatureBitMask
)
2. Please update the year in the copyright.
With these comments
No change from V1 or V2 or V3.
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Monday, April 1, 2019 7:47 PM
To: edk2-devel@lists.01.org
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Chiu, Chasel ; Gao,
Liming ; Kinney, Michael D
Subject:
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Monday, April 1, 2019 7:47 PM
To: edk2-devel@lists.01.org
Cc: Desimone, Nathaniel L ; Chiu, Chasel
; Gao, Liming ; Kinney, Michael D
Subject: [edk2-platforms/devel-MinPlatform][PATCH v4 1/3]
No change from V1 or V2 or V3.
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Monday, April 1, 2019 7:47 PM
To: edk2-devel@lists.01.org
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Chiu, Chasel ; Gao,
Liming ; Kinney, Michael D
Subject:
Reviewed-by: Ray Ni
Please remember to update the year in copyright when pushing.
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove
43 matches
Mail list logo
