Re: [edk2] [PATCH V2 3/3] ShellPkg UefiDpLib: Remove TimerLib dependency

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 08, 2016 3:24 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Cinnamon Sh

Re: [edk2] [PATCH] MdePkg/BaseLib: Add 2 more safe string functions.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiewen Yao > Sent: Thursday, June 02, 2016 7:39 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <micha

Re: [edk2] Memory Consumption after BLT (GOP)

Well... sadly the best way to debug would be to get the memory map yourself, run your graphical operation, and then compare all inside the same program (assuming that you allocate no memory within your memory map acquisitions). -Jaben > -Original Message- > From: edk2

Re: [edk2] StdLib for EFI DRIVER type

solution for? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jabir > Sent: Monday, May 23, 2016 7:16 AM > To: edk2-devel@lists.01.org > Subject: [edk2] StdLib for EFI DRIVER type > Importance: High > > H

Re: [edk2] [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.

Marvin, I will review your patches this week. -Jaben > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Thursday, May 19, 2016 1:20 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject:

Re: [edk2] [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.

Can we safely remove the ASSERt now? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 19, 2016 12:04 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>

Re: [edk2] System Table and more

Those pointers are dependent on library constructors from associated libraries. You need to correctly include the library to make them function. The table pointer in your module's entry point should always be valid though. -Jaben > -Original Message- > From: edk2-devel [mailt

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

unhelpful. I like return values way more than I do asserts. The same way we have libraries in EDKII that have constructors and no destructors which means they are risky and potentially useless for any code that must support unload. -Jaben > On May 18, 2016, at 9:57 AM, Carsey, Jaben <jab

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

Sure. Reviewed by: Jaben Carsey <jaben.car...@intel.com> -Jaben > On May 18, 2016, at 9:44 AM, El-Haj-Mahmoud, Samer > <samer.el-haj-mahm...@hpe.com> wrote: > > Thanks Jaben! > > Will you give it a reviewed-by ? > > -Original Message- > F

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

> -Original Message- > From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] > Sent: Wednesday, May 18, 2016 9:21 AM > To: jim_dai...@dell.com; Carsey, Jaben <jaben.car...@intel.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

t it > to copy as much of the source string as possible instead of > ASSERT'ing or returning an error (and copying nothing) when the [Jaben] I disagree here. I think that returning the error and copying nothing is expected. I agree that the ASSERT is really unpleasant though and I like

Re: [edk2] [Patch] Use a local variable to cache the pointer.

Amended for commit. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, May 12, 2016 3:20 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shum

[edk2] [Patch] Use a local variable to cache the pointer.

CC: Qiu Shumin <shumin@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- ShellPkg/Application/Shell/Shell.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Application/Shel

[edk2] [Patch v2] report line number for command errors in a script.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- ShellPkg/Application/Shell/Shell.c | 6 +- ShellPkg/Application/Shell/Shell.uni | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Application

Re: [edk2] [Patch] ShellPkg: Add argument to set block size for tftp command.

Why write the function UintnToAscDec to convert UINTN to ascii string? PrintLib can do that for you. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Fu, Siyuan > Sent: Thursday, May 05, 2016 7:33 PM > To: edk2-devel@lists.01.org &

Re: [edk2] [PATCH] ShellPkg: Remove debug message in release binaries.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Wednesday, May 04, 2016 11:05 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> >

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Thanks! > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 9:39 PM > To: Carsey, Jaben <jaben.car...@intel.com>; Cinnamon Shia > <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; samer.el-haj-m

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 1:25 AM > To: Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben >

Re: [edk2] [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData()

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com] > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.

Re: [edk2] [PATCH] ShellPkg UefiDpLib: Delete one comment introduced by 196ccda08fc4

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shia, Cinnamon > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

I missed that the default was from the RFC. I agree with you. -Jaben > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, April 29, 2016 11:00 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: Marcin Wojtas <m...@s

[edk2] [review]Please review changes to UNI file format document

ribution Agreement 1.0 Signed-off-by: Jaben Carsey <jaben.car...@intel.com<mailto:jaben.car...@intel.com>> There are 3 sections here. The table of changes, the beginning of chapter 2, and chapter 4. 1.3 Added: * Syntax for non-ascii characters inside quoted stri

Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Maybe we should have a PCD control the default value so that people who build it can set it as per their own best value. Adding a parameter seems like a great (but separate) solution. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] accessing IP info. set using ifconfig shell command in EFI application.

You could look at the source code for that command since you know that does what you want. It's located here: ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > devendra rawat > Sent:

Re: [edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

possible. I mean it's a lot harder to use a DXE/PEI DRIVER in an application or unloadable driver than it is to link to a library. I just think that libraries should inherently be self-contained. That does not mean that you should add one in this case though... Reviewed-by: Jaben Carsey

Re: [edk2] [PATCH] ShellPkg: Fix pci command for '_e' option

Done. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Attar, Abdul Lateef > Sent: Tuesday, April 26, 2016 3:42 AM > To: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni, Ruiyu &l

Re: [edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

Laszlo, Does the library destructor not get called? Shouldn't that destructor unregister the protocol notify and leave the callback pointer in DXE core correct? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ers

Re: [edk2] [PATCH] ShellPkg: Fix typos and EDK2 coding style issues

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Wednesday, April 27, 2016 8:11 AM > To: Shah, Tapan <tapands...@hpe.com>; edk2-deve

Re: [edk2] [Patch] ShellPkg: Enhance ping6 to select the interface automatically

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, April 26, 2016 6:21 PM > To: Bhupesh Sharma <bhupesh.sha...@nxp.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Y

Re: [edk2] [PATCH] ShellPkg: Fix Shell treats every .EFI file as an executable application.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, April 24, 2016 10:56 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> &g

Re: [edk2] [PATCH] ShellPkg: Fix pci command for '_e' option

Looks good to me. I will let Shumin or Ray review also. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Thursday, April 21, 2016 4:24 AM &

Re: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively with '-r'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> From: Qiu, Shumin Sent: Tuesday, April 19, 2016 7:52 PM To: Carsey, Jaben <jaben.car...@intel.com> Cc: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] ShellPkg: Support connect a device h

Re: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively with '-r'.

I am confused. It looks like the code change is that "-r" requires ...GetCount() >2 where it used to be >1. Why? I didn't think that recursive searching required both DeviceHandle and DriverHandle to be on the command line... -Jaben > -Original Message-

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Monday, April 18, 2016 6:52 PM > To: edk2-devel@lists.01.org > Cc: David Van Arnem <dvanar...@cmlab.biz>; Bhupesh Sharma > <bhupesh.sha...@nxp.com>; C

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

That sounds like a good enhancement to me. -Jaben > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, April 14, 2016 8:52 PM > To: Carsey, Jaben <jaben.car...@intel.com>; David Van Arnem > <dvanar...@cmlab.biz>; Bhupesh Sharma <bhupesh.sha...

Re: [edk2] [PATCH v2] PerformancePkg: Make Dp print help information with -? flag in Shell.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Wednesday, April 13, 2016 1:07 AM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

Patch looks good, but let's make sure to give Bhupesh some time to test. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 13, 2016 3:30 AM > To: Wu, Jiaxin <jiaxin..

Re: [edk2] [PATCH v2] ShellPkg : Cache the environment variable into memory to enhance the performance.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, April 13, 2016 12:16 AM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.

Re: [edk2] [PATCH] ShellPkg : Cache the environment variable into memory to enhance the performance.

2 comments below. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, April 10, 2016 5:55 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.ca

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Friday, April 08, 2016 3:10 AM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin &

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, April 07, 2016 12:30 AM > To: Justen, Jordan L ; Ni, Ruiyu > ; edk2-devel@lists.01.org >

Re: [edk2] Using multiple SNP drivers on Shell

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, April 04, 2016 10:47 AM > To: Bhupesh Sharma > Cc: edk2-devel@lists.01.org ; David Van Arnem >

Re: [edk2] How to initiate a PXE boot from the UEFI shell

If your BDS supports PXE booting, you should be able to "exit" the shell and then use BDS to initiate a PXE boot.. I think you're right that there is no built in command to initiate a PXE boot. There is no command to initiate any boot type. -Jaben > -Original Message-

Re: [edk2] [PATCH] ShellPkg: Refine the comparisons code in ShellPkg.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, March 27, 2016 11:48 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, March 22, 2016 1:36 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH] ShellPkg: Make the USB mouse

Re: [edk2] Shell Aliases and Case-Sensitivity

-Jaben > On Mar 22, 2016, at 10:32 AM, "jim_dai...@dell.com" <jim_dai...@dell.com> > wrote: > > >> Jaben asked: > >> Why would we want to add something case sensitive when everything else >> is not case sensitive? Do we really want to have

Re: [edk2] Shell Aliases and Case-Sensitivity

insensitive? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Tuesday, March 22, 2016 7:13 AM > To: edk2-devel@lists.01.org > Subject: [edk2] Shell Aliases and Case-Sensitivity > Import

Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

hpe.com; Carsey, Jaben > <jaben.car...@intel.com>; Tapan Shah <tapands...@hpe.com> > Subject: [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the > Firmware Management Protocol Image Descriptor Information. > Importance: High > > Modify 'dh' shell command to d

Re: [edk2] [PATCH] ShellPkg: Modify 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

One final question below. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 10:32 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben > <jaben.car...@intel.com>; Tapan Shah <ta

Re: [edk2] [PATCH] ShellPkg: Modify 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

Got it. makes sense. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 11:08 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

Looks good to me. I will let Shumin check also. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, March 18, 2016 9:32 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@h

Re: [edk2] [PATCH] ShellPkg:

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 15, 2016 2:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shu

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when read 'TAB' key fail from 'ConIn'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, March 13, 2016 7:14 PM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: RE

Re: [edk2] EDK2 Setup & Configuration Issue

BaseTools and Conf should be one directory up I think. From: Jim Slaughter [mailto:jwslau...@yahoo.com] Sent: Tuesday, March 08, 2016 4:19 PM To: Carsey, Jaben <jaben.car...@intel.com>; Gao, Liming <liming@intel.com>; Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.

Re: [edk2] EDK2 Setup & Configuration Issue

Jim, You need to download or build the BaseTools that are used during the build. Have you done that? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jim > Slaughter > Sent: Tuesday, March 08, 2016 2:21 PM > To: Gao,

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> -Original Message- > From: Justen, Jordan L > Sent: Tuesday, March 08, 2016 11:37 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com>; Bjorge, Erik > C <erik.c.bjo...@intel.com> > Su

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> On Mar 7, 2016, at 7:16 PM, Jordan Justen wrote: > > The script is updated to support both python 2.7 and python 3. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > Cc: Yonghong Zhu

Re: [edk2] [PATCH] ShellPkg: Use DOS format end of line.

Fix Intel's copyright years in the modified files. If you do that, then good. Reviewed-By: Jaben Carsey <jaben.car...@intel.com> -Jaben Sent from my iPad. > On Mar 8, 2016, at 4:57 AM, Qiu, Shumin <shumin@intel.com> wrote: > > Use DOS format end of line(CR, LF).

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

Also for series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Monday, March 07, 2016 4:57 AM > To: edk2-devel@lists.01.org; Shia,

Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > On Mar 2, 2016, at 4:33 PM, Wu, Jiaxin <jiaxin...@intel.com> wrote: > > Thanks, Laszlo, I will fix it before commit the patch. > > >> -Original Message- >> From: Ryan Harkin [mailto:ryan.har..

Re: [edk2] [PATCH] ShellPkg: Don't strip BOM when piping UCS2 data to a UEFI app

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> This patch worked great! > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 01, 2016 1:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...

Re: [edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

Jim, Given that the email says " Dell - Internal Use - Confidential", I feel odd applying it to the open source. Can you remove that line? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com >

Re: [edk2] [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in Editor.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Thursday, February 25, 2016 10:54 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.co

Re: [edk2] [PATCH v4 0/2] Enhance Shell to support finding help message embeded in resource section.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, February 22, 2016 11:01 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v4 0/2]

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> -Jaben Sent from my iPad. > On Feb 21, 2016, at 6:49 PM, Qiu, Shumin <shumin@intel.com> wrote: > > Do NULL pointer check before the pointer is used to avoid dereferenced. > > Cc: Jaben Carsey <jaben.car...@in

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

That sounds good to me. > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Thursday, February 18, 2016 8:26 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org &

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Thursday, February 18, 2016 7:52 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <s

Re: [edk2] [PATCH v1 1/1] StdLib/BsdSocketLib: Fix minor memory leak.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daryl McDaniel > Sent: Tuesday, February 16, 2016 12:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jab

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, February 15, 2016 6:07 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [PATCH] ShellPkg: ShellFileHandleReadLine must return UCS2 lines

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Wednesday, February 10, 2016 6:16 AM > To: jim_dai...@dell.com > Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

olm > Sent: Tuesday, February 09, 2016 8:54 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin > <shumin@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: Re: [

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

Thanks for the ---author info. The email case is completely arbitrary to me... I honestly don't care (or maybe I should say I don't understand if I should care). -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ryan Hark

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Tuesday, February 09, 2016 10:13 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Qiu, Shumin <shumin@i

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

Disregard my earlier comment. I didn’t realize that was a link to the wiki at first. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, February 09, 2016 11:46 AM >

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, February 09, 2016 9:19 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com>; Ard Biesheuvel <ard

Re: [edk2] [PATCH] ShellPkg/UefiDpLib: Refine the code of locating all handles in DpTrace.c.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, February 08, 2016 9:39 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] Sh

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

as you did the file path from above the root of the revision controlled system. There are additional changes required before this is committed. You need to update the INF files for the library and the shell itself and change the revision minor by +1. -Jaben From: jim_dai...@dell.com [mail

Re: [edk2] [PATCH] Update Shell Library INF file version

Committed and done. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Monday, February 08, 2016 1:53 PM > To: edk2-devel@lists.01.or

Re: [edk2] manually booting efi file

codes to get the first portion of the EFI_DEVICE_PATH_PROTOCOL for your file. You can look in ShellProtocol.c for 2 functions involved: EfiShellGetDevicePathFromFilePath, and EfiShellGetFilePathFromDevicePath (one for each direction of conversion). -Jaben > -Original Message- > From: edk2-devel [ma

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

sten, Jordan L > <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Leif Lindholm > <leif.lindh...@linaro.org>; linaro-u...@lists.linaro.org; Carsey, Jaben > <jaben.car...@intel.com> > Subject: Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM > Platform D

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

> -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Wednesday, February 03, 2016 9:25 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-de...@ml01.01.org; linaro-u...@lists.linaro.org; Leif Lindholm > <leif.lindh...@li

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

Change looks good. Question - Is there a way to optimize the patch/email for this type of change so that we do not see the "diff" for a file that is deleted? It seems redundant to show a whole file of "-" lines... -Jaben > -Original Message- > From: edk2-dev

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

Looks like good info. Should we clarify that SVN is read only also? Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Tuesday, February 02, 2016 9:03 A

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

I like that a lot. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, February 02, 2016 9:35 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.c

Re: [edk2] [PATCH] ShellPkg: Refine the code to avoid use a constant number as offset.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, January 25, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Thursday, January 21, 2016 12:47 AM > To: Laszlo Ersek <ler...@redhat.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org de...@ml01.01.org> > Su

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, January 21, 2016 8:13 AM > To: Carsey, Jaben <jaben.car...@intel.com>; Ryan Harkin > <ryan.har...@linaro.org> > Cc: edk2-devel

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

For series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel

Re: [edk2] [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update whitespace & layout

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel

Re: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

All 3 modified libraries need their version information modified. I think that the minor version of all 3 libraries debug, BCFG, and ShellCommandLib need to be incremented. Otherwise I think this looks good. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-deve

Re: [edk2] Shell BCFG command - adding option data

ize?L'N':L'Y'); -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, January 20, 2016 11:48 AM > To: Ryan Harkin <ryan.har...@linaro.org>; edk2-devel@lists.01.org de...@ml01.01.org>

Re: [edk2] [PATCH] [ShellPkg] fix operator

I will wait. -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 20, 2016 1:21 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-de...@ml01.01.org > Cc: ryan.har...@linaro.org > Subject: Re: [PATCH]

[edk2] [PATCH] [ShellPkg] fix operator

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: jaben carsey <jaben.car...@intel.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellBcfgComm

Re: [edk2] Shell BCFG command - adding option data

ER_OPT (x) (BCFG_VAR_BUFFER_DPATH(x)+BCFG_VAR_BUFFER_LEN(x)) -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 20, 2016 1:26 PM > To: Ryan Harkin <ryan.har...@linaro.org>; Carsey, Jaben > <jaben.car...@intel.com&

Re: [edk2] [PATCH] [ShellPkg] fix operator

Note that when you specify your 1 2 3 it’s interpreted as a keystroke code. If you want a string you should use “1 2 3”… From: Ryan Harkin [mailto:ryan.har...@linaro.org] Sent: Wednesday, January 20, 2016 2:18 PM To: Carsey, Jaben <jaben.car...@intel.com> Cc: edk2-devel@lists.01.org &l

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

to be in ShellPkg so that may have been the reason... -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Burigo, Arthur Crippa > Sent: Tuesday, January 19, 2016 10:11 AM > To: Long, Qin <qin.l...@intel.com>; Laszlo Ersek <ler..

Re: [edk2] [PATCH 2/2] ShellPkg UefiDpLib: Use Image->FilePath to get name for SMM drivers

for the series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Sunday, January 17, 2016 10:02 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming....@intel.com>; Carsey, Jaben > <jaben.car..

Re: [edk2] [PATCH] ShellPkg: Update 'dh' command to reflect correct driver handle information

Thanks for the Contributed-under line update. Done 19648. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, January 15, 2016 9:04 AM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com> > Cc: samer.el-haj-mah

<    4   5   6   7   8   9   10   >