Re: [edk2] [Patch v2] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-02-11 Thread Laszlo Ersek
On 01/25/19 22:30, Stefan Berger wrote: > This patch adds the TCG2 Configuration menu to the Device Manager > menu. We can apparently reuse the sample Tcg2ConfigDxe from > SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The > added TCG2 Configuration menu now shows details about the

Re: [edk2] [PATCH v2 05/10] OvmfPkg/README: Remove UNIXGCC

2019-02-11 Thread Laszlo Ersek
On 02/11/19 03:48, Shenglei Zhang wrote: > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek >

Re: [edk2] [PATCH v4 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox()

2019-02-11 Thread Laszlo Ersek
ment of UpdateLockBox() with > its counterparts in MdeModulePkg. > > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 11 --- > 1 file changed, 8 insertions(+), 3 d

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-08 Thread Laszlo Ersek
On 02/08/19 18:33, Rebecca Cran wrote: > > On February 8, 2019 at 2:01:59 AM, Laszlo Ersek > (ler...@redhat.com(mailto:ler...@redhat.com)) wrote: > >> I don't see the workflow modification as viable. The "patch series" >> concept is integral to every single

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-08 Thread Laszlo Ersek
On 02/08/19 07:41, Rebecca Cran wrote: > On Thursday, 7 February 2019 11:30:38 MST stephano wrote: > >> My apologies if I was not clear in the minutes. We are not rejecting >> Github, but rather taking time to evaluate how we can supplement >> Github's features to emulate our current patch

Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-08 Thread Laszlo Ersek
On 02/07/19 18:48, Philippe Mathieu-Daudé wrote: > Hi Antoine, > > On 2/7/19 6:13 PM, Antoine Coeur wrote: >> Thank you Laszlo. >> >> Do you have any recommendations regarding the maximum size of a patch for >> smooth reviewing on this mailing list? >> I have about 9000 lines of additional typos

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-07 Thread Laszlo Ersek
On 02/07/19 15:59, Philippe Mathieu-Daudé wrote: > On 2/7/19 2:04 PM, Ryszard Knop wrote: >> Hi Philippe, Antoine, >> >> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >>> Hi Antoine, >>> >>> On 2/6/19 6:24 PM, Antoine Coeur wrote: Fix various typos in CryptoPkg.

Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-07 Thread Laszlo Ersek
On 02/06/19 16:48, Antoine Coeur wrote: > Fix various typos in ArmVirtPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c

Re: [edk2] FW: [PATCH] BaseTools/BuildReport: fix report for platforms/arches without struct PCDs

2019-02-07 Thread Laszlo Ersek
On 02/07/19 00:08, Carsey, Jaben wrote: > I sent this earlier, but failed the mailing list part. > > Reviewed-by: Jaben Carsey > And pushed. Thanks! This is commit 963517211cae1ad38984821061ad7982c448f934 now. Laszlo ___ edk2-devel mailing list

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Laszlo Ersek
On 02/06/19 18:44, Rebecca Cran wrote: > On Wednesday, 6 February 2019 09:36:43 MST Laszlo Ersek wrote: > >> please refer to the HTTP_BOOT_ENABLE define in the OVMF DSC files; the >> default value is FALSE. >> >> If you'd like HTTP over IPv6, then ple

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Laszlo Ersek
Hello Rebecca, On 02/06/19 07:06, Rebecca Cran via edk2-devel wrote: > I'm trying to fetch a file over HTTP in a boot loader, but gBS- >> LocateHandleBuffer doesn't find either of the >> EFI_TCP4_SERVICE_BINDING_PROTCOL > or EFI_HTTP_SERVICE_BINDING_PROTOCOL. > > I'm running a build of OVMF

Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-06 Thread Laszlo Ersek
+779,11 @@ PlatformBootManagerBeforeConsole ( >Do the platform specific action after the console is ready >Possible things that can be done in PlatformBootManagerAfterConsole: >> Console post action: > -> Dynamically switch output mode from 100x31 to 80x25 for cer

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Laszlo Ersek
t; previous two. > > Reported-by: Leif Lindholm > Fixes: f8d11e5a4aaa90bf63b4789f3993dd6d16c60787 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Philippe Mathieu-Daude > Tested-by: Leif Lindholm > Acked-by: Laszlo Ersek > --- > v2: > - fix

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Laszlo Ersek
On 02/05/19 22:20, Carsey, Jaben wrote: > Laszlo, > > not sure which Andrew you wanted, but he didn’t get added so far as I can > tell. He did, it's just the mailman2 list software pulling tricks on us again. The default setting for list subscribers is to eliminate duplicates. That is, if you

Re: [edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-06 Thread Laszlo Ersek
On 02/06/19 16:46, Ard Biesheuvel wrote: > On Wed, 6 Feb 2019 at 12:11, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: armvirt_pcd_clean >> >> (1) The procedure described below depends on: >> >> [edk2] [PA

[edk2] [PATCH 10/14] ArmVirtPkg/ArmVirtXen: don't set PcdPL031RtcBase

2019-02-06 Thread Laszlo Ersek
ds for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtXen.

[edk2] [PATCH 14/14] ArmVirtPkg/ArmVirtXen: don't set Pcd*ImageVerificationPolicy

2019-02-06 Thread Laszlo Ersek
-D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirt.dsc.inc | 7 --- ArmVirtPkg/ArmVirtQemu.dsc | 7 +++ ArmVirt

[edk2] [PATCH 09/14] ArmVirtPkg: don't set PcdDebugPrintErrorLevel in RELEASE builds

2019-02-06 Thread Laszlo Ersek
) != RELEASE). ("feat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Er

[edk2] [PATCH 02/14] ArmVirtPkg: don't set PcdRelocateVectorTable

2019-02-06 Thread Laszlo Ersek
eat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- Ar

[edk2] [PATCH 12/14] ArmVirtPkg/ArmVirtXen: don't set PcdShellFile

2019-02-06 Thread Laszlo Ersek
ds for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtX

[edk2] [PATCH 08/14] ArmVirtPkg: don't set PcdDebugClearMemoryValue

2019-02-06 Thread Laszlo Ersek
OT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirt.dsc.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/ArmVirtPkg/

[edk2] [PATCH 11/14] ArmVirtPkg/ArmVirtXen: don't set PcdTerminalTypeGuidBuffer

2019-02-06 Thread Laszlo Ersek
er: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirt.dsc.inc | 6 -- ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 3 +++ ArmVirtPkg/ArmVirtXen.dsc| 3 --- 4 files changed, 6 insertions(+), 9 deletions(-) d

[edk2] [PATCH 13/14] ArmVirtPkg/ArmVirtXen: don't set PcdTurnOffUsbLegacySupport

2019-02-06 Thread Laszlo Ersek
and ArmVirtQemuKernel platforms. ("feat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Sign

[edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-06 Thread Laszlo Ersek
decide that we want to do something else (e.g. file a BZ, and fill the gap later). For such cases I wanted to be able to drop individual patches at will. Cc: Ard Biesheuvel Cc: Julien Grall Thanks, Laszlo Laszlo Ersek (14): ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBas

[edk2] [PATCH 04/14] ArmVirtPkg: don't set PcdPostCodePropertyMask

2019-02-06 Thread Laszlo Ersek
eat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 03/14] ArmVirtPkg/{ArmVirtQemu, ArmVirtQemuKernel}: don't set PcdTrustzoneSupport

2019-02-06 Thread Laszlo Ersek
eat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek -

[edk2] [PATCH 01/14] ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBase

2019-02-06 Thread Laszlo Ersek
ot; stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVir

[edk2] [PATCH 06/14] ArmVirtPkg/PrePi: drop wrong PcdCoreCount dependency

2019-02-06 Thread Laszlo Ersek
The PcdCoreCount dependency in the "ArmVirtPrePiUniCoreRelocatable.inf" file is false; the module doesn't consume the PCD. Clean up the INF. Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVir

[edk2] [PATCH 07/14] ArmVirtPkg: don't set PcdCoreCount

2019-02-06 Thread Laszlo Ersek
eat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek -

[edk2] [PATCH 05/14] ArmVirtPkg: clean up PcdSetNxForStack setting (applies to ArmVirtQemu only)

2019-02-06 Thread Laszlo Ersek
ot;feat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".) Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Arm

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-05 Thread Laszlo Ersek
On 02/05/19 13:02, Philippe Mathieu-Daudé wrote: > On 2/5/19 10:03 AM, Laszlo Ersek wrote: >> On 02/05/19 02:23, Philippe Mathieu-Daudé wrote: >>> Since 9c2d68c0a299 the build tools default to the python version >>> provided by the ${PYTHON} environment variable. >>

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-05 Thread Laszlo Ersek
(+Mike, +Andrew) On 02/05/19 12:47, Leif Lindholm wrote: > On Tue, Feb 05, 2019 at 10:03:21AM +0100, Laszlo Ersek wrote: >> On 02/05/19 02:23, Philippe Mathieu-Daudé wrote: >>> Since 9c2d68c0a299 the build tools default to the python version >>> provided by the ${P

Re: [edk2] BaseTools: handling of $(ARCH) in .dsc/.fdf when multiple -a specified

2019-02-05 Thread Laszlo Ersek
On 02/05/19 12:08, Leif Lindholm wrote: > On Mon, Feb 04, 2019 at 08:02:55PM +0100, Laszlo Ersek wrote: >> AIUI, "-a IA32 -a X64" it means "build the Components.* sections >> (plural) as dictated by the '-a' flags, and then organize the full >> (multi-arch) se

[edk2] [PATCH] BaseTools/BuildReport: fix report for platforms/arches without struct PCDs

2019-02-05 Thread Laszlo Ersek
et() method. Reported-by: Vladimir Olovyannikov Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1513 Fixes: 97c8f5b9e7d3136b6051a05cf056ce5ca9e79893 Cc: Bob Feng Cc: Liming Gao Cc: Vladimir Olovyannikov Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-05 Thread Laszlo Ersek
generate the SourcePcdDict and BinaryPcdDict > PGen = PlatformAutoGen(self, self.MetaFile, Target, Toolchain, > Arch) > -for BuildData in PGen.BuildDatabase._CACHE_.values(): > + for BuildData in list(PGen.BuildDatabase._CACHE_.values()): > if Bui

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-04 Thread Laszlo Ersek
On 02/03/19 06:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > On some Linux environment, there may be no distutils.util > library for python3 that will cause build tool crash. > This patch implement distutils.util.split_quoted > in BaseTools so that the

Re: [edk2] BaseTools: handling of $(ARCH) in .dsc/.fdf when multiple -a specified

2019-02-04 Thread Laszlo Ersek
On 02/04/19 19:31, Leif Lindholm wrote: > Hi Bob, Liming, > > So, I've been playing around with merging the .dsc/.fdf files in > OvmfPkg. Merging IA32 and X64 is simple enough, since you can test on > > !if $(ARCH) == "X64" > > However, from what I can tell, when trying to merge in the >

Re: [edk2] BlockIo2 Protocol test tool

2019-02-04 Thread Laszlo Ersek
lid to report it asynchronously too. > In short, i am bit confused what should be the "Transaction Status" that > should be signaled by the driver. Please comment. Hopefully the above helps. Thanks, Laszlo > On Mon, Jan 28, 2019 at 2:17 PM Laszlo Ersek wrote: > >>

Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 10:50, Philippe Mathieu-Daudé wrote: > Hi, > > On 2/1/19 6:34 AM, Shenglei Zhang wrote: >> Remove content related to UNIXGCC in README. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1377 >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >&

Re: [edk2] [PATCH 12/14] OvmfPkg/MptScsiDxe: Implement the PassThru method

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > Machines should be able to boot after this commit. Tested with different Linux > distributions (Ubuntu, CentOS) and different Windows versions (Windows 7, > Windows 10, Server 2016). > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 11/14] OvmfPkg/MptScsiDxe: Initialize hardware

2019-02-01 Thread Laszlo Ersek
Hi Nikita, I've jumped ahead a little bit to point out other style issues, so you can address them at once in v2. These are again general comments, likely applying to several patches in the series. On 01/31/19 11:07, Nikita Leshenko wrote: > +typedef struct { > + UINT8 WhoInit; > + UINT8

Re: [edk2] [PATCH 04/14] OvmfPkg/MptScsiDxe: Probe PCI devices and look for MptScsi

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > The MptScsiControllerSupported function is called for every handle > that appears on the system This statement is incorrect. The Supported() function is generally called on such handles that the ConnectController() boot service tries to connect. More

Re: [edk2] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > This series adds driver support for: > - LSI53C1030 > - SAS1068 > - SAS1068E > > These controllers are widely supported by QEMU, VirtualBox and VMWare. This > work > is part of the more general agenda of enhancing OVMF boot device support to > have >

Re: [edk2] [PATCH 03/14] OvmfPkg/MptScsiDxe: Report name of driver

2019-02-01 Thread Laszlo Ersek
+ (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) , > + "en" // SupportedLanguages, RFC 4646 language codes > +}; > + > // > // Entry Point > // > @@ -87,7 +144,7 @@ MptScsiEntryPoint ( > SystemTable, > , > ImageHandle, // The handle to install on

Re: [edk2] [PATCH 02/14] OvmfPkg/MptScsiDxe: Install DriverBinding Protocol

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > In order to probe and connect to the MptScsi device we need this > protocol. Currently it does nothing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by:

Re: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver

2019-02-01 Thread Laszlo Ersek
On 02/01/19 03:16, Bi, Dandan wrote: > Hi Nikita, > > I have one comment here, could you help to verify this patch series with VS > tool chain build before commit the patches? (1) Nikita, when you post the v2 series, please push it to a public repo/branch of yours as wel. So that developers

Re: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > In preparation for implementing LSI Fusion MPT SCSI devices, create a > basic scaffolding for a driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by:

Re: [edk2] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > This series adds driver support for: > - LSI53C1030 > - SAS1068 > - SAS1068E > > These controllers are widely supported by QEMU, VirtualBox and VMWare. This > work > is part of the more general agenda of enhancing OVMF boot device support to > have >

Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-01 Thread Laszlo Ersek
x->Length) { > +ZeroMem ( > + (VOID *)((UINTN)LockBox->SmramBuffer + (UINTN)LockBox->Length), > + Offset - (UINTN)LockBox->Length > + ); > + } > + LockBox->Length = Offset + Length; > +} else { > + // >

Re: [edk2] [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-01 Thread Laszlo Ersek
mmit bd3afeb1d62c ("MdeModulePkg: SmmLockBoxPeiLib: work without EFI_PEI_SMM_COMMUNICATION_PPI", 2015-11-16). In that regard, I'm OK with this patch; this alone would suffice for me to give an Acked-by. However, having re-reviewed bd3afeb1d62c now, I see that this patch is actually

Re: [edk2] [PATCH v3 09/12] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-01 Thread Laszlo Ersek
Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 26 +++ > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.c | 78 > ++-- > 3 files changed, 63 insertions(+), 63 deletions(-) Reviewed-by: Laszlo Ersek ___ edk2-devel mailing lis

Re: [edk2] [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC

2019-02-01 Thread Laszlo Ersek
GGCCxASL_EBC_*_FAMILY = INTEL > - > -*_CYGGCCxASL_EBC_PP_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_CC_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_DLINK_PATH= DEF(EBC_BIN)\link.exe > -*_CYGGCCxASL_EBC_SLINK_PATH= DEF(EBC_BIN)\link.exe > -*_CYGGCCxASL_EBC_VFRPP_PATH= DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_RC_PATH = DEF(MS_VS_BIN)\rc.exe > - > -*_CYGGCCxASL_EBC_CC_FLAGS = /nologo /c /WX /W3 /FIAutoGen.h > /D$(MODULE_ENTRY_POINT)=$(ARCH_ENTRY_POINT) > -*_CYGGCCxASL_EBC_SLINK_FLAGS= /lib /NOLOGO /MACHINE:EBC > -*_CYGGCCxASL_EBC_DLINK_FLAGS= "C:\Program > Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF > /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 > /DRIVER > > > > # > Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC

2019-02-01 Thread Laszlo Ersek
> $(DEST_DIR_DEBUG)/$(BASE_NAME).map > -*_ELFGCC_X64_SLINK_FLAGS = > -*_ELFGCC_X64_ASM_FLAGS = -c -x assembler -imacros > $(DEST_DIR_DEBUG)/AutoGen.h > -*_ELFGCC_X64_PP_FLAGS = -E -x assembler-with-cpp -include > $(DEST_DIR_

Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-un

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-02-01 Thread Laszlo Ersek
On 02/01/19 04:13, Feng, Bob C wrote: > I have pushed py3 patch set to edk2 master. Thanks! I've noted the commit range on the BZ (cc01b26e053c..8189be6fd7d7) and closed the BZ (#55). Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
TH= DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc > -*_UNIXGCC_X64_RC_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)objcopy > -*_UNIXGCC_X64_OBJCOPY_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)objcopy > - > -*_UNIXGCC_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS) > -*_UNIXGCC_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS) > -*_UNIXGCC_X64_OBJCOPY_FLAGS = > -*_UNIXGCC_X64_NASM_FLAGS= -f win64 > - > > > # > # GCC 4.8 - This configuration is used to compile under Linux to produce > Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc:

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-02-01 Thread Laszlo Ersek
On 01/31/19 22:01, Andrew Fish wrote: > > >> On Jan 31, 2019, at 11:57 AM, Leif Lindholm wrote: >> >> +Andrew, Laszlo, Mike. >> >> On Thu, Jan 31, 2019 at 06:19:48PM +0100, Ard Biesheuvel wrote: >>> On Thu, 31 Jan 2019 at 16:24, Leif Lindholm >>> wrote: On Tue, Jan 29, 2019 at

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if reloc info is invalid

2019-01-30 Thread Laszlo Ersek
sueh > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > Cc: Laszlo Ersek > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/MdePkg/Library/BasePeCoffLi

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if reloc info is invalid

2019-01-30 Thread Laszlo Ersek
sueh > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > Cc: Laszlo Ersek > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/MdePkg/Library/BasePeCoffLi

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Laszlo Ersek
On 01/29/19 11:54, Tomas Pilar (tpilar) wrote: >> Why TFTP client just pull one packet per second? I think it’s not >> correct and it could use the poll() function to accelerate the >> receive. Why you trying to solve a TFTP layer problem in SNP layer? >> It breaks the design principle of network

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Laszlo Ersek
On 01/29/19 14:13, Ni, Ray wrote: > > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, January 29, 2019 7:12 PM >> To: Ni, Ray ; edk2-devel@lists.01.org >> Cc: Zim

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-29 Thread Laszlo Ersek
ed for testing is Huawei D06 (AArch64), and its CPU chip is >> 1620 (self-developed chip that follows the arm v8.2 specification). >> Its vmid >> is 16 bit. >> >> Thanks. >> Xiaojun. >> >> On 2019/1/28 21:46, Mark Rutland wrote: >>> On Mon, Jan

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Laszlo Ersek
cessfully built OvmfPkg for IA32, IA32X64, and X64. (I don't have a cross-compiler installed in this environment yet, nor a RHEL8 aarch64 KVM guest, so I couldn't test ArmVirtQemu for now). (b2) I set PYTHON_COMMAND to "/usr/libexec/platform-python". Didn't set PYTHON3_ENABLE. The same

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Laszlo Ersek
Hi Ray, On 01/29/19 06:59, Ni, Ray wrote: > Hello, > I'd like to propose to split today's BIG packages in following ways: > > ==Overview = > > 1. Separate Industry standard definitions from UEFI and PI interfaces. > 2. Separate UEFI and PI interfaces from

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
ssage-Format > > > Thanks, > Dandan > >> -Original Message- >> From: Hsueh, Hong-chihX >> Sent: Tuesday, January 29, 2019 2:41 AM >> To: edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Gao, Liming >> ; Bi, Dandan ; Laszlo Ersek >&g

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
-off-by: Neo Hsueh > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > Cc: Laszlo Ersek > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCo

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
On 01/29/19 00:40, Hsueh, Hong-chihX wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, January 28, 2019 2:17 PM >> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Gao, Liming >>

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-28 Thread Laszlo Ersek
ned-off-by: Neo Hsueh > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > Cc: Laszlo Ersek > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c > b/Mde

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Laszlo Ersek
On 01/28/19 14:09, Tan Xiaojun wrote: > On 2019/1/28 19:54, Laszlo Ersek wrote: >> On 01/28/19 11:46, Mark Rutland wrote: >>> On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote: >>>> On 01/23/19 10:26, Ard Biesheuvel wrote: >>>>> On W

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-28 Thread Laszlo Ersek
posting status, that is, commit 41c0616fc081. Thanks Laszlo > -Original Message- > From: Feng, Bob C > Sent: Monday, January 28, 2019 10:33 AM > To: 'Laszlo Ersek' > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: RE: [edk2] [Patch 00/33] BaseTools python3 migration patc

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Laszlo Ersek
On 01/28/19 11:46, Mark Rutland wrote: > On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote: >> On 01/23/19 10:26, Ard Biesheuvel wrote: >>> On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: >>>> On 01/22/19 16:37, Ard Biesheuvel wrote: >> >>&

Re: [edk2] BlockIo2 Protocol test tool

2019-01-28 Thread Laszlo Ersek
Hi, On 01/26/19 17:57, Sajeesh Kk wrote: > Hello Rafeal, > > I believe The UEFI Sct test suite cannot be used for performance testing. > Are there any tools which can be used from UEFI shell to measure disk IO > perfomance using BlockIO2 Protocol ? > Please let me know. from a cursory look,

Re: [edk2] [Patch v2] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-28 Thread Laszlo Ersek
fdf > index afaa334384..d0cc107928 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -388,6 +388,9 @@ INF > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > > !if $(TPM2_ENABLE) == TRUE > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +!if $(TPM2_CONFIG_ENA

Re: [edk2] Drop CSM support in OvmfPkg?

2019-01-28 Thread Laszlo Ersek
On 01/25/19 21:28, Brian J. Johnson wrote: > On 1/24/19 5:30 AM, Laszlo Ersek wrote: >> On 01/24/19 10:31, David Woodhouse wrote: >>> On Thu, 2019-01-24 at 01:48 +, Ni, Ray wrote: >>>> David, >>>> I think we got an agreement here to move CSM compo

Re: [edk2] [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Laszlo Ersek
Hi, (1) when posting a patch, please CC all people marked with "M" for the subject package in Maintainers.txt. And, if in doubt, please CC the "R" people too. Adding the others now. (2) In [a] [b], you mentioned a need to repost, due to your email address having changed. However, that posting,

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-25 Thread Laszlo Ersek
On 01/25/19 10:42, Feng, Bob C wrote: > [...] > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 25, 2019 4:57 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch 00/33] BaseTools

Re: [edk2] [Patch] BaseTools: Enable CODE format in DEC file

2019-01-25 Thread Laszlo Ersek
Hi Bob, On 01/25/19 09:58, Feng, Bob C wrote: > Enable CODE format in DEC File. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > .../Source/Python/Workspace/DscBuildData.py | 38 +++ >

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-25 Thread Laszlo Ersek
On 01/25/19 00:18, Neo Hsueh wrote: > 1.Skip runtime relocation for PE images that provide invalid relocation > infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting > Windows. > 2.Add a magic number check for PE32+ image. > > Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-25 Thread Laszlo Ersek
Hi Bob, On 01/25/19 05:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > This patch set is to enable python3 on BaseTools. Basetools code will be > compatible with both python3 and python2. > > We will have two envs PYTHON3_ENABLE and PYTHON_COMMAND. The

Re: [edk2] Text attachments

2019-01-24 Thread Laszlo Ersek
On 01/24/19 12:38, Tomas Pilar (tpilar) wrote: > Hi, > > Does the mailing list support plaintext attachments? No, it doesn't forward any attachments. People that you CC directly will get the attachment, but the list will not reflect any attachments to subscribers, nor will the list archive carry

Re: [edk2] Network Stack Budgeting

2019-01-24 Thread Laszlo Ersek
On 01/24/19 14:25, Tomas Pilar (tpilar) wrote: > Hmm, > > Mnp->Configure() will eventually call MnpStartSnp(). > > A grep for Mnp->Configure shows that: > * ArpDxe performs this on DriverBinding.Start() > * Ip6Dxe performs this on DriverBinding.Start() > > Ipv4 and DnsDhcp do this as a part of

Re: [edk2] UEFI Shell + startup.nsh

2019-01-24 Thread Laszlo Ersek
On 01/24/19 13:22, Rafael Machado wrote: > Hi everyone. > > I have a question. > Considering I have a PXE server that my client downloads a shell.efi app. > Considering also that I need to execute a .nsh script, but I their is no > media at the system. (no usb or storage device attached) > >

Re: [edk2] Network Stack Budgeting

2019-01-24 Thread Laszlo Ersek
On 01/24/19 12:37, Tomas Pilar (tpilar) wrote: > > Hi Laszlo, > >> Can you capture a call stack when Snp.Start() is invoked for the very >> first time (which, IIUC, is a call that should not happen, in your >> opinion)? >> > Unfortunately I do not have access to the platform firmware itself (I

Re: [edk2] parallelism in the module-level, generated GNUmakefile's

2019-01-24 Thread Laszlo Ersek
On 01/24/19 10:57, Gao, Liming wrote: > Yes. BaseTools should make sure the complete dependency in the generated > Makefile. If you find any missing, please submit BZs. Awesome. That's a huge help. Thank you Liming! Laszlo ___ edk2-devel mailing list

Re: [edk2] Drop CSM support in OvmfPkg?

2019-01-24 Thread Laszlo Ersek
On 01/24/19 10:31, David Woodhouse wrote: > On Thu, 2019-01-24 at 01:48 +, Ni, Ray wrote: >> David, >> I think we got an agreement here to move CSM components in OvmfPkg. >> I prefer we firstly clone the required CSM components in OvmfPkg right no. >> Finally I can remove the

Re: [edk2] A VM failed to boot when I changed the gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size

2019-01-24 Thread Laszlo Ersek
On 01/24/19 10:25, Wuzongyong (Euler Dept) wrote: (1) Either way, if you'd like to check whether this issue is specific to the iPXE option ROM, you could prevent QEMU from loading the ROM image into the NIC's ROM BAR, and retest. The QEMU option for that is -device

Re: [edk2] A VM failed to boot when I changed the gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size

2019-01-24 Thread Laszlo Ersek
On 01/24/19 03:35, Wuzongyong (Euler Dept) wrote: >> (1) Either way, if you'd like to check whether this issue is specific >> to the iPXE option ROM, you could prevent QEMU from loading the ROM >> image into the NIC's ROM BAR, and retest. The QEMU option for that is >> >> -device

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-23 Thread Laszlo Ersek
On 01/23/19 15:02, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 10:55, Laszlo Ersek wrote: >> >> On 01/23/19 10:26, Ard Biesheuvel wrote: >>> On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: >>>> On 01/22/19 16:37, Ard Biesheuvel wrote: >> >

Re: [edk2] Network Stack Budgeting

2019-01-23 Thread Laszlo Ersek
On 01/23/19 17:27, Tomas Pilar (tpilar) wrote: > >> The set of devices connected during BDS is platform policy. It is not >> the "network stack" that calls Snp.Start(), but the platform BDS code >> that calls gBS->ConnectController() on the device, possibly without a >> good reason (e.g. without

Re: [edk2] parallelism in the module-level, generated GNUmakefile's

2019-01-23 Thread Laszlo Ersek
On 01/23/19 17:36, Gao, Liming wrote: > Laszlo: By design, BaseTools generates GNUMakefile with the complete > dependency. So, the generated GNUMakefile should support parallelism > run. But, I don't verify this functionality. Have you found any > limitation to forbid parallelism run in module

Re: [edk2] Network Stack Budgeting

2019-01-23 Thread Laszlo Ersek
Hi, On 01/23/19 11:55, Tomas Pilar (tpilar) wrote: > Hi, > > Recently I have done some performance improvements to my network > driver. I am however finding that on some platforms, it's becoming > impossible to boot if the network cable has a lot of traffic on it > that is not filtered by the

Re: [edk2] A VM failed to boot when I changed the gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size

2019-01-23 Thread Laszlo Ersek
Hi, (adding Alex, Gerd, Dave) On 01/23/19 12:40, Wuzongyong (Euler Dept) wrote: > > Hi, > > Recently I do a test with edk2 on rhel platform. Cool :) I don't frequently see RHEL-related reports on this list. > I resized the gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size value to 1TB for >

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-23 Thread Laszlo Ersek
On 01/23/19 10:26, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: >> On 01/22/19 16:37, Ard Biesheuvel wrote: >>> Is SetUefiImageMemoryAttributes() being >>> called to remap the memory R-X ? >> >> No, it is not; the grub binar

Re: [edk2] Drop CSM support in OvmfPkg?

2019-01-23 Thread Laszlo Ersek
Hi All, On 01/23/19 04:43, Ni, Ray wrote: >> -Original Message- >> From: David Woodhouse >> Sent: Wednesday, January 23, 2019 12:23 AM >> To: Ni, Ray ; Gerd Hoffmann ; >> Laszlo Ersek ; Richardson, Brian >> >> Cc: Justen, Jordan L ; edk2-devel

Re: [edk2] EDK II Network Stack Issue

2019-01-22 Thread Laszlo Ersek
Willers wrote: > On 2019-01-16 17:51, Laszlo Ersek wrote: > >>> >>> Could please someone shed some light on how to enable debug prints >>> using UefiDebugLibConOut in EfiSocketLib/Socket.c. Enabling debug >>> prints is, IMHO, not very intuitive in

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-22 Thread Laszlo Ersek
On 01/22/19 16:09, Laszlo Ersek wrote: > (I plan to undo commit cf580da1bc4c ("ArmPkg/ArmLib: don't invalidate > entire I-cache on range operation", 2016-05-12) and commit b7de7e3cab3f > ("ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU", > 2015

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-22 Thread Laszlo Ersek
Performing thread-necromancy on a patch from 2015, which is today known as commit b7de7e3cab3f. Also CC'ing Christoffer and Marc. Question at the bottom. On 12/07/15 08:06, Ard Biesheuvel wrote: > From: "Cohen, Eugene" > > This patch updates the ArmPkg variant of InvalidateInstructionCacheRange

[edk2] parallelism in the module-level, generated GNUmakefile's

2019-01-22 Thread Laszlo Ersek
Hi Liming, I'd like to ask a question about parallel ("multi threaded") make. The use case is the following: (1) The edk2 "build" BaseTools utility itself is invoked from a *higher-level* Makefile that is outside of the edk2 project. (2) The outer make process is invoked with "make -jN". (3)

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-21 Thread Laszlo Ersek
Hi Phil, On 01/21/19 14:26, Philippe Mathieu-Daudé wrote: > Hi, > > On 1/21/19 1:53 PM, Gao, Liming wrote: >> Thanks Ard and Laszlo. For the minor change in single patch, the patch may >> be sent separately with the clear subject. Or, the patch set can be sent >> again. > > Since it is hard

<    1   2   3   4   5   6   7   8   9   10   >