On 4/2/19 5:16 PM, Eric Jin wrote:
> Remove the macros which are already defined in
> MdePkg/Include/Uefi/UefiInternalFormRepersentation.h
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
> ---
>
Hi Bret,
On 4/2/19 7:50 AM, Zhichao Gao wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677
>
> For some pointer and UINT64 data, the debug code print with '%x'.
> Which would loss the upper 32bit data. So update '%x' to '%lx'
> for these data.
Some are
On 2/28/19 2:29 PM, Feng, Bob C wrote:
> Hi Phil,
>
> Your suggested code is good but it still print the call stack. I changed it a
> little, it only print the error message now.
>
> Thanks,
> Bob
>
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, February 28, 2019 9:19 PM
On 2/28/19 3:04 AM, Feng, Bob C wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1509
> V2:
> Remove OS/Package specific words. Print the error info which
> is from python error message.
>
> Add python3-distutils Ubuntu package checking.
>
> Contributed-under: TianoCore Contribution
On 2/27/19 10:21 PM, Laszlo Ersek wrote:
> The current language for "Package Reviewer" only vaguely hints that
> Package Reviewers should be able to provide guidance and directions.
> Make this more obvious.
>
> Cc: Andrew Fish
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Liming Gao
> Cc:
xt
> index 7772926b2f..3c17038fab 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,6 +82,7 @@ M: Laszlo Ersek
> M: Ard Biesheuvel
> R: Julien Grall
> (Xen modules)
> +R: Philippe Mathieu-Daudé
>
> BaseTools
> W: https://github.com/tianocore/tian
Hi Hao A,
On 2/20/19 2:11 AM, Wu, Hao A wrote:
> Thanks Mateusz,
>
> Reviewed-by: Hao Wu
> And pushed via commit 68c67d3a2a33261e41ff0123129b4e9759617f71.
I think you mean "pushed 'after' commit
68c67d3a2a33261e41ff0123129b4e9759617f71".
Commit 68c67d3a2a33261e41ff0123129b4e9759617f71 is:
Hi Laszlo,
On 2/13/19 9:37 AM, Laszlo Ersek wrote:
> Hi,
>
> using QEMU, when I specify a nonzero LUN for the hard disk that sits on
> the "SCSI bus" that embodies the USB Bulk Only Transfer device, then
> UsbMassStorageDxe fails to recognize the hard disk.
>
> (1) Consider the following QEMU
On 2/12/19 3:02 PM, Laszlo Ersek wrote:
> On 02/12/19 14:33, Gao, Liming wrote:
>> Laszlo:
>> To install python3-distutils should resolve this issue. I expect BaseTools
>> build functionality doesn't depend on the third party python lib.
>
> I completely agree with your expectation, regarding
Hi Antoine,
On 2/7/19 6:13 PM, Antoine Coeur wrote:
> Thank you Laszlo.
>
> Do you have any recommendations regarding the maximum size of a patch for
> smooth reviewing on this mailing list?
> I have about 9000 lines of additional typos corrections in queue at
>
On 2/7/19 2:04 PM, Ryszard Knop wrote:
> Hi Philippe, Antoine,
>
> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote:
>> Hi Antoine,
>>
>> On 2/6/19 6:24 PM, Antoine Coeur wrote:
>>> Fix various typos in CryptoPkg.
>>>
>>> C
ut forgot the sendemail.from, and now I see my
lastname got mojibaked :S
No worry, my bad.
Regards,
Phil.
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, February 06, 2019 8:26 AM
>> To: Philippe Mathieu-Daudé ; Kinney, Micha
On 2/6/19 4:46 PM, Antoine Coeur wrote:
> Fix various typos in ArmPlatformPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
> ---
> ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++--
> ArmPlatformPkg/Include/Library/ArmPlatformLib.h| 2 +-
>
On 2/6/19 4:48 PM, Antoine Coeur wrote:
> Fix various typos in ArmVirtPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
Reviewed-by: Philippe Mathieu-Daude
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
>
Hi Antoine,
On 2/6/19 6:24 PM, Antoine Coeur wrote:
> Fix various typos in CryptoPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
> ---
> CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
> CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4
On 2/6/19 4:51 PM, Antoine Coeur wrote:
> Fix various typos in BeagleBoardPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
Reviewed-by: Philippe Mathieu-Daude
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
>
Hi Antoine,
On 2/6/19 4:37 PM, Antoine Coeur wrote:
> Fix various typos in AppPkg.
Thanks for updating the title and description.
The content looks the same than v1, so you could have kept my R-b tag.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
On 2/6/19 1:03 PM, Philippe Mathieu-Daudé wrote:
[...]
>
> Reported-by: Leif Lindholm
> Fixes: f8d11e5a4aaa90bf63b4789f3993dd6d16c60787
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Philippe Mathieu-Daude
> Tested-by: Leif Lindholm
> A
agraph about bisection not working is not relevant to
the fix, keep it as background info but move it after (Laszlo)
Signed-off-by: Philippe Mathieu-Daudé
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Aut
Hi Antoine,
I'd rename the patch subject as "AppPkg: Fix various typos"
On 2/6/19 7:10 AM, Antoine Coeur wrote:
> Various typo in AppPkg, ignoring Python folder.
Ditto.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
Reviewed-by: Philippe Mathieu-Daude
>
Hi Pete,
On 2/4/19 1:47 PM, Pete Batard wrote:
> This is designed to be used on platforms where a a real RTC is not
> available and relies on an RtcEpochSeconds variable having been set or,
> if that is not the case, falls back to using the epoch embedded at
> compilation time.
>
> Note that, in
On 2/5/19 10:03 AM, Laszlo Ersek wrote:
> On 02/05/19 02:23, Philippe Mathieu-Daudé wrote:
>> Since 9c2d68c0a299 the build tools default to the python version
>> provided by the ${PYTHON} environment variable.
>> However the Python3 transition is not effective before d943b0c3
Since 9c2d68c0a299 the build tools default to the python version
provided by the ${PYTHON} environment variable.
However the Python3 transition is not effective before d943b0c339fe.
With Python3, the dict.value() method returns an iterator.
If a dictionary is updated while an iterator on his keys
On 2/4/19 12:54 PM, Philippe Mathieu-Daudé wrote:
> On 2/4/19 10:58 AM, Leif Lindholm wrote:
>> Hi Bob, Liming,
>>
>> With the latest BaseTools (current HEAD, 6c61ec4c62), building
>> multiple targets from a single command line crashes.
>>
>> To reproduce:
s already being filtered out for other architectures.
>
> Cc: Daryl McDaniel
> Cc: Jaben Carsey
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm
Reviewed-by: Philippe Mathieu-Daudé
> ---
>
> Resending only 1/6, since the others g
Hi,
On 2/4/19 10:58 AM, Leif Lindholm wrote:
> Hi Bob, Liming,
>
> With the latest BaseTools (current HEAD, 6c61ec4c62), building
> multiple targets from a single command line crashes.
>
> To reproduce:
> build -a IA32 -t GCC5 -b RELEASE -b NOOPT -p OvmfPkg/OvmfPkgIa32.dsc
> (I first built with
Hi,
On 2/1/19 6:34 AM, Shenglei Zhang wrote:
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Contributed-under: TianoCore Contribution
On 1/21/19 10:21 PM, Laszlo Ersek wrote:
> Hi Phil,
>
> On 01/21/19 14:26, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> On 1/21/19 1:53 PM, Gao, Liming wrote:
>>> Thanks Ard and Laszlo. For the minor change in single patch, the patch may
>>> be sent sep
in public trees. So delete before it can cause
>> damage.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Leif Lindholm
>
> Reviewed-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
>
>> ---
>> ArmPkg/Include/
Hi,
On 1/21/19 1:53 PM, Gao, Liming wrote:
> Thanks Ard and Laszlo. For the minor change in single patch, the patch may be
> sent separately with the clear subject. Or, the patch set can be sent again.
Since it is hard to follow technical discussion when top-posted (see
n Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Leif Lindholm
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseTools/Conf/tools_def.template | 27 +++-
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/BaseTools/Conf/to
On 1/14/19 2:18 PM, Gao, Liming wrote:
> Ard:
> Could you consider the suggestion from
> https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
There might be a special case for Aarch64, but I'm not seeing it.
>
> Thanks
> Liming
>> -Original Message-
>> From: Leif
Hi Ard,
On 1/7/19 7:55 AM, Ard Biesheuvel wrote:
> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> enabled. Since LTO has no benefit whatsoever here, just disable
> it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
Hi Shenglei,
On 1/7/19 9:35 AM, Shenglei Zhang wrote:
> Introduce public functions Base64Encode and Base64Decode.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1370
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei
/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 -
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 -
> EmulatorPkg/Unix/Host/Host.inf | 4 -
> EmulatorPkg/build.sh | 18 +-
> MdePkg/Include/Base.h | 3 +-
> OvmfPkg/README | 6 +-
> OvmfPkg/build.sh | 16 +-
> Vlv2TbltDevicePkg/bld_vlv.sh | 14 +-
> 12 files changed, 81 insertions(+), 627 deletions(-)
>
Series:
Reviewed-by: Philippe Mathieu-Daudé
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
the one used for DEBUG output (which
> often gets occluded due to the console driver clearing the screen)
You missed the trailing '.' :)
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> --
ia SerialDxe.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/
On 12/17/18 11:27 AM, Laszlo Ersek wrote:
> On 12/17/18 11:08, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> On 12/11/18 2:31 AM, Shenglei Zhang wrote:
>>> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to
>>> EFI_RETURNING_FROM_EFI_APPLICATION.
>>>
>
3 files changed, 5 insertions(+), 5 deletions(-)
>
NACK, this change has to be in the same patch to be bisectable.
However, if you resend the same change squashed in a single patch, you
can directly add my:
Reviewed-by: Philippe Mathieu-Daudé
Regards,
Phil.
mage name:
# $ docker run --rm -v $PWD/build:/build atf-raspi3-builder fiptool info
build/rpi3/release/fip.bin
# Trusted Boot Firmware BL2: offset=0x88, size=0x41F1, cmdline="--tb-fw"
# EL3 Runtime Firmware BL31: offset=0x4279, size=0x6079, cmdline="--soc-fw"
#
# 4/ Enter the D
onRomSize - 1;
> +GetResourceFromDevice (RootBridgeDev, IoBridge, Mem32Bridge,
> PMem32Bridge, Mem64Bridge, PMem64Bridge);
> + }
>
> //
>// Create resourcemap by going through all the devices subject to this
> root bridge
>
Reviewed-by: Philippe Mathieu-Daudé
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Hi Bob,
On 12/14/18 10:55 AM, BobCF wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1390
> 1. support hex number for array index
> 2. support Non-Dynamic Pcd for array data type
> 3. support {} and {CODE()} for array data type
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
ARM GNU ld toolchains to position independent veneers.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion
DDRESS.
This looks to me best this way, thanks for cleaning this.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Yonghong Zhu
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
>
Hi Stephano,
On 14/11/18 19:34, stephano wrote:
> We are currently researching several different options to help make
> contributing to TianoCore easier for the community. A big part of this
> effort will be enabling pull requests and allowing for a more
> customizable code review process.
>
> I
ement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
> index 12ca5b26673e..3b29d33d
Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Jaben Carsey
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseTools/Source/C/Common/CommonLib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/Com
d-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseTools/Source/C/Common/CommonLib.h | 24 ---
> BaseTools/Source/C/Common/CommonLib.c | 174 +---
> 2 files changed, 5 insertions(+), 193 deletio
less it assumes the value fits
> in 32-bit, so this change is a no-op even on 32-bit build hosts.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Jaben Carsey
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseT
On 30/11/18 23:45, Ard Biesheuvel wrote:
> Replace invocations of StrHexToUintn() with StrHexToUint64(), so
> that we can drop the former.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Jaben Carsey
Reviewed-by: Phil
trToIpv6Address() to use UINT64
> types instead of UINTN types when parsing strings.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BaseTools/Source/C/Common/CommonLib.c | 28 +
e-apply/patch:16: trailing whitespace.
Maintainers.txt with new maintainer, and the new maintainer should
error: patch failed: Maintainers.txt:6
error: Maintainers.txt: patch does not apply
Thanks for adding the maintainership handover clarification, I appreciate :)
With space fixed (s
particularly useful anyway.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.inf| 7
> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemI
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 1 -
> ArmVirtPkg/PrePi/PrePi.c| 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ArmVirtPkg/PrePi/Arm
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> BeagleBoardPkg/PrePi/PeiUniCore.inf | 1 -
> BeagleBoardPkg/PrePi/PrePi.c| 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/BeagleBoardPkg/PrePi/PeiUniCore.inf
> b/Beag
ion ();
>
>// Publish the CPU memory and io spaces sizes
This comment is misleading, maybe 'sizes' -> 'addressable bits'?
(not related to this series)
> - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize));
> + BuildCpuHob (ArmGetPhysicalAddressBits (
ount as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 3 ---
> ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf| 3 ---
>
-
Good diffstat :)
Reviewed-by: Philippe Mathieu-Daudé
> 4 files changed, 5 insertions(+), 75 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.inf
> b/ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.inf
> index cd4c805a4db9
On 28/11/18 15:33, Ard Biesheuvel wrote:
> Add a helper function that returns the maximum physical address space
> size as supported by the current CPU.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philipp
figBase, ConfigSize);
> + ASSERT_EFI_ERROR (Status);
> + if (EFI_ERROR (Status)) {
> +return Status;
> + }
> +
> + //
> + // Map the MMIO window that provides I/O access - the PCI host bridge code
> + // is not aware of this translation and so it will only map the I/O
Hi,
On 27/11/18 15:59, Liming Gao wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao
> Cc: Star Zeng
The usual workflow to hand over is the previous maintainer send the
patch, and you Ack-by it.
Exceptions are acceptable but require an explanation in
Hi,
On 27/11/18 9:35, Lokesh B V wrote:
> As the GenBin tool is necessary for SCT build, it is appropriate to
> support it's build in the SCT build procedure.
>
> SctPkg/Tools: Fix incorrect line ending detection by GenBin tool
>
> Some windows editors uses "\r\n" for line feed. While
On Mon, Nov 26, 2018 at 11:43 PM Philippe Mathieu-Daudé
wrote:
>
> On 26/11/18 23:37, Ard Biesheuvel wrote:
> > Add a helper function that returns the maximum physical address space
> > size as supported by the current CPU.
> >
> > Contributed-under: TianoC
On 26/11/18 23:37, Ard Biesheuvel wrote:
> Add a helper function that returns the maximum physical address space
> size as supported by the current CPU.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philipp
Hi Laszlo,
On 25/11/18 11:01, Laszlo Ersek wrote:
> QEMU's test suite includes a set of cases called "BIOS tables test". Among
> other things, it locates the RSD PTR ACPI table in guest RAM, and then
> (chasing pointers to other ACPI tables) performs various sanity checks on
> the QEMU-generated
register encode the size of the
>> +// physical address space support on this CPU:
>> +// 0 == 32 bits, 1 == 36 bits, etc etc
>> +// 6 and 7 are reserved
>> +//
>> +.LPARanges:
>> + .byte 32, 36, 40, 42, 44, 48, -1, -1
>> +
>
> Note: as Drew pointed o
eateInstance(). These are cosmetic
> changes only, the resulting binaries should be identical.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmPlatformPkg/Driv
Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 38 +---
> 1 file changed, 33 insertions(+), 5 deletions(-)
>
> diff --git a/ArmVirt
all flash banks,
> and update the driver's device path handling to include an index
> to identify each bank uniquely.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> Reviewed-by: Laszlo Ersek
> Reviewed-by: Leif Lindholm
Reviewed-by: Phili
On 16/11/18 21:46, stephano wrote:
This looks great.
I'm going to dig in a bit and see if we can export discussions for
logging purposes or if they are locked into Github.
For people on the move, having bad internet (3rd world countries), email
system is very powerful, you can download once
Cc'ing qemu-devel@
On 15/11/18 6:58, A Z wrote:
This is an issue that involves a combination of different software
packages, so my apologies in advance if this is the wrong list to post on.
I'm experiencing terrible boot times when I assign a large amount of RAM to
a VM when used in
e.
I agree that this change qualifies as a bugfix for the hard feature
freeze. From that perspective, without checking any technical details:
Acked-by: Laszlo Ersek
I checked NVM Express spec Revision 1.3c.
Reviewed-by: Philippe Mathieu-Daudé
*However*, please clean up the description in the bugzi
er definitions"
OvmfPkg: simply use the Bochs interface for vmsvga
FWIW Patches 1-4:
Reviewed-by: Philippe Mathieu-Daudé
Patch 5 (not yet merged) is still on my TODO because I want to run
detailed testing.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 12/11/18 13:21, Laszlo Ersek wrote:
On 11/12/18 12:28, Philippe Mathieu-Daudé wrote:
On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek
wrote:
On 11/06/18 14:44, Philippe Mathieu-Daudé wrote:
On 6/11/18 14:36, Laszlo Ersek wrote:
On 11/06/18 12:47, Laszlo Ersek wrote:
... While we discuss
Hi Marvin,
I just noticed the trailing '.' in the patch subject, you should remove
it (also in the 2nd patch).
Regards,
Phil.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek wrote:
> On 11/06/18 14:44, Philippe Mathieu-Daudé wrote:
> > On 6/11/18 14:36, Laszlo Ersek wrote:
> >> On 11/06/18 12:47, Laszlo Ersek wrote:
> >>
> >>> ... While we discuss this, I'll go ahead and push the f
e31285..revert_revert_bz_1319 -- OvmfPkg/
[nothing]
Thanks, and sorry about the churn
Laszlo
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: yuchenlin
Laszlo Ersek (4):
Reapply "OvmfPkg: VMWare SVGA display device register definitions&
.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser
Reviewed-by: Philippe Mathieu-Daudé
---
MdePkg/Library/UefiDebugLibStdErr/DebugLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/UefiDebugLibStdErr/DebugLib
.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser
Reviewed-by: Philippe Mathieu-Daudé
---
MdePkg/Library/UefiDebugLibConOut/DebugLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/UefiDebugLibConOut/DebugLib
On 7/11/18 10:36, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Jim Dailey
Cc: Hao A Wu
Reviewed-by: Philippe Mathieu-Daudé
---
ShellPkg/Library/UefiShellLib/UefiShellLib.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
appended:
Reviewed-by: Philippe Mathieu-Daudé
dmb
bx lr
@@ -141,5 +142,6 @@ ASM_PFX(MmioRead64Internal):
//
ASM_PFX(MmioWrite64Internal):
dmb st
- strdr2, r3, [r0]
+ str r2, [r0]
+ str r3, [r0, #4]
bx lr
diff --git a/MdePkg/Library
Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
---
IntelUndiPkg/GigUndiDxe/Hii.c | 8
IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
index 43c184cb03c8..a5d8ae207819 100644
Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
---
IntelUndiPkg/GigUndiDxe/Hii.c | 8
IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
index 43c184cb03c8..a5d8ae207819 100644
On 6/11/18 21:35, Ard Biesheuvel wrote:
On 6 November 2018 at 21:31, Philippe Mathieu-Daudé wrote:
Hi Ard,
On 6/11/18 18:58, Ard Biesheuvel wrote:
UINT8 and CHAR8 are not the same underlying type on all architectures,
so add an explicit cast where necessary.
Contributed-under: TianoCore
TICAL) */
+ i = 0;
+#endif /* (DBG_LVL & RX) */
This context is easier to understand when looking at the whole function.
Reviewed-by: Philippe Mathieu-Daudé
PacketType = PXE_FRAME_TYPE_NONE;
StatCode= PXE_STATCODE_NO_DATA;
- i = 0;
// acknowledge the
On 6/11/18 18:58, Ard Biesheuvel wrote:
Silence a 'misleading indentation' GCC warning by fixing the
incorrect indentation.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
-by: Philippe Mathieu-Daudé
---
IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
index 4c9a06b8cf73..28c900e3ad63 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.c
+++ b
On 6/11/18 18:58, Ard Biesheuvel wrote:
E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the
arguments to the correct type.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
---
IntelUndiPkg
Mathieu-Daudé
---
IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++--
IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
index bd7d4defc9a3..72f6a95ccb6d 100644
Hi Ard,
On 6/11/18 18:58, Ard Biesheuvel wrote:
UINT8 and CHAR8 are not the same underlying type on all architectures,
so add an explicit cast where necessary.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
1
-by: Philippe Mathieu-Daudé
---
IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++---
IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b
On 6/11/18 18:58, Ard Biesheuvel wrote:
Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace
all #include references with lowercase ones as well.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
On 6/11/18 18:58, Ard Biesheuvel wrote:
Remove the Ctrl-Z markers at the end of each file: these break the
GCC build on Linux.
Weird...
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daudé
---
IntelUndiPkg
On 6/11/18 14:36, Laszlo Ersek wrote:
On 11/06/18 12:47, Laszlo Ersek wrote:
... While we discuss this, I'll go ahead and push the first four
patches. The code being reverted is dead anyway. I'll report back about
the commit hashes.
Before pushing the first four patches, I regression-tested
Hi Yu-chen Lin,
On 24/10/18 8:40, yuchen...@synology.com wrote:
From: yuchenlin
In this series, replace the original vmsvga driver to Bochs
interface.
This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs when
initializing vmsvga':
Hi Yu-chen Lin,
On 24/10/18 8:40, yuchen...@synology.com wrote:
From: yuchenlin
This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2.
Can we have a comment here about why we need to revert this patch?
(same for patches 2 and 3).
Contributed-under: TianoCore Contribution Agreement
Hi Yu-chen Lin,
On 24/10/18 8:40, yuchen...@synology.com wrote:
From: yuchenlin
BAR |std vga | vmsvga
-
0| Framebuffer | I/O space
1| Reserved | Framebuffer
2| MMIO | FIFO
Because of the PCI BARs difference between std
Hi Marcin, Tomasz.
On 05/10/2018 15:25, Marcin Wojtas wrote:
> From: Tomasz Michalec
>
> Some SD Host Controlers use different values in Host Control 2 Register
My two cents, in various places "Controler" is miswritten, this should
be "Controller".
> to select UHS Mode. This patch adds a new
populate EBX like that itself.
>
> Cc: Liming Gao
> Cc: Michael D Kinney
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1208
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
> ---
> MdePkg
Liming Gao
> Cc: Michael D Kinney
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1208
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
> ---
> MdePkg/Library/BaseSynchronizationLib/X64/Gcc
1 - 100 of 103 matches
Mail list logo
