Re: [edk2] Mixed (unix/windows) line endings in EDK2

2015-08-05 Thread David Woodhouse
On Wed, 2015-08-05 at 01:27 -0500, Scott Duplichan wrote: How can we make these files use consistent line endings? Would a patch work? Git can handle this, and automatically check out the appropriate type of line endings according to the system you're working on. Perhaps we should use that

Re: [edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-08-05 Thread Laszlo Ersek
On 08/04/15 21:50, Wei Huang wrote: I tested this version of binary with QEMU that supports SMBIOS 3.0. The guest VM is a 64-bit RHEL Server for ARM. Everything worked out of box. With it: Tested-by: Wei Huang w...@redhat.com Thanks a lot, Wei! Jordan -- can you please (1) skim the OVMF

Re: [edk2] Building on Windows

2015-08-05 Thread David Woodhouse
On Wed, 2015-08-05 at 09:43 -0500, Scott Duplichan wrote: Here is how you can build Ovmf on Windows (tested with Win7 x64): 1) Get edk2, including BaseTools\Bin\Win32. You are right, git doesn't work for getting the external BaseTools\Bin\Win32. 2) Install Visual Studio 2008. EDK2 supports

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. Cc: Jiewen Yao jiewen@intel.com

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 8:38 AM, Kinney, Michael D michael.d.kin...@intel.com wrote: Andrew, I would recommend a DSC define setting have precedence over the WORKSPACE_MULTIPLE environment variable. This way, a single development environment can support many platform DSC files. Most of

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 08/05/15 18:18, Andrew Fish wrote: On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD

Re: [edk2] Building on Windows

2015-08-05 Thread Scott Duplichan
David Woodhouse [mailto:dw...@infradead.org] wrote: ]Sent: Wednesday, August 05, 2015 10:32 AM ]To: Scott Duplichan sc...@notabs.org; edk2-de...@ml01.01.org ]Cc: david.woodho...@intel.com; 'Long, Qin' qin.l...@intel.com ]Subject: Re: [edk2] Building on Windows ] ]On Wed, 2015-08-05 at 09:43

Re: [edk2] Building on Windows

2015-08-05 Thread Blibbet
Some Windows/EDK2 blog posts that may help: http://uefi.blogspot.com/2013/06/how-to-set-up-edk2s-windows-hosted-uefi.html http://pete.akeo.ie/2015/01/easily-create-uefi-applications-using.html http://spyker729.blogspot.com/2012/10/how-to-build-edk-edkii-environment-in.html If you look at the

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people prefers to keep WOSKAPCE as single directory, and introduce new env $(WORKSPACE_MULTIPLE). I'm not sure about this conclusion. I think Paolo, Laszlo and I all expressed that using WORKSPACE for the multiple

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 12:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people prefers to keep WOSKAPCE as single directory, and introduce new env $(WORKSPACE_MULTIPLE). I'm not sure about this

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Kinney, Michael D
Jordan, We already have EDK_TOOLS_PATH for the path to the tools, so I don't think we should add WORKSPACE_TOOLS. The DSC file specifies the output directory and the syntax supports both workspace relative paths and absolute paths. I am not sure I understand what issue is addressed by adding

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
On 2015-08-05 12:19:47, Andrew Fish wrote: On Aug 5, 2015, at 12:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people prefers to keep WOSKAPCE as single directory, and introduce new env

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 12:40 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 12:19:47, Andrew Fish wrote: On Aug 5, 2015, at 12:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source locations in Platform DSC file. It doesn't conflict with this proposal. We can implement $(WORKSPACE_MULTIPLE) feature

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Tim Lewis
Agree with Andrew. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Wednesday, August 05, 2015 1:22 PM To: Jordan Justen jordan.l.jus...@intel.com Cc: Paolo Bonzini pbonz...@redhat.com; edk2-devel@lists.01.org; Laszlo Ersek

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 2:36 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 12:51:47, Andrew Fish wrote: On Aug 5, 2015, at 12:40 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Unless we do something about most of those references then WORKSPACE will have

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
On 2015-08-05 13:21:37, Andrew Fish wrote: On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source locations in Platform DSC file. It doesn't conflict with this proposal. We

Re: [edk2] [Patch] ShellPkg: Fix issue about ping fail with IPv4

2015-08-05 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Wu, Jiaxin Sent: Thursday, August 06, 2015 12:08 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting Subject: [Patch] ShellPkg: Fix issue about ping fail with IPv4 Fix issue about ping fail with IPv4, which is

Re: [edk2] Error on executing shell command ifconfig

2015-08-05 Thread Wu, Jiaxin
Did you use the default shell in ShellBinPkg? If so, you should rebuild latest shell in ShellPkg. Thanks. Jiaxin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting Sent: Thursday, August 6, 2015 8:26 AM To: Sharma Bhupesh;

[edk2] [PATCH 1/2] ShellPkg: Fix build failure in VS2015.

2015-08-05 Thread Qiu Shumin
Initialize local variable before it is passed into a function by reference. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Kinney, Michael D michael.d.kin...@intel.com Reviewed-by: Qiu Shumin shumin@intel.com --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c |

[edk2] [Patch] ShellPkg: Fix issue about ping fail with IPv4

2015-08-05 Thread Jiaxin Wu
Fix issue about ping fail with IPv4, which is caused by the incorrect checksum in request message. Cc: Fu Siyuan siyuan...@intel.com Cc: Ye Ting ting...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu jiaxin...@intel.com ---

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Zeng, Star
I am working on that. One thing is strange that StartupAllAPs is working well with my qemu by OVMF and even real machine. Anyway, there is mismatch between BSP and AP when PcdSetNxForStack is TRUE. As BSP and AP share same page table, 0xC080 has BIT11 set for BSP, AP needs to sync up the

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 2:46 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 13:21:37, Andrew Fish wrote: On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source

Re: [edk2] efi acpidump port

2015-08-05 Thread Smith, Jonathan D
By the way, here it is on my personal github. Repo page URL: https://github.com/jnthsmth/edk2/tree/master/AcpicaPkg Clone URL: g...@github.com:jnthsmth/edk2.git Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jonathan Smith jonathan.d.sm...@intel.com Yay process.

Re: [edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-08-05 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-07-31 11:40:52, Laszlo Ersek wrote: The SMBIOS 3.x entry point is structurally different from the 2.x variant, therefore the current code used by OvmfPkg and ArmVirtPkg doesn't recognize an SMBIOS 3.0 entry point structure

Re: [edk2] Error on executing shell command ifconfig

2015-08-05 Thread Ye, Ting
Do you know whether the LanIntelE1000Dxe works properly? You may type drivers in shell to check connecting status of UEFI network drivers. Best Regards, Ye Ting -Original Message- From: Sharma Bhupesh [mailto:bhupesh.sha...@freescale.com] Sent: Wednesday, August 05, 2015 6:43 PM To: