[edk2] MdePkg: DebugAssert enhancement

Hi, Current DebugAssert function prints the file name and line number. If the assert happens in a library, then it's hard to determine which module using that library is generating that assert. Can we add gEfiCallerBaseName to display the module name as well? -Baranee diff --git

Re: [edk2] [patch 3/3] MdeModulePkg/NvmExpress: Clean Phase/CqHdbl/SqTdbl fields to restart HC

Hi Feng, Your changes all look fine to me. Thanks. Here is a minor comment issue which is separate from your changes below - In NvmExpress.h, the comment for Buffer under NVME_CONTROLLER_PRIVATE_DATA doesn't seem to reflect the actual sequence as they are initialized. Based on the

Re: [edk2] [PATCH] ArmPkg: Convert whole-cache InvalidateInstructionCache to just ASSERT

Ard, My workflow is a Windows host using TortoiseGit and I'm formatting a patch and using send-mail using MAPI which invoked Outlook. I'm guessing this couldn't be more different than your workflow. :) I don't think another mail client works well with our IT department but I'll see what I

Re: [edk2] MdePkg: DebugAssert enhancement

Change seems fine to me. Note that I am not maintainer on this PKG. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Anbazhagan, Baraneedharan > Sent: Tuesday, December 01, 2015 3:26 PM >

Re: [edk2] MdePkg: DebugAssert enhancement

Good enhancement. Reviewed-by: Liming Gao Could you help also update MdeModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeDebugLibReportStatusCode.inf and IntelFrameworkModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeDebugLibReportStatusCode.inf?

[edk2] [PATCH] BaseTools PatchCheck.py: Support binary diff

This allows a patch with binary data that is generated with --binary to be parsed by the PatchCheck.py script. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Yonghong Zhu Cc: Liming Gao

Re: [edk2] [PATCH] BaseTools RVCT: use scatter file to implement minimum section alignment

Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, December 01, 2015 4:59 PM To: edk2-devel@lists.01.org; eug...@hp.com Cc: leif.lindh...@linaro.org; Gao, Liming; Ard Biesheuvel Subject: [PATCH]

[edk2] HII ConfigRouting Assert - Why?

In the HiiDatabaseDxe driver there's an ASSERT that seems oddly placed to me: if (IsEfiVarStore) { // // Call the GetVariable function to extract settings. // Status = GetConfigRespFromEfiVarStore(This, EfiVarStoreInfo, ConfigRequest, , ); FreePool

Re: [edk2] ifconfig command issue in edk2

Hi Shaveta, We will try to reproduce the ASSERT issue at first. We will investigate how to fix it as soon as we can reproduce this, or back to you once we fail to reproduce. For below one, it seems you split the ifconfig command to two parts, and shell does not recognize the second part as

Re: [edk2] [Patch] [patch] Vlv2TbltDevicePkg: Add SsdtUpdate Application to update Ssdt table to ACPI table.

Reviewed-by: Tim He -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex Sent: Tuesday, December 01, 2015 2:42 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] [patch] Vlv2TbltDevicePkg: Add SsdtUpdate Application to

[edk2] [PATCH v2] ArmPkg/ArmSoftfloatLib: add missing entry points for RVCT

The RVCT compiler may emit calls to the various __aeabi_c?cmp?? functions, which return their results via the CPU condition flags C and Z. According to ARM doc IHI 0043D 'Run-time ABI for the ARM architecture': The 3-way comparison functions c*cmple, c*cmpeq and c*rcmple return their

[edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

Since debugging tools on ARM usually take the ELF image as input, while the target runs the PE/COFF version, we need to take special care to ensure that the two look identical in memory. The minimum section alignment imposed by GenFw is 32 bytes, so introduce a RVCT scatter file that sets this

[edk2] [PATCH v2 0/3] ARM: RVCT: fix ELF to PE/COFF conversion

Recent fixes for correctness in GenFw have resulted in build problems under GCC. These patches fix that by introducing linker scripts (scatter files in ARM speak) and updating GenFw to enforce identical memory layouts between ELF and PE/COFF as we do for GCC. Patch #3 illustrates how we can now

[edk2] [PATCH v2 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

Unlike GNU ld, which can be instructed to emit symbol based static relocations into fully linked binaries using the --emit-relocs command line switch, the RVCT armlink tool can only emit dynamic relocations into the PT_DYNAMIC segment. This has two consequences . we can only identify absolute

[edk2] [PATCH v2 3/3] ArmVirtPkg RVCT: build DXE_RUNTIME_DRIVER modules with 4 KB alignment

This adds the RVCT armlink command line switches to build modules of type DXE_RUNTIME_DRIVER with 4 KB PE/COFF section alignment, allowing the OS to apply stricter permissions to the .text and .data sections. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH] ArmPkg: Convert whole-cache InvalidateInstructionCache to just ASSERT

In SVN 18756 ("disallow whole D-cache maintenance operations") InvalidateInstructionCache was modified to remove the full data cache clean but left the full instruction cache invalidate. The change was made to address issues in the set/way clean methodology but the resulting code could lead

Re: [edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

> On Dec 1, 2015, at 9:52 AM, Cohen, Eugene wrote: > > Ard, > >> Since debugging tools on ARM usually take the ELF image as input, while >> the target runs the PE/COFF version, we need to take special care to >> ensure that the two look identical in memory. > > The issue is not

Re: [edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

Ard, > Since debugging tools on ARM usually take the ELF image as input, while > the target runs the PE/COFF version, we need to take special care to > ensure that the two look identical in memory. The issue is not just a debugging thing. If the relative position of .text and .data is changed

Re: [edk2] [PATCH] ArmPkg: Convert whole-cache InvalidateInstructionCache to just ASSERT

On 1 December 2015 at 19:09, Cohen, Eugene wrote: > In SVN 18756 ("disallow whole D-cache maintenance operations") > InvalidateInstructionCache was modified to remove the full data cache clean > but left the full instruction cache invalidate. The change was made to > address

Re: [edk2] [PATCH 0/5] Enable ECR1263 Customized Secure Boot

The patch series is good to me. Please make the patch subjects and description more clear, as Laszlo's comments. And also need to check the RetVal descriptions in your new-added functions. Best Regards & Thanks, LONG, Qin > -Original Message- > From: Laszlo Ersek

Re: [edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature

Hi Chao, I have comments below to this patch about AuthVariableLib update. 1. Move SecureBootState to AuthService.c since it is only used by AuthService.c, and update the name to mSecureBootState. 2. Remove IsPkExist and SetupModeValAttr fields from SECURE_BOOT_MODE structure since only any

[edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

In multiple root bridge platforms, different root bridges may share the same segment but occupy different range of buses, or may occupy different segments. The fix is to find the correct root bridge IO instance by comparing not only the segment but also the bus ranges. Directly use Cpu Io for MMIO

[edk2] [Patch 0/2] Fix Shell mm command bugs

The patches fix shell mm command help message and let it support multiple root bridge platforms. Ruiyu Ni (2): ShellPkg/mm: Fix the help message of mm to align to implementation. ShellPkg/mm: Fix mm to support multiple root bridge platform ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c

[edk2] [Patch 1/2] ShellPkg/mm: Fix the help message of mm to align to implementation.

The implementation is already aligned to spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- .../UefiShellDebug1CommandsLib.uni | Bin 140676 -> 139696 bytes 1 file changed, 0

[edk2] [PATCH] BaseTools RVCT: use scatter file to implement minimum section alignment

Since debugging tools on ARM usually take the ELF image as input, while the target runs the PE/COFF version, we need to take special care to ensure that the two look identical in memory. The minimum section alignment imposed by GenFw is 32 bytes, so introduce a RVCT scatter file that sets this

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

On 30 November 2015 at 10:39, Michael Zimmermann wrote: >> Unrelated note: *please* get rid of the ARM BDS and use the Intel BDS >> instead. The ARM BDS violates the UEFI spec, (i.e., you cannot boot >> installer images from it without a lot of hassle) and does not allow

[edk2] [PATCH 2/4] MdeModulePkg ScsiDiskDxe: Add BlockIO2 Support

Together with EFI_BLOCK_IO_PROTOCOL, EFI_BLOCK_IO2_PROTOCOL is installed as well in ScsiDiskDxe. Block I/O 2 functions are implemented: Reset ReadBlocksEx WriteBlocksEx FlushBlocksEx Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 1/4] MdePkg UefiScsiLib: Add non-blocking support for SCSI Read/Write command

Four new functions are added to UefiScsiLib: ScsiRead10CommandEx ScsiWrite10CommandEx ScsiRead16CommandEx ScsiWrite16CommandEx They support both blocking and non-blocking SCSI Read/Write operation depending on the optional parameter 'Event' passed to those APIs. When 'Event' is NULL, these four

[edk2] [PATCH 4/4] MdeModulePkg ScsiBusDxe: Fix caller event may nerver be signaled

For function ScsiExecuteSCSICommand(), when the 'Event' parameter is not NULL but the target SCSI device does not support non-blocking I/O, it will execute a blocking I/O operation instead. However, after the SCSI operation is done, the 'Event' is not signaled to inform the caller.

[edk2] ifconfig command issue in edk2

Hi, I am observing one issue while using "ifconfig" command. When ifconfig command is used with incomplete parameters like below, it hangs the system by throwing an ASSERT: Shell> ifconfig -s eth0 static 192.168.2.142 ASSERT

Re: [edk2] [Patch] UefiCpuPkg/CpuS3DataDxe: Add more detailed description on GUID in INF

On 12/01/15 08:53, Jeff Fan wrote: > Add the GUID gEfiEndOfDxeEventGroupGuid usage description in more details in > INF file. > > Cc: Feng Tian > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff

Re: [edk2] [EDK2] Why apic timer vector is 5 in Ovmf Sec?

On 12/01/15 06:35, winddy wrote: > Dear Expert, > I see in file OvmfPkg\Sec\SecMain.c, line 810: > // > // Initialize Local APIC Timer hardware and disable Local APIC Timer > // interrupts before initializing the Debug Agent and the debug timer is > // enabled. > // >

[edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to point of unification (PoU)

This patch updates the ArmPkg variant of InvalidateInstructionCacheRange to flush the data cache only to the point of unification (PoU). This improves performance and also allows invalidation in scenarios where it would be inappropriate to flush to the point of coherency (like when executing

Re: [edk2] Where do I find the system table address for an EFI app ?

 I'm sorry but this was unclear. I meant where do I find the System Table address for a UEFI Shell App ?The debugger is asking for it. I couldn't find it in the generated *.map file. Thanks Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com On Monday, November 30, 2015

Re: [edk2] Where do I find the system table address for an EFI app ?

Its passed as a parameter to the "main" function when your app starts. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shubha Ramani > Sent: Tuesday, December 01, 2015 8:35 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] Where