[edk2] Help in testing PCIe driver from UEFI shell

2015-12-16 Thread Mahan, Patrick
All, I am looking for information on how to test our PCIe DXE driver for our NIC on Intel. I am building from the latest EDK2 sources using gcc v4.8 on Ubuntu. The 'ver' command from the UEFI shell gives - EFI Specification Revision : 2.10 EFI Vendor : Dell EFI

Re: [edk2] [Patch] NetworkPkg: Update iSCSI driver to check existing AIP instances

2015-12-16 Thread El-Haj-Mahmoud, Samer
Ting, Apologies for the delay. One comment I have is on IScsiCheckAip(). Is it possible to check the platform network boot policy PCD (probably with a new value) that indicates to ALWAYS run the iSCSI SW Initiator, and ignore AIP. You can do this before searching for any AIP handles. This

Re: [edk2] trouble building edkii

2015-12-16 Thread Jarlstrom, Laurie
Hi, First off what is your build environment? Which version of Microsoft Visual studio are you using? Is your Windows OS 32 or 64 bit? When you installed Microsoft Visual Studio did you open it for the first time and Select C++ for the language? thanks, Laurie   laurie.jarlst...@intel.com

[edk2] trouble building edkii

2015-12-16 Thread Guyen Gankhuyag
Hello there, I downloaded the EDKII package from tianocore.org and setup build environment using the guidelines in BuildNotes2.txt also necessary stps in Patch-HOWTO.txt (attached).However I am having trouble building the edk with build -t VS2008x86 switch. Can someone help on this

[edk2] [PATCH v3] MdeModulePkg: Add HTTP 1.1 industry standard definitions

2015-12-16 Thread Samer El-Haj-Mahmoud
Add common HTTP 1.1 industry standard definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud ---

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread El-Haj-Mahmoud, Samer
Mike, If you would like to avoid introducing the new PCD, I am fine with looking at the Option ROM BAR and degrade only if there is a legacy option ROM. Would you like me to submit a new patch that does that? Thanks, --Samer -Original Message- From: Kinney, Michael D

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread Michael Brown
On 14/12/15 23:35, El-Haj-Mahmoud, Samer wrote: We ran into the same issue of automatic demoation simply because of the presence of an OptionROM. We believe this is an overly aggressive policy. In fact, I have a patch that I am about to submit that adds a platform PCD to enable/disable this

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread Kinney, Michael D
Samer, Yes. Thank you! Mike From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, December 16, 2015 8:59 AM To: patrick.ma...@caviumnetworks.com; edk2-devel@lists.01.org; Kinney, Michael D Cc: El-Haj-Mahmoud, Samer

Re: [edk2] trouble building edkii

2015-12-16 Thread Jarlstrom, Laurie
>From your Build.log file: fatal error C1083: Ca nnot open include file: 'windows.h': No such file or directory typically this is a result of something in your environment not set correctly, (i.e. the C include paths.) When EdkSetup.bat runs it is trying to find the correct version of Visual

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread Mahan, Patrick
Mike, If the option ROM is disabled, would you agree that degrading the BARs from 64-bit to 32-bit should be skipped? Also, if the driver is not coming from the option ROM, should the BARs still be degraded? Thanks, Patrick From: Michael Brown

Re: [edk2] Help in testing PCIe driver from UEFI shell

2015-12-16 Thread Carsey, Jaben
I think that you need to debug your DriverBinding.Start() and DriverBinding.Supported() APIs. Those are what gets called in your driver when 'connect' shell command it used. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Mahan,

Re: [edk2] trouble building edkii

2015-12-16 Thread Jarlstrom, Laurie
Here are some Edk II training options: 1) Online Training: "Defining Specifications' Role in Firmware" and Lessons 1-5 of "Implementing the Boot Process." https://github.com/tianocore/tianocore.github.io/wiki/UEFI-EDKII-Learning-Dev I Recommend Downloading the Zip File** for each of the

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread El-Haj-Mahmoud, Samer
Thanks Mike. This is probably another reason why degrading the BARs when a Legacy OptionROM is present is a good idea. Does anyone see any issue if we change the code to Always Degrade if a Legacy OptionROM is present, and ignore the presence of an EFI Option ROM? -Original Message-

Re: [edk2] trouble building edkii

2015-12-16 Thread Guyen Gankhuyag
I dont feel very comfortable with the response. Are you sure this will work? If so, how it is not documented in the build guide? Is anyone in charge of maintaining the build has accurate information or is it just abandoned? The reason I mailed here is to get professional support, instead of

Re: [edk2] [Patch] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Class.

2015-12-16 Thread Gao, Liming
Daocheng: PEI phase global variable can't be used. You need to locate PPI in every function call. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:46 PM To: edk2-devel@lists.01.org

[edk2] [patch] MdeModulePkg:Fix bug that get the password width info incorrectly

2015-12-16 Thread Dandan Bi
Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [edk2] [Patch 2/4] SecurityPkg: Correct Pcd Usage PcdTpm2HashMask in Tcg2Pei

2015-12-16 Thread Zhang, Chao B
Liming: The patch is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Thursday, December 17, 2015 12:57 PM To: Zhang, Chao B Subject: FW: [edk2] [Patch 2/4] SecurityPkg: Correct Pcd Usage

[edk2] [PATCH V2] NetworkPkg: Update iSCSI driver to check existing AIP instances

2015-12-16 Thread Ye Ting
According to UEFI spec, iSCSI HBA must install an AIP instance with network boot information block. This patch updates UEFI iSCSI driver to check whether there are AIP instances installed by iSCSI HBA adapter and if yes, the UEFI iSCSI driver will return EFI_ABORTED in its driver binding Start().

[edk2] [Patch] MdePkg: Convert IoLibEbc.c source file to DOS format

2015-12-16 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c | 342 +-- 1 file changed, 171 insertions(+), 171 deletions(-) diff --git

Re: [edk2] [Patch] Maintainers.txt: Update maintainers for Quark*Pkg

2015-12-16 Thread Jordan Justen
Looks good. Reviewed-by: Jordan Justen On 2015-12-16 17:21:02, Michael Kinney wrote: > Fix typo in email address > Consolidate QuarkPlatformPkg and QuarkSocPkg > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney

Re: [edk2] [Patch 1/4] SecurityPkg: Correct Pcd Usage PcdTcg2HashAlgorithmBitmap

2015-12-16 Thread Zhang, Chao B
Liming: The patch is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Thursday, December 17, 2015 12:58 PM To: Zhang, Chao B Subject: FW: [edk2] [Patch 1/4] SecurityPkg: Correct Pcd Usage

[edk2] [PATCH v2 3/3] EdkCompatibilityPkg: Fix GCC error to avoid the duplicated global variables

2015-12-16 Thread Liming Gao
SmmBaseHelper uses the same name global variables to the one in SmmMemoryAllocateLib. Update SmmBaseHelper to use SmmMemLib SmmIsBufferOutsideSmmValid(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

Re: [edk2] [patch] MdeModulePkg:Fix bug that get the password width info incorrectly

2015-12-16 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 10:56 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Fix bug that get the password width info incorrectly Cc: Liming Gao

Re: [edk2] [PATCH] MdeModulePkg: Fix VS2012 build failure.

2015-12-16 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Qiu, Shumin Sent: Thursday, December 17, 2015 13:03 To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Tian, Feng; Cecil Sheng Subject: [PATCH] MdeModulePkg: Fix VS2012 build failure. Cc: Feng Tian Cc:

[edk2] [PATCH] MdeModulePkg: Fix VS2012 build failure.

2015-12-16 Thread Qiu Shumin
Cc: Feng Tian Cc: Cecil Sheng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [edk2] [Patch 4/4] SourceLevelDebugPkg: Correct gEfiDebugAgentGuid usage in DxeDebugAgentLib

2015-12-16 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, December 15, 2015 1:45 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 4/4] SourceLevelDebugPkg: Correct gEfiDebugAgentGuid

[edk2] Display progress from HII config access callback for an operation running in loop

2015-12-16 Thread Krishna Kumar
Hi, I am trying to display the progress of an operation which runs in a loop from HII config access callback function. The setup browser will not update the form until the control is returned from the callback function. In this case how can I display the progress on form when the control is

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-16 Thread Anbazhagan, Baraneedharan
Updating FDF with 'FvForceRebase = FALSE' resolved the build issue. Thanks. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, December 15, 2015 8:41 PM > To: Anbazhagan, Baraneedharan; Kinney, Michael D; Yao, Jiewen; Laszlo Ersek > Cc: Hamel, Lee M;

Re: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Class.

2015-12-16 Thread Yao, Jiewen
And UEFI_APPLICATION, I think. :-) -Original Message- From: Gao, Liming Sent: Thursday, December 17, 2015 8:48 AM To: Bu, Daocheng; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Class. Does it need to support

Re: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Class.

2015-12-16 Thread Gao, Liming
Does it need to support DXE_CORE, UEFI_DRIVER? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:44 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2] [Patch] MdeModulePkg: Add

Re: [edk2] [Patch] NetworkPkg: Update iSCSI driver to check existing AIP instances

2015-12-16 Thread Ye, Ting
Samer, Thanks for the suggestion. I think this makes sense. I will add this and send out an updated patch later. Thanks, Ting -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, December 17, 2015 1:27 AM To: Ye, Ting;

Re: [edk2] trouble building edkii

2015-12-16 Thread Gao, Liming
Hi, To build Nt32Pkg, "edksetup.bat --nt32" can help setup VS env. Could you try it? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guyen Gankhuyag Sent: Thursday, December 17, 2015 3:32 AM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [Patch] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Class.

2015-12-16 Thread Gao, Liming
Daocheng: This is a typo? + , Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:51 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2] [Patch]

Re: [edk2] [Patch] MdeModulePkg: Add IpmiLib header file.

2015-12-16 Thread Gao, Liming
Is there only EFI_NOT_FOUND error return status? I see UefiScsiLib ScsiWrite16CommandEx() API has more return status EFI_NOT_READY, EFI_DEVICE_ERROR, EFI_TIMEOUT, EFI_UNSUPPORTED, EFI_OUT_OF_RESOURCES. Could you help confirm it? -Original Message- From: edk2-devel

[edk2] [Patch] Maintainers.txt: Update maintainers for Quark*Pkg

2015-12-16 Thread Michael Kinney
Fix typo in email address Consolidate QuarkPlatformPkg and QuarkSocPkg Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Maintainers.txt | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [edk2] [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict.

2015-12-16 Thread Dong, Eric
Add more description for it: GCC49 has enhance the global variable name conflict check. If different module share the same global name, it will report link error. This patch fixed one case reported for DxeTpmMeasureBootLib and DxeImageVerificationLib. -Original Message- From:

Re: [edk2] [Patch] MdePkg: Convert IoLibEbc.c source file to DOS format

2015-12-16 Thread Kinney, Michael D
Liming, Thanks for fixing this. Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Liming Gao > Sent: Wednesday, December 16, 2015 11:22 PM > To: edk2-devel@lists.01.org >

[edk2] [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict.

2015-12-16 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- .../Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c| 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Mark Rutland
On Wed, Dec 16, 2015 at 12:24:30PM +0100, Ard Biesheuvel wrote: > On 16 December 2015 at 12:18, Mark Rutland wrote: > > On Wed, Dec 16, 2015 at 10:37:39AM +0100, Ard Biesheuvel wrote: > >> diff --git a/ArmPkg/Include/Chipset/AArch64.h > >> b/ArmPkg/Include/Chipset/AArch64.h

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Leif Lindholm
On Wed, Dec 16, 2015 at 12:16:01PM +, Mark Rutland wrote: > On Wed, Dec 16, 2015 at 12:24:30PM +0100, Ard Biesheuvel wrote: > > On 16 December 2015 at 12:18, Mark Rutland wrote: > > > On Wed, Dec 16, 2015 at 10:37:39AM +0100, Ard Biesheuvel wrote: > > >> diff --git

[edk2] [Patch] MdeModulePkg: Add Ipmi Ppi header file.

2015-12-16 Thread Daocheng Bu
Add Ipmi Ppi header file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdeModulePkg/Include/Ppi/IpmiPpi.h | 49 ++ 1 file changed, 49 insertions(+) create

[edk2] [Patch] MdeModulePkg: Add BaseIpmiLibNull Library Class.

2015-12-16 Thread Daocheng Bu
Add BaseIpmiLibNull Library Class for BMC-Less platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- .../Library/BaseIpmiLibNull/BaseIpmiLibNull.c | 47 ++

[edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Class.

2015-12-16 Thread Daocheng Bu
Add DxeIpmiLibIpmiProtocol Library Class that will depend on Ipmi stack driver produces Ipmi Protocol in Dxe Phase under SMS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao ---

[edk2] [PATCH v2 4/5] ArmVirtPkg/ArmXenRelocatablePlatformLib: add ARM support

2015-12-16 Thread Ard Biesheuvel
This is a port of the AARCH64 low level init routines to ARM. This mainly covers the platform boot code that extracts the system base and size from the DTB, copies it and updates the FD and FV base addresses according to the load time offset. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v2 1/5] OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2

2015-12-16 Thread Ard Biesheuvel
GCC_ASM_EXPORT() not only exports a symbol as a function, it also emits a .type , %function directive, which is used by the ARM linker to decide whether to emit interworking branches. So replace the explicit .global with GCC_ASM_EXPORT(), or the code will not be callable from Thumb-2 code.

[edk2] [PATCH v2 2/5] ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB memory node retrieval in C

2015-12-16 Thread Ard Biesheuvel
Parsing the DTB early on using a handcoded assembly routine is a pointless waste of brain cycles, since the UEFI firmware always executes from RAM under Xen. So instead, set up a temporary stack in the memory region at the beginning of the image, and use the libfdt C library. Contributed-under:

[edk2] [PATCH v2 5/5] ArmVirtPkg/ArmVirtXen: add ARM support

2015-12-16 Thread Ard Biesheuvel
This adds ARM support to the ArmVirtXen platform. As is the case for AARCH64, the ARM port adheres to the ARM Linux boot protocol, i.e., it expects the address of a DTB describing the platform to be passed in r2, and relocates itself at runtime to the actual load time memory offset.

[edk2] [Patch] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Class.

2015-12-16 Thread Daocheng Bu
Add SmmIpmiLibSmmIpmiProtocol Library Class that will depend on Ipmi stack smm driver produces Ipmi Protocol in SMM mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao ---

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 13:08, Alcantara, Paulo wrote: > This patch fixes the following compile error under GCC 5.3.1: > > /home/pcacjr/work/edk2.git/ShellPkg/Application/Shell/ShellManParser.c: > In function 'IsTitleHeader': >

[edk2] [Patch] MdeModulePkg: Add IpmiLib header file.

2015-12-16 Thread Daocheng Bu
Add IpmiLib header file for ipmi command submit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdeModulePkg/Include/Library/IpmiLib.h | 47 ++ 1 file changed, 47

[edk2] [Patch] MdeModulePkg: Add Ipmi Protocol header file.

2015-12-16 Thread Daocheng Bu
Add Ipmi Protocol header file for both DXE and SMM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdeModulePkg/Include/Protocol/IpmiProtocol.h | 56 1 file changed,

[edk2] [PATCH v2 3/5] ArmVirtPkg/PrePiRelocatable: add ARM support

2015-12-16 Thread Ard Biesheuvel
This adds support to the self relocating PrePi instance that is built as a PIE ET_DYN executable. It primarily involves porting the relocation routine to use ELF32 REL entries instead of ELF64 RELA entries which is what AArch64 uses. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v2 0/5] ArmVirtPkg: add ARM support to ArmVirtXen

2015-12-16 Thread Ard Biesheuvel
By special request, this implements ARM support to the ArmVirtXen platform. This time, I managed to test it myself under Xen on actual AArch64 hardware, after I figured out that 64-bit supports 32-bit guests as well. Changes since v1: - two patches have been merged, and hence dropped from this

[edk2] [Patch] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Class.

2015-12-16 Thread Daocheng Bu
Add PeiIpmiLibIpmiPpi Library Class that will depend on Ipmi stack PEIM produces Ipmi Ppi in Pei Phase under SMS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao ---

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 13:23, Leif Lindholm wrote: > On Wed, Dec 16, 2015 at 12:16:01PM +, Mark Rutland wrote: >> On Wed, Dec 16, 2015 at 12:24:30PM +0100, Ard Biesheuvel wrote: >> > On 16 December 2015 at 12:18, Mark Rutland wrote: >> > > On

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 12:18, Mark Rutland wrote: > On Wed, Dec 16, 2015 at 10:37:39AM +0100, Ard Biesheuvel wrote: >> Unfortunately, Clang does not support the use of symbol references in .org >> directives, and bails with the following error message when it encounters >>

[edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-16 Thread Ard Biesheuvel
The runtime test whether the compiler supports arithmetic shift of negative signed numbers currently relies on undefined behavior in C, which means that all bets are off regarding whether the condition that follows passes or fails, regardless of whether the compiler in fact supports arithmetic

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Mark Rutland
On Wed, Dec 16, 2015 at 10:37:39AM +0100, Ard Biesheuvel wrote: > Unfortunately, Clang does not support the use of symbol references in .org > directives, and bails with the following error message when it encounters > them: > > <...>:error: expected assembly-time absolute expression > .org

[edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Alcantara, Paulo
This patch fixes the following compile error under GCC 5.3.1: /home/pcacjr/work/edk2.git/ShellPkg/Application/Shell/ShellManParser.c: In function 'IsTitleHeader': /home/pcacjr/work/edk2.git/ShellPkg/Application/Shell/ShellManParser.c:502:5: error: enumeration value 'Final' not handled in switch

Re: [edk2] [Patch 3/3] EdkCompatibilityPkg: Fix GCC error to avoid the duplicated global variables

2015-12-16 Thread Yao, Jiewen
Hi Liming Can we use SmmIsBufferOutsideSmmValid() in SmmMemLib? Then we can remove IsAddressValid() completely. Thank you Yao Jiewen -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 16, 2015 6:18 PM To:

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, December 16, 2015 5:30 AM > To: Alcantara, Paulo > Cc: edk2-devel@lists.01.org; Carsey, Jaben

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 17:37, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > Committed as SVN r19304 Thanks >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Wednesday, December 16, 2015 5:30

[edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
Unfortunately, Clang does not support the use of symbol references in .org directives, and bails with the following error message when it encounters them: <...>:error: expected assembly-time absolute expression .org DebugAgentVectorTable + 0x000 So replace the .org arguments with absolute

[edk2] [Patch] NetworkPkg: Correct gEfiUdp4ProtocolGuid usage in DnsDxe

2015-12-16 Thread Liming Gao
DnsDxe driver locates gEfiUdp4ProtocolGuid. Its usage should be TO_START. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- NetworkPkg/DnsDxe/DnsDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [Patch] EdkCompatibilityPkg: Fix wrong guid value of gEfiManagedNetworkProtocolGuid

2015-12-16 Thread Liming Gao
UEFI2.1B corrects the guid value of gEfiManagedNetworkProtocolGuid. ECP package updates its value in ManagedNetwork.h, but miss the one in EdkIIGlueLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

Re: [edk2] [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well

2015-12-16 Thread Ye, Ting
Reviewed by: Ye Ting   -Original Message- From: Zhang, Lubo Sent: Wednesday, December 16, 2015 3:26 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well When HttpLib

Re: [edk2] [Patch] NetworkPkg: Correct gEfiUdp4ProtocolGuid usage in DnsDxe

2015-12-16 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 16, 2015 4:38 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] NetworkPkg: Correct gEfiUdp4ProtocolGuid usage in

Re: [edk2] [patch] NetworkPkg:Fix the issue Http boot hang when network failed.

2015-12-16 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Tuesday, December 15, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [patch] NetworkPkg:Fix the issue Http boot hang when network failed. For both IPv4 and

Re: [edk2] [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well

2015-12-16 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Wednesday, December 16, 2015 3:26 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well When HttpLib

Re: [edk2] [patch 2/2] MdeModulePkg/PciSioSerialDxe:bitwise operation have same width operands

2015-12-16 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng Sent: Tuesday, December 15, 2015 8:47 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Tian, Feng Subject: [edk2] [patch 2/2]

Re: [edk2] [patch 1/2] MdeModulePkg/PciSioSerialDxe:add non-null pointer dereference assertion

2015-12-16 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng Sent: Tuesday, December 15, 2015 8:47 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Tian, Feng Subject: [edk2] [patch 1/2]

Re: [edk2] [patch 0/2] Fix two issues in PciSioSerialDxe

2015-12-16 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng Sent: Tuesday, December 15, 2015 8:47 AM To: edk2-devel@lists.01.org Subject: [edk2] [patch 0/2] Fix two issues in PciSioSerialDxe There are

Re: [edk2] [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well

2015-12-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Lubo Sent: Wednesday, December 16, 2015 3:26 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin Subject: [patch]

[edk2] [PATCH 1/2] BaseTools CLANG35: use -target in PP flags as well

2015-12-16 Thread Ard Biesheuvel
The Clang preprocessor may rely on builtin defines that are target dependent, so we should add the -target argument also when invoking the preprocessor directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 2/2] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-16 Thread Ard Biesheuvel
Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [Patch 2/3] DuetPkg: Fix GCC error to avoid the duplicated global variable in SmbiosGenDxe

2015-12-16 Thread Liming Gao
Update SmbiosGenDxe to use UefiHiiServicesLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- DuetPkg/SmbiosGenDxe/SmbiosGen.c | 11 --- DuetPkg/SmbiosGenDxe/SmbiosGen.h | 1 + DuetPkg/SmbiosGenDxe/SmbiosGen.inf | 1 + 3

[edk2] [Patch 1/3] DuetPkg: Fix GCC error to avoid the duplicated global variables in EfiLdr

2015-12-16 Thread Liming Gao
Move the global variable definitions into source code instead of head filer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- DuetPkg/EfiLdr/EfiLdr.h| 3 --- DuetPkg/EfiLdr/EfiLoader.c | 3 +++ 2 files changed, 3 insertions(+), 3

[edk2] [Patch 0/3] Fix GCC error to avoid the duplicated global variables

2015-12-16 Thread Liming Gao
GCC adds the compiler options to detect the duplicated global variables. Update the below modules to avoid it and pass GCC build. Liming Gao (3): DuetPkg: Fix GCC error to avoid the duplicated global variables in EfiLdr DuetPkg: Fix GCC error to avoid the duplicated global variable in