Re: [edk2] [PATCH 00/35] remove unused but set variables

On 2016/3/24 18:36, Laszlo Ersek wrote: This series removes unused but set variables from edk2, so that the source builds after Ard's patch (the last one in this series) lets -Wunused-but-set-variables take effect for GCC DEBUG builds. I used the following method for locating these warnings: *

[edk2] [PATCH 30/35] SourceLevelDebugPkg: DebugAgentCommon: remove set but unused variables

Cc: Jeff Fan Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[edk2] [PATCH 23/35] QuarkSocPkg: QNCInit/Dxe: remove set but unused variables

This patch also eliminates a PCI config space access, but that should be fine. Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 13/35] MdeModulePkg: BootManagerMenuApp: remove set but unused variables

Cc: Feng Tian Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c | 2 -- 1 file

[edk2] [PATCH 18/35] OptionRomPkg: FtdiUsbSerialDxe: remove set but unused variables

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH 29/35] QuarkSocPkg: Ohci/Pei: remove set but unused variables

Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c | 10 --

[edk2] [PATCH 19/35] QuarkSocPkg: IntelQNCLib: remove set but unused variables

This patch also removes a few PCI config space accesses, but that shouldn't be a problem. Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 26/35] QuarkSocPkg: Spi/Common: remove set but unused variables

Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkNorthCluster/Spi/Common/SpiCommon.c | 23 1 file changed,

[edk2] [PATCH 17/35] NetworkPkg: IpSecDxe: remove set but unused variables

Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- NetworkPkg/IpSecDxe/Ikev2/Utility.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH 21/35] QuarkSocPkg: QNCSmmLib: remove set but unused variables

This patch also removes a PcdGet16() call, but that should be harmless. Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 25/35] QuarkSocPkg: SmmControlPei: remove set but unused variables

Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmControlPei/SmmControlPei.c | 4 +--- 1 file changed, 1

[edk2] [PATCH 16/35] MdeModulePkg: DeviceManagerUiLib: remove set but unused variables

Cc: Feng Tian Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 -- 1 file changed, 2

[edk2] [PATCH 32/35] UefiCpuPkg/MtrrLib: remove unused but set variable

From: Ard Biesheuvel Remove variable TempQWord that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 28/35] QuarkSocPkg: Ohci/Dxe: remove set but unused variables

Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c| 9 -

[edk2] [PATCH 31/35] SourceLevelDebugPkg: DebugCommunicationLibUsb: remove set but unused variables

Cc: Jeff Fan Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c | 14 +- 1 file changed, 1

[edk2] [PATCH 15/35] MdeModulePkg: BootMaintenanceManagerUiLib: remove set but unused variables

Cc: Feng Tian Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 6 --

[edk2] [PATCH 14/35] MdeModulePkg: UfsPassThruDxe: remove set but unused variables

Cc: Feng Tian Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c| 4

[edk2] [PATCH 22/35] QuarkSocPkg: MemoryInit/Pei: remove set but unused variable TRFC

The expression that was used to set it had no side effects. Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 34/35] UefiCpuPkg: CpuMpPei: remove set but unused variables

Cc: Jeff Fan Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[edk2] [PATCH 35/35] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

From: Ard Biesheuvel This aligns the GCC definitions for 4.6 and up to align with the ARM and AARCH64 definitions, which is to ignore unused but set variables only on RELEASE builds. This allows us to find instances of unused variables that are left behind after

[edk2] [PATCH 33/35] UefiCpuPkg: PiSmmCpuDxeSmm: remove set but unused variables

Cc: Jeff Fan Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 34 +++- 1 file changed, 11 insertions(+), 23

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

Pushed at a7b15909e8a6dd221944d87f51b689e633308199. Thanks for the contribution. Star On 2016/3/24 8:48, Tian, Feng wrote: Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Thursday, March 24, 2016 8:44 AM To: Alcantara, Paulo

[edk2] [PATCH 10/35] IntelFrameworkModulePkg: LegacyBootMaintUiLib: remove set but unused variables

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 16 1 file changed, 16 deletions(-) diff --git

[edk2] [PATCH 00/35] remove unused but set variables

This series removes unused but set variables from edk2, so that the source builds after Ard's patch (the last one in this series) lets -Wunused-but-set-variables take effect for GCC DEBUG builds. I used the following method for locating these warnings: * "-Werror" was temporarily removed; * I

[edk2] [PATCH 11/35] IntelFspWrapperPkg: PeiFspHobProcessLibSample: remove set but unused variables

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelFspWrapperPkg/Library/PeiFspHobProcessLibSample/FspHobProcessLibSample.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[edk2] [PATCH 07/35] EmulatorPkg: CpuRuntimeDxe: remove set but unused variables

Cc: Jordan Justen Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- EmulatorPkg/CpuRuntimeDxe/Cpu.c | 9 - 1 file changed, 9 deletions(-) diff --git

[edk2] [PATCH 08/35] IntelFrameworkModulePkg: BiosVideo: remove set but unused variable

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[edk2] [PATCH 06/35] EdkCompatibilityPkg: SmmBaseHelper: remove set but unused variables

This patch also eliminates an AsmReadCr3() call in PageFaultHandler(), but that should not be a problem. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 12/35] MdeModulePkg/PciHostBridgeDxe: remove unused but set variables

From: Ard Biesheuvel Remove variables that are declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 03/35] EdkCompatibilityPkg: UefiEfiIfrSupportLib: remove set but not used variables

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c | 4

[edk2] [PATCH 01/35] CorebootPayloadPkg: FbGop: remove set but unused variables

Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- CorebootPayloadPkg/FbGop/FbGop.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-)

[edk2] [PATCH 09/35] IntelFrameworkModulePkg: DxeCapsuleLib: remove set but unused variables

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelFrameworkModulePkg/Library/DxeCapsuleLib/DxeCapsuleLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH 02/35] CorebootPayloadPkg: PlatformBdsLib: remove set but unused variables

Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- CorebootPayloadPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 -- 1 file changed, 2 deletions(-) diff

[edk2] [PATCH 04/35] EdkCompatibilityPkg: BsSerialStatusCode: remove set but unused variable

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- EdkCompatibilityPkg/Sample/Platform/Generic/RuntimeDxe/StatusCode/Lib/BsSerialStatusCode/BsSerialStatusCode.c | 4 1 file changed, 4

[edk2] [PATCH 05/35] EdkCompatibilityPkg: EdkIIGlueLib: remove set but unused variables

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- EdkCompatibilityPkg/Foundation/Library/EdkIIGlueLib/Library/DxePerformanceLib/PerformanceLib.c | 5 - 1 file changed, 5 deletions(-) diff --git

[edk2] [PATCH 27/35] QuarkSocPkg: SDMediaDeviceDxe: remove set but unused variables

Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDMediaDeviceDxe/CEATA.c | 3 ---

[edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

During real world testing I was getting an error with too many entries in db and dbx. This occurs because we don't set the maximum authenticated variable size, so it inherits this from the maximum variable size, which is 8192. This allows for about 6 reasonably sized X509 keys. Increase to the

Re: [edk2] [PATCH 00/35] remove unused but set variables

On 24 March 2016 at 11:36, Laszlo Ersek wrote: > This series removes unused but set variables from edk2, so that the > source builds after Ard's patch (the last one in this series) lets > -Wunused-but-set-variables take effect for GCC DEBUG builds. > > I used the following

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

Hi Ruiyu, I had seen the other comments and I just needed more time to think about them :) Please see my comments below. On 03/24/2016 03:26 PM, Ni, Ruiyu wrote: Heyi, I had 7 comments in previous mail. I guess you may miss the other comments. What Timer driver are you using? How many

Re: [edk2] [PATCH 00/35] remove unused but set variables

On 03/24/16 14:35, Ard Biesheuvel wrote: > On 24 March 2016 at 11:36, Laszlo Ersek wrote: >> Maintainers are invited to exert caution while reviewing the patches. >> Namely, in a few cases, the silencing is almost certainly wrong, and >> should be replaced with proper error

Re: [edk2] [PATCH 00/35] remove unused but set variables

Laszlo: Reviewed-by: Liming Gao for the patches in EdkCompatibilityPkg. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01

[edk2] BUG : Firmware don't recognize flash

Hi, I use MinnowBoard Max board revision A2. On MinnowBoard Max we changed SMD IC flash part ( Winbond W25Q64FW ). On that board we test firmware 0.90 version which we download from intel-web. Also we tested other version. On that board work 0.78, 0.79, 0.80, 0.81 versions, but 0.82, 0.83, 0.84,

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

On 25 March 2016 at 03:52, Ni, Ruiyu wrote: > Heyi, > I was not able to remove the blue bar in the beginning of every line if I > embedded my reply. > So I will directly write down here. > > > 1. I would like to know in what circumstance the key loss happens. > Because

Re: [edk2] Error while loading a symbol file (No Debug Directory)

On 25 March 2016 at 01:48, Vladimir Olovyannikov wrote: > Hi Ard, > > Thank you for the hint. > Here is the result of git bisection (first bad): > > Author: Cohen, Eugene 2016-03-07 07:16:35 > Committer: Ard Biesheuvel

Re: [edk2] [PATCH 35/35] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

On 25 March 2016 at 00:19, Jordan Justen wrote: > On 2016-03-24 03:37:24, Laszlo Ersek wrote: >> From: Ard Biesheuvel >> >> This aligns the GCC definitions for 4.6 and up to align with the ARM and >> AARCH64 definitions, which is to ignore

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

On 03/24/16 17:03, James Bottomley wrote: > On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote: >> Either way, I think all flash sizes are finite in practice, so we >> shouldn't be trying to increase PcdMaxAuthVariableSize specifically >> for dbx's sake. For enrolling whitelist-like stuff

[edk2] [PATCH v2] OvmfPkg: Increase the maximum size for Authenticated variables

During real world testing I was getting an error with too many entries in db: On my Secure boot laptop, I currently have seven certificates: two Microsoft ones, Three Kernel ones from various distributions, my own Secure Key and a temporary test key. That gives a total EFI Signature List size of

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

On Thu, 2016-03-24 at 17:19 +0100, Laszlo Ersek wrote: > On 03/24/16 17:03, James Bottomley wrote: > > On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote: > > > > Either way, I think all flash sizes are finite in practice, so we > > > shouldn't be trying to increase PcdMaxAuthVariableSize > >

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

On 03/24/16 15:47, James Bottomley wrote: > During real world testing I was getting an error with too many entries > in db and dbx. This occurs because we don't set the maximum > authenticated variable size, so it inherits this from the maximum > variable size, which is 8192. This allows for

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote: [...] > Note that OVMF has ~56 KB for variable store (0xe000, see > NV_VARIABLE_STORE in "OvmfPkg/VarStore.fdf.inc"). Do we really need > to allow a single authenticated variable to grow as big as 32KB? > > I think I've discussed this

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

(tangent) On 03/24/16 17:25, James Bottomley wrote: > Heh, I've seen too many cockups with git-send-email on the kernel > mailing list ever to want to use it myself. If you use git show and > your regular email tool, you always know what you're sending. Perhaps unexpectedly, but this even

Re: [edk2] [PATCH v2] OvmfPkg: Increase the maximum size for Authenticated variables

On 03/24/16 17:30, James Bottomley wrote: > During real world testing I was getting an error with too many entries > in db: On my Secure boot laptop, I currently have seven certificates: > two Microsoft ones, Three Kernel ones from various distributions, my > own Secure Key and a temporary test

[edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit pointers

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- ArmPlatformPkg/ArmPlatformPkg.dec| 6 +++--- ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 2 +-

[edk2] [PATCH] MdeModulePkg: support for ACPI tables only above 4GB's

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- MdeModulePkg/MdeModulePkg.dec | 6 .../Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | 3 +-

[edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit mailbox pointers

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 -- ArmPlatformPkg/PrePi/MainMPCore.c | 10 -- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH] EmbeddedPkg: fixups for 64-bit pointers

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH] ArmPkg: apply A57 errata

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- ArmPkg/Drivers/ArmCpuLib/ArmCortexA5xLib/ArmCortexA5xLib.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[edk2] [PATCH] EmbeddedPkg/RTC: use returned status at init-time

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c

[edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 88 +- .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 1 +

[edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- ArmPkg/ArmPkg.dec| 4 ++-- ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 4 ++-- 2 files changed, 4

Re: [edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Reviewed-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix GUID reference

Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Palmer, Thomas Sent: Thursday, March 24, 2016 5:05 PM To: edk2-devel@lists.01.org Cc: jaben.car...@intel.com; shumin@intel.com; El-Haj-Mahmoud, Samer ; Ard Biesheuvel

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix GUID reference

I need a review on this patch. Thomas -Original Message- From: Palmer, Thomas Sent: Wednesday, March 9, 2016 1:19 PM To: edk2-devel@lists.01.org Cc: jaben.car...@intel.com; shumin@intel.com; El-Haj-Mahmoud, Samer ; Palmer, Thomas

Re: [edk2] [PATCH] EmbeddedPkg: fixups for 64-bit pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran This patch needs to be merged with the patch that changes the type of the

Re: [edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran As mentioned in response to the EmbeddedPkg patch that changes to 64-bit

Re: [edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit mailbox pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran > --- > ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 -- > ArmPlatformPkg/PrePi/MainMPCore.c | 10 -- > 2

Re: [edk2] [PATCH 35/35] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

On 2016-03-24 03:37:24, Laszlo Ersek wrote: > From: Ard Biesheuvel > > This aligns the GCC definitions for 4.6 and up to align with the ARM and > AARCH64 definitions, which is to ignore unused but set variables only on > RELEASE builds. This allows us to find instances

Re: [edk2] [PATCH] ArmPkg: apply A57 errata

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Hi Leo, Thanks for the patches. I will respond to the patches

Re: [edk2] [PATCH] MdeModulePkg: support for ACPI tables only above 4GB's

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran I already fixed this issue upstream. Please refer to f9bbb8d9c3f0

Re: [edk2] [PATCH] ArmPkg: apply A57 errata

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Reviewed-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH] BaseTools: fixups to get rid of compiler warnings

(+ Yonghong, Liming) On 24 March 2016 at 21:30, Leo Duran wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran > --- > BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 18 +- >

Re: [edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

-Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, March 24, 2016 4:13 PM To: Duran, Leo Cc: edk2-devel@lists.01.org; Leif Lindholm; Leendert van Doorn Subject: Re: [PATCH] ArmPkg: fixups for 64-bit pointers On 24 March 2016 at 21:30, Leo Duran

Re: [edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran The presence of this patch suggests that you are copying the vector table

Re: [edk2] [PATCH] BaseTools: fixups to get rid of compiler warnings

On 03/24/16 22:16, Ard Biesheuvel wrote: > (+ Yonghong, Liming) > > On 24 March 2016 at 21:30, Leo Duran wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Leo Duran >> --- >>

Re: [edk2] [PATCH] EmbeddedPkg/RTC: use returned status at init-time

On 24 March 2016 at 21:30, Leo Duran wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Reviewed-by: Ard Biesheuvel > --- > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 -

Re: [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'.

On 23 March 2016 at 16:42, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: Qiu, Shumin >> Sent: Tuesday, March 22, 2016 1:36 AM >> To: edk2-devel@lists.01.org >> Cc: Carsey, Jaben

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

On 03/24/2016 10:47 AM, Ni, Ruiyu wrote: Regards, Ray -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 9:09 AM To: Ryan Harkin ; Laszlo Ersek Cc: Ni, Ruiyu ; Tian, Feng

[edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

This is a followup to Laszlo's post a couple of days ago. I fixed a couple of occurrences where the new GCC flags in patch #4 cause build errors, but since Laszlo mentioned 33 patches and counting, there may be other instances that need to be fixed before #4 can be considered for merging. The

[edk2] [PATCH 1/4] MdeModulePkg/PciHostBridgeDxe: remove unused but set variables

Remove variables that are declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 4/4] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

This aligns the GCC definitions for 4.6 and up to align with the ARM and AARCH64 definitions, which is to ignore unused but set variables only on RELEASE builds. This allows us to find instances of unused variables that are left behind after refactoring. It also allows us to find bad new code,

[edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: remove unused but set variable

Remove variable TempQWord that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

Remove variable FStartRow that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [patch] NetworkPkg:Fix bug when parsing the dhcp6 option 16

Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Thursday, March 24, 2016 4:46 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [patch]

Re: [edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

On 24 March 2016 at 09:11, Laszlo Ersek wrote: > On 03/24/16 07:45, Ard Biesheuvel wrote: >> On 24 March 2016 at 07:41, Gao, Liming wrote: >>> Ard: >>> Thanks for your contribution. I agree to enable this warning in DEBUG >>> only. Reviewed-by: Liming

Re: [edk2] [patch] NetworkPkg:Fix bug when parsing the dhcp6 option 16

Reviewed-by: Hegde, Nagaraj P -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, March 24, 2016 2:16 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan

Re: [edk2] [PATCH 00/35] remove unused but set variables

MdeModulePkg series reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01 Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen,

Re: [edk2] [PATCH] OvmfPkg: Increase the maximum size for Authenticated variables

Hi On 2016/3/24 23:51, Laszlo Ersek wrote: On 03/24/16 15:47, James Bottomley wrote: During real world testing I was getting an error with too many entries in db and dbx. This occurs because we don't set the maximum authenticated variable size, so it inherits this from the maximum variable

Re: [edk2] [PATCH v2] OvmfPkg: Increase the maximum size for Authenticated variables

Hi, Comments below, with that updated, you can have my R-b. From now, low response as out of office today. On 2016/3/25 1:31, Laszlo Ersek wrote: On 03/24/16 17:30, James Bottomley wrote: During real world testing I was getting an error with too many entries in db: On my Secure boot laptop,

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix GUID reference

Reviewed-by: Qiu Shumin -Original Message- From: Thomas Palmer [mailto:thomas.pal...@hpe.com] Sent: Thursday, March 10, 2016 3:19 AM To: edk2-devel@lists.01.org Cc: Carsey, Jaben; Qiu, Shumin; samer.el-haj-mahm...@hpe.com; Thomas Palmer Subject: [PATCH]

Re: [edk2] [PATCH 15/35] MdeModulePkg: BootMaintenanceManagerUiLib: remove set but unused variables

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 15/35]

Re: [edk2] [PATCH 16/35] MdeModulePkg: DeviceManagerUiLib: remove set but unused variables

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 16/35]

Re: [edk2] [PATCH v2] OvmfPkg: Increase the maximum size for Authenticated variables

On Thu, 2016-03-24 at 18:31 +0100, Laszlo Ersek wrote: > On 03/24/16 17:30, James Bottomley wrote: > > During real world testing I > > was getting an error with too many entries > > in db: On my Secure boot > > laptop, I currently have seven certificates: > > two Microsoft ones, Three > > Kernel

Re: [edk2] [patch] NetworkPkg:Fix bug when parsing the dhcp6 option 16

Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Lubo > Sent: Thursday, March 24, 2016 4:46 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [patch]

Re: [edk2] [PATCH 00/35] remove unused but set variables

Good code clean-up. For OptionRomPkg and DuetPkg, Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Thursday, March 24, 2016 6:37 PM >To: edk2-devel-01 >Cc:

Re: [edk2] Is EsrtDxe broken?

Felix： SyncEsrtFmp & LockEsrtRepository are called by Bds by design, as only Bds has the knowledge whether Connect All happens and is the right point to sync ESRT table with FMP instances. So there are generally 2 paths in BDS 1. Normal Boot--> LockEsrtRepository 2. Connect All Boot -->

Re: [edk2] [PATCH 17/35] NetworkPkg: IpSecDxe: remove set but unused variables

Thanks Laszlo, it's good to me. Reviewed-by: Jiaxin Wu > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

On 03/24/16 07:28, Ard Biesheuvel wrote: > Remove variable FStartRow that is declared, assigned but never referenced. > This fixes a warning emitted by GCC when -Wunused-but-set-variable is in > effect. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: remove unused but set variable

On 03/24/16 07:28, Ard Biesheuvel wrote: > Remove variable TempQWord that is declared, assigned but never referenced. > This fixes a warning emitted by GCC when -Wunused-but-set-variable is in > effect. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 4/4] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

On 03/24/16 07:28, Ard Biesheuvel wrote: > This aligns the GCC definitions for 4.6 and up to align with the ARM and > AARCH64 definitions, which is to ignore unused but set variables only on > RELEASE builds. This allows us to find instances of unused variables that > are left behind after

Re: [edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

On 03/24/16 07:45, Ard Biesheuvel wrote: > On 24 March 2016 at 07:41, Gao, Liming wrote: >> Ard: >> Thanks for your contribution. I agree to enable this warning in DEBUG >> only. Reviewed-by: Liming Gao for this serials. >> > > Thanks Liming. > >

  1   2   >