Re: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

Looks good. Are you planning on committing this code? I have a few updates I would like to send for review, but they need the initial patches to be committed first. Series reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Jiaxin Wu

Re: [edk2] [PATCH 4/4] ArmVirtPkg/VirtFdtDxe: drop PCI host bridge handling

On 12 April 2016 at 18:10, Laszlo Ersek wrote: > On 04/12/16 15:47, Ard Biesheuvel wrote: >> Now that the PCI host bridge driver parses the DT node that describes >> the PCI host bridge directly via the FDT client protocol, we can drop the >> handling from VirtFdtDxe

Re: [edk2] TCPIP Client for UEFI

Jim, I think your only recourse is to contact the who provided the SOC board and ask about how to rebuild the UEFI bootloader image for that board. Then look at those instructions to see how to enable the network stack. Good luck, Patrick From:

Re: [edk2] [Patch 5/6] Vlv2TbltDevicePkg: Reference the PCD defined in MdeModulePkg

It is good for me. Reviewed-by: zwei4 Thanks, David Intel SSG BIOS -Original Message- From: Ni, Ruiyu Sent: Monday, April 11, 2016 3:47 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Wei, David Subject: [Patch 5/6]

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On 05/04/16 03:10, Dong, Eric wrote: > >> On a separate but related note: The ConfigHdr portion of Request and > >> Response seems to contain absolutely zero information by the time it > >> reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is > >> meaningful only to

Re: [edk2] [Patch 3/3] MdeModulePkg: Update Guid/Protocol usages in INF files.

Liming, Some comments below. On 2016/4/7 14:54, Liming Gao wrote: Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../Library/VarCheckUefiLib/VarCheckUefiLib.inf| 78 +++---

[edk2] [Patch] NetworkPkg: Fix issue in Ip6Dxe SetData

EFI_NOT_READY should not be treated as an error status returned from SetData for Ip6ConfigDataTypeManualAddress since there is an asynchronous operation for DAD process. Cc: Ye Ting Cc: Fu Siyuan Cc: Hegde Nagaraj P

Re: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

HPE verified both https boot (with dhcp handshake) and https download from a url to work, but with a hard coded certificate (not using the variable yet). I think PEER cert validation is working, but not the timestamp check. We are. looking at that tomorrow. There might be a few changes needed

[edk2] [patch 1/3] MdeModulePkg/Sd: Fix wrong response type of SD Deselect cmd

The SD CMD7 deselect cmd have no response according to SD physical layer simplified spec. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 6 --

[edk2] [patch 2/3] MdeModulePkg/SdMmcPciHc: Reset the slot when sd device is connected

The original code doesn't reset the slot when there is device change. It may bring issue on device identification procedure of some SD cards. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian ---

[edk2] [patch 3/3] MdeModulePkg/Sd: wait 1ms before check DATA line in voltage switch proc

According to SD Host Controller 3.0 spec figure 3-10, we have to wait 1ms before checking DAT[3:0] in voltage switch proc Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian ---

[edk2] [patch 0/3] Fix some bugs found in EDKII SD/MMC stack

this series is used to fix some bugs found with some sd cards Feng Tian (3): MdeModulePkg/Sd: Fix wrong response type of SD Deselect cmd MdeModulePkg/SdMmcPciHc: Reset the slot when sd device is connected MdeModulePkg/Sd: wait 1ms before check DATA line in voltage switch proc

Re: [edk2] [Patch] NetworkPkg: Fix issue in Ip6Dxe SetData

Thanks Jiaxin for the quick fix. Code looks fine. Reviewed-by: Sriram Subramanian We'll also test it and let you know. Thanks, Sriram. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Wednesday, April 13, 2016

[edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

This patch is used to update ping command options to sync with shell2.2 Spec. Considering the backward compatible issue, the patch keeps ‘-_s’ command option unchanged, only add the new option '-s' and make the old option '-_s' function same as new one. Cc: Ye Ting Cc: Fu

[edk2] BaseTools: fix PLATFORM_DIR variable value for multiple workspace

when enable the multiple workspace, the PLATFORM_DIR still is $(WORKSPACE)\AnyPkg, even though it is in a PACKAGES_PATH folder. this patch fix this issue to use the real path. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [Patch] NetworkPkg: Fix issue in Ip6Dxe SetData

Reviewed-by: Hegde Nagaraj P Tested-by: Hegde Nagaraj P -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Subramanian, Sriram (EG Servers Platform SW) Sent: Wednesday, April 13, 2016 8:54 AM To:

[edk2] [PATCH v2] ShellPkg : Cache the environment variable into memory to enhance the performance.

Currently UEFI Shell reads variable storage to get the environment variables every time running a new command. And reading(writing) UEFI variables is a high cost operation on most platforms. In order to enhance the performance this patch read the variable storage once and cache the environment

Re: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

That's fine, but whether commit to the newly proposed branches in github or not, I'm not sure since there is no final conclusion for that currently. Thanks your feedback again. From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, April 13, 2016 10:16 AM To:

Re: [edk2] [Patch 1/3] SecurityPkg: Update protocol usage in module INF files.

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Thursday, April 07, 2016 2:54 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [Patch 1/3] SecurityPkg: Update protocol usage in module INF files.

[edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

On ARM, manipulating live page tables is cumbersome since the architecture mandates the use of break-before-make, i.e., replacing a block entry with a table entry requires an intermediate step via an invalid entry, or TLB conflicts may occur. Since it is not generally feasible to decide in the

[edk2] [PATCH] MdePkg: Add EFI Erase Block Protocol definitions

This protocol is newly introduced in UEFI 2.6 spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Include/Protocol/EraseBlock.h | 105 +++ MdePkg/MdePkg.dec| 3 + 2 files

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

On 11 April 2016 at 21:14, Laszlo Ersek wrote: > On 04/11/16 18:22, Ard Biesheuvel wrote: >> On 11 April 2016 at 16:50, Laszlo Ersek wrote: >>> On 04/11/16 16:34, Ard Biesheuvel wrote: On 11 April 2016 at 16:12, Laszlo Ersek wrote:

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

On 04/12/16 12:10, Ard Biesheuvel wrote: > On 11 April 2016 at 21:14, Laszlo Ersek wrote: >> * Can you please submit a separate patch that removes >> PcdPciExpressBaseAddress from "ArmVirtPkg/ArmVirtXen.dsc"? >> > > Well, this patch needs to wait after the PCI references

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Correct the ReallocatePool size

Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

Allow EfiVarStore to get from Hii Driver, and enhance code logic in MergeDefaultString function to get a full AltCfgResp. The logic in function MergeDefaultString after enhancement: (1) If there are no in AltCfgResp, merge the in DefaultAltCfgResp to AltCfgResp. (2)If there are in AltCfgResp,

Re: [edk2] [PATCH v2] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

On Mon, Apr 11, 2016 at 06:50:06PM +0200, Ard Biesheuvel wrote: > On 11 April 2016 at 18:47, Mark Rutland wrote: > > On Mon, Apr 11, 2016 at 06:08:29PM +0200, Ard Biesheuvel wrote: > >> +//VOID > >> +//ArmReplaceLiveTranslationEntry ( > >> +// IN UINT64 *Entry, > >> +//

[edk2] [PATCH] PerformancePkg: Make Dp print help information with -? flag in Shell.

Since Shell supports finding help information from resource section of application image. We enhance the Dp to add help information string. After the Dp are loaded in system the help string will be stored in resource section of the application image. Cc: Ruiyu Ni Cc: Jaben

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

On 11 April 2016 at 21:14, Laszlo Ersek wrote: > On 04/11/16 18:22, Ard Biesheuvel wrote: >> On 11 April 2016 at 16:50, Laszlo Ersek wrote: >>> On 04/11/16 16:34, Ard Biesheuvel wrote: On 11 April 2016 at 16:12, Laszlo Ersek wrote:

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

On 04/12/16 12:51, Dandan Bi wrote: > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > + // ::=�OFFSET=��=�=�. > +// ::= �=� | �=�. > +// ::=�OFFSET=��=�=� > style. > +// ::= �=� | �=� style.

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

On 04/12/16 12:59, Laszlo Ersek wrote: > I wonder what a good name could be, for this new plugin lib. > PciPcdProducerLib? Maybe stick in a reference to "Fdt" as well... Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] 答复: 答复: [EDK2]an issue that PXE boot failed when received a NACK from the DHCP server

On 06/04/16 14:39, Liuxilong (A) wrote: Multiple boards connect to the DHCP server through a switch . The MAC of each board is the same and building VLAN through the switch to isolate each board. Don't do that. Use a unique MAC address for each board. If I understand you correctly,

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 05/04/16 03:10, Dong, Eric wrote: On a separate but related note: The ConfigHdr portion of Request and Response seems to contain absolutely zero information by the time it reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is meaningful only to EFI_HII_CONFIG_ROUTING_PROTOCOL

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

On 04/12/16 12:15, Ard Biesheuvel wrote: > On 11 April 2016 at 21:14, Laszlo Ersek wrote: >> * Patch >> >> 8528ac9292e4 ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol >> >> also looks mostly good. Some comments: >> >> - Please fix a typo in the commit message:

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 01/04/16 21:41, Laszlo Ersek wrote: I am (and was) aware of "MdeModulePkg/Universal/DriverSampleDxe", the same driver that Eric recommended as an example in this thread earlier. In my opinion, that driver is supremely over-sized and -cluttered to be usable as a learning tool. I'm glad

Re: [edk2] [PATCH 1/4] ArmVirtPkg: implement FdtPciPcdProducerLib

On 04/12/16 16:16, Laszlo Ersek wrote: > [...] Aargh, ignore this. I forgot to disable word wrapping in tbird, before pasting my reply. I'll resend my reply sanely wrapped. Sorry Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH 1/4] ArmVirtPkg: implement FdtPciPcdProducerLib

On 04/12/16 15:47, Ard Biesheuvel wrote: > This implements a library FdtPciPcdProducerLib which is intended to > be incorporated into modules that consume the PCI related dynamic PCDs > PcdPciExpressBaseAddress and PcdPciDisableBusEnumeration, either via NULL > library class resolution or via a

Re: [edk2] [PATCH 1/4] ArmVirtPkg: implement FdtPciPcdProducerLib

On 04/12/16 15:47, Ard Biesheuvel wrote: > This implements a library FdtPciPcdProducerLib which is intended to > be incorporated into modules that consume the PCI related dynamic PCDs > PcdPciExpressBaseAddress and PcdPciDisableBusEnumeration, either via NULL > library class resolution or via a

Re: [edk2] [PATCH 1/4] ArmVirtPkg: implement FdtPciPcdProducerLib

On 12 April 2016 at 16:18, Laszlo Ersek wrote: > On 04/12/16 15:47, Ard Biesheuvel wrote: >> This implements a library FdtPciPcdProducerLib which is intended to >> be incorporated into modules that consume the PCI related dynamic PCDs >> PcdPciExpressBaseAddress and

[edk2] [PATCH 3/4] ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol

Instead of relying on VirtFdtDxe to populate various dynamic PCDs with information retrieved from the host-provided device tree, perform the PCI ECAM related DT node parsing directly in PciHostBridgeDxe. Since we expect PcdPciExpressBaseAddress to have already been assigned by the time this

[edk2] [PATCH 4/4] ArmVirtPkg/VirtFdtDxe: drop PCI host bridge handling

Now that the PCI host bridge driver parses the DT node that describes the PCI host bridge directly via the FDT client protocol, we can drop the handling from VirtFdtDxe completely. This means some PCI related PCDs are no longer set, such as PcdPciBusMin, PcdPciBusMax, PcdPciIoBase, PcdPciIoSize,

[edk2] [PATCH 0/4] VirtFdtDxe refactoring and removal: the PCI edition

These four patches have been split off from the series 'VirtFdtDxe refactoring and removal' for which I sent out a v2 on Friday. This series deals with the removal of PCI host bridge discovery from VirtFdtDxe in a way that ensures that all dependencies on the various PCDs that VirtFdtDxe sets

[edk2] [PATCH 2/4] ArmVirtPkg/BaseCachingPciExpressLib: depend on PciPcdProducerLib

Make BaseCachingPciExpressLib depend on PciPcdProducerLib, so that we have a chance to populate PcdPciExpressBaseAddress based on the contents of the device tree. Also update the platforms under ArmVirtPkg that support PCI to use this special MAX_UINT64 as the build time default for

[edk2] [PATCH 1/4] ArmVirtPkg: implement FdtPciPcdProducerLib

This implements a library FdtPciPcdProducerLib which is intended to be incorporated into modules that consume the PCI related dynamic PCDs PcdPciExpressBaseAddress and PcdPciDisableBusEnumeration, either via NULL library class resolution or via a direct dependency (for other libraries or modules

Re: [edk2] [PATCH 2/4] ArmVirtPkg/BaseCachingPciExpressLib: depend on PciPcdProducerLib

On 04/12/16 15:47, Ard Biesheuvel wrote: > Make BaseCachingPciExpressLib depend on PciPcdProducerLib, so that we > have a chance to populate PcdPciExpressBaseAddress based on the contents > of the device tree. > > Also update the platforms under ArmVirtPkg that support PCI to use this > special

Re: [edk2] [PATCH 3/4] ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol

On 04/12/16 15:47, Ard Biesheuvel wrote: > Instead of relying on VirtFdtDxe to populate various dynamic PCDs with > information retrieved from the host-provided device tree, perform the > PCI ECAM related DT node parsing directly in PciHostBridgeDxe. > > Since we expect PcdPciExpressBaseAddress to

Re: [edk2] [Patch] QuarkSocPkg: Add /Oi option to let MemoryInit pass build.

Reviewed-by: Michael Kinney > -Original Message- > From: Gao, Liming > Sent: Monday, April 11, 2016 8:04 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: [Patch] QuarkSocPkg: Add /Oi option to let MemoryInit

Re: [edk2] [PATCH 3/4] ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol

On 12 April 2016 at 17:41, Laszlo Ersek wrote: > On 04/12/16 15:47, Ard Biesheuvel wrote: >> Instead of relying on VirtFdtDxe to populate various dynamic PCDs with >> information retrieved from the host-provided device tree, perform the >> PCI ECAM related DT node parsing

Re: [edk2] [PATCH 3/4] ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol

On 04/12/16 17:59, Ard Biesheuvel wrote: > On 12 April 2016 at 17:41, Laszlo Ersek wrote: >> On 04/12/16 15:47, Ard Biesheuvel wrote: >>> Instead of relying on VirtFdtDxe to populate various dynamic PCDs with >>> information retrieved from the host-provided device tree, perform

Re: [edk2] [PATCH 4/4] ArmVirtPkg/VirtFdtDxe: drop PCI host bridge handling

On 04/12/16 15:47, Ard Biesheuvel wrote: > Now that the PCI host bridge driver parses the DT node that describes > the PCI host bridge directly via the FDT client protocol, we can drop the > handling from VirtFdtDxe completely. > > This means some PCI related PCDs are no longer set, such as