[edk2] Sending command to SAS devices

2016-10-13 Thread Rafael Machado
Hi everyone I'm trying to send a command to a SAS (serial attached scsi) storage device to retrieve some SMART information, but I'm facing some problems that maybe you can give me some light. During a research about how does the SAS devices work I faced this specification:

[edk2] [shell] Problems in EfiShellGetGuidFromName

2016-10-13 Thread Tim Lewis
In EfiShellGetGuidFromName (ShellProtocol.c), we see: EfiShellGetGuidFromName( IN CONST CHAR16 *GuidName, OUT EFI_GUID *Guid ) { EFI_GUID*NewGuid; EFI_STATUS Status; if (Guid == NULL || GuidName == NULL) { return (EFI_INVALID_PARAMETER); } Status =

[edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
In using AsciiPrint (I'm presuming the behavior is also in Print, but I haven't tested), I found an interesting behavior for linefeed characters embedded in strings that are parameters. I post it here just so people who are mystified by their output can understand it. Consider this example:

Re: [edk2] SmmCommunicationCommunicate question?

2016-10-13 Thread Ken Taylor
I think there are a couple of assumptions here that should be reconsidered... First, it is not always the case that entry into SMM on one CPU will always pull all CPUs into SMM. There are methods to deliver targeted SMIs via the local APIC on some processors. In addition, I have 2nd hand

Re: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

2016-10-13 Thread Mudusuru, Giri P
Yes Star thanks for catching the merge issue. Will fix it before check-in. Thanks, -Giri > -Original Message- > From: Zeng, Star > Sent: Thursday, October 13, 2016 9:25 PM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org > Cc: Kinney, Michael D

Re: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

2016-10-13 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, October 13, 2016 10:11 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Kinney, Michael D > > Subject: [edk2] [PATCH] IntelSiliconPkg:

Re: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

2016-10-13 Thread Zeng, Star
Shouldn't +#include SmBios.h be +#include ? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Giri P Mudusuru Sent: Thursday, October 13, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ;

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Gao, Liming
Tim: The first parameter in AsciiPrint() is the Format string. Per PrintLib.h definition, \n will be changed to \r\n in the format string. The following end of line(EOL) translations must be performed on the contents of the format string: - '\\r' is translated to '\\r' - '\\r\\n'

Re: [edk2] [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.

2016-10-13 Thread Ni, Ruiyu
Please remove the ending back-slash in following lines. They are not needed. + while (MaxSize >= sizeof (EFI_DEVICE_PATH_PROTOCOL) && \ +(MaxSize - sizeof (EFI_DEVICE_PATH_PROTOCOL) >= Size) && \ +!IsDevicePathEnd (DevicePath)) { With the above changes, Reviewed-by: Ruiyu Ni

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
Liming -- And I agree that this should be the behavior. I was surprised by the lack of translation for the other string printed via %s. Tim -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, October 13, 2016 6:24 PM To: Tim Lewis ;

Re: [edk2] [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT

2016-10-13 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Ye, Ting > Sent: Thursday, September 29, 2016 1:59 PM > To: edk2-devel@lists.01.org > Cc: Subramanian; Sriram ; Fu, Siyuan > ; Zhang, Lubo > Subject:

[edk2] [Patch] BaseTools: support PCD value to use expression in the DEC file

2016-10-13 Thread Yonghong Zhu
This patch add the support for Pcd value to use expression in the DEC file. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Misc.py | 57

[edk2] [Patch] BaseTools: PatchCheck to align with wiki and report error for EFI_D_*

2016-10-13 Thread Yonghong Zhu
This patch updates PatchCheck.py: 1.Update max line length to 70 that describe in wiki 2.remove the two [] when do the char count calculation 3.report error for EFI_D_* macro if it is used, recommend to use DEBUG_* format. Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] Format a volume in UEFI (or delete all files)

2016-10-13 Thread Laszlo Ersek
On 10/13/16 03:29, GN Keshava wrote: > Thanks Laszlo. > > Is it possible to run RM (or any shell command) from my C application > code? Something like "System()" in Linux? Whether we can use LoadImage > for this purpose? Can't say for sure; I'd opt for a separate implementation. Thanks Laszlo

Re: [edk2] [PATCH] Nt32Pkg/WinNtBusDriverDxe: Fix small memory overrun

2016-10-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Thomas Palmer [mailto:thomas.pal...@hpe.com] >Sent: Thursday, October 13, 2016 4:30 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; joseph.shiffl...@hpe.com; Thomas Palmer >

Re: [edk2] Format a volume in UEFI (or delete all files)

2016-10-13 Thread GN Keshava
Got it. Thanks for the help, Laszlo. Regards, Keshava On Thu, 13 Oct 2016 at 14:03 Laszlo Ersek wrote: > On 10/13/16 03:29, GN Keshava wrote: > > Thanks Laszlo. > > > > Is it possible to run RM (or any shell command) from my C application > > code? Something like "System()"

Re: [edk2] SmmCommunicationCommunicate question?

2016-10-13 Thread Anbazhagan, Baraneedharan
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > On 13/10/2016 11:07, Laszlo Ersek wrote: > > > > Instead, once the first CPU enters SMM, it brings all the other CPUs > > into SMM as well, where they will be executing known, secure code -- > > i.e., the

Re: [edk2] SmmCommunicationCommunicate question?

2016-10-13 Thread Paolo Bonzini
On 13/10/2016 11:07, Laszlo Ersek wrote: > > Instead, once the first CPU enters SMM, it brings all the other CPUs > into SMM as well, where they will be executing known, secure code -- > i.e., the first CPU to enter SMM forces the other CPUs to temporarily > abandon any (possibly malicious)