Re: [edk2] [PATCH v2 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, April 24, 2017 1:59 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star Subject: [PATCH v2 2/2] MdeModulePkg/UfsPciHc: Avoid

Re: [edk2] [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes

On 2017-04-24 02:43:08, Leif Lindholm wrote: > Incorrect line endings, trailing spaces and missing line break at end > of file. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > > This addresses only issues found when

Re: [edk2] [MAC HELP] Does Mac has a grubx64.efi ? /

> On Apr 24, 2017, at 5:27 AM, Amit kumar wrote: > > Hi , > > I am trying to boot a mac OS X from the efi shell so i opened the EFI > partition. > As usual there was EFI directory inside which there was APPLE director. > so i went to EFI/APPLE director and found out

Re: [edk2] [MAC HELP] Does Mac has a grubx64.efi ?

Run '/System/Library/CoreServices/boot.efi' (without the quotes) on the macOS root partition, not the ESP. Regards, Marvin. -Ursprüngliche Nachricht- Von: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] Im Auftrag von Amit kumar Gesendet: Montag, 24. April 2017 14:27 An:

[edk2] [ edk2-DecSpecification PATCH 4/4] Declarations not allowed to be both public and private

https://bugzilla.tianocore.org/show_bug.cgi?id=482 Clarify that Includes, Protocols, PPIs, and GUIDs declared in and a DEC file are now allowed to be both public and private. If this condition is detected the build tools must terminate with an error. Cc: Liming Gao Cc:

[edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package

https://bugzilla.tianocore.org/show_bug.cgi?id=465 https://bugzilla.tianocore.org/show_bug.cgi?id=482 GitHub word diff view of the patches in this series * [1/4] https://github.com/mdkinney/edk2-DecSpecification/commit/24a07ae89ef0467c9009633d19d24bb1ba2e115a?w=1 * [2/4]

Re: [edk2] ARM virt machine boots fail with 14 ioh3420

On 2017/4/24 18:16, Marcel Apfelbaum wrote: > On 04/24/2017 01:02 PM, Laszlo Ersek wrote: >> On 04/14/17 04:41, Shannon Zhao wrote: >>> Hi Laszlo, >>> >>> Thanks a lot for your reply:) >>> >>> On 2017/4/14 1:09, Laszlo Ersek wrote: Adding Andrea, Ard, Drew and Marcel; and the main qemu list

[edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

https://bugzilla.tianocore.org/show_bug.cgi?id=465 GitHub word diff view of the patches in this series * https://github.com/mdkinney/edk2-BuildSpecification/commit/97290a0b1e926c946959ed11f931fd2db26ad04b?w=1 Process new syntax in the DEC file that specifies information that can only be used

[edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

https://bugzilla.tianocore.org/show_bug.cgi?id=465 Process new syntax in the DEC file that specifies information that can only be used by modules within the package. When modules outside the packages attempt to use this content, the EDK II build system must break with an error regarding content

[edk2] [ edk2-DecSpecification PATCH 2/4] Update version from 1.25 to 1.26

Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dec_file_overview/24_[defines]_usage.md| 2 +-

[edk2] [ edk2-DecSpecification PATCH 1/4] Remove trailing spaces from README.MD

Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- README.md | 28 ++-- 1 file

[edk2] [ edk2-DecSpecification PATCH 3/4] Add support for Private declarations in a package

https://bugzilla.tianocore.org/show_bug.cgi?id=465 Add new syntax to the DEC file for specifying information that can only be used by modules within the package. When modules outside the packages attempt to use this content, the EDK II build system must break with an error regarding content not

Re: [edk2] Unable to boot OVMF on qemu-x86_64

On 2017-04-24 13:41:50, Laszlo Ersek wrote: > On 04/18/17 07:29, Prakhya, Sai Praneeth wrote: > > Hi All, > > > > I am facing an issue booting OVMF on qemu, could you please help me? > > I have cloned EDKII, and built OVMF for X64 using GCC5. I have > > followed the steps given at

Re: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal

The patch has been pushed at fed709deb444084594c2e11a1886819fa54afc00. Thanks, Star -Original Message- From: Zeng, Star Sent: Saturday, April 22, 2017 9:03 PM To: Jeff Westfahl ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

Laszlo, There is no any real issue we encountered. Some static code check tool reported AcquireSpinLockOrFai() return value was not been checked. Then I found we may ignore some issue if AcquireSpinLockOrFai() return FALSE (even it will not be happened). Using AcquireSpinLock() is due to the

Re: [edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 25, 2017 9:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

Re: [edk2] [PATCH V2 0/4] Add SmmIoLib

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Jiewen Yao >Sent: Monday, April 24, 2017 10:15 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH V2 0/4] Add SmmIoLib > > V2 >Remove

[edk2] [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes

Incorrect line endings, trailing spaces and missing line break at end of file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- This addresses only issues found when hacking on some scripts for sanity checking .inf files. Since

[edk2] [patch] MdemodulePkg/DisplayEngine: clean the line before showing message

Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../CustomizedDisplayLibInternal.c | 21 - .../Universal/DisplayEngineDxe/FormDisplay.c| 15 +++

[edk2] [Patch] MdeModulePkg: Update PiSmmCore to set correct ImageAddress into LoadedImage

Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [Patch] MdeModulePkg: Update PiSmmCore to set correct ImageAddress into LoadedImage

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Monday, April 24, 2017 4:57 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg: Update PiSmmCore to set correct ImageAddress into

Re: [edk2] [Patch] MdeModulePkg PiSmmIpl: Fix the issue in LMFA feature

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, April 24, 2017 4:58 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [Patch]

Re: [edk2] ARM virt machine boots fail with 14 ioh3420

On 04/14/17 04:41, Shannon Zhao wrote: > Hi Laszlo, > > Thanks a lot for your reply:) > > On 2017/4/14 1:09, Laszlo Ersek wrote: >> Adding Andrea, Ard, Drew and Marcel; and the main qemu list >> >> On 04/13/17 09:37, Shannon Zhao wrote: >>> Hi, >>> >>> I'm testing the PCIe devices hotplug for

[edk2] [Patch] MdeModulePkg PiSmmIpl: Fix the issue in LMFA feature

SmramBase should be got from mLMFAConfigurationTable. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [edk2] ARM virt machine boots fail with 14 ioh3420

On 04/24/2017 01:02 PM, Laszlo Ersek wrote: On 04/14/17 04:41, Shannon Zhao wrote: Hi Laszlo, Thanks a lot for your reply:) On 2017/4/14 1:09, Laszlo Ersek wrote: Adding Andrea, Ard, Drew and Marcel; and the main qemu list On 04/13/17 09:37, Shannon Zhao wrote: Hi, I'm testing the PCIe

Re: [edk2] Unable to boot OVMF on qemu-x86_64

On 04/18/17 07:29, Prakhya, Sai Praneeth wrote: > Hi All, > > I am facing an issue booting OVMF on qemu, could you please help me? > I have cloned EDKII, and built OVMF for X64 using GCC5. I have > followed the steps given at https://wiki.ubuntu.com/UEFI/EDK2. "last edited 2012-11-16 20:22:59"

Re: [edk2] Python issue in UEFI shell

Hello, Can someone please shed some light on this issue? Thanks Thanks On Tue, Apr 18, 2017 at 2:56 PM, KT wrote: > Hi experts, > > I am experimenting python scripts in UEFI shell and as part of the first > step I tried compiling python as per the instructions in >

[edk2] [MAC HELP] Does Mac has a grubx64.efi ?

Hi , I am trying to boot a mac OS X from the efi shell so i opened the EFI partition. As usual there was EFI directory inside which there was APPLE director. so i went to EFI/APPLE director and found out there where two more directories inside /EFI/APPLE 1. FIRMWARE and 2. EXTENSIONS but there

Re: [edk2] [PATCH] kvm: pass the virtual SEI syndrome to guest OS

On 04/21/17 15:27, gengdongjiu wrote: > Hi all/Laszlo, > > sorry, I have a question to consult with you. > > > On 2017/4/7 2:55, Laszlo Ersek wrote: >> On 04/06/17 14:35, gengdongjiu wrote: >>> Dear, Laszlo >>>Thanks for your detailed explanation. >>> >>> On 2017/3/29 19:58, Laszlo Ersek

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

Hi Jeff, On 04/18/17 04:16, Jeff Fan wrote: > SMM BSP's *busy* state should be acquired. We could use AcquireSpinLock() > instead of AcquireSpinLockOrFail(). > > Cc: Hao Wu > Cc: Feng Tian > Cc: Michael Kinney >

[edk2] Possible UEFI Shell DrvDiag Command Error

Although this question is about the shell's drvdiag command, the answer is related to the interpretation of the UEFI specification with respect to the diagnostics protocol's RunDiagnostics() function. Ultimately, the question is, is the drvdiag command in error in trying to free the ErrorType

[edk2] [PATCH V2 3/4] MdePkg/dec: Add SmmIoLib.

Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdePkg/MdePkg.dec | 4 1 file changed, 4 insertions(+) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec

[edk2] [PATCH V2 2/4] MdePkg/SmmIoLib: Add sample instance.

The sample instance check if IO resource is valid one defined in GCD. A platform may choose add more check to exclude some other IO resource. Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao

[edk2] [PATCH V2 0/4] Add SmmIoLib

V2 Remove ASSERT(FALSE). (From Jeff Fan) V1 This patch series add SmmIoLib. It is the first part of bugzillar 491. https://bugzilla.tianocore.org/show_bug.cgi?id=491 Move generic function - OpalIsValidMmioSpace from OPAL driver to library. This SmmIoLib is similar to

[edk2] [PATCH V2 1/4] MdePkg/SmmIoLib: Add header file.

This SmmIoLib is used to check if an IO resource is valid in SMM. Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdePkg/Include/Library/SmmIoLib.h | 42

[edk2] [PATCH V2 4/4] MdePkg/dsc: add SmmIoLib

Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdePkg/MdePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index

Re: [edk2] Python issue in UEFI shell

I am not sure here, but I think that you may have issues running multiple threads in the UEFI environment. Have you tried not using multiple threadS? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of KT > Sent: Monday, April 24, 2017 5:32 AM >

Re: [edk2] Possible UEFI Shell DrvDiag Command Error

I would say the shell should not free the GUID. > -Original Message- > From: jim.dai...@dell.com [mailto:jim.dai...@dell.com] > Sent: Monday, April 24, 2017 5:46 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [edk2]

Re: [edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

Hi Mike, This patch is good to me. Reviewed-by: Yonghong Zhu while during review this patch, I found one update we wound made for " 5. Command line cannot be used to set the PCD value.". It is not related with this topic, but we can create another patch to update

Re: [edk2] [PATCH] PeCoffGetEntryPointLib: Fix spelling issue

Reviewed-by: Liming Gao >-Original Message- >From: Fan, Jeff >Sent: Monday, April 24, 2017 10:29 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Tian, Feng ; >Kinney, Michael D >Subject:

Re: [edk2] [ edk2-BuildSpecification PATCH] Update build report to support -Y HASH option

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 25, 2017 9:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

[edk2] [ edk2-BuildSpecification PATCH] Update build report to support -Y HASH option

https://bugzilla.tianocore.org/show_bug.cgi?id=504 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [ edk2-BuildSpecification PATCH] Update build report to support -Y HASH option

https://bugzilla.tianocore.org/show_bug.cgi?id=504 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_504_AddBuildReportHashFlag GitHub word diff view of the patches in this series: *

Re: [edk2] [PATCH 0/2] Borrow the space below 1MB for AP reset vector

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 2:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH 0/2] Borrow the space below

Re: [edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

Yonghong, The sentence about setting a PCD from the command line is related to https://bugzilla.tianocore.org/show_bug.cgi?id=480 #480 Build spec: add description for Override PCD value on the command line This will update the Build Specification to add the --pcd command line flag to set PCD

Re: [edk2] [PATCH V2 2/4] MdePkg/SmmIoLib: Add sample instance.

Slight cleanup suggestion. Since you are already linking MemoryAllocationLib, you could just call FreePool in that library instead of using UefiBootServicesTableLib and using gBS->FreePool (since you have no other use of gBS that I see). -Jaben > -Original Message- > From: edk2-devel

Re: [edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

Yes, I think we should remove it as part of #480. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 25, 2017 10:36 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D

Re: [edk2] [ edk2-BuildSpecification PATCH] Add support for Private declarations in a package

Yonghong, Thanks. I have updated #480 with that recommendation. Mike > -Original Message- > From: Zhu, Yonghong > Sent: Monday, April 24, 2017 7:38 PM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Shaw, Kevin W