In function FindFileEntry():
Instead of using the function parameter 'FileEntry', use a local
variable to store the buffer allocated for disk read operation.
For the below calling stack:
UdfOpenVolume() -> FindRootDirectory() -> FindFileEntry()
In FindFileEntry(), the call to
In order to create all of the children (El Torito standard and UDF) for
a CD/DVD media in an entry of the PartitionDriverBindingStart(), this
commit merges the discovery of the El Torito feature
(PartitionInstallElToritoChildHandles) into function
PartitionInstallUdfChildHandles.
Cc: Paulo
Update the EhciPei driver to consume IOMMU_PPI to allocate DMA buffer.
If no IOMMU_PPI exists, this driver still calls PEI service to allocate
DMA buffer, with assumption that DRAM==DMA.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
V2 changes:
For patch
MdeModulePkg/PartitionDxe: Merge the discovery of ElTorito into UDF:
PartitionInstallUdfChildHandles() should return EFI_SUCCESS when either El
Torito feature or UDF support is detected on CD/DVD media.
Previous version of the series only return EFI_SUCCESS when the UDF
Add /B build option for Benson FAB B.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
Platform/BroxtonPlatformPkg/BuildBxtBios.sh | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git
Paulo,
Those attached stack traces don't look right.
Thanks,
Andrew Fish
> On Nov 15, 2017, at 5:46 PM, Paulo Alcantara wrote:
>
> Hi,
>
> On 11/15/2017 11:18 PM, Paulo Alcantara wrote:
>> Hi,
>> This series adds stack trace support during a X64 CPU exception.
>>
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 16, 2017 11:58 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [Patch V3 0/2] Add Max LUN
https://bugzilla.tianocore.org/show_bug.cgi?id=767
Changes in V3
* Only check number of bytes transfered if Direction is not UsbNoData.
Add error check to USB I/O Protocol UsbControlTransfer() for the
number of bytes actually transfered. If less than requested, then
return EFI_DEVICE_ERROR.
https://bugzilla.tianocore.org/show_bug.cgi?id=767
The USB I/O Protocol function ControlTransfer() has a DataLength
parameter that specifies the size of the Data buffer. The
UsbBusDxe module implements the USB I/O Protocol using the
services of the USB2 Host Controller Protocol. The DataLength
https://bugzilla.tianocore.org/show_bug.cgi?id=767
If a USB Mass Storage device does not support the Get
Max LUN command, then the USB I/O Protocol ControlTransfer()
service may return an error. If an error is returned for
this command, then assume that the device does not support
multiple LUNs
Star,
I agree they are optional. The description says
DataLength should be 0 and Data should be NULL for
the EfiUsbNoData case. That is why I did not think
Direction needed to be evaluated if DataLength must
be 0 in this case.
In fact, the Host Controller implementations return
an error if
I second.
Since this patch breaks existing OS, I agree that we should rollback the memory
map change.
It means we can use original memory map, by filtering all page attributes.
I also suggest we add detail comment on why we do that.
GCD map is OK, which has both attribute and capability. And GCD
Mike,
Yes, the DataLength could be read. And Data/DataLength is optional when
Direction is EfiUsbNoData per my understanding.
IN OUT VOID*Data, OPTIONAL
IN UINTN DataLength, OPTIONAL
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Hi Paulo
Thanks to bring this cool feature.
I have same feeling as Jeff Fan. It is great!
I have some questions, hope you can clarify.
1) Would you please let us know which tool change is validated? Such as MSVC,
or GCC?
2) Would you please let us know which phase is validated? Such as PEI
Hi,
On 11/15/2017 11:18 PM, Paulo Alcantara wrote:
Hi,
This series adds stack trace support during a X64 CPU exception.
Informations like back trace, stack contents and image module names
(that were part of the call stack) will be dumped out.
We already have such support in ARM/AArch64
Hi,
This series adds stack trace support during a X64 CPU exception.
Informations like back trace, stack contents and image module names
(that were part of the call stack) will be dumped out.
We already have such support in ARM/AArch64 (IIRC) exception handling
(thanks to Ard), and then I
This patch adds stack trace support during a IA32 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
This function will be used by both IA32 and X64 exception handling in
order to print out image module names during stack unwinding.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
On 2017/11/15 22:03, Ard Biesheuvel wrote:
> On 15 November 2017 at 13:51, Laszlo Ersek wrote:
>> > On 11/14/17 11:22, Ard Biesheuvel wrote:
>>> >> The VariableRuntimeDxe driver may use CopyMem () on NOR flash regions,
>>> >> assuming such regions always have full memory
Hi Paolo,
On 11/15/17 18:30, Paolo Bonzini wrote:
> When SEV is enabled, every debug message printed by OVMF to the
> QEMU debug port traps from the guest to QEMU character by character
> because "REP OUTSB" cannot be used by IoWriteFifo8. Furthermore,
> when OVMF is built with the DEBUG_VERBOSE
The bug is https://bugzilla.tianocore.org/show_bug.cgi?id=780 .
I will update the message to more clear, thanks.
Best Regards,
Zhu Yonghong
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, November 16, 2017 12:23 AM
To: Zhu, Yonghong
On 11/15/17 15:03, Ard Biesheuvel wrote:
> Now that the PL031 RTC driver library no longer depends on the ARM
> platform specific ArmPlatformSysConfigLib, we no longer need to
> implement ArmPlatform.h or have a resolution for that library.
> This allows us to get rid of a rather dodgy practice of
(1) In the PEI phase, the PCD database is maintained in a GUID HOB. In
OVMF, we load the PCD PEIM before any other PEIMs (using APRIORI PEI),
so that all other PEIMs can use dynamic PCDs. Consequently,
- the PCD GUID HOB is initially allocated from the temporary SEC/PEI
heap,
This allows the PEI core to report the maximum temporary SEC/PEI stack
usage on the DEBUG_INFO level, in the PeiCheckAndSwitchStack() function
[MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c]:
* Normal boot:
> Temp Stack : BaseAddress=0x814000 Length=0x4000
> Temp Heap : BaseAddress=0x81
This allows the PEI core to report the maximum temporary SEC/PEI stack
usage on the DEBUG_INFO level, in the PeiCheckAndSwitchStack() function
[MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c]:
* Normal boot:
> Temp Stack : BaseAddress=0x814000 Length=0x4000
> Temp Heap : BaseAddress=0x81
"Main.asm" calls TransitionFromReal16To32BitFlat (and does some other
things) before it jumps to the platform's SEC entry point.
TransitionFromReal16To32BitFlat enters big real mode, and sets the DS, ES,
FS, GS, and SS registers to offset ("selector") LINEAR_SEL in the GDT
(defined in
Repo: https://github.com/lersek/edk2.git
Branch: temp_ram_tweaks_v2
This is a series for
https://bugzilla.tianocore.org/show_bug.cgi?id=747
specifically an update on the v1 series at
https://lists.01.org/pipermail/edk2-devel/2017-November/017239.html
Each patch has its notes section on
When SEV is enabled, every debug message printed by OVMF to the
QEMU debug port traps from the guest to QEMU character by character
because "REP OUTSB" cannot be used by IoWriteFifo8. Furthermore,
when OVMF is built with the DEBUG_VERBOSE bit (value 0x0040)
enabled in
These modules have been imported into edk2-platforms where they belong
so remove them from the main EDK2 branch.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/FileSystem/BootMonFs/BootMonFs.inf |
EBL is being phased out so remove ArmPlatformPkg's copy of EblCmdLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Library/EblCmdLib/AArch64/EblCmdMmu.c | 33 --
None of the platforms we support use these so remove them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmPlatformPkg.dec | 7 -
ArmPlatformPkg/Drivers/SP804TimerDxe/SP804Timer.c
This driver is no longer used anywhere so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Drivers/ArmTrustZone/ArmTrustZone.c | 113
No platform uses this so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Drivers/PL35xSmc/InitializeSMC.S | 60
ArmPlatformPkg/Drivers/PL35xSmc/InitializeSMC.asm | 62
Remove PL34xDmc driver which is not used by any platforms
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
NOTE: this driver is used by the CTA9x4, which is unused itself, so it doesn't
need to be migrated with the
Remove ArmVExpressPkg from EDK2 now that its contents have moved into
edk2-platforms/Platform/ARM where they belong.
Since LcdGraphicsOutputDxe is only used by VExpressPkg, it has been moved
there as well so remove it too.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
This driver is not used by any platforms so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Drivers/PL310L2Cache/PL310L2Cache.c | 126
The only remaining user of ArmPlatformSysConfigLib has absorbed this
definition into its own edk2-platforms package, so let's remove it from
the shared code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
No platforms use this driver so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Drivers/PL301Axi/PL301Axi.c | 108
ArmPlatformPkg/Drivers/PL301Axi/PL301Axi.inf | 27 -
Remove ArmJunoPkg now that it has been moved into edk2-platforms
where it belongs.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmJunoPkg/ArmJuno.dec | 47 --
The PL031 driver implements a VExpress/Juno specific hack to set the
battery backed clock in addition to the PL031. However, none of the
remaining VExpress based hardware we support in EDK2 actuall implements
this feature so we can just remove it, and get rid of the cumbersome
dependency on
This library class is not used by any drivers, so remove it in its
entirety.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibCTA9x4/ArmVExpressSecLib.inf
| 55
The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself
an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM.
Given that we'd prefer to get rid of ArmPlatformLib entirely, let's
remove ArmGetCpuCountPerCluster () from the API as a first step.
Contributed-under: TianoCore
Remove NorFlashArmVExpressLib now that it has been moved into edk2-platforms
where it belongs.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c
Remove ArmTrustedMonitorLib and its only [NULL] implementation.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Include/Library/ArmTrustedMonitorLib.h
| 24
This implementation of ArmPlatformSecExtraActionLib is no longer used
anywhere so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Library/DebugSecExtraActionLib/DebugSecExtraActionLib.c | 121
Remove everything from ArmPlatformPkg that is either unused, or so highly
specific to development platforms manufactured by ARM Ltd. that they really
don't belong in the main branch.
Note that the migration involves patches against edk2-platforms that add
some of this code back under
This module is not used anywhere under edk2 or edk2-platforms, so let's
remove it. This removes the only dependency on ArmPlatformLib from ArmPkg.
While at it, remove a mention of ArmPlatformPkg from a comment in the
.dec file as well.
Contributed-under: TianoCore Contribution Agreement 1.1
Star,
I have read that section, and I do not see anything
that says the DataLength parameter can not be read.
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, November 14, 2017 8:23 PM
> To: Kinney, Michael D ;
> edk2-devel@lists.01.org
> Cc:
Hello Yonghong,
On 11/14/17 06:52, Yonghong Zhu wrote:
> when collect source files list we should also consider build rule
> family.
what bug does this patch fix? I guess the bug is that something is
missed / not done, because changes to the build rules are not noticed?
Can you please elaborate
On 15 November 2017 at 15:48, Laszlo Ersek wrote:
> Hi Jian,
>
> On 11/15/17 10:27, Wang, Jian J wrote:
>> I tried this workaround and there're no failure in booting Fedora 26 and
>> Windows
>> server 2016 now. If no objection, I'll merge it into new version of this
>> patch.
Hi Jian,
On 11/15/17 10:27, Wang, Jian J wrote:
> I tried this workaround and there're no failure in booting Fedora 26 and
> Windows
> server 2016 now. If no objection, I'll merge it into new version of this
> patch.
I'm not too familiar with the Linux kernel's EFI pieces myself; that's
why I
Paulo,
I have no strong opinion on IA32 support in v2 patch or in separate patch.
I think UefiCpuPkg owner/reviewer may provide their own suggestions on this
point.
Thanks!
Jeff
From: Paulo Alcantara
Sent: Wednesday, November 15,
Hi Fan,
On 15/11/2017 11:21, Fan Jeff wrote:
Paulo,
I will try to validate my code firstly and try to integrate into your
patch.
OK. Thank you very much for the effort!
Before my part ready, it’s also welcome if you or others provide yours
own solution on X64 MSFT toolchain.
Yes - that
No FVP driver uses this library so remove the resolution.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git
Remove copy-pasted ArmTrustedMonitorLib library class resolutions
that none of the platforms actually need.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 --
Move ArmJunoPkg into edk2-platforms, so it can be removed from the main
EDK2 tree.
This allows use to remove the dodgy -I arguments to GCC to build shared
modules with a different copy of ArmPlatform.h, which was making it very
difficult to properly split the various modules into their own
Remove false copy-pasted dependencies on various VExpress support
libraries.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/Hisilicon/D02/Pv660D02.dsc | 3 ---
Platform/Hisilicon/D03/D03.dsc | 5 -
This is mostly a preparatory series that will allow us to get rid of a lot
of code that is specific to only a single ARM development platform out of
the main EDK2 tree.
First of all, it removes a couple of false dependencies of various platforms
on libraries that are no longer used, or not
Remove copy-pasted ArmPlatformSecExtraActionLib library class resolutions
that none of the platforms actually need.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc |
The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself
an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM.
Given that we'd prefer to get rid of ArmPlatformLib entirely, let's
remove ArmGetCpuCountPerCluster () from the API as a first step.
Contributed-under: TianoCore
Now that the PL031 RTC driver library no longer depends on the ARM
platform specific ArmPlatformSysConfigLib, we no longer need to
implement ArmPlatform.h or have a resolution for that library.
This allows us to get rid of a rather dodgy practice of including
platform headers using compiler flags,
On 15 November 2017 at 13:51, Laszlo Ersek wrote:
> On 11/14/17 11:22, Ard Biesheuvel wrote:
>> The VariableRuntimeDxe driver may use CopyMem () on NOR flash regions,
>> assuming such regions always have full memory semantics. Given that
>> those regions cannot be mapped as
On 11/14/17 11:22, Ard Biesheuvel wrote:
> The VariableRuntimeDxe driver may use CopyMem () on NOR flash regions,
> assuming such regions always have full memory semantics. Given that
> those regions cannot be mapped as ordinary memory on ARM (due to the
> fact that the NOR flash requires device
On 15 November 2017 at 13:34, Udit Kumar wrote:
> Hi,
> I recently noticed in my build as well, we need to include CapsuleLib even
> platform does not support Capsule update feature.
> Thanks to help me, why this dependency is added in edk2.
>
It was added as a dependency to
Hi,
I recently noticed in my build as well, we need to include CapsuleLib even
platform does not support Capsule update feature.
Thanks to help me, why this dependency is added in edk2.
Regards
Udit
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
Paulo,
I will try to validate my code firstly and try to integrate into your patch.
Before my part ready, it’s also welcome if you or others provide yours own
solution on X64 MSFT toolchain.
In my mind, IA32 arch should use the same solution with yours, have you tested
your solution on
The PL031 driver implements a VExpress/Juno specific hack to set the
battery backed clock in addition to the PL031. However, none of the
remaining VExpress based hardware we support in EDK2 actuall implements
this feature so we can just remove it, and get rid of the cumbersome
dependency on
Pushed at: 1fbe8276c4
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, November 14, 2017 3:49 PM
> To: 'Paulo Alcantara'; Ni, Ruiyu; edk2-devel@lists.01.org
> Cc: Dong, Eric; Zeng, Star
>
On 15 November 2017 at 11:27, kalyan-nagabhirava
wrote:
> "Instance of library class [CapsuleLib] is not found" build error is
> coming for Hikey platform, to resolve this issueadded CapsuleLib to
> "LibraryClasses.common" section
>
> Contributed-under:
"Instance of library class [CapsuleLib] is not found" build error is
coming for Hikey platform, to resolve this issueadded CapsuleLib to
"LibraryClasses.common" section
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: kalyan-nagabhirava
Hi,
2017-11-15 12:19 GMT+01:00 Ard Biesheuvel :
> From: Pipat Methavanitpong
>
> Add Macronix MX66U1G45G definition to NorFlashInfoLib
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pipat Methavanitpong
From: Pipat Methavanitpong
Add Macronix MX66U1G45G definition to NorFlashInfoLib
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pipat Methavanitpong
Signed-off-by: Ard Biesheuvel
I tried this workaround and there're no failure in booting Fedora 26 and Windows
server 2016 now. If no objection, I'll merge it into new version of this patch.
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, November 15, 2017 3:37 PM
> To: Zeng, Star ;
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
Platform/BroxtonPlatformPkg/Common/Tools/FCE/BfmLib | Bin
Platform/BroxtonPlatformPkg/Common/Tools/FCE/FCE| Bin
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 =>
GPIOs Change for FAB B. (FAB A does not use these GPIOs)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
.../Board/BensonGlacier/BoardInitPostMem/BoardGpios.h| 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
.../BroxtonPlatformPkg/Board/BensonGlacier/BoardInitPostMem/BoardInit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
77 matches
Mail list logo