Re: [edk2] [Patch] BaseTools: Support multiple .h file

Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Monday, January 29, 2018 2:10 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Support multiple .h file >

Re: [edk2] [Patch] BaseTool: Add comments in PcdValueInit.c.

Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, January 31, 2018 5:45 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTool: Add comments in

Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

On 01/31/18 13:27, Liming Gao wrote: > In SafeUintnToChar8(), update its output parameter name. > Update pui8Result --> Result to match its library implementation > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- >

Re: [edk2] [PATCH 0/3] UefiCpuPkg/PiSmmCpuDxeSmm: fix IA32 SmmStartup() regression on KVM

On 01/30/18 16:33, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: smm_startup_ia32_nocond > > This small series fixes the IA32 SMM regression on KVM that I reported > recently. The first two patches are cleanups (no functional changes), > the third patch is the fix. > >

Re: [edk2] [Patch] BaseTool: Enhance error handling.

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >BobCF >Sent: Wednesday, January 31, 2018 5:32 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch]

[edk2] [Patch 1/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile

With this change, enter single tool directory, make can pass. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/Makefiles/header.makefile | 28 ++-- 1 file changed, 26 insertions(+), 2

[edk2] [Patch 2/2] BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile

HOST_ARCH has been moved into the common header.makefile Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/BootSectImage/GNUmakefile| 3 +-- BaseTools/Source/C/BrotliCompress/GNUmakefile | 3 +--

[edk2] [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile

Liming Gao (2): BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile BaseTools/Source/C/BootSectImage/GNUmakefile| 3 +-- BaseTools/Source/C/BrotliCompress/GNUmakefile | 3 +--

[edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

In SafeUintnToChar8(), update its output parameter name. Update pui8Result --> Result to match its library implementation Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdePkg/Include/Library/SafeIntLib.h | 12 ++-- 1 file

Re: [edk2] [RFC] Remove X86 .asm and .S assembly files in EDK2

On 01/31/18 12:06, Gao, Liming wrote: > Edk2 has used nasm assembly file for all tool chains. So, IA32 and > X64 .asm and .S assembly files can be removed if their nasm files are > ready. It can save the maintain effort and avoid the confuse. > > > > If you have any comments on this change,

[edk2] [Patch] DSC spec: Add flexible PCD value format into spec

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 3_edk_ii_dsc_file_format/310_pcd_sections.md | 160

[edk2] [Patch] DEC spec: Add flexible PCD value format into spec

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 3_edk_ii_dec_file_format/310_pcd_sections.md | 14

[edk2] [Patch] INF spec: Add flexible PCD value format into spec

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- .../32_component_inf_definition.md | 71

[edk2] [Patch] Build spec: Add flexible PCD value format into spec

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 7_build_environment/73_guided_tools.md | 8

[edk2] [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex.

As per PI specification v1.6, As per section 2.1.4.1, The following file types exist: Table 3. Defined File Types Name Value EFI_FV_FILETYPE_RAW0x01 EFI_FV_FILETYPE_FREEFORM 0x02 EFI_FV_FILETYPE_SECURITY_CORE 0x03

Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

Reviewed-by: Michael D Kinney > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Liming Gao > Sent: Wednesday, January 31, 2018 4:27 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] MdePkg SafeIntLib:

[edk2] [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device tree compiler

To allow device tree compilation to be customized at the platform or module level, pass the contents of the DTC_FLAGS variable on the dtc command line. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [staging/edk2-test Patch] MdePkgUnitTest: Add UefiLib unit tests

Add UefiLib unit tests for the new API EfiLocateProtocolBuffer(). Cc: Sean Brogan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney ---

Re: [edk2] [PATCH edk2-platforms v2 02/15] Hisilicon/D05: Add PPTT support

Hi, On 01/26/2018 02:00 AM, Ming Huang wrote: Add Processor Properties Topology Table, PPTT include Processor hierarchy node, Cache Type Structure and ID structure. PPTT is needed for lscpu command to show socket information correctly. https://bugs.linaro.org/show_bug.cgi?id=3206

Re: [edk2] [Patch] BaseTools: Structure Pcd in CommandLine.

Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, January 31, 2018 4:49 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Structure Pcd in

Re: [edk2] [Patch 0/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Mike: Just confirm. Do we still need to add new API in IntelFrameworkPkg FrameworkUefiLib? I think we don't need add new feature in IntelFrameworkPkg and IntelFrameworkModulePkg. >-Original Message- >From: Kinney, Michael D >Sent: Thursday, February 01, 2018 7:33 AM >To:

Re: [edk2] [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device tree compiler

Ard: Do you consider to add DTC_FLAGS in tools_def.template file? Its value can be empty. So, user bases on tools_def.txt to know which option can be set. >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, February 01, 2018 5:49 AM >To:

Re: [edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Hi Mike, UefiLib is capable to be used by SMM Core or SMM driver before SmmReadyToLock. And the new interface has the comment below. +The returned buffer is allocated using +EFI_BOOT_SERVICES.AllocatePool(). The caller is +

Re: [edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Star, I agree with your observation. And the API specifically says that EFI_BOOT_SERVICES.AllocatePool() is used, so I agree with your suggested change. However, there are other APIs in the UefiLib implementation that use the MemoryAllocationLib services. Should those be updated too? Mike >

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

gCpu->SetMemoryAttributes() called by SetUefiImageMemoryAttributes() will return without any problem if Length is 0. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, January 30, 2018 10:09 AM > To: Wang, Jian J ; edk2-devel@lists.01.org >

Re: [edk2] [Patch 0/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Liming, I looks like we still do updates if a new API is added to the UefiLib class. https://github.com/tianocore/edk2/commit/6212b9481d822a6765f8cd264ceb8454291948bd#diff-b3a4a95eeed10a8932c1738829d8cd7f I will update the patch. Mike > -Original Message- > From: Gao, Liming > Sent:

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

Hi Laszlo, Thanks for your comments. Explain the issue first: In CpuCommonFeaturesLib.inf -> CpuCommonFeaturesLib.c -> CpuCommonFeaturesLibConstructor() function, it invokes RegisterCpuFeature() to register CPU feature. Some original source codes is here. if (IsCpuFeatureSupported

[edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=838 Add new API to the UefiLib that locates and returns an array of protocols instances that match a given protocol. Cc: Sean Brogan Cc: Jiewen Yao

[edk2] [Patch 0/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

https://bugzilla.tianocore.org/show_bug.cgi?id=838 Add new API to the UefiLib that locates and returns an array of protocols instances that match a given protocol. Branch for review: https://github.com/mdkinney/edk2/tree/Bug_838_EfiLocateProtocolBuffer_V3 Cc: Sean Brogan

Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 1/29/2018 4:50 PM, Guo Heyi wrote: Sorry for the late; I caught cold and didn't work for several days last week :( Please see my comments below: On Mon, Jan 22, 2018 at 11:36:14AM +0800, Ni, Ruiyu wrote: On 1/18/2018 9:26 AM, Guo Heyi wrote: On Wed, Jan 17, 2018 at 02:08:06PM +, Ard

Re: [edk2] [PATCH 2/6] MdeModulePkg/ConSplitter: ReadKeyStrokeEx always return key state

Hi Ruiyu, One comment: ConSplitterTextInPrivateReadKeyStroke() needs filter out partial key from ConSplitterTextInExDequeueKey(). With the comment above handled, Reviewed-by: Star Zeng to this patch series. Thanks, Star -Original Message- From: Ni, Ruiyu Sent:

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

On 2/1/2018 9:17 AM, Wang, Jian J wrote: You're right. Using a mask or separating the API into two (SetMemoryAttributes/ClearMemoryAttributes) is much better and can avoid many potential issues. Regards, Jian For now the patch is good enough to leave NULL pointer detection feature enabled.

Re: [edk2] [PATCH] MdeModulePkg/Core: fix guard page missing issue

On 1/29/2018 12:52 PM, Jian J Wang wrote: This issue is a regression one caused by a patch at 425d25699be83c35e12df8470b827d7fbcef3bce That fix didn't take the 0 page to free into account, which still needs to call UnsetGuardPage() even no memory needs to free. The fix is just moving the

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and heap guard

On 1/29/2018 8:09 PM, Jian J Wang wrote: Considering following scenario (both NX memory protection and heap guard are enabled): 1. Allocate 3 pages. The attributes of adjacent memory pages will be |NOT-PRESENT| present | present | present |NOT-PRESENT| 2. Free the middle

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

Ok. Thanks for the comments. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, February 01, 2018 1:54 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric ; > Zeng, Star

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

On 1/31/2018 5:44 PM, Laszlo Ersek wrote: On 01/31/18 08:00, Song, BinX wrote: Current CPU feature dependency check will hang on when meet below or similar case: if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { Status = RegisterCpuFeature ( "AESNI",

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

On 2/1/2018 1:33 PM, Ni, Ruiyu wrote: On 2/1/2018 9:17 AM, Wang, Jian J wrote: You're right. Using a mask or separating the API into two (SetMemoryAttributes/ClearMemoryAttributes) is much better and can avoid many potential issues. Regards, Jian For now the patch is good enough to leave

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

"Yao, Jiewen" writes: Hi Jiewen, > === > OVMF IA32: DXE worked, but SMM not. > > Since the page fault is only occurring in IA32 with no paging enabled > (default case), I suspect that when we don't have paging, we are unable > to successfully validate

Re: [edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Mike, Depend on whether the allocated buffer will be returned to caller or not, and whether the implementation is matched with the function comments. Some cases seem ok. 1. There are paired interfaces, for example AddUnicodeString and FreeUnicodeStringTable, etc. 2. There are clear comments,

[edk2] Need help about a Hii tutorial.

Hi, I am learning Hii and I know few about Hii,luckly,I found a good tutorial here: https://firmware.intel.com/sites/default/files/Lab_Material_FW.zip source_code locate in:Lab_Material_FW.zip\FW\LabSampleCode\MyWizardDriver https://firmware.intel.com/sites/default/files/Presentations161017.zip

Re: [edk2] [Patch] BaseTools: Fix the bug to align VPD PCD based on value type

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Tuesday, January 30, 2018 2:57 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the bug to align VPD PCD

Re: [edk2] [Patch] BaseTools: Update BPDG to support L'' and '' format as VPD Pcd Value

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Tuesday, January 30, 2018 11:20 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Update BPDG to support L''

[edk2] [Patch] BaseTools: Structure Pcd in CommandLine.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py| 110 +++- BaseTools/Source/Python/Common/Expression.py | 2 +-

Re: [edk2] [Patch] DSC spec: Update Skuid value to support Hex number

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, January 23, 2018 11:18 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

[edk2] [Patch] BaseTool: Enhance error handling.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 116 - .../Source/Python/Workspace/MetaFileParser.py | 3 + 2 files

[edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/PcdValueCommon.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c

[edk2] [RFC] Remove X86 .asm and .S assembly files in EDK2

Edk2 has used nasm assembly file for all tool chains. So, IA32 and X64 .asm and .S assembly files can be removed if their nasm files are ready. It can save the maintain effort and avoid the confuse. If you have any comments on this change, please let me know. Thanks Liming

Re: [edk2] [PATCH v2] PcAtChipsetPkg: Add PeiAcpiTimerLib to save PerformanceCounterFrequency in HOB

Star: Thanks for you feedback. I will update the patch and push it. >-Original Message- >From: Zeng, Star >Sent: Friday, January 26, 2018 1:57 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: RE: [edk2] [PATCH v2]

[edk2] [Patch] UefiCpuPkg: Remove the unused file ResetVec.asm16

ResetVec.nasmb is used. ResetVec.asm16 can be retired. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- UefiCpuPkg/SecCore/Ia32/ResetVec.asm16 | 106 - 1 file changed, 106 deletions(-) delete mode 100644

[edk2] [Patch] BaseTool: Add comments in PcdValueInit.c.

Add Comments for __FLEXIBLE_SIZE () statement. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [edk2] [Patch] UefiCpuPkg: Remove the unused file ResetVec.asm16

On 01/31/18 10:45, Liming Gao wrote: > ResetVec.nasmb is used. ResetVec.asm16 can be retired. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- > UefiCpuPkg/SecCore/Ia32/ResetVec.asm16 | 106 > - >

Re: [edk2] [PATCH 1/3] UefiCpuPkg/PiSmmCpuDxeSmm: update comments in IA32 SmmStartup()

On 01/30/18 23:25, Kinney, Michael D wrote: > Laszlo, > > I agree that the function is better than a macro. > > I thought of the alignment issues as well. CopyMem() > is a good solution. We could also consider > WriteUnalignedxx() functions in BaseLib. IMO, the WriteUnalignedxx functions are

Re: [edk2] difference between asm16 and asm files

Tiger: Nasm compiler supports to generate 16bit raw code. User doesn't need to install the additional tool. And, the raw code is 16bit code. You need 16bit assembler. It is also nasm compiler. So, it is obvious to use nasm to directly do it. Thanks Liming >-Original Message- >From:

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

On 01/31/18 08:00, Song, BinX wrote: > Current CPU feature dependency check will hang on when meet below or > similar case: > if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { > Status = RegisterCpuFeature ( > "AESNI", > AesniGetConfigData, > AesniSupport, >

Re: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 31, 2018 5:04 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools

Re: [edk2] [PATCH 1/3] UefiCpuPkg/PiSmmCpuDxeSmm: update comments in IA32 SmmStartup()

On 01/31/18 06:44, Ni, Ruiyu wrote: > Mike, Laszlo, > Does the patch only apply to the operand? > If so, PatchAssembly looks too general. > How about the name like PatchAssemblyOperand? Originally I meant to call the function "PatchInstruction", but then I thought it could be used for patching

Re: [edk2] [PATCH 1/3] UefiCpuPkg/PiSmmCpuDxeSmm: update comments in IA32 SmmStartup()

On 01/31/18 06:54, Ni, Ruiyu wrote: > Laszlo, Mike, > Considering this patch doesn't make the code worse, > actually improved a tiny bit, can we firstly check in the three patches? I agree; the PatchAssembly() discussion is taking quite a bit of thought, meanwhile IA32 SMM is broken on KVM --