Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 3/7/2018 2:01 PM, Guo Heyi wrote: Thanks. Please let me know if any further changes are needed. Regards, Heyi On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: On 3/6/2018 10:44 AM, Guo Heyi wrote: Hi Ray, Any comments for v5? Heyi, Some backward compatibility concerns were

Re: [edk2] EFI ExitBootServices() function crashes in QEMU

On 03/14/18 00:28, Anatol Pomozov wrote: > Hello > > I am implementing a simple UEFI bootloader. Most EFI functions that I > tried work me - I can clear Console, print text, successfully read > files from system partition, allocate memory pages. > > But if I try to read memory map and then call

[edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

Due to the fact that HeapGuard needs CpuArchProtocol to update page attributes, the feature is normally enabled after CpuArchProtocol is installed. Since there're some drivers are loaded before CpuArchProtocl, they cannot make use HeapGuard feature to detect potential issues. This patch fixes

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

On Wed, 14 Mar 2018 00:25:09 +, Guo Heyi wrote: > > On Tue, Mar 13, 2018 at 09:33:33AM +, Marc Zyngier wrote: > > On 13/03/18 00:31, Heyi Guo wrote: > > > If timer interrupt is level sensitive, reloading timer compare > > > register has a side effect of clearing GIC pending status, so a

Re: [edk2] [PATCH] ShellPkg/Dmpstore: Enhance display information for Auth3 variable.

Chen Chen: Please update license header. Others are good to me. Reviewed-by: Chao Zhang -Original Message- From: Chen, Chen A Sent: Tuesday, March 13, 2018 3:37 PM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Ni, Ruiyu

[edk2] Intel Reference Board doesn't work after inserting INT 15h/86h into Flat32.asm

Hello everyone, I have an Intel Reference Board. I was trying to force BIOS to wait 1 second in SEC phase. I inserted these assemble code (BIOS wait function) into very first of ProtectedModeEntryPoint in Flat32.asm file: MOV CX, 0FH MOV DX, 4240H MOV AH, 86H INT 15H

Re: [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy for connecting devices

On 03/13/18 22:22, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: qemu_bootorder_connect > > Adding tens or hundreds of bootable devices to a QEMU VM config slows > the OVMF and ArmVirtQemu boots to a crawl, several people have reported > in the past. > > There are at

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

On 14 March 2018 at 12:24, Leif Lindholm wrote: > On Thu, Jan 04, 2018 at 07:24:20PM +, Ard Biesheuvel wrote: >> On 4 January 2018 at 18:55, Girish Pathak wrote: >> > Hi Ard, >> > >> >> -Original Message- >> >> From: edk2-devel

Re: [edk2] [PATCH V2 0/6] SourceLevelDebugPkg DebugUsb3: Re-Support IOMMU

The series is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, March 14, 2018 5:34 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu,

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

Mike, Evaluating block size is a good idea! The block size of the target USB device is 2048 in my platform. I modify the UsbMassBoot.c with evaluating block size and it works. I will send the patch later. Thanks, Ming On 2018/3/13 9:38, Kinney, Michael D wrote: > Star, > > Maybe we should

[edk2] [PATCH V2 6/6] SourceLevelDebugPkg DebugUsb3: Re-Support IOMMU

de8373fa07f87ca735139bb86c51e2c29fb1d956 could not handle two cases. 1. For the case that the USB3 debug port instance and DMA buffers are from PEI HOB with IOMMU enabled, it was to reallocate the DMA buffers by AllocateAddress with the memory type accessible by SMM environment. But reallocating

[edk2] [PATCH V2 5/6] SourceLevelDebugPkg DebugCommUsb3: Refine some formats/comments

Refine some formats/comments and remove some unused prototypes. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../DebugCommunicationLibUsb3Common.c | 16

[edk2] [PATCH] BaseTools/PosixLike: honor pre-set PYTHONPATH

Utilities written in Python may depend on external (preinstalled) Python packages; for example, Ecc depends on "antlr_python_runtime-3.0.1". Such packages need not be installed system-wide, as long as they are reachable through PYTHONPATH. Therefore we shouldn't overwrite the user's PYTHONPATH

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 14 March 2018 at 07:57, Ni, Ruiyu wrote: > On 3/7/2018 2:01 PM, Guo Heyi wrote: >> >> Thanks. Please let me know if any further changes are needed. >> >> Regards, >> >> Heyi >> >> On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: >>> >>> On 3/6/2018 10:44 AM, Guo

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

On Wed, Mar 14, 2018 at 12:35:03PM +, Ard Biesheuvel wrote: > >> I guess Leif and I are in disagreement here. In particular, I think > >> his comment > >> > >> """ > >> ASSERT (FALSE)? (You already know Status is an EFI_ERROR, and a > >> console message saying ASSERT (Status) is not getting

[edk2] [PATCH V2 3/6] Revert "DebugUsb3: Support IOMMU"

This reverts commit de8373fa07f87ca735139bb86c51e2c29fb1d956. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../DebugCommunicationLibUsb3Common.c | 222

[edk2] [PATCH V2 4/6] SourceLevelDebugPkg DebugUsb3: Re-Fix GCC build failures

Fix GCC build failures below. variable 'EvtTrb' set but not used [-Werror=unused-but-set-variable] variable 'Index' set but not used [-Werror=unused-but-set-variable] The build failure could only be caught with -D SOURCE_DEBUG_USE_USB3 build flag. ad6040ec9b5bbc462762331f9738b8e42c0b9c80 needs

[edk2] [PATCH V2 2/6] Revert "DebugUsb3: Fix GCC build failures"

This reverts commit ad6040ec9b5bbc462762331f9738b8e42c0b9c80. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

[edk2] [PATCH V2 0/6] SourceLevelDebugPkg DebugUsb3: Re-Support IOMMU

The patch series is also at https://github.com/lzeng14/edk2 DebugCommUsb3AfterIOMMUV2 branch. Based on the feedbacks from Ray and Hao. It is V2 of https://lists.01.org/pipermail/edk2-devel/2018-March/022586.html. It has no essential difference with V1 about the final code, but re-arranges the

[edk2] [PATCH V2 1/6] Revert "DebugUsb3: Check mUsb3Instance before dereferencing it"

This reverts commit 6ef394ffe29bbc67038fc16ed540bfe6eed10e16. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

Re: [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy for connecting devices

On 13 March 2018 at 21:22, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: qemu_bootorder_connect > > Adding tens or hundreds of bootable devices to a QEMU VM config slows > the OVMF and ArmVirtQemu boots to a crawl, several people have reported > in

Re: [edk2] [PATCH V2 0/6] SourceLevelDebugPkg DebugUsb3: Re-Support IOMMU

On 3/14/2018 5:33 PM, Star Zeng wrote: The patch series is also at https://github.com/lzeng14/edk2 DebugCommUsb3AfterIOMMUV2 branch. Based on the feedbacks from Ray and Hao. It is V2 of https://lists.01.org/pipermail/edk2-devel/2018-March/022586.html. It has no essential difference with V1

Re: [edk2] [PATCH v5 1/6] CorebootPayloadPkg/PciHostBridgeLib: Init PCI aperture to 0

On 1 March 2018 at 06:57, Heyi Guo wrote: > Use ZeroMem to initialize all fields in temporary > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but > helpful for future extension: when we add new fields to > PCI_ROOT_BRIDGE_APERTURE and the default value of

Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

Hi Arvind, On Sat, Mar 10, 2018 at 11:11:58AM -0500, Arvind Prasanna wrote: > It is possible to source edksetup.sh from another script. If the > calling/sourcing script has any positional parameters set, those are > incorrectly accounted for in edksetup.sh while sourcing it resulting in > the the

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

On Thu, Jan 04, 2018 at 07:24:20PM +, Ard Biesheuvel wrote: > On 4 January 2018 at 18:55, Girish Pathak wrote: > > Hi Ard, > > > >> -Original Message- > >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >> Ard Biesheuvel > >> Sent: 23

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

On 14 March 2018 at 07:45, Marc Zyngier wrote: > On Wed, 14 Mar 2018 00:25:09 +, > Guo Heyi wrote: >> >> On Tue, Mar 13, 2018 at 09:33:33AM +, Marc Zyngier wrote: >> > On 13/03/18 00:31, Heyi Guo wrote: >> > > If timer interrupt is level sensitive, reloading timer

Re: [edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

There's a bit operation error found in 32-bit platform. I'll send a v2 patch later. Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Wednesday, March 14, 2018 4:31 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [RFC] Remove X86 .asm and .S assembly files in EDK2

Mike: Now, %pragma macho subsections_via_symbols can't be enabled. So, will nasm generate the bigger image size than .S assembly on macho? If yes, I agree nasm is not same to .S. .S may be kept for a while. But, .asm is not necessary. We can remove .asm first. Thanks Liming > -Original

Re: [edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

On 3/15/2018 10:27 AM, Jian J Wang wrote: v2 changes: Fix a logic hole in bits operation on address on 64K boundary with just 64-bit length (SetBits(), ClearBits(), GetBits()). Due to the fact that HeapGuard needs CpuArchProtocol to update page attributes, the feature is normally

Re: [edk2] [PATCH v6 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 3/15/2018 12:00 PM, Heyi Guo wrote: PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as "device address" or "address in PCI view") set to PCI BAR registers in configuration space might be different from the address which is used by CPU

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 3/15/2018 10:57 AM, Guo Heyi wrote: Hi Ray, Sorry I never tried Ecc tool before, for there is few documents about it. When I tried running python BaseTools/Source/Python/Ecc/Ecc.py -t -s , it showed me with error message: ImportError: No module named Common.LongFilePathOs Then I found

[edk2] [PATCH v6 0/6] Add translation support to generic PciHostBridge

v6: - Patch 1, 2: implement 3 comments from Laszlo. - Patch 4: implement 3 comments from Ray. Patch v5 inherits the code from RFC v4; we don't restart the version number for RFC to PATCH change. v5: - Patch 4/6: Modify the code according to the comments from Ray. - Patch 1/6 and 2/6 are totally

Re: [edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

Thanks catching this. New patch has sent out. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, March 15, 2018 11:47 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric ; >

[edk2] [PATCH v3 2/3] MdeModulePkg/PiSmmCore: fix bits operation error on a boundary condition

If given address is on 64K boundary and the requested bit number is 64, all SetBits(), ClearBits() and GetBits() will encounter ASSERT problem in trying to do a 64 bits of shift, which is not allowed by LShift() and RShift(). This patch tries to fix this issue by turning bits operation into whole

[edk2] [PATCH v3 0/3] fix empty window period of HeapGuard before CpuArchProtocol

> v3: >Split the fixes into three patch files. > v2: >Fix a logic hole in bits operation on address on 64K boundary with >just 64-bit length (SetBits(), ClearBits(), GetBits()). This patch series fills up an empty window period of HeapGuard feature before CpuArchProtocol installed,

[edk2] [PATCH v3 3/3] MdeModulePkg/Core: fix bits operation error on a boundary condition

If given address is on 64K boundary and the requested bit number is 64, all SetBits(), ClearBits() and GetBits() will encounter ASSERT problem in trying to do a 64 bits of shift, which is not allowed by LShift() and RShift(). This patch tries to fix this issue by turning bits operation into whole

Re: [edk2] [PATCH v6 0/6] Add translation support to generic PciHostBridge

On Thu, Mar 15, 2018 at 01:27:59PM +0800, Ni, Ruiyu wrote: > On 3/15/2018 12:00 PM, Heyi Guo wrote: > >v6: > >- Patch 1, 2: implement 3 comments from Laszlo. > >- Patch 4: implement 3 comments from Ray. > > > >Patch v5 inherits the code from RFC v4; we don't restart the version number > >for >

[edk2] [PATCH V2] SecurityPkg OpalPasswordDxe:Fix wrong BufferSize input to UnicodeSPrint

Current code uses string length as BufferSize input to UnicodeSPrint, it is wrong and makes the pop up string trimmed. The BufferSize input to UnicodeSPrint should be the size, in bytes, of the output buffer. This is to use sizeof (mPopUpString) as the BufferSize input to UnicodeSPrint, it also

[edk2] [PATCH v6 2/6] OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init

Use ZeroMem() to initialize (or re-initialize) all fields in temporary PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but is helpful for future extension: when we add new fields to PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can safely be zero, this code will

[edk2] [PATCH v6 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as "device address" or "address in PCI view") set to PCI BAR registers in configuration space might be different from the address which is used by CPU to access the registers in memory BAR or

[edk2] [PATCH v6 3/6] MdeModulePkg/PciHostBridgeLib.h: add address Translation

Add Translation field to PCI_ROOT_BRIDGE_APERTURE. Translation is used to represent the difference between device address and host address, if they are not the same on some platforms. In UEFI 2.7, "Address Translation Offset" is "Offset to apply to the Starting address to convert it to a PCI

[edk2] [PATCH v6 1/6] CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init

Use ZeroMem() to initialize (or re-initialize) all fields in temporary PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but helpful for future extension: when we add new fields to PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can safely be zero, this code will not

[edk2] [PATCH v6 5/6] MdeModulePkg/PciBus: convert host address to device address

According to UEFI spec 2.7, PciRootBridgeIo->Configuration() should return host address (CPU view ddress) rather than device address (PCI view address), so in function GetMmioAddressTranslationOffset we need to convert the range to device address before comparing. And device address = host

[edk2] [PATCH v6 6/6] MdeModulePkg/PciBus: return CPU address for GetBarAttributes

According to UEFI spec 2.7, PciIo->GetBarAttributes should return host address (CPU view ddress) rather than device address (PCI view address), and device address = host address + address translation offset, so we subtract translation from device address before returning. Contributed-under:

Re: [edk2] [RFC] Remove X86 .asm and .S assembly files in EDK2

> On Mar 14, 2018, at 6:56 PM, Gao, Liming wrote: > > Mike: > Now, %pragma macho subsections_via_symbols can't be enabled. So, will nasm > generate the bigger image size than .S assembly on macho? Yes. Thanks, Andrew Fish > If yes, I agree nasm is not same to .S.

Re: [edk2] [PATCH v6 0/6] Add translation support to generic PciHostBridge

On 3/15/2018 12:00 PM, Heyi Guo wrote: v6: - Patch 1, 2: implement 3 comments from Laszlo. - Patch 4: implement 3 comments from Ray. Patch v5 inherits the code from RFC v4; we don't restart the version number for RFC to PATCH change. v5: - Patch 4/6: Modify the code according to the comments

Re: [edk2] [PATCH v3 0/3] fix empty window period of HeapGuard before CpuArchProtocol

On 3/15/2018 1:03 PM, Jian J Wang wrote: v3: Split the fixes into three patch files. v2: Fix a logic hole in bits operation on address on 64K boundary with just 64-bit length (SetBits(), ClearBits(), GetBits()). This patch series fills up an empty window period of HeapGuard

[edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

> v2 changes: >Fix a logic hole in bits operation on address on 64K boundary with >just 64-bit length (SetBits(), ClearBits(), GetBits()). Due to the fact that HeapGuard needs CpuArchProtocol to update page attributes, the feature is normally enabled after CpuArchProtocol is installed.

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Hi Ray, Sorry I never tried Ecc tool before, for there is few documents about it. When I tried running python BaseTools/Source/Python/Ecc/Ecc.py -t -s , it showed me with error message: ImportError: No module named Common.LongFilePathOs Then I found there was an executable named "Ecc" in

[edk2] To save size, use NULL library for DebugLib and ReportStatusCodeLib

What does that mean?? Sorry for asking beginner questions but was just wondering. Trying to shrink the size of the Duet image. Thank you ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] To save size, use NULL library for DebugLib and ReportStatusCodeLib

Here is NULL DebugLib and ReportStatusCodeLib instance. They are dummy implementation. They will not take the image size, and remove the debug message and ASSERT code from the image. So, they can help to save the image size. MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf

Re: [edk2] [PATCH v5 0/6] Add translation support to generic PciHostBridge

On 3/1/2018 2:57 PM, Heyi Guo wrote: Patch v5 inherits the code from RFC v4; we don't restart the version number for RFC to PATCH change. v5: - Patch 4/6: Modify the code according to the comments from Ray. - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of

Re: [edk2] [Patch 4/5] Vlv2TbltDevicePkg/PlatformBootManagerLib: Check PcdPkcs7CertBufferXdr

Reviewed-by: david wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Kinney, Michael D Sent: Tuesday, March 13, 2018 3:30 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ;

[edk2] [PATCH v1 2/2] BaseTools: AutoGen should use is None not == None

change to the style we document as in use Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 138

[edk2] [PATCH v1 1/2] BaseTools: Autogen - modify to use standard parent/child class relationships

use __new__ and __init__ to create/manage/initialize objects in standard flow. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 0/2] BaseTools: AutoGen code style compliance

update the object factory and child classes to use standard functions update the file to use is None instead of == None Jaben Carsey (2): BaseTools: Autogen - modify to use standard parent/child class relationships BaseTools: AutoGen should use is None not == None

[edk2] [staging/dynamictables PATCH] Branch to implement Dynamic Tables Framework

This patch introduces a branch for implementing Dynamic Tables Framework. The description is in the Readme.md file. Please create a branch called 'dynamictables' in edk2-staging. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar

Re: [edk2] [Patch 0/5] Add multi-cert PcdPkcs7CertBufferXdr

Reviewed-by: Kelly Steele Thanks, Kelly > -Original Message- > From: Kinney, Michael D > Sent: March 12, 2018 12:30 > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zhu, Yonghong > ; Gao, Liming

Re: [edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

On Thu, Feb 15, 2018 at 01:31:50PM +, achin.gu...@arm.com wrote: > From: Achin Gupta > > This patch adds maintainers, reviewer and directory for the > StandaloneMmPkg. This package will host an implementation of Standalone > Management Mode as specified in the Platform

Re: [edk2] AARCH64:Use of EFI_MEMORY_XP

On 14 March 2018 at 19:34, Evan Lloyd wrote: > Hi Ard. > We still have a minor problem in that the spec disqualifies EFI_MEMORY_XP for > AARCH64. > Do you have any thoughts on this? > How should we proceed here? I assume the specification statement was a > considered

[edk2] [PATCH][platforms/devel-dynamictables] Branch to implement Dynamic Tables Framework

This patch introduces a branch for implementing Dynamic Tables Framework. The description is in the Readme.md file. Please create a branch called 'devel-dynamictables' in edk2-platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar

[edk2] AARCH64:Use of EFI_MEMORY_XP

Hi Ard. We still have a minor problem in that the spec disqualifies EFI_MEMORY_XP for AARCH64. Do you have any thoughts on this? How should we proceed here? I assume the specification statement was a considered decision. Do we need to get it changed, or is EFI_MEMORY_XP unnecessary? Regards,