[edk2] [Patch 1/2] SecurityPkg/TcgStorageOpalLib: Fix GCC build failure.

Function definition different with function implementation caused this build failure. Change code to make them consistent to pass the build. Done Unit Test: 1. Pass GCC build. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong

Re: [edk2] [Patch 0/2] Fix 2 regression caused by enabling pyrite 2.0 feature changes.

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Monday, May 14, 2018 3:36 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Fix 2 regression

[edk2] [Patch 2/2] SecurityPkg/OpalPassword: Fix PSID revert no hint message.

For no warning message when do the PSID revert action, the message in the popup dialog is not enough. The error use of NULL for CreatePopUp function caused this regression. This change fixed it. Passed Unit Test: 1. Check PSID revert with/without warning message cases. Cc: Hao Wu

[edk2] [Patch 0/2] Fix 2 regression caused by enabling pyrite 2.0 feature changes.

Fix GCC build failure and PSID revert no hint message issues caused by enabling pyrite 2.0 feature. Eric Dong (2): SecurityPkg/TcgStorageOpalLib: Fix GCC build failure. SecurityPkg/OpalPassword: Fix PSID revert no hint message. .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 4 ---

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: connect consoles unconditionally

On 05/14/18 12:28, Ard Biesheuvel wrote: > On 13 May 2018 at 00:55, Laszlo Ersek wrote: >> If both ConIn and ConOut exist, but ConIn references none of the PS/2 >> keyboard, the USB wild-card keyboard, and any serial ports, then >> PlatformInitializeConsole() currently allows

Re: [edk2] [PATCH 0/7] MdePkg, OvmfPkg, ArmVirtPkg: add and use PCI(E) Capabilities Library

ping On 05/04/18 23:36, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: pci_cap > > In message [1], Jordan suggested a general "capabilities helper lib that > could iterate & read the PCI capability structs". Patch #1 introduces > that library (class and central BASE

[edk2] [Patch 1/3] MdePkg UefiLib: Fix XCODE5 varargs warning

https://bugzilla.tianocore.org/show_bug.cgi?id=741 Change GetBestLanguage() parameter type from BOOLEAN to UINTN Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Steven Shi Cc: Liming Gao --- MdePkg/Include/Library/UefiLib.h | 2

[edk2] [Patch 0/3] Fix XCODE5 varargs warning in GetBestLanguage API

https://bugzilla.tianocore.org/show_bug.cgi?id=741 Change GetBestLanguage() parameter from BOOLEAN to UINTN PI S3SaveState protocol will be updated after new PI spec is public. Liming Gao (3): MdePkg UefiLib: Fix XCODE5 varargs warning IntelFrameworkPkg UefiLib: Fix XCODE5 varargs warning

[edk2] [Patch 2/3] IntelFrameworkPkg UefiLib: Fix XCODE5 varargs warning

https://bugzilla.tianocore.org/show_bug.cgi?id=741 Change GetBestLanguage() parameter type from BOOLEAN to UINTN Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Steven Shi Cc: Liming Gao ---

[edk2] [Patch 3/3] MdeModulePkg Variable: Fix XCODE5 varargs warning

https://bugzilla.tianocore.org/show_bug.cgi?id=741 Change VariableGetBestLanguage() parameter type from BOOLEAN to UINTN Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Steven Shi Cc: Liming Gao ---

Re: [edk2] [Patch] BaseTools: Enhance error message when file is not exist for Gensec

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Sunday, May 13, 2018 5:46 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Enhance error message

Re: [edk2] [PATCH 0/7] MdePkg, OvmfPkg, ArmVirtPkg: add and use PCI(E) Capabilities Library

Laszlo: I have not fully understood its goal and design. Could you give me one more week to review it? Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, May 14, 2018 9:16 PM > To: edk2-devel-01 > Cc: Kinney,

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: connect consoles unconditionally

On 13 May 2018 at 00:55, Laszlo Ersek wrote: > If both ConIn and ConOut exist, but ConIn references none of the PS/2 > keyboard, the USB wild-card keyboard, and any serial ports, then > PlatformInitializeConsole() currently allows the boot to proceed without > any input devices

Re: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files

Laszlo: 1) Yes. Bug 881 is for nasm update. I will refer it in the commit log. 2) Agree 3) I will add notes to describe .asm in Vtf0 directory are used as nasm source. I don't clean up them. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent:

Re: [edk2] [PATCH 0/7] MdePkg, OvmfPkg, ArmVirtPkg: add and use PCI(E) Capabilities Library

On 05/14/18 17:06, Gao, Liming wrote: > Laszlo: > I have not fully understood its goal and design. Could you give me one more > week to review it? Sure! Thank you. Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, May 14, 2018 9:16 PM >>

Re: [edk2] [PATCH] Enable using device address when programming BARs

On 14 May 2018 at 19:28, Roman Bacik wrote: > Ard, > > Thank you very much for your comment. > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Sunday, May 13, 2018 3:25 AM >> To: Roman Bacik >> Cc:

Re: [edk2] [PATCH] Enable using device address when programming BARs

Ard, Thank you very much for your comment. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday, May 13, 2018 3:25 AM > To: Roman Bacik > Cc: edk2-devel@lists.01.org; Ruiyu Ni; Vladimir Olovyannikov > Subject: Re: [edk2] [PATCH] Enable using

[edk2] [PATCH v1 00/11] BaseTools refactoring

This patch cleans up BaseTools. On classes that are not instantiated and are deisgned as purely base classes, they get marked using the abstract base class to prevent instantiation. This prevents future errors. Create a new shared base class to centralize some code that was identical in multiple

[edk2] [PATCH v1 04/11] BaseTools: remove repeated calls to startswith/endswith

As both can take a tuple, use that instead of calling repeatedly. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 02/11] BaseTools: Workspace - create a base class

refactor 3 classes and create a new base class for their shared functions. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 03/11] BaseTools: remove unused code

delete commented out code delete never used class/variable/function/import refactor to remove Ffs class dont construct class just for class attribute Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v1 06/11] BaseTools: refactor section generation

use with for opening files remove unneeded variables dont seek to 0 for just opened file Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 08/11] BaseTools: refactor to change object types

change to object types that are closer to use case. for example: when using a list as a double ended queue, use the built in object. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

[edk2] [PATCH v1 05/11] BaseTools: use set presence instead of series of equality

Instead of testing each equality individually, just make a set and test once. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH] MdePkg: Update MmSwDispatch.h's references to SmmSw2Dispatch.

MmSwDispatch.h current refers to the deprecated SmmSw2Dispatch protocol. Replace those references with the new MmSwDispatch name. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Include/Protocol/MmSwDispatch.h | 8

[edk2] [PATCH] EmulatorPkg/SmbiosLib: Declare the correct library class.

Currently, SmbiosLib declares the PcdLib library class. Update the declaration to declare SmbiosLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf | 4 ++-- 1 file changed, 2

Re: [edk2] [PATCH] Enable using device address when programming BARs

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, May 14, 2018 10:35 AM > To: Roman Bacik > Cc: edk2-devel@lists.01.org; Ruiyu Ni; Vladimir Olovyannikov > Subject: Re: [edk2] [PATCH] Enable using device address when programming > BARs > > On 14

[edk2] Proposition of a BmEnumerateBootOptions() hook.

Hey Star, Eric and everyone else, I have seen that some platforms add a Boot Option for the UEFI Shell in "PlatformBootManagerBeforeConsole()", which is called as part of the regular boot flow. This is surely beneficial for development platforms that are supposed to boot to UEFI Shell by

Re: [edk2] [PATCH] Enable using device address when programming BARs

Hi Roman, On 05/14/18 19:35, Ard Biesheuvel wrote: > On 14 May 2018 at 19:28, Roman Bacik wrote: >> Ard, >> >> Thank you very much for your comment. >> >>> -Original Message- >>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>> Sent: Sunday, May 13,

[edk2] [PATCH v1 11/11] BaseTools: remove extra assignment

there is no use to assign back to a variable. just return the result. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 09/11] BaseTools: refactor to stop re-allocating strings

strings are immutable. allocate minimal duplication. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2] [PATCH v1 07/11] BaseTools: refactor file opening/writing

change mode minimal needed permissions change to use with statement Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] Query regarding hole in EFI Memory Map

Hi All, Recently, I have observed that there was a hole in EFI Memory Map passed by firmware to Linux kernel. So, wanted to check with you if this is expected or not. My Test setup: I usually boot qemu with OVMF and Linux kernel. I use below command to boot kernel. "qemu-system-x86_64 -cpu

Re: [edk2] Query regarding hole in EFI Memory Map

Of all the gin joints in all the towns in all the world, Prakhya, Sai Praneeth had to walk into mine at 16:30 on Monday 14 May 2018 and say: > Hi All, > > Recently, I have observed that there was a hole in EFI Memory Map passed by > firmware to Linux kernel. So, wanted to check with you if this

Re: [edk2] Query regarding hole in EFI Memory Map

And now you see it again with 64-bit machines, where the flash and PCI config space (and MMIO) appear below 4GB, but there is DRAM above and below 4GB. Tim -Original Message- From: edk2-devel On Behalf Of Bill Paul Sent: Monday, May 14, 2018 6:13 PM To:

Re: [edk2] Query regarding hole in EFI Memory Map

> Of all the gin joints in all the towns in all the world, Prakhya, Sai > Praneeth had to > walk into mine at 16:30 on Monday 14 May 2018 and say: > > > Hi All, > > > > Recently, I have observed that there was a hole in EFI Memory Map > > passed by firmware to Linux kernel. So, wanted to check

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

Cc Ray. Thanks, Star From: Marvin H?user [mailto:marvin.haeu...@outlook.com] Sent: Tuesday, May 15, 2018 3:00 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: Proposition of a BmEnumerateBootOptions() hook. Hey Star, Eric and everyone