Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Monday, July 02, 2018 4:57 PM
>To: edk2-devel@lists.01.org
>Cc: Bi, Dandan ; Gao, Liming ;
>Zeng, Star
>Subject: [edk2] [PATCH] MdeModulePkg Variable:
Hi Zenith,
I like your patch. Sorry for the late response. I see your patch has no impact
to current supported relocation types, and I also hope we can add more
relocation types in our GenFw tool.
Below are some code style issues in your patch:
> +STATIC
> +VOID
>
Hi Liming,
Using a bitmask to advertise capabilities is a common mechanism in driver APIs
(e.g. network link capabilites). In some cases, one needs to allocate a buffer
per capability and thus they need to count the set bits. The algorithms to do
that are fairly well known and generally
On 02/07/18 10:31, Tomas Pilar (tpilar) wrote:
> Hi Liming,
>
> Using a bitmask to advertise capabilities is a common mechanism in driver
> APIs (e.g. network link capabilites). In some cases, one needs to allocate a
> buffer per capability
Apologies, I meant 'buffer with size proportional
On Mon, Jul 02, 2018 at 08:37:41AM +, Wu, Jiaxin wrote:
> Sorry, I can't access below google link:(. It will be better to share us the
> steps to reproduce the issue. I don't know whether the below two files are
> enough to reproduce the issue, but you can share it to me first, then I will
Please add reference to bugzilla link into the commit log.
https://bugzilla.tianocore.org/show_bug.cgi?id=944
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, June 25, 2018 3:37 PM
To:
Please add reference to bugzilla link into the commit log.
https://bugzilla.tianocore.org/show_bug.cgi?id=944
Another, is there any reason to only add debug message for " if
((BmpHeader->PixelHeight == 0) || (BmpHeader->PixelWidth == 0)) { ", but not "
if ((PixelHeight == 0) || (PixelWidth ==
Thanks for linking that issue. I'd really like to see that getting solved.
As for ninja: Yes it usually reduces build time a lot because unlike make
it uses a very simple and fast to parse language and handles threads
completely by its own(you don't have to tell it how many jobs to use).
Sorry, I can't access below google link:(. It will be better to share us the
steps to reproduce the issue. I don't know whether the below two files are
enough to reproduce the issue, but you can share it to me first, then I will
try that.
> bootx64.efi: 1208528 bytes
> grub.efi: 1057792 bytes
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 2/3] MdeModulePkg/[Pei|Dxe]ResetSystemLib: Add PPI/Protocol
dependency
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 1/3] MdeModulePkg/ResetUtilityLib: Add pack(1) for reset data
structure
RESET_UTILITY_GUID_SPECIFIC_RESET_DATA structure should be
Tomas:
Could you share some background what code depends on new added APIs?
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Tomas Pilar (tpilar)
>Sent: Friday, June 29, 2018 5:42 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2]
Reviewed-by: Star Zeng
How about doing same update in ResetSystemPei in an updated patch or a
separated patch?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 3/3]
On Mon, Jul 02, 2018 at 05:34:29AM +, Wu, Jiaxin wrote:
> Hi Gary,
>
> Thanks the verification, in my part, HTTPS works well. Can you send me
> the failure wireshark packet/full debug message?
>
> (correct the typo)
>
Per my test, HTTPS worked for firmware -> bootx64.efi(shim.efi), and
shim
Today's MpInitLib PEI implementation directly calls
PeiServices->GetHobList() from AP which may cause racing issue.
This patch fixes this issue by duplicating IDT for APs.
Because CpuMpData structure is stored just after IDT, the CpuMPData
address equals to IDTR.BASE + IDTR.LIMIT + 1.
v2:
1.
Michael:
There is one bugzilia https://bugzilla.tianocore.org/show_bug.cgi?id=972 on
top level makefile generation. Its purpose is to let the make utility figure
out how to multi-thread the build and see whether there is the build
performance improvement.
Edk2 BaseTools generates AutoGen
Use compare logic in if condition to fix ECC issue.
It is caused by aa4240edff41034d709938a15b42cf4fd3214386.
Cc: Hao Wu
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 2 +-
1 file
It is caused by 09808bd39b0c76559354253639766458ec24da79.
Cc: Liming Gao
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Universal/Variable/Pei/Variable.c| 3 +++
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2
On Wed, Jun 27, 2018 at 05:47:41PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
>
> The changes can be seen at
> https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1
For series:
Reviewed-by: Leif Lindholm
Pushed as
On Wed, Jun 27, 2018 at 05:48:42PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
>
> The changes can be seen at
> https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1
For series:
Reviewed-by: Leif Lindholm
Pushed as
Hi Tomas
I'm not a maintainer here, so my comments are just that and carry no weight
beyond making suggestions that you may wish to consider.
> -Original Message-
> From: edk2-devel On Behalf Of Tomas
> Pilar (tpilar)
> Sent: 29 June 2018 10:42
> To: edk2-devel@lists.01.org
> Subject:
On 07/02/18 08:01, Ruiyu Ni wrote:
> Today's MpInitLib PEI implementation directly calls
> PeiServices->GetHobList() from AP which may cause racing issue.
>
> This patch fixes this issue by duplicating IDT for APs.
> Because CpuMpData structure is stored just after IDT, the CpuMPData
> address
Good idea, I agree.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Tuesday, July 3, 2018 9:05 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zeng, Star
Subject: RE: [edk2] [PATCH] MdeModulePkg SataControllerDxe: Use compare logic
in if condition
Maybe:
if ((Data32
Thanks.
And with the change:
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, July 03, 2018 9:17 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Bi, Dandan; Zeng, Star
> Subject: RE: [edk2] [PATCH] MdeModulePkg SataControllerDxe: Use
On 7/2/2018 6:05 PM, Zeng, Star wrote:
Please add reference to bugzilla link into the commit log.
https://bugzilla.tianocore.org/show_bug.cgi?id=944
OK
Another, is there any reason to only add debug message for " if ((BmpHeader->PixelHeight == 0) ||
(BmpHeader->PixelWidth == 0)) { ", but
REF: https://github.com/christopherco/edk2-platforms/tree/win_build_doc_v2
v1: https://lists.01.org/pipermail/edk2-devel/2018-June/026677.html
v2: Split v1 into separate commits to fix issues found by patch check and
new instructions to setup and build in a Windows Environment
Contributed-under:
Fix for issue found when running patch check script
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christopher Co
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Readme.md | 454 ++--
1 file changed, 227 insertions(+), 227 deletions(-)
Fix for issue found when running patch check script.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christopher Co
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Readme.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
These instructions explain how to setup a Windows build environment
with extra instructions to build for ARM platforms
using the GCC cross-compiler toolchain.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christopher Co
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael
On 7/2/18 10:21 PM, Zeng, Star wrote:
> Please use
> if ((GcdDescriptor.Attributes & EFI_MEMORY_RUNTIME) == 0) {
> instead of
> if (!(GcdDescriptor.Attributes & EFI_MEMORY_RUNTIME)) {
>
> There is coding style and ECC tool check about it. See
>
Maybe:
if ((Data32 & ((UINT32) 1 << MaxPortNumber)) != 0) {
instead of:
if ((Data32 & (UINT32) (1 << MaxPortNumber)) != 0) {
to avoid possible undefined behavior for case like '1 << 31'?
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel
So, you mean caller knows ((PixelHeight == 0) || (PixelWidth == 0)), and caller
knows TranslateGopBltToBmp will return RETURN_UNSUPPORTED for that?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:03 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney,
On 7/3/2018 10:10 AM, Zeng, Star wrote:
So, you mean caller knows ((PixelHeight == 0) || (PixelWidth == 0)), and caller
knows TranslateGopBltToBmp will return RETURN_UNSUPPORTED for that?
Caller knows an error status may return when any of
PixelHeight/PixelWidth is 0.
But that's not the reason
Ok. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:17 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney, Michael D
Subject: Re: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check
PixelHeight/PixelWidth against 0
On 7/3/2018
Please use
if ((GcdDescriptor.Attributes & EFI_MEMORY_RUNTIME) == 0) {
instead of
if (!(GcdDescriptor.Attributes & EFI_MEMORY_RUNTIME)) {
There is coding style and ECC tool check about it. See
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 4:57 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Gao, Liming ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 5:42 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Bi, Dandan ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
Set the EFI_MEMORY_RUNTIME attribute in FtwNotificationEvent() only if
the attribute is not already present. This will ensure that the attributes
set by the platform drivers (e.g Ovmf pflash) is not lost.
Cc: Dong Eric
Cc: Justen Jordan L
Cc: Zeng Star
Cc: Laszlo Ersek
Contributed-under:
When SEV is active, the flash memory range is mapped as unencrypted by
AmdSevDxe. Mark the flash memory range with EfiGcdMemoryTypeMemoryMappedIo
so that OS maps this memory range as unencrypted.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Liming Gao
If no other comment, I will help push this change.
>-Original Message-
>From: Chris Co [mailto:christopher...@microsoft.com]
>Sent: Friday, June 29, 2018 3:31 AM
>To: edk2-devel@lists.01.org
>Cc: Leif Lindholm ; Zhu, Yonghong
>; Gao, Liming
>Subject: [PATCH v2
OK. Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Monday, July 02, 2018 11:13 AM
>To: Gao, Liming ; edk2-devel@lists.01.org
>Cc: Feng, Bob C
>Subject: RE: [Patch] BaseTool: Add cache for the result of SkipAutogen.
>
>Hi Liming,
>
>Based on my testing, a module
41 matches
Mail list logo
