[edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win Host

2018-08-27 Thread Ruiyu Ni
The patch sets make Win Host boot in 64 bit, fix all SCT issues regarding to console input/output, switch to use MdeModulePkg/Bds. Ruiyu Ni (10): EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode EmulatorPkg/Win: U

[edk2] [PATCH 03/10] EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation

2018-08-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 1 + EmulatorPkg/Win/Host/WinGop.h | 4 +- EmulatorPkg/Win/Host/WinGopScreen.c | 218 EmulatorPkg/W

[edk2] [PATCH 01/10] EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmuGopDxe/GopInput.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/EmulatorPkg/E

[edk2] [PATCH 04/10] EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/Win/Host/WinGopInput.c | 17 + 1 file changed, 17 insertions(+) diff --git a/EmulatorPkg/Win/Host

[edk2] [PATCH 09/10] EmulatorPkg: Use MdeModulePkg/Bds module

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1120 Logo is enabled by adding a separate core driver LogoDxe. UiApp and BootManagerMenuApp are added to provide two UIs. LoadFileOnFv2 is added to auto-install LoadFile protocol for applications in FV so the boot options for applications can be

[edk2] [PATCH 06/10] EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)

2018-08-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 6 +- EmulatorPkg/Win/Host/WinBlockIo.c | 2 +- EmulatorPkg/Win/Host/WinHost.c| 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff

[edk2] [PATCH 05/10] EmulatorPkg/Win: Do not zero out file content

2018-08-27 Thread Ruiyu Ni
The patch changes the behavior to not zero out file content when the file size is not multiple of block size. Instead, it just provides access to the contents that are multiple of block size and leaves the remaining content (less than block size) untouched. Contributed-under: TianoCore Contributio

[edk2] [PATCH 10/10] EmulatorPkg: IoThunk->Close() is called too early, may causing hang

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1121 To produce a EFI_BLOCK_IO_PROTOCOL instance in Emulator platform, EmulatorPkg defines the EMU_IO_THUNK_PROTOCOL. OS dependent layer needs to produce this protocol implementation and a generic OS independent layer consumes this protocol to pr

[edk2] [PATCH 07/10] EmulatorPkg/AutoScanPei: Report the correct CPU address size

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1119 Today's implementation unconditionally reports CPU address size as 36 through CPU HOB. But when WinHost is running at 64bit, the system memory might be allocated above 2^36. It causes system asserts when DxeCore code tries to find the corre

[edk2] [PATCH 02/10] EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode

2018-08-27 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmuGopDxe/GopScreen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/EmulatorPkg/EmuG

[edk2] [PATCH 08/10] EmulatorPkg/Win: Add VS2017 project file

2018-08-27 Thread Ruiyu Ni
Developer can build the Win Host in VS2017 and launch to debug it. Platform 'x64' is to build 64bit EmulatorWin. Platform 'Win32' is to build 32bit EmulatorWin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/Win/VS2017

Re: [edk2] [PATCH 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-08-27 Thread Sumit Garg
On Fri, 24 Aug 2018 at 23:33, Matteo Carlini wrote: > > +Achin > > SPD (for OP-TEE and other Trusted-OSes payloads running at S-EL1) and SPM > (for Secure Partitions at S-EL0) are currently mutually exclusive into > Trusted Firmware-A codebase. > > In other words, you cannot turn them on in para

[edk2] [PATCH v2 0/2] Add ArmPkg/Optee library APIs

2018-08-27 Thread Sumit Garg
Changes in v2: 1. Separate patch for MdePkg/Include/IndustryStandard/GlobalPlatform.h. 2. Correct comments style for struct members. 3. Update commit message. Sumit Garg (2): MdePkg/IndustryStandard: Add Global Plaform header file ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE ArmPkg/I

[edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

2018-08-27 Thread Sumit Garg
Add Global Plaform header file specific to TEE Client API Specification v1 . Cc: Michael D Kinney Cc: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sumit Garg ---

[edk2] [PATCH v2 2/2] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-08-27 Thread Sumit Garg
Add following APIs to communicate with OP-TEE pseudo/early TAs: 1. OpteeInit 2. OpteeOpenSession 3. OpteeCloseSession 4. OpteeInvokeFunc Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sumit Garg --- ArmPkg/Include/Library/OpteeLib.h

[edk2] Can we use python 3 to build edk2?

2018-08-27 Thread heyi . guo
It is said that python3 is not compatible with python2. Can we use python3 to build edk2? Thanks, Heyi ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Can we use python 3 to build edk2?

2018-08-27 Thread Zhu, Yonghong
We are in migrating BaseTools to Python3. Best Regards, Zhu Yonghong -Original Message- From: heyi@linaro.org [mailto:heyi@linaro.org] Sent: Monday, August 27, 2018 7:53 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: Can we use python 3 to build edk2? I

Re: [edk2] Can we use python 3 to build edk2?

2018-08-27 Thread Laszlo Ersek
On 08/27/18 13:53, heyi@linaro.org wrote: > It is said that python3 is not compatible with python2. Did you mean s/said/sad/? :) > Can we use python3 to build edk2? Gary and Mike wrote several BaseTools patches for python3 compatibility; I'm unsure if we have a high-level tracker BZ for that

Re: [edk2] Can we use python 3 to build edk2?

2018-08-27 Thread Zhu, Yonghong
We have a bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=55 Current I am working on it. And planned to finish to migrate to Python 3 before end of October. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Las

Re: [edk2] Can we use python 3 to build edk2?

2018-08-27 Thread Laszlo Ersek
On 08/27/18 15:31, Zhu, Yonghong wrote: > We have a bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=55 > Current I am working on it. And planned to finish to migrate to Python 3 > before end of October. Thank you! Laszlo ___ edk2-devel mailing

[edk2] [PATCH v1 1/1] BaseTools: AutoGen.py remove unused import

2018-08-27 Thread Jaben Carsey
AutoGen does not use anything defined in BuildClassObject Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Source/Pytho

Re: [edk2] [PATCH] BaseTools: Add check only VOID* type Pcd need the maxsize info

2018-08-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, August 27, 2018 10:03 AM To: edk2-devel@lists.01.org Cc: Fan, ZhijuX ; Gao, Liming Subject: [edk2] [PATCH] BaseTool

Re: [edk2] Can we use python 3 to build edk2?

2018-08-27 Thread heyi . guo
That's really good news; thank you all! Heyi On Mon, Aug 27, 2018 at 05:58:35PM +0200, Laszlo Ersek wrote: > On 08/27/18 15:31, Zhu, Yonghong wrote: > > We have a bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > Current I am working on it. And planned to finish to migrate to Pyth

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-27 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Tuesday, August 21, 2018 11:05 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Ni, > Ruiyu > Subject: [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single > step in #PF handler > > > v2

[edk2] [Patch 0/2] Add 32bit subnet mask support for IP4 PXE

2018-08-27 Thread Fu Siyuan
Fu Siyuan (2): MdeModulePkg/Network: Add 32bit subnet mask support for IP4 PXE boot. ShellPkg: Update Ifconfig command to accept 32bit subnet mask. MdeModulePkg/Include/Library/NetLib.h | 5 +- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c| 13 +- .../Universal/Network/Ip4Dxe/Ip4C

[edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask.

2018-08-27 Thread Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Fu Siyuan Cc: Ruiyu Ni Cc: Ye Ting Cc: Wu Jiaxin --- ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c b/S

[edk2] [Patch 1/2] MdeModulePkg/Network: Add 32bit subnet mask support for IP4 PXE boot.

2018-08-27 Thread Fu Siyuan
This patch updates IP4 stack to support 32bit subnet mask in PXE boot process. When 32bit subnet mask is used, the IP4 driver couldn't use the subnet mask to determine whether destination IP address is on-link or not, so it will always try to send all the packets to the destination IP address dir

Re: [edk2] [PATCH V2 1/2] MdePkg SmBios.h: Add SMBIOS 3.2.0 definitions

2018-08-27 Thread Gao, Liming
I have no other comments. Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Monday, August 27, 2018 9:07 AM >To: Bi, Dandan ; edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Zeng, Star >Subject: RE: [PATCH V2 1/2] MdePkg SmBios.h: Add SMBIOS 3.2.0 defin

[edk2] [patch] MdeModulePkg/Setup: Fix incorrect size used in AllocateCopyPool

2018-08-27 Thread Dandan Bi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1115 When the type of HiiValue is EFI_IFR_TYPE_BUFFER, its question type is EFI_IFR_ORDERED_LIST_OP. And the buffer size allocated for Statement->BufferValue of orderedList is "Statement->StorageWidth" in IfrParse.c. So here when backup the buffe

Re: [edk2] [edk2-wiki PATCH] release planning: Add "SMBIOS 3.2.0 support" in Proposed Features

2018-08-27 Thread Zeng, Star
Pushed the patch at 5ec70b030eb623f0e5dfc66eeabbae513235d238. Thanks very much. Star -Original Message- From: Zeng, Star Sent: Friday, August 24, 2018 5:16 PM To: Laszlo Ersek ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Andrew Fish ; Leif Lindholm ; Bi, Dandan ; Zeng, Star Subjec

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-27 Thread Wang, Jian J
Thanks. Since there're just some minor changes, I'll not provide v3 patches and push the changes to master soon. Regards, Jian From: Dong, Eric Sent: Tuesday, August 28, 2018 9:15 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Ni, Ruiyu Subject: RE: [PATCH v2 2/4] UefiCpuPkg/Cp

[edk2] [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFs

[edk2] [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry Cc: Jiewen Yao Cc: Chasel Chiu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed

[edk2] [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize Cc: Jiewen Yao Cc: Chasel Chiu Cc: Laszlo

[edk2] [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize Cc: Jiewen Yao Cc: Chasel Chiu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- ..

[edk2] [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision gEfiMdeModulePkgTokenSpa

[edk2] [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress Cc: Jiewen Yao Cc: Chasel Chiu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNo

[edk2] [PATCH v3 00/16] Removed unused PCDs

2018-08-27 Thread shenglei
A lot of unused PCDs are removed from inf. All packages are built and the results are "pass". v2: 1.Split MdeModulePkg into separated patches. 2.Split IntelFsp2Pkg into separated patches. v3: 1.Split ShellPkg into separated patches. 2.Split SecurityPkg into separated patches. 3.Split IntelFsp2Wra

[edk2] [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gEfiMdePkgTokenSpaceGuid.PcdPciExpr

[edk2] [PATCH v3 10/16] MdePkg/BaseLib: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Laszlo Ersek --- MdePkg/Library/BaseLib/Ba

[edk2] [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shengl

[edk2] [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress Cc: Jiewen Yao Cc: Chao Zhang Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Config/Tcg2

[edk2] [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCap

[edk2] [PATCH v3 14/16] ShellPkg/DpDynamicCommand: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpApp.inf gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpDynamicCommand.inf Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contributio

[edk2] [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Star Zeng --- .../FirmwarePerformance

[edk2] [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Eric Dong --- UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommon

[edk2] [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD

2018-08-27 Thread shenglei
The PCD below is unused, so it has been removed from inf. gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiHandlePar

[edk2] [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs

2018-08-27 Thread shenglei
The PCDs below are unused, so they have been removed from inf. gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Re

Re: [edk2] [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs

2018-08-27 Thread Zeng, Star
Shenglei, The library Pcdlib is not linked, so "#include " is deleted. There is massy code, please correct it before it can be pushed. Thanks, Star -Original Message- From: Zhang, Shenglei Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Er

Re: [edk2] [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD

2018-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel ; Laszlo Ersek Subject: [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD The PCD below

Re: [edk2] [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs

2018-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel ; Laszlo Ersek Subject: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs The PCDs be

[edk2] [PATCH] Maintainers.txt: Update maintainer of MdeModulePkg

2018-08-27 Thread Star Zeng
Add Jian J Wang and remove Eric Dong . Eric is focusing on UefiCpuPkg. Cc: Jian J Wang Cc: Eric Dong Cc: Michael D Kinney Cc: Laszlo Ersek Cc: Andrew Fish Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- Maintainers.txt | 2 +- 1 file

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer of MdeModulePkg

2018-08-27 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Tuesday, August 28, 2018 1:36 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Dong, Eric ; Kinney, Michael D > ; Laszlo Ersek ; Andrew Fish > ; Leif Lindholm > Subject: [PATCH] Maintainers.txt:

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer of MdeModulePkg

2018-08-27 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zeng, Star > Sent: Tuesday, August 28, 2018 1:36 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Dong, Eric ; Kinney, Michael D > ; Laszlo Ersek ; Andrew > Fish ; Leif Lindholm > Subject: [PATCH] Maintainers.txt: Up

Re: [edk2] [Patch] BaseTools: Fix one expression bug to support ~ operate

2018-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, August 22, 2018 3:17 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix one expression bug to support ~ operate >

[edk2] [V2 patch] ShellPkg/SmbiosView: Update SmbiosView for SMBIOS3.2.0

2018-08-27 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099 Update SmbiosView to parse the new definitions which are introduced in SMBIOS3.2.0 V2: 1. Add structure length check before dump the fileds in Type 9 and Type 17 in case some fileds are not organized and reported by drivers. 2. Dump the Int

Re: [edk2] [PATCH v1 1/1] BaseTools: AutoGen.py remove unused import

2018-08-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, August 28, 2018 6:08 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools: AutoGen.py remove unused import AutoGen does not use anyth

Re: [edk2] [Patch 1/2] MdeModulePkg/Network: Add 32bit subnet mask support for IP4 PXE boot.

2018-08-27 Thread Wu, Jiaxin
Hi Siyuan, In Ip4SendFrameToDefaultRoute(), you tried to find the default gateway IP address by using the found RtCacheEntry->Tag, I'm confused why it's the default gateway? In my understanding, tag is the cache's corresponding route entry. Besides, why we must send the frame to "DefaultRouter