[edk2] [PATCH] MdePkg UefiLib: Check Table against NULL in ScanTableInSDT

2018-10-19 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1266 af5e95215928e052445c473f1244412dadea8252 abstracted generic functions from different modules (IntelVTdDxe, S3SaveStateDxe, PcRtc, DpDynamicCommand and PiSmmCpuDxeSmm). Some of them (IntelVTdDxe and PcRtc) checked Table against NULL before

Re: [edk2] [PATCH] MdePkg UefiLib: Check Table against NULL in ScanTableInSDT

2018-10-19 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Friday, October 19, 2018 4:07 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Kinney, Michael D ; Wang, Jian J > > Subject: [PATCH] MdePkg UefiLib: Check Table against NULL in ScanTableInSDT >

Re: [edk2] [PATCH] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2018-10-19 Thread Zeng, Star
On 2018/10/19 13:28, Ard Biesheuvel wrote: On 19 October 2018 at 13:25, Zeng, Star wrote: Be honest, I am not clear about the history why EfiBootServicesData is required for ESRT. But OS indeed cares about ESRT table, for example, I guess the Firmware in Device Manager for Windows is built

[edk2] [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set

2018-10-19 Thread Yonghong Zhu
the bug is PcdValueFromComm is not set, but the Pcd have been override by the command line option. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DscBuildData.py | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

2018-10-19 Thread Gao, Liming
Laszlo: I try to answer your question. I also include the BZ submitter brent.holtsc...@intel.com. Holtsclaw, please add your comments if my info is not enough. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, October 19, 2018 12:01 AM

Re: [edk2] [staging/MicroPythonTestFramework]: MicroPython Test Framework for UEFI

2018-10-19 Thread Richardson, Brian
Leif: Thank you for your feedback. Long Qin is a good starting contact for MicroPython issues. There are readme files for the sub-components, but I agree that the missing top-level readme file is an issue.

Re: [edk2] [PATCH v2] NetworkPkg/IpSecDxe: Fix issue to parse SA Payload.

2018-10-19 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, October 18, 2018 4:44 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin Subject: [PATCH v2] NetworkPkg/IpSecDxe: Fix issue to parse SA Payload. Ref:

Re: [edk2] CVE-2018-3613 [was: MdeModulePkg Variable: Fix Timestamp zeroing issue on APPEND_WRITE]

2018-10-19 Thread Zeng, Star
Hi Laszlo, Cc Qin also. Qin and Chao are secure boot experts, I also had some talk with them. On 2018/10/19 5:45, Laszlo Ersek wrote: Hi All, On 10/16/18 04:41, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415 When SetVariable() to a time based auth variable with

[edk2] [Patch] BaseTools: Fix the *B and *F Flag display for Structure Pcd

2018-10-19 Thread Yonghong Zhu
Because of we newly add the PcdFieldValueFromComm and PcdFieldValueFromFdf in early parser phase, so in the report we use the saved value in this two variables to print it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch] BaseTools: Fix the crash issue when Dynamic structure Pcd use in FDF

2018-10-19 Thread Yonghong Zhu
The case is use Dynamic structure Pcd in the FDF file. Current code already save the Guid, Name and Filed info for those Pcd, but it directly use the dict key as [Name, Guid] and cause this crash issue. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1264 Contributed-under: TianoCore

Re: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.

2018-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Thursday, October 18, 2018 1:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options

Re: [edk2] [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set

2018-10-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, October 19, 2018 12:27 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix the bug that PcdValueFromComm is > not

Re: [edk2] [Patch] BaseTools: Fix the crash issue when Dynamic structure Pcd use in FDF

2018-10-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, October 19, 2018 12:21 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix the crash issue when Dynamic > structure

Re: [edk2] [Patch v4 1/6] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

2018-10-19 Thread Laszlo Ersek
On 10/19/18 04:06, Eric Dong wrote: > v3 changes: > 1. Move CPU_FEATURE_DEPENDENCE_TYPE definition here from > RegisterCpuFeaturesLib.h file. > 2. Add Invalid type for REGISTER_TYPE which will be used in code. > > v2 changes: > 1. Add more description about why we do this change. > 2. Change

Re: [edk2] [Patch v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support semaphore type.

2018-10-19 Thread Laszlo Ersek
On 10/19/18 04:06, Eric Dong wrote: > V4 changes: > 1. Serial console log for different threads when program register table. > 2. Check the AcpiCpuData before use it to avoid potential ASSERT. > > V3 changes: > 1. Use global variable instead of internal function to return string for > register

Re: [edk2] [PATCH v1 4/6] ArmVirtPkg: Save DT base address from X0 in PCD

2018-10-19 Thread Ard Biesheuvel
On 14 October 2018 at 05:35, Laszlo Ersek wrote: > On 10/12/18 16:40, Sami Mujawar wrote: >> Some virtual machine managers provide the base address of the DT >> in memory in the X0 register. Save the DT Base address in the >> PcdDeviceTreeInitialBaseAddress so that the firmware can use the >> PCD

Re: [edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-10-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > BobCF > Sent: Friday, October 19, 2018 5:00 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTool: Filter out unused structure pcds >

Re: [edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

2018-10-19 Thread Gao, Liming
Laszlo: > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 19, 2018 7:25 PM > To: Gao, Liming ; Zeng, Star ; > edk2-devel@lists.01.org; Ard Biesheuvel > ; Holtsclaw, Brent > Subject: Re: [edk2] [Patch 0/3] Add more checker for Tianocompress and

Re: [edk2] [Patch v4 1/6] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

2018-10-19 Thread Laszlo Ersek
On 10/19/18 04:06, Eric Dong wrote: > v3 changes: > 1. Move CPU_FEATURE_DEPENDENCE_TYPE definition here from > RegisterCpuFeaturesLib.h file. > 2. Add Invalid type for REGISTER_TYPE which will be used in code. > > v2 changes: > 1. Add more description about why we do this change. > 2. Change

Re: [edk2] [Patch v4 5/6] UefiCpuPkg/CpuS3DataDxe: Keep old data if value already existed.

2018-10-19 Thread Laszlo Ersek
On 10/19/18 04:06, Eric Dong wrote: > AcpiCpuData add new fields, keep these fields if old data already existed. > > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > Reviewed-by: Ruiyu Ni > --- >

[edk2] TianoCore Community Meeting Minutes

2018-10-19 Thread Jeremiah Cox
Finally finding time to respond to an older thread... >>> The was a concern raised over potential lock-in to Github's, specifically in >>> regards to history retention. >>> Several Github users brought up that this shouldn't be an issue. >> >> Hopefully they said more than that. >> What does

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-19 Thread Jeremiah Cox
In GitHub, adding a link from a PR to an Issue is extremely easy: https://help.github.com/articles/closing-issues-using-keywords/ Use any of the following strings, followed by a number, in a PR description... close closes closed fix fixes fixed resolve resolves resolved For example: "Closes

[edk2] [platforms: PATCH 04/12] Marvell/Armada70x0Db: Introduce board description library

2018-10-19 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada70x0Db and introduces ArmadaBoardDescGpioGet routine with per-board I2C IO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc

[edk2] [platforms: PATCH 05/12] Marvell/Armada80x0Db: Introduce board description library

2018-10-19 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0Db and introduces ArmadaBoardDescGpioGet routine with per-board I2C IO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc

[edk2] [platforms: PATCH 12/12] Marvell/Armada7k8k: Introduce NonDiscoverable device init routines

2018-10-19 Thread Marcin Wojtas
To abstract the initialization required for non-discoverable devices, which is often platform specific (i.e., enabling VBUS gpios for USB), introduce a NonDiscoverableInitLib for use by the NonDiscoverable code, for which each platform can supply its own version. Add VBUS enabling routines for

[edk2] [platforms: PATCH 10/12] Marvell/Drivers: MvPca95xxDxe: Introduce I2C GPIO driver

2018-10-19 Thread Marcin Wojtas
Marvell Armada 7k/8k-based platforms may use Pca95xx to extend amount of the GPIO pins. This patch introduces support for PCA95xxx I2C IO expander family, which is a producer of MARVELL_GPIO_PROTOCOL, by implementing necessary routines. Driver is based on initial work done by Allen Yan .

[edk2] [platforms: PATCH 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information

2018-10-19 Thread Marcin Wojtas
This patch extends library with GPIO devices per-board description. Both embedded SoC controllers and I2C IO expanders are supported. Add a helper routine for obtaining information about the latter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 09/12] Marvell/Drivers: I2c: Use common header for macros

2018-10-19 Thread Marcin Wojtas
Hitherto I2c solution used same macros, defined in multiple places. Move them to a new common header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 ---

[edk2] [platforms: PATCH 11/12] Marvell/Armada7k8k: Enable GPIO drivers compilation

2018-10-19 Thread Marcin Wojtas
Enable building new GPIO drivers before adding VBUS pins handling. Update relevant boards .dsc files with IO expander information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 ++

[edk2] [platforms: PATCH 03/12] SolidRun/Armada80x0McBin: Introduce board description library

2018-10-19 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and introduces ArmadaBoardDescGpioGet routine with per-board I2C IO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 07/12] Marvell/Protocol: Introduce MARVELL_GPIO_PROTOCOL

2018-10-19 Thread Marcin Wojtas
From: jinghua This patch introduces protocol that can be used by multiple producers (e.g. platform driver or I2C I/O expander). It exposes generic api for controlling GPIO pins state. Drives are differentiated by MARVELL_GPIO_DRIVER_TYPE field of driver's MV_GPIO_DEVICE_PATH. In order to ease

[edk2] [platforms: PATCH 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2018-10-19 Thread Marcin Wojtas
Introduce new callback that can provide information about GPIO SoC controllers, as well as on-board I2C IO expanders. According ArmadaSoCDescLib ArmadaBoardDescLib routines are used for obtaining required data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2018-10-19 Thread Marcin Wojtas
From: jinghua Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers, one in AP and two in each possible CP hardware blocks. This patch introduces support for them, which is a producer of MARVELL_GPIO_PROTOCOL, which add necessary routines. Hardware description of the controllers is

[edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-10-19 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescGpioGet ()), which dynamically allocates and fills MV_SOC_GPIO_DESC structure with the SoC description of GPIO controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 00/12] Armada7k8k GPIO support

2018-10-19 Thread Marcin Wojtas
Hi, This patchset introduces entire infrastructure for using GPIO on Marvell devices. Finally the USB ports are properly power-supplied on all currently supported boards. Main changes are as follows: - New GPIO protocol for handling basic pins operations. It allows very easy usage from

[edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-10-19 Thread BobCF
The current code handle all the structure pcds even if there is no module or library use them. This patch is going to filter out the unused structure pcds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-19 Thread Laszlo Ersek
On 10/19/18 03:50, Jian J Wang wrote: > UAF (Use-After-Free) memory detection is new feature introduced to > detect illegal access to memory which has been freed. The principle > behind is similar to heap guard feature, that is the core turn all pool > memory allocation to page allocation and mark

Re: [edk2] CVE-2018-3613 [was: MdeModulePkg Variable: Fix Timestamp zeroing issue on APPEND_WRITE]

2018-10-19 Thread Laszlo Ersek
On 10/19/18 09:09, Zeng, Star wrote: > Hi Laszlo, > > Cc Qin also. Qin and Chao are secure boot experts, I also had some talk > with them. > > On 2018/10/19 5:45, Laszlo Ersek wrote: >> Hi All, >> >> On 10/16/18 04:41, Star Zeng wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415

[edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-10-19 Thread Ard Biesheuvel
Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows for ACPI/Linux support") updated the min/max/offset definitions for the PCIe I/O resource windows on SynQuacer, and updated the read path of the platform's EfiCpuIo2 protocol implementation, but failed to update the write path as well,

Re: [edk2] [PATCH] MdePkg UefiLib: Check Table against NULL in ScanTableInSDT

2018-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Friday, October 19, 2018 4:07 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Kinney, Michael D ; Wang, > Jian J > Subject: [PATCH] MdePkg UefiLib: Check Table against NULL in ScanTableInSDT >

Re: [edk2] [PATCH] MdePkg/BaseLib: AsciiStrToUnicodeStr(S) not handle EASCII properly

2018-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Friday, October 19, 2018 11:06 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Bin . Lain ; > Yao, Jiewen ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH] MdePkg/BaseLib: AsciiStrToUnicodeStr(S) not handle

Re: [edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

2018-10-19 Thread Laszlo Ersek
On 10/19/18 08:40, Gao, Liming wrote: > Laszlo: > I try to answer your question. I also include the BZ submitter > brent.holtsc...@intel.com. Holtsclaw, please add your comments if my > info is not enough. > > Thanks > Liming >> -Original Message- >> From: Laszlo Ersek

Re: [edk2] [PATCH 1/3] MdeModulePkg/MdeModulePkg.dec: add new PCD for UAF detection feature

2018-10-19 Thread Laszlo Ersek
On 10/19/18 03:50, Jian J Wang wrote: > UAF (Use-After-Free) memory detection is new feature introduced to > detect illegal access to memory which has been freed. The principle > behind is similar to heap guard feature, that is we'll turn all pool > memory allocation to page allocation and mark

Re: [edk2] [PATCH 2/3] UefiCpuPkg/CpuDxe: fix an infinite loop issue

2018-10-19 Thread Laszlo Ersek
On 10/19/18 03:50, Jian J Wang wrote: > The UAF (Use-After-Free) memory detection feature will cause an > infinite calling of InitializePageTablePool(). This is due to a > fact that AllocateAlignedPages() is used to allocate page table > pool memory. This function will most likely call

[edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-19 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265 FSP should not override IDT table when it is initialized by boot loader. IDT should be re-initialized in FSP only when it is invalid. Test: Verified on internal platform and boots successfully. Cc: Jiewen Yao Cc: Desimone Nathaniel L