Re: [edk2] [PATCH v3 12/12] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-30 Thread Ard Biesheuvel
On 30 July 2015 at 02:59, Gao, Liming liming@intel.com wrote: Jordan: I have verified 4K aligned image build. Test-by: Liming Gao liming.gao@intel Thanks Liming Just to be clear, I assume you added something like this diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-30 Thread Laszlo Ersek
On 07/30/15 13:37, David Woodhouse wrote: On Tue, 2015-07-28 at 20:26 +0200, Laszlo Ersek wrote: series (up to and including 3/2) Tested-by: Laszlo Ersek ler...@redhat.com If you did this by pulling my tree, rather than manually applying patches — which I'm fairly sure you did — then you

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Leif Lindholm
Hi Jordan, On Wed, Jul 29, 2015 at 02:59:04PM -0700, Jordan Justen wrote: But, the name 'open platform' also sounds strange, assuming this a plain PCI bus driver. Couldn't it live in a 'pci drivers' package? Personally, I think we should rename OptionRomPkg to DriversPkg, or split

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Jordan Justen
On 2015-07-30 11:51:56, Kinney, Michael D wrote: Jordan, I agree with the concept of having package(s) for device driver content. OptionRomPkg is really only intended to provide good examples for writing drivers, and we want to restrict what goes in there to a good example for each driver

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Blibbet
[...] Sorry I was thinking more about routine maintenance (like the string n cleanup recently), or refactoring of the code disabling the exploit mechanism with out knowledge that the exploit exists. I guess an older branch can get patched, but the commit history in master is not going to

Re: [edk2] [PATCH 2/4] ArmVirtPkg: use 'auto' alignment and FIXED placement for XIP modules

2015-07-30 Thread Laszlo Ersek
On 07/28/15 18:42, Ard Biesheuvel wrote: Now that GenFw correctly propagates the minimum alignment of the ELF input sections to the PE/COFF binary, we can simply select 'auto' alignment in the FDF Rule section instead of tweaking it by hand. Also add the FIXED FFS attribute to the module

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Jordan Justen
On 2015-07-30 15:35:58, Yao, Jiewen wrote: Hello Do we consider below 2 options? -- DriversPkg/Vendor/VendorName/Bus/BusType ? or -- DriversPkg/Bus/BusType/Vendor/VendorName ? Another option is that we add DriverCategory, like GOP/UNDI/RAID/SIO. Then we can put UNDI driver together, no

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-30 Thread Yao, Jiewen
Thanks for the info. That makes sense. It is pity that there is no X64 version and SMP not work. We can make improvement step by step. Thank you Yao Jiewen -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, July 29,

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Yao, Jiewen
Hello Do we consider below 2 options? -- DriversPkg/Vendor/VendorName/Bus/BusType ? or -- DriversPkg/Bus/BusType/Vendor/VendorName ? Another option is that we add DriverCategory, like GOP/UNDI/RAID/SIO. Then we can put UNDI driver together, no matter it is PCI based or USB based. Thank you Yao

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-30 Thread Ard Biesheuvel
On 31 July 2015 at 01:17, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed as SVN r18077 ... r18080 I do have another

[edk2] [Patch] Remove the useless code to fix build failure caused by error depend on IntelFrameworkModulePkg.

2015-07-30 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com --- .../Application/UiApp/BootMaint/BootOption.c | 58 -- .../Application/UiApp/BootMaint/UpdatePage.c | 29 --- MdeModulePkg/Application/UiApp/Ui.h

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Andrew Fish
On Jul 30, 2015, at 3:35 PM, Laszlo Ersek ler...@redhat.com wrote: On 07/30/15 20:54, Jordan Justen wrote: On 2015-07-30 10:09:34, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization

2015-07-30 Thread Laszlo Ersek
On 07/31/15 01:31, Andrew Fish wrote: On Jul 30, 2015, at 4:17 PM, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed as

Re: [edk2] [Patch 2/2] Update copyright info, use BDS license.

2015-07-30 Thread Dong, Eric
Daryl and Ard, Sorry for the incorrect description. This file is new created and changed from an old existed file, so the old copyright is error kept. I have update the copyright info. Because this is new added file, so I only kept the 2015 copyright. Thanks, Eric -Original Message-

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization

2015-07-30 Thread Laszlo Ersek
On 07/31/15 01:49, Ard Biesheuvel wrote: On 31 July 2015 at 01:17, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed as SVN

[edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Laszlo Ersek
(Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally different from the prior versions (because why not). Therefore, now

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Bill Jacobs (billjac)
Bravo! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, July 30, 2015 9:58 AM To: Blibbet; edk2-de...@ml01.01.org Cc: Peter Jones Subject: Re: [edk2] today's US CERT UEFI advisory On 07/30/15 17:49, Blibbet wrote:

Re: [edk2] [Patch 2/2] Update copyright info, use BDS license.

2015-07-30 Thread Daryl McDaniel
The copyright information was incorrectly updated. The correct copyright is: Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.BR Previous copyrights must be maintained. This patch should be rejected and a new one submitted with the corrected copyright notice and subject

Re: [edk2] [Patch 2/2] Update copyright info, use BDS license.

2015-07-30 Thread Ard Biesheuvel
On 29 July 2015 at 10:59, Eric Dong eric.d...@intel.com wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com The license is called 'BSD' not 'BDS' Could you fix up the commit titles please? -- Ard. ---

[edk2] today's US CERT UEFI advisory

2015-07-30 Thread Blibbet
FYI, in case any OEM's missed today's US-CERT UEFI vulnerability notice: http://firmwaresecurity.com/2015/07/30/us-cert-bios-vulnerability-note-vu577140/ Remember that any TianoCore-based bugs may be in your platorm: https://twitter.com/XenoKovah/status/623483244890189824 Can anyone clarify if

Re: [edk2] [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs

2015-07-30 Thread Bruce Cran
On 7/27/2015 11:39 PM, He, Tim wrote: Yes, these 2 typedefs is being defined twice, we need to remove the second definition, I will check in the code patch. Thanks. Just to check, how long is there normally between accepting the patch and committing it? I don't see any of my recent

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Laszlo Ersek
(resending this one too) On 07/30/15 19:09, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally

Re: [edk2] [PATCH 11/58] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-07-30 Thread Laszlo Ersek
On 07/30/15 20:50, Paolo Bonzini wrote: On 28/07/2015 20:44, Laszlo Ersek wrote: I have a significant update for this patch. On S3 resume, the APMC_EN bit (and other bits) are cleared in SMI_EN (which is necessary, see qemu commit be66680e). For the trigger method to work right after S3

Re: [edk2] [PATCH 11/58] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-07-30 Thread Paolo Bonzini
On 28/07/2015 20:44, Laszlo Ersek wrote: I have a significant update for this patch. On S3 resume, the APMC_EN bit (and other bits) are cleared in SMI_EN (which is necessary, see qemu commit be66680e). For the trigger method to work right after S3 resume, the APMC_EN bit must be set again

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Andrew Fish
On Jul 30, 2015, at 9:58 AM, Laszlo Ersek ler...@redhat.com wrote: On 07/30/15 17:49, Blibbet wrote: FYI, in case any OEM's missed today's US-CERT UEFI vulnerability notice: http://firmwaresecurity.com/2015/07/30/us-cert-bios-vulnerability-note-vu577140/ Remember that any

Re: [edk2] [Patch] Remove the useless code to fix build failure caused by error depend on IntelFrameworkModulePkg.

2015-07-30 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Dong, Eric Sent: Friday, July 31, 2015 9:32 AM To: Ni, Ruiyu; Gao, Liming; edk2-devel@lists.01.org Subject: [Patch] Remove the useless code to fix build failure caused by error depend on IntelFrameworkModulePkg.

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Laszlo Ersek
On 07/30/15 20:09, Andrew Fish wrote: On Jul 30, 2015, at 9:58 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/30/15 17:49, Blibbet wrote: FYI, in case any OEM's missed today's US-CERT UEFI vulnerability notice:

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Jordan Justen
On 2015-07-30 10:09:34, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally different from the

Re: [edk2] [PATCH v2] MdeModulePkg PeiCore: Add PCD to specify PEIM Shadow

2015-07-30 Thread Zeng, Star
Reviewed-by: Star Zeng star.z...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, July 30, 2015 5:40 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] MdeModulePkg PeiCore: Add PCD to specify PEIM

Re: [edk2] posting to the new list without subscription?

2015-07-30 Thread Laszlo Ersek
On 07/29/15 23:38, Jordan Justen wrote: On 2015-07-28 12:59:46, Laszlo Ersek wrote: Hi Jordan, what are the rules for posting to the new list without being subscribed? On the old list, I think we dropped all such emails. Currently we are rejecting them on the new list. Paolo posted a

Re: [edk2] posting to the new list without subscription?

2015-07-30 Thread David Woodhouse
On Wed, 2015-07-29 at 14:38 -0700, Jordan Justen wrote: On 2015-07-28 12:59:46, Laszlo Ersek wrote: Hi Jordan, what are the rules for posting to the new list without being subscribed? On the old list, I think we dropped all such emails. Currently we are rejecting them on the new

Re: [edk2] [Patch] UiApp: Move reset menu from frontpage to BMM page.

2015-07-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Dong, Eric Sent: Thursday, July 30, 2015 4:56 PM To: Ni, Ruiyu ruiyu...@intel.com; edk2-devel@lists.01.org Subject: [Patch] UiApp: Move reset menu from frontpage to BMM page. Contributed-under: TianoCore

[edk2] [PATCH v2] MdeModulePkg PeiCore: Add PCD to specify PEIM Shadow

2015-07-30 Thread Liming Gao
v2 changelog: Check CurrentPeimHandle to check the matched PeimHandle. Add check point to ShadowPeiCore based on PCD. v1 changelog: PeiCore LoadImage always shadow itself and PEIM on normal boot after the physical memory is installed. On the emulator platform, the shadow may be not necessary. To

[edk2] [Patch] UiApp: Move reset menu from frontpage to BMM page.

2015-07-30 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com --- MdeModulePkg/Application/UiApp/BootMaint/Bm.vfr | 8 MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c | 4 MdeModulePkg/Application/UiApp/BootMaint/FormGuid.h | 1 +