[edk2] Hello World

2016-02-09 Thread Mangefeste, Tony
Hello There. I’m Tony. I had the intent of writing an introduction that went into all sorts details about who I am, what I love, and why I’m emailing this community. Pardon the clichéd, over used subject line; I failed at thinking of something that wouldn’t turn out to be super stuffy. In

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

2016-02-09 Thread Ryan Harkin
Hi Jaben, On 9 Feb 2016 21:17, "Carsey, Jaben" wrote: > > Thanks for the ---author info. The email case is completely arbitrary to me... I honestly don't care (or maybe I should say I don't understand if I should care). > I think the only difference is that all your previous commits use mixed c

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Tuesday, February 09, 2016 10:13 AM > To: Carsey, Jaben > Cc: edk2-devel@lists.01.org; Qiu, Shumin ; Ard > Biesheuvel > Subject: Re: [edk2] [PATCH] Maintainers.txt: Upda

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

2016-02-09 Thread Carsey, Jaben
Thanks for the ---author info. The email case is completely arbitrary to me... I honestly don't care (or maybe I should say I don't understand if I should care). -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ryan Harkin > Sent: T

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Carsey, Jaben
Disregard my earlier comment. I didn’t realize that was a link to the wiki at first. Reviewed-by: Jaben Carsey > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, February 09, 2016 11:46 AM > To: Leif Lindholm > Cc: edk2-devel@lists.01.org;

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 18:18, Leif Lindholm wrote: > Separate ShellPkg and ShellBinPkg into separate entities. > Add Leif Lindholm and Ard Biesheuvel as ShellBinPkg maintainers > for ARM/AArch64 only. > Add indicaton that Jaben Carsey and Shumin Qiu are maintainers for > Ia32/X64 specifically. > >

Re: [edk2] [PATCH v3 0/4] EmbeddedPkg/Lan9118Dxe: MemoryFence and PCD

2016-02-09 Thread Ryan Harkin
to keep them. > > [1] http://article.gmane.org/gmane.comp.bios.edk2.devel/7341 > This series can be pulled from here: https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/upstreaming-20160209-002 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ryan Harkin
When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted that most calls to gBS->Stall() in this driver seem to be used to prevent timing issues between the device updating data and the host reading the values. And that replacing most of these calls with a MemoryFence() would be more r

[edk2] [PATCH v3 3/4] EmbeddedPkg/Lan9118Dxe: minor DEBUG tidyup

2016-02-09 Thread Ryan Harkin
This patch makes a few minor DEBUG output changes: - Fix typo in DEBUG output: Negociation->Negotiation - Change DEBUG occurrences of "Lan9118" to "LAN9118" to make grepping the log output easier. - Change the warning that auto-negotiation is not supported when AutoNegotiate() returns an err

[edk2] [PATCH v3 2/4] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Ryan Harkin
Add a PCD for the link negotiation timeout so the platform can over-ride the default value. The code previously did 2000 iterations of the loop with a 2us stall, so the code has been changed subtly to set the number of iterations equal to the PCD value divided by the stall time. Since the stall t

[edk2] [PATCH v3 4/4] EmbeddedPkg/Lan9118Dxe: rename TimeOut to Retries

2016-02-09 Thread Ryan Harkin
The variable TimeOut is actually a retry, not a timeout, so I renamed the variable accordingly. This patch makes no functional change. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin Reviewed-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- EmbeddedPkg/Drive

[edk2] [PATCH v3 0/4] EmbeddedPkg/Lan9118Dxe: MemoryFence and PCD

2016-02-09 Thread Ryan Harkin
This is a follow up from my previous patch [1] to add a PCD for the auto-negotiation timeout and the v2 series that followed it. Review comments on the edk2-devel mailing list and on the #linaro-enterprise IRC channel evolved the solution into two different patches: [PATCH 1/4] EmbeddedPkg/Lan911

Re: [edk2] [PATCH] ArmPlatformPkg/Bds: Early Console Initialization

2016-02-09 Thread Leif Lindholm
On Mon, Feb 08, 2016 at 03:33:30PM -0600, Supreeth Venkatesh wrote: > Setup the EFI System Table with information about the > Console Devices early, so that error messages in bds > are printed on the console. > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Supreeth

[edk2] PCD Local Token Numbers in PEI/DXE

2016-02-09 Thread Tim Lewis
We have run into an interesting problem with the PCD database when the PEI and DXE databases were not built at the same time. This happens with boot-block type arrangements. This is not a Dynamic vs. DynamicEx issue. Short form: 1) The standard PCD database for Dynamic/DynamicEx PCDs is b

Re: [edk2] [PATCH] rrecp has been allocated but is not freed on the error return path if the strdup fails. This is a minor memory leak that is easily fixed by free'ing rrecp on the error return.

2016-02-09 Thread Daryl McDaniel
Colin, Thank you for reporting this. I have added it to the list things to fix. It will be addressed ASAP. Sincerely, Daryl McDaniel > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, February 09, 2016 4:55 AM > To: edk2-devel@lists.01.org > Cc: D

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

2016-02-09 Thread Ryan Harkin
Hi Jaben, On 8 February 2016 at 19:35, Carsey, Jaben wrote: > I think that the changes look fine. > Unfortunately, this patch crashes my board when Shell runs startup.nsh. I have yet to track down what part of the patch is causing the problem, but I see this: Press ESC in 1 seconds to skip sta

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Leif Lindholm
On Tue, Feb 09, 2016 at 06:03:45PM +, Carsey, Jaben wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Tuesday, February 09, 2016 9:19 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben ; Qiu, Shumin > > ; Ard Biesheuvel > > Su

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Carsey, Jaben
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, February 09, 2016 9:19 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > ; Ard Biesheuvel > Subject: [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg > Importance:

[edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

2016-02-09 Thread Leif Lindholm
Separate ShellPkg and ShellBinPkg into separate entities. Add Leif Lindholm and Ard Biesheuvel as ShellBinPkg maintainers for ARM/AArch64 only. Add indicaton that Jaben Carsey and Shumin Qiu are maintainers for Ia32/X64 specifically. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-o

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Leif Lindholm
On Tue, Feb 09, 2016 at 06:01:48PM +0100, Laszlo Ersek wrote: > On 02/09/16 17:53, Leif Lindholm wrote: > > Thanks! > > > > (Argh, forgot to add your reviewed-by before I pushed!) > > > > So, could I do something like splitting ShellPkg/ShellBinPkg and then: > > > > ShellBinPkg > > W: https://gi

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Laszlo Ersek
On 02/09/16 17:53, Leif Lindholm wrote: > Thanks! > > (Argh, forgot to add your reviewed-by before I pushed!) > > So, could I do something like splitting ShellPkg/ShellBinPkg and then: > > ShellBinPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg > M: Jaben Carsey > M: Shu

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Carsey, Jaben
I would actually say mark Shumin and myself as "(Ia32/X64)" similar to marking you and Ard as ARM/AArch64. I am not really involved in ARM binaries at all. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Tuesday, Febru

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Leif Lindholm
Thanks! (Argh, forgot to add your reviewed-by before I pushed!) So, could I do something like splitting ShellPkg/ShellBinPkg and then: ShellBinPkg W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg M: Jaben Carsey M: Shumin Qiu M: Leif Lindholm (ARM/AArch64) M: Ard Biesh

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And yes I agree that you both should be added as maintainers of the ShellBinPkg. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Tuesday, February 09, 2016 8:41 AM > To: edk2-devel@lists.01.or

[edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2016-02-09 Thread Leif Lindholm
The binaries of ShellBinPkg are generated with ShellPkg from 9a8f6fb40712 ("ArmPlatformPkg: remove unused Sec library"). This reintroduces the non-standard tftp commands that were unintentionally dropped with svn r18243. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif

Re: [edk2] [PATCH v5 0/5] ArmPlatformPkg: remove unused code

2016-02-09 Thread Leif Lindholm
mVExpress-RTSM-A15_MPCore.dsc/fdf > [PATCH v3 v3 5/5] ArmPlatformPkg: remove unused Sec library > > This series can be found on the ARM Landing Team git tree [2]. > > [1] https://git.linaro.org/uefi/OpenPlatformPkg.git > [2] > https://

Re: [edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 14:25, Ard Biesheuvel wrote: > On 9 February 2016 at 12:41, Ryan Harkin wrote: >> When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted >> that most calls to gBS->Stall() in this driver seem to be used to >> prevent timing issues between the device updating da

Re: [edk2] [PATCH v2 4/4] EmbeddedPkg/Lan9118Dxe: rename TimeOut to Retries

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 12:41, Ryan Harkin wrote: > The variable TimeOut is actually a retry, not a timeout, so I renamed > the variable accordingly. > > This patch makes no functional change. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ryan Harkin Reviewed-by: Ard

Re: [edk2] [PATCH v2 3/4] EmbeddedPkg/Lan9118Dxe: minor DEBUG tidyup

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 12:41, Ryan Harkin wrote: > This patch makes a few minor DEBUG output changes: > > - Fix typo in DEBUG output: Negociation->Negotiation > > - Change DEBUG occurrences of "Lan9118" to "LAN9118" to make grepping > the log output easier. > > - Change the warning that auto-nego

Re: [edk2] [PATCH v2 2/4] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 12:41, Ryan Harkin wrote: > Add a PCD for the link negotiation timeout so the platform can over-ride > the default value. > > When the ARM Juno Development Platform uses the "EFI Network" option > with then LAN9118 driver, it fails to boot the first time and so the > board dr

Re: [edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ard Biesheuvel
On 9 February 2016 at 12:41, Ryan Harkin wrote: > When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted > that most calls to gBS->Stall() in this driver seem to be used to > prevent timing issues between the device updating data and the host > reading the values. And that replacing

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-09 Thread Ryan Harkin
000FE3177C0 SPSR 0x3309 FPSR 0x ESR 0x9605 FAR 0x00025D928326 ESR : EC 0x25 IL 0x1 ISS 0x0005 Data abort: Translation fault, first level ASSERT [ArmCpuDxe] /working/platforms/uefi/edk2/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c(186): ((BOOLEAN)(0==1)) [1] https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/armlt-20160209 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v5 0/5] ArmPlatformPkg: remove unused code

2016-02-09 Thread Ryan Harkin
tree [2]. > > [1] https://git.linaro.org/uefi/OpenPlatformPkg.git > [2] > https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/upstreaming-20160209-001 This tag also contains my latest LAN9118 series. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 2/5] ArmPlatformPkg: remove ArmVExpress-FVP-AArch64.dsc/fdf

2016-02-09 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, FVP exists both in EDK2's ArmPlatformPkg and in OpenPlatformPkg [2]. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the .dsc

[edk2] [PATCH v3 5/5] ArmPlatformPkg: remove unused Sec library

2016-02-09 Thread Ryan Harkin
The Sec library was built by the AARCH64 FVP models, but the binary was unused because it was part of a legacy booting strategy from before ARM Trusted Firmware came along. This change requires changes in OpenPlatformPkg to remove the Sec binary from the FVP build. Signed-off-by: Ryan Harkin ---

[edk2] [PATCH v3 3/5] ArmPlatformPkg: remove ArmJuno.dsc/fdf

2016-02-09 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, Juno exists both in EDK2's ArmPlatformPkg and in OpenPlatformPkg [2]. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the .ds

[edk2] [PATCH v3 4/5] ArmPlatformPkg: remove ArmVExpress-RTSM-A15_MPCore.dsc/fdf

2016-02-09 Thread Ryan Harkin
This platform is untested and no longer supported, so remove it from the tree. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 297 - .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 3

[edk2] [PATCH v5 0/5] ArmPlatformPkg: remove unused code

2016-02-09 Thread Ryan Harkin
ttps://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/upstreaming-20160209-001 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 1/5] ArmPlatformPkg: remove ArmVExpress-CTA15-A7.dsc/fdf

2016-02-09 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, TC2 exists both in EDK2's ArmPlatformPkg and in OpenPlatformPkg [2]. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the .dsc

Re: [edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Leif Lindholm
On Tue, Feb 09, 2016 at 11:41:02AM +, Ryan Harkin wrote: > When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted > that most calls to gBS->Stall() in this driver seem to be used to > prevent timing issues between the device updating data and the host > reading the values. And th

Re: [edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ryan Harkin
On 9 February 2016 at 12:04, Laszlo Ersek wrote: > comments below: > > On 02/09/16 12:41, Ryan Harkin wrote: >> When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted >> that most calls to gBS->Stall() in this driver seem to be used to >> prevent timing issues between the device upda

Re: [edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Laszlo Ersek
comments below: On 02/09/16 12:41, Ryan Harkin wrote: > When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted > that most calls to gBS->Stall() in this driver seem to be used to > prevent timing issues between the device updating data and the host > reading the values. And that rep

Re: [edk2] [PATCH v2 2/4] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Ryan Harkin
On 9 February 2016 at 11:56, Laszlo Ersek wrote: > On 02/09/16 12:41, Ryan Harkin wrote: >> Add a PCD for the link negotiation timeout so the platform can over-ride >> the default value. >> >> When the ARM Juno Development Platform uses the "EFI Network" option >> with then LAN9118 driver, it fail

Re: [edk2] [PATCH v2 4/4] EmbeddedPkg/Lan9118Dxe: rename TimeOut to Retries

2016-02-09 Thread Laszlo Ersek
On 02/09/16 12:41, Ryan Harkin wrote: > The variable TimeOut is actually a retry, not a timeout, so I renamed > the variable accordingly. > > This patch makes no functional change. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ryan Harkin > --- > EmbeddedPkg/Drive

Re: [edk2] [PATCH v2 3/4] EmbeddedPkg/Lan9118Dxe: minor DEBUG tidyup

2016-02-09 Thread Laszlo Ersek
On 02/09/16 12:41, Ryan Harkin wrote: > This patch makes a few minor DEBUG output changes: > > - Fix typo in DEBUG output: Negociation->Negotiation > > - Change DEBUG occurrences of "Lan9118" to "LAN9118" to make grepping > the log output easier. > > - Change the warning that auto-negotiation

Re: [edk2] [PATCH v2 2/4] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Laszlo Ersek
On 02/09/16 12:41, Ryan Harkin wrote: > Add a PCD for the link negotiation timeout so the platform can over-ride > the default value. > > When the ARM Juno Development Platform uses the "EFI Network" option > with then LAN9118 driver, it fails to boot the first time and so the > board drops back t

[edk2] [PATCH v2 2/4] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Ryan Harkin
Add a PCD for the link negotiation timeout so the platform can over-ride the default value. When the ARM Juno Development Platform uses the "EFI Network" option with then LAN9118 driver, it fails to boot the first time and so the board drops back to Shell again: Warning: LAN9118 Driver in stopp

[edk2] [PATCH v2 4/4] EmbeddedPkg/Lan9118Dxe: rename TimeOut to Retries

2016-02-09 Thread Ryan Harkin
The variable TimeOut is actually a retry, not a timeout, so I renamed the variable accordingly. This patch makes no functional change. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 22 +++-

[edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ryan Harkin
This is a follow up from [1] my previous patch to add a PCD for the auto-negotiation timeout. Review comments on the edk2-devel mailing list and on the #linaro-enterprise IRC channel evolved the solution into two different patches: [PATCH 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence [PATCH 2/4] E

[edk2] [PATCH v2 1/4] EmbeddedPkg/Lan9118Dxe: use MemoryFence

2016-02-09 Thread Ryan Harkin
When reviewing my LAN9118 driver PCD patch [1], Ard Biesheuvel noted that most calls to gBS->Stall() in this driver seem to be used to prevent timing issues between the device updating data and the host reading the values. And that replacing most of these calls with a MemoryFence() would be more r

[edk2] [PATCH v2 3/4] EmbeddedPkg/Lan9118Dxe: minor DEBUG tidyup

2016-02-09 Thread Ryan Harkin
This patch makes a few minor DEBUG output changes: - Fix typo in DEBUG output: Negociation->Negotiation - Change DEBUG occurrences of "Lan9118" to "LAN9118" to make grepping the log output easier. - Change the warning that auto-negotiation is not supported when AutoNegotiate() returns an err

Re: [edk2] SATA 3.0 AHCI host controller codebase

2016-02-09 Thread Bhupesh Sharma
> From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 08, 2016 1:20 PM > > On 02/06/16 09:38, Bhupesh Sharma wrote: > >> From: Laszlo Ersek > >> Sent: Friday, February 05, 2016 2:27 AM > >> > >> On 02/03/16 22:39, Leif Lindholm wrote: > >>> Hi Shaveta, > >>> > >>> On Tue, Feb 02

Re: [edk2] [PATCH] EmbeddedPkg/Lan9118Dxe: add PCD for negotiation timeout

2016-02-09 Thread Ryan Harkin
On 8 February 2016 at 19:36, Laszlo Ersek wrote: > On 02/08/16 18:59, Ryan Harkin wrote: >> Add a PCD for the default link negotiation timeout so the platform can >> over-ride the default value. >> >> When the ARM Juno Development Platform uses the "EFI Network" option >> with then LAN9118 driver,