[edk2] [EDK2]an issue that PXE boot failed when received a NACK from the DHCP server

2016-03-30 Thread Liuxilong (A)
Hi Folks: Recently, we used our board to do some tests about PXE booting and encountered an issue . Sometimes the PXE booting would fail when the PXE client sent a request to confirm IP but received the NACK from the DHCP server, which is displayed in the figure below. [cid:image002.jpg@01D18B55

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Fix incorrect RAM disk memory address calculation

2016-03-30 Thread Wu, Hao A
Pushed at 5eae4ff0024318030495838fe50ed34f4c15711a. Best Regards, Hao Wu > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Wednesday, March 30, 2016 7:13 AM > To: edk2-devel@lists.01.org > Cc: tapands...@hpe.com; Wu, Hao A; Tian, Feng; Samer E

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Michael Brown
On 31/03/16 02:17, Dong, Eric wrote: Those sections of the UEFI spec are so badly written that I cannot begin to guess what might count as either correct or incorrect. Could you please give a concrete example of what you think iPXE should be returning here? We have a sample driver in MdeModule

[edk2] ACPI SBST - How to populate Battery Info

2016-03-30 Thread Galla Rao
Hello Everyone! Good Morning from Bangalore! Am trying to get the battery details on my laptop in UEFI. /// /// Smart Battery Description Table (SBST) /// typedef struct { EFI_ACPI_DESCRIPTION_HEADER Header; UINT32 WarningEnergyLevel; UINT32 LowEne

[edk2] [Patch] NetworkPkg: Add RAM disk boot support to HTTP Boot driver.

2016-03-30 Thread Fu Siyuan
This patch updates the HTTP Boot driver to support the download and boot a RAM disk image from HTTP server. The HTTP RAM disk boot is described in section 23.7 "HTTP Boot" in UEFI 2.6. HTTP server could provide either an UEFI image or a RAM disk image for the HTTP boot client to use. The RAM disk i

[edk2] [PATCH 1/4] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-03-30 Thread Star Zeng
Currently, the LockBox protocol is installed in entrypoint of OVMF AcpiS3SaveDxe, that is strange. We can let the first driver run with LockBoxDxeLib linked to have its library constructor to install LockBox protocol on the ImageHandle. As other drivers may have gEfiLockBoxProtocolGuid dependency,

[edk2] [PATCH 2/4] MdeModulePkg S3SaveStateDxe: Move S3Ready() functional code from AcpiS3SaveDxe

2016-03-30 Thread Star Zeng
The S3Ready() functional code in AcpiS3SaveDxe of IntelFrameworkModulePkg is to do ACPI S3 Context save. In fact, that is not really related to Intel framework ACPI S3 protocol. IntelFrameworkModulePkg will be deprecated step by step, so move the functional code to MdeModulePkg and S3SaveStateDxe

[edk2] [PATCH 0/4] Move S3Ready() functional code from AcpiS3SaveDxe to S3SaveStateDxe

2016-03-30 Thread Star Zeng
The S3Ready() functional code in AcpiS3SaveDxe of IntelFrameworkModulePkg is to do ACPI S3 Context save. In fact, that is not really related to Intel framework ACPI S3 protocol. IntelFrameworkModulePkg will be deprecated step by step, so move the functional code to MdeModulePkg and S3SaveStateDxe

[edk2] [PATCH 3/4] OvmfPkg: Retire AcpiS3SaveDxe

2016-03-30 Thread Star Zeng
The same functional code has been in S3SaveStateDxe, OVMF AcpiS3SaveDxe can be retired now. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c | 550

[edk2] [PATCH 4/4] IntelFrameworkModulePkg AcpiS3SaveDxe: Remove S3Ready() functional code

2016-03-30 Thread Star Zeng
The S3Ready() functional code has been moved to S3SaveStateDxe in MdeModulePkg, the ACPI global variable related code is leaved as is for compatibility. PcdS3BootScriptStackSize is also moved to MdeModulePkg. Cc: Jiewen Yao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Sig

Re: [edk2] EDK2 Python

2016-03-30 Thread Daryl McDaniel
Hello, When you try to run Python in QEMU, are you launching it from the Shell? Currently, Python requires the Shell environment to run. Another possibility is that the QEMU environment does not have STDERR output enabled by default. Python sends all prompts to stderr, so if it appears t

Re: [edk2] [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-03-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, March 31, 2016 10:37 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fu, Siyuan > Subject: [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for > RAM Disk boot media > > Use reserved memory to ho

[edk2] [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-03-30 Thread Ruiyu Ni
Use reserved memory to hold the buffer for the RAM disk to follow the ACPI spec requirement. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Siyuan Fu --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 149 +++-- .../Library/UefiBootMana

Re: [edk2] [Patch v3 2/3] MdeModulePkg/Bds: Free resources after ram disk boot finishes

2016-03-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, March 30, 2016 8:29 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fu, Siyuan ; Tian, > Feng > Subject: [Patch v3 2/3] MdeModulePkg/Bds: Free resources after ram disk > boot finishes > > The resource fr

Re: [edk2] [Patch v2 3/3] MdeModulePkg/Bds: Memory Bins don't count the memory used by RAM Disk

2016-03-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, March 29, 2016 6:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fu, Siyuan ; > Kinney, Michael D > Subject: [Patch v2 3/3] MdeModulePkg/Bds: Memory Bins don't count the > memory used by RAM Disk > > M

Re: [edk2] [Patch v2 2/3] MdeModulePkg/Bds: Free resources after ram disk boot finishes

2016-03-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, March 29, 2016 6:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fu, Siyuan ; Tian, > Feng > Subject: [Patch v2 2/3] MdeModulePkg/Bds: Free resources after ram disk > boot finishes > > The resource fre

Re: [edk2] [Patch v2 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-03-30 Thread Fu, Siyuan
Hi, Ray In below code the FileBuffer should be freed according to its allocation method (page or pool). Other part is good with me. > + Status = LoadFile->LoadFile (LoadFile, FilePath, TRUE, &BufferSize, > FileBuffer); > + if (EFI_ERROR (Status)) { > +FreePool (FileBuffer); > +return

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
Yes, we can also enhance Hiidatabase to not assert. From: Ni, Ruiyu Sent: Thursday, March 31, 2016 8:57 AM To: Dong, Eric; Laszlo Ersek; Bi, Dandan; Michael Brown Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel Subject: RE: HII incompatibility between edk2 and iPXE? Eric, Shall we also fix th

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
We have a sample driver in MdeModulePkg/Universal/DriverSampleDxe. It also use a Name/Value varstore. You can reference that driver about how to implement the EFI Config Access Protocol. > -Original Message- > From: Michael Brown [mailto:mc...@ipxe.org] > Sent: Wednesday, March 30, 2016

Re: [edk2] [PATCH] MdeModulePkg EmmcDxe: Fix GCC build failure with set but unused variables

2016-03-30 Thread Tian, Feng
I am surprised that I didn't get such error with GCC52 windows compiler. (Why I don't use GCC492/493 windows compiler in EDKII sourceforge to do GCC verification is because it always prompt "make.exe no disk" window at my local) Anyway the patch is good to me Reviewed-by: Feng Tian Thanks Fe

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: BmGetActiveConsoleIn code cleanup

2016-03-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Thomas Palmer [mailto:thomas.pal...@hpe.com] >Sent: Thursday, March 31, 2016 1:17 AM >To: edk2-devel@lists.01.org >Cc: samer.el-haj-mahm...@hpe.com; Tian, Feng ; Zeng, Star >; Ni, Ruiyu >; Thomas Palmer >Subject: [PATCH] MdeModulePkg/U

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Ni, Ruiyu
Eric, Shall we also fix the core driver to not assert when the string is incorrect? Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric Sent: Wednesday, March 30, 2016 11:09 PM To: Laszlo Ersek ; Bi, Dandan ; Michael Brown Cc: Justen, Jordan L ; edk2-

Re: [edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing register access issue in Apple Eth Adapter

2016-03-30 Thread Ni, Ruiyu
pushed @ 7361d3f Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Thursday, March 31, 2016 8:42 AM To: Shivamurthy Shastri Cc: fathi.bou...@linaro.org; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing registe

[edk2] [Patch v2] Revert "TerminalDxe: select the UART's default receive FIFO depth"

2016-03-30 Thread Ruiyu Ni
This reverts commit 31ae446b1a039a55d0336f2201d77d1032533413. Changing the receive FIFO depth in Terminal driver Start() is not recommended. A new PCD PcdUartDefaultReceiveFifoDepth was added and MdeModulePkg/SerialDxe driver uses the PCD as the default receive FIFO depth. Signed-off-by: Ruiyu Ni

Re: [edk2] Building the ShellPkg

2016-03-30 Thread David Van Arnem
On 03/30/2016 05:35 PM, Mahan, Patrick wrote: Build environment: Ubuntun 14.04 LTS GCC v4.8 Edk2, SVN revision 20433 Dell 5810 I am attempting to build the UEFI shell from sources so that I can debug an keyboard issue (SHIFT key acts like a ). However, the ShellPkg fails during the ld, here

Re: [edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing register access issue in Apple Eth Adapter

2016-03-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shivamurthy Shastri >Sent: Wednesday, March 30, 2016 5:14 PM >To: Ni, Ruiyu >Cc: fathi.bou...@linaro.org; edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2] OptionRomPk

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-30 Thread Ni, Ruiyu
No there is no issue in exposing this function API. comments about this patch: 1. the patch title is "Expose BmLoadOption" which is confusing. 2. Internal function is called by internal code so some parameter checking can be ignored or just use assertion check. To make it public, the

[edk2] Building the ShellPkg

2016-03-30 Thread Mahan, Patrick
Build environment: Ubuntun 14.04 LTS GCC v4.8 Edk2, SVN revision 20433 Dell 5810 I am attempting to build the UEFI shell from sources so that I can debug an keyboard issue (SHIFT key acts like a ). However, the ShellPkg fails during the ld, here is a snippet of the output - "ld" -o /home/pm

[edk2] Shell Path Issues with "../.."

2016-03-30 Thread Cohen, Eugene
Dear ShellPkg maintainer, We're seeing some weird stuff related to '..' in the shell. The issue is that when we try to cd up two levels using the "../.." notation we only go up one level: FS0:\dir1\dir2\dir3\> FS0:\dir1\dir2\dir3\> cd ..\.. FS0:\dir1\dir2\> The same issue occurs using forwar

[edk2] EDK2 Python

2016-03-30 Thread Bella Jaguar
Hey guys, I'm compiling python.efi (under AppPkg) and the build finishes successfully but the image only runs in SecMain.exe and not in QEMU emulator running OVMF. Does any one know what might cause this behavior? Regards, Bella ___ edk2-devel mailing li

Re: [edk2] [PATCH v3] OvmfPkg: Add RAM disk support

2016-03-30 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-03-30 14:49:37, Alcantara, Paulo wrote: > Currently booting off of a RAM disk is not supported by > IntelFrameWorkModulePkg BDS, however on systems without writable > disks, the RAM disk can be made useful when loading raw HDD images > into it -- specially the o

[edk2] [PATCH v3] OvmfPkg: Add RAM disk support

2016-03-30 Thread Alcantara, Paulo
Currently booting off of a RAM disk is not supported by IntelFrameWorkModulePkg BDS, however on systems without writable disks, the RAM disk can be made useful when loading raw HDD images into it -- specially the ones with a FAT32 partition on which files can be natively accessed by system firmware

Re: [edk2] [PATCH v2] OvmfPkg: Add RAM disk support

2016-03-30 Thread Paulo Alcantara
On Wed, Mar 30, 2016 at 6:29 PM, Laszlo Ersek wrote: > I have two comments: > > On 03/30/16 19:28, Alcantara, Paulo wrote: >> Currently booting off of a RAM disk is not supported by >> IntelFrameWorkModulePkg BDS, however on diskless systems, the RAM disk >> can be made useful when writing raw HDD

Re: [edk2] [PATCH v2] OvmfPkg: Add RAM disk support

2016-03-30 Thread Laszlo Ersek
I have two comments: On 03/30/16 19:28, Alcantara, Paulo wrote: > Currently booting off of a RAM disk is not supported by > IntelFrameWorkModulePkg BDS, however on diskless systems, the RAM disk > can be made useful when writing raw HDD images to it -- specially the > ones with a FAT32 partition o

Re: [edk2] How to initiate a PXE boot from the UEFI shell

2016-03-30 Thread Mahan, Patrick
Andrew, Thanks, I suspect that I might need to roll my own on this. WRT option rom, that is coming on the next revision of the NIC hardware, but I am currently having to make do on a NIC that does not have a working option rom. That will be the next step, but I have been asked to do a demo, h

Re: [edk2] How to initiate a PXE boot from the UEFI shell

2016-03-30 Thread Andrew Fish
> On Mar 30, 2016, at 11:14 AM, Mahan, Patrick > wrote: > > I'm trying to understand what the ipconfig -r command means, the help states > that it restarts the PXE base code and DHCP settings. > > There is also a '-c Instance' option that I am not sure about. But this > looks like my best h

Re: [edk2] How to initiate a PXE boot from the UEFI shell

2016-03-30 Thread Mahan, Patrick
I'm trying to understand what the ipconfig -r command means, the help states that it restarts the PXE base code and DHCP settings. There is also a '-c Instance' option that I am not sure about. But this looks like my best hope. Patrick From: Carsey, Ja

[edk2] [PATCH v2] OvmfPkg: Add RAM disk support

2016-03-30 Thread Alcantara, Paulo
Currently booting off of a RAM disk is not supported by IntelFrameWorkModulePkg BDS, however on diskless systems, the RAM disk can be made useful when writing raw HDD images to it -- specially the ones with a FAT32 partition on which files can be natively acessed by system firmware. This patch add

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: BmGetActiveConsoleIn code cleanup

2016-03-30 Thread Thomas Palmer
Check for NULL from AllocateCopyPool before setting Count to 1. Also change sizeof (EFI_HANDLE*) to sizeof (EFI_HANDLE). Handles is a EFI_HANDLE pointer, so the allocated memory must be the size of EFI_HANDLE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer -

Re: [edk2] How to initiate a PXE boot from the UEFI shell

2016-03-30 Thread Carsey, Jaben
If your BDS supports PXE booting, you should be able to "exit" the shell and then use BDS to initiate a PXE boot.. I think you're right that there is no built in command to initiate a PXE boot. There is no command to initiate any boot type. -Jaben > -Original Message- > From: edk2-dev

Re: [edk2] Error while loading a symbol file (No Debug Directory)

2016-03-30 Thread Vladimir Olovyannikov
Ard, Many thanks. The script works fine now, no single issue adding symbols or source-level debugging. Vladimir > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, March 30, 2016 3:50 AM > To: Vladimir Olovyannikov > Cc: af...@apple.com; Eugen

[edk2] How to initiate a PXE boot from the UEFI shell

2016-03-30 Thread Mahan, Patrick
All, I am testing a the UEFI driver for our new NIC and can load it via the UEFI shell, ifconfig it and ping across it. However, I now need to somehow perform a PXE boot but I don't see any instructions or shell commands for doing this. I did find some (old) references back to the 2.0.0.1 rel

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Michael Brown
On 30/03/16 16:27, Dong, Eric wrote: I download the iPXE code and check the hii related code. I'm very confused why you dynamic generate the ifr data? Why not use vfr file to descript the form data? Use vfr file is much easy than dynamic generate it. Also I found you use name/value store to sa

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Michael Brown
On 30/03/16 16:09, Dong, Eric wrote: This error is caused by iPXE driver not return the correct string in EFI_HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig() function. Base on the spec requirement, if the function return success, the Results string should follow format. But the data returned by iPX

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
> On 29/03/16 16:20, Laszlo Ersek wrote: > > recent edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII > configuration settings available to OS runtime") seems to trigger an issue > between edk2 and iPXE. > > Thanks for debugging this! > > Is iPXE misbehaving here? At the time that I implemented

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
This error is caused by iPXE driver not return the correct string in EFI_HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig() function. Base on the spec requirement, if the function return success, the Results string should follow format. But the data returned by iPXE driver is not follow this rule, so t

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-30 Thread El-Haj-Mahmoud, Samer
There are use cases for it in platform customizations of BDS behavior... Is there an issue in exposing the function through the library API? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, March 29, 2016 7:52 PM To: El-Haj

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-03-30 Thread El-Haj-Mahmoud, Samer
Hao, Thanks for the patch! It looks like this change will create an NFIT table instead of trying to append to an existing one. This is problematic, as NFIT table might already exist (from NVDIMM support code for instance). Both NVDIMM and RAMDisk code that deals with NFIT need to be able to ap

Re: [edk2] [MinnowBoard] MNW2: No BIOS information in BIOS Setup Browser

2016-03-30 Thread Wei, David
I think Mike has told you how to configure the name string: The string comes from BiosID. Check out four files BiosIdxx.env in Vlv2TbltDevicePkg. The description of the string is in the .env file header # BIOS ID string format:

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 10:42, Laszlo Ersek wrote: >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Jordan Justen > This is huge. It will enable Fedora to ship OvmfPkg and ArmVirtPkg > builds. It will enable RHEL to ship OVMF in Main. > > Of course other GNU/Linux distros

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

2016-03-30 Thread Paulo Alcantara
Hi Laszlo, On Wed, Mar 30, 2016 at 6:33 AM, Laszlo Ersek wrote: > On 03/22/16 01:13, Paulo Alcantara wrote: >> Hi Jordan, >> >> On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen >> wrote: >>> On 2016-03-21 01:02:53, Laszlo Ersek wrote: On 03/20/16 17:58, Paulo Alcantara wrote: > This patch

Re: [edk2] Error while loading a symbol file (No Debug Directory)

2016-03-30 Thread Ard Biesheuvel
On 30 March 2016 at 12:30, Ard Biesheuvel wrote: > On 30 March 2016 at 02:06, Vladimir Olovyannikov > wrote: >>> -Original Message- >>> From: af...@apple.com [mailto:af...@apple.com] >>> Sent: Tuesday, March 29, 2016 4:09 PM >>> To: Vladimir Olovyannikov >>> Cc: Eugene Cohen; Ard Biesheuv

Re: [edk2] [Patch] Revert "TerminalDxe: select the UART's default receive FIFO depth"

2016-03-30 Thread Ryan Harkin
On 30 March 2016 at 09:22, Ryan Harkin wrote: > > On 29 Mar 2016 18:30, "Laszlo Ersek" wrote: >> >> On 03/29/16 09:31, Ruiyu Ni wrote: >> > This reverts commit 31ae446b1a039a55d0336f2201d77d1032533413. >> > Changing the receive FIFO depth in Terminal driver Start() is not >> > recommended. >> > A

Re: [edk2] Error while loading a symbol file (No Debug Directory)

2016-03-30 Thread Ard Biesheuvel
On 30 March 2016 at 02:06, Vladimir Olovyannikov wrote: >> -Original Message- >> From: af...@apple.com [mailto:af...@apple.com] >> Sent: Tuesday, March 29, 2016 4:09 PM >> To: Vladimir Olovyannikov >> Cc: Eugene Cohen; Ard Biesheuvel; edk2-devel@lists.01.org >> Subject: Re: [edk2] Error wh

Re: [edk2] PCIe memory transaction issue

2016-03-30 Thread Shaveta Leekha
Thanks for the help!! It worked. The issue is found in E1000 Intel driver that I have picked from open source. It was not configuring 64 bit DMA transactions properly, though it was setting 64 addresses seemingly (as I had pasted the code) But that part of code was not working actually. After p

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

2016-03-30 Thread Laszlo Ersek
On 03/30/16 09:47, Tian, Feng wrote: > Hao, > > I think here you meant Volatile Caching feature is optional. FUA bit is shown > up on SCSI & NVMe spec. This bit is not optional. My concern is what will happen if the device doesn't support DPO / FUA (which is allowed), but the write request asks

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

2016-03-30 Thread Laszlo Ersek
On 03/22/16 01:13, Paulo Alcantara wrote: > Hi Jordan, > > On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen > wrote: >> On 2016-03-21 01:02:53, Laszlo Ersek wrote: >>> On 03/20/16 17:58, Paulo Alcantara wrote: This patch adds RamDiskDxe driver to OVMF through a new introduced flag "RAMDIS

[edk2] [PATCH] MdeModulePkg EmmcDxe: Fix GCC build failure with set but unused variables

2016-03-30 Thread Star Zeng
Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c index f07

Re: [edk2] [Patch v2 0/3] HTTP Boot to RAM Disk

2016-03-30 Thread Laszlo Ersek
On 03/30/16 02:14, Ni, Ruiyu wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, March 29, 2016 11:40 PM >> To: Ni, Ruiyu >> Cc: edk2-de...@ml01.01.org; Justen, Jordan L ; >> Paulo Alcantara >> Subject: Re: [edk2] [Patch v2 0/3] HTTP Boot to RA

[edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing register access issue in Apple Eth Adapter

2016-03-30 Thread Shivamurthy Shastri
The USB command CMD_RXQTC ("RX Queue Cascade Threshold Control") tries to access the register and is always failing when using the Apple Ethernet adapter. It is fixed by checking flag before sending command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shivamurthy Shastr

[edk2] MNW2: No BIOS information in BIOS Setup Browser

2016-03-30 Thread Anteja Vuk Macek
Hi, We crate board similar to MinnowBoard Max and for that we want to brand BIOS for MinnowBoard Max. At first I changed firmware *.bin file name. Before I did this, I noticed that I didn't have some information about Computer model, CPU model and BIOS version. Information which I didn't have yo

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

2016-03-30 Thread Laszlo Ersek
CC Peter Maydell On 03/30/16 10:42, Laszlo Ersek wrote: > On 03/30/16 03:10, Jordan Justen wrote: >> I don't think sending all 62 patches will be useful (but, I can easily >> send them out if requested). Instead, the patches are available at: >> >> web: https://github.com/jljusten/edk2/tree/fatpkg

Re: [edk2] Tianocore Community Update - March 30, 2016

2016-03-30 Thread Mangefeste, Tony
It is Indeed appropriate to thank them. I did so in the tweet this AMCheck out @tianocore's Tweet: https://twitter.com/tianocore/status/715016134982930432?s=09 And thank you for alerting the Debian community. They were dependent on this as well. -- Original message-- From: Laszlo Ersek

Re: [edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing register access issue in Apple Eth Adapter

2016-03-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shivamurthy Shastri >Sent: Wednesday, March 30, 2016 3:48 PM >To: Ni, Ruiyu >Cc: fathi.bou...@linaro.org; edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2] OptionRomPkg

Re: [edk2] Tianocore Community Update - March 30, 2016

2016-03-30 Thread Laszlo Ersek
On 03/30/16 04:40, Mangefeste, Tony wrote: > Good morning from Taipei! > > I'd like to take this opportunity to bring you all up to date one > several developments. > > This morning, I'll be giving a state of the Tianocore program to the > UEFI Plugfests. Please see the attached Roadmap update.

[edk2] [Patch 1/2] SecurityPkg OpalPasswordSupportLib: Fix GCC build failure.

2016-03-30 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng Tian --- SecurityPkg/Library/OpalPasswordSupportLib/OpalPasswordSupportLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/OpalPasswordSupportLib/OpalPasswordSupportLib.c b/Secur

[edk2] [Patch 2/2] SecurityPkg TcgStorageOpalLib: Fix GCC build failure.

2016-03-30 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng Tian --- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 2 +- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[edk2] [Patch 0/2] Fix GCC build failure

2016-03-30 Thread Eric Dong
These two patches fixed GCC build failure for Opal Passowrd code. Eric Dong (2): SecurityPkg OpalPasswordSupportLib: Fix GCC build failure. SecurityPkg TcgStorageOpalLib: Fix GCC build failure. SecurityPkg/Library/OpalPasswordSupportLib/OpalPasswordSupportLib.c | 1 + SecurityPkg/Library/Tcg

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

2016-03-30 Thread Laszlo Ersek
On 03/30/16 03:10, Jordan Justen wrote: > I don't think sending all 62 patches will be useful (but, I can easily > send them out if requested). Instead, the patches are available at: > > web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-v1 > > git: https://github.com/jljusten/edk2.git

Re: [edk2] [Patch] Revert "TerminalDxe: select the UART's default receive FIFO depth"

2016-03-30 Thread Ryan Harkin
On 29 Mar 2016 18:30, "Laszlo Ersek" wrote: > > On 03/29/16 09:31, Ruiyu Ni wrote: > > This reverts commit 31ae446b1a039a55d0336f2201d77d1032533413. > > Changing the receive FIFO depth in Terminal driver Start() is not > > recommended. > > A new PCD PcdDefaultUartReceiveFifoDepth was added and > >

[edk2] [PATCH v2] OptionRomPkg: Ax88772b: Fixing register access issue in Apple Eth Adapter

2016-03-30 Thread Shivamurthy Shastri
The USB command CMD_RXQTC ("RX Queue Cascade Threshold Control") tries to access the register and is always failing when using the Apple Ethernet adapter. It is fixed by checking flag before sending command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shivamurthy Shastr

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

2016-03-30 Thread Tian, Feng
Hao, I think here you meant Volatile Caching feature is optional. FUA bit is shown up on SCSI & NVMe spec. This bit is not optional. Thanks Feng -Original Message- From: Wu, Hao A Sent: Wednesday, March 30, 2016 3:12 PM To: Laszlo Ersek ; edk2-de...@ml01.01.org; Tian, Feng Cc: Paolo

[edk2] [PATCH] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-03-30 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- .../Universal/Disk/RamDiskDxe/RamDiskDxe.inf | 9 ++ .../Universal/Disk/RamDiskDxe/RamDiskImpl.h| 4 + .../Universal/Disk/RamDiskDxe/RamDiskProtocol.c| 173 + 3 files change

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

2016-03-30 Thread Wu, Hao A
Hi Laszlo, I checked the NVM Express 1.2a spec and the SCSI Block Commands - 4 (SBC-4) spec. Though FUA is an optional feature for Scsi and NvmE devices, setting the FUA bit in Nvme write command and setting the DPO and FUA bit in SCSI Write(10/16) commands are not prohibited by both specs. Ther