Re: [edk2] [Patch] NetworkPkg: Need update Http token status while timeout happened

2016-05-23 Thread Wu, Jiaxin
Siyuan, I agree Http->Response() is designed to a unblocking interface. Actually, current implementation is blocking one. So, handling EFI_TIMEOUT status in the token (HttpBootDxe driver) or return directly, both of them are fine to me . But Tcp->Cancel() still should be necessary calling if

Re: [edk2] [BaseTools] PACKAGES_PATH issue?

2016-05-23 Thread Andrew Fish
Liming, I finally figured out what was causing the issue. It looks like it is a DEFINE combined with PACKAGES_PATH seems to cause the issue in the FDF file. The DSC file is still set to OvmfPkg/AcpiTables/AcpiTables.inf, I'm not sure if that is also required. It seems like if the DEFINE is

Re: [edk2] [Patch] NetworkPkg: update code for NULL pointer check.

2016-05-23 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Monday, May 23, 2016 5:49 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [Patch] NetworkPkg: update code for NULL pointer check.

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options

2016-05-23 Thread Tian, Feng
Thomas, Usually it's verified and added by Arm owner:-) But yes, I also think Hao can add it at this time. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Palmer, Thomas Sent: Tuesday, May 24, 2016 10:19 AM To: Wu, Hao A

Re: [edk2] TCP4: Failure to Acknowledge due to DPC Dispatch Nesting

2016-05-23 Thread Fu, Siyuan
Hi, Eugene Thanks for your detail analysis to help understanding the problem. We think it's a bug about the DelayedAck flag update in TCP driver, not in DPC, and here is the detail. At the time the TcpTicking() is running, the under layer (MnpSystemPoll) also has a timer to receive network

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options

2016-05-23 Thread Palmer, Thomas
No AARCH64 ? Thomas -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, May 23, 2016 8:59 PM To: edk2-devel@lists.01.org; feng.t...@intel.com Cc: Hao Wu Subject: [edk2] [PATCH] MdeModulePkg RamDiskDxe:

[edk2] [PATCH] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options

2016-05-23 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/MdeModulePkg.dsc | 2 +- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [Patch] NetworkPkg: update code for NULL pointer check.

2016-05-23 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Monday, May 23, 2016 11:06 AM To: edk2-devel@lists.01.org Cc: Ye; Ye, Ting ; Wu; Wu, Jiaxin Subject: [Patch] NetworkPkg: update code for NULL pointer check. This

Re: [edk2] [RFC] Email tags for Bugzilla and administrative events

2016-05-23 Thread Mangefeste, Tony
The server had a bit of a hiccup, but it's back :) > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, May 23, 2016 2:57 PM > To: Mangefeste, Tony > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2]

Re: [edk2] [PATCH 1/1] CorebootPayloadPkg: Consume PlatformHookLib in PlatformBootManagerLib

2016-05-23 Thread Leahy, Leroy P
Reviewed by: Lee Leahy Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 From: Ma, Maurice Sent: Monday, May 23, 2016 3:03 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman,

Re: [edk2] [BaseTools] PACKAGES_PATH issue?

2016-05-23 Thread Andrew Fish
> On May 23, 2016, at 5:52 AM, Gao, Liming wrote: > > Andrew: > The buid output path is always in $(WORKSPACE)\Build directory. You mean the path in $(WORKSPACE)\Build does not match the WORKSPACE relative path of the file? That seems to imply that code from different

Re: [edk2] [RFC] MdePkg: BaseLib: don't use aligned pointers for unaligned accessors

2016-05-23 Thread Leif Lindholm
Hi Mike, Apologies for going silent - I spent last week in China, with very restricted access to my primary email account. On Tue, May 17, 2016 at 05:38:21PM +, Kinney, Michael D wrote: > Leif, > > What are the specific warnings that are being triggered by CLANG > -Weverything for the

Re: [edk2] StdLib for EFI DRIVER type

2016-05-23 Thread Carsey, Jaben
StdLib also supports apps not in the shell environment. You can certainly port many the APIs to work for drivers. The goal of StdLib is to support existing applications being moved to UEFI environment. That does not really apply to drivers. What is the issue that you are finding a StdLib

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-23 Thread Gao, Liming
Andrew: Sorry, I have not fully understood your prototype. In this prototype, after the module with sample.pcd and sample.h is built, the output AutoGenTool file is generated. It includes below contents for PCD value initialization. The driver can directly consumes PcdFakePcdExample, and

[edk2] StdLib for EFI DRIVER type

2016-05-23 Thread jabir
Hi, I found that StdLib package can be only used for Apps in shell environment.. Is there any way to port StdLib for EFI DRIVER type? Is there any alternate package that can be used? Please help. Thanks in advance. -- Jabir ___ edk2-devel mailing list

Re: [edk2] [BaseTools] PACKAGES_PATH issue?

2016-05-23 Thread Laszlo Ersek
On 05/23/16 14:52, Gao, Liming wrote: > Andrew: > The buid output path is always in $(WORKSPACE)\Build directory. It is > not related to $(PACKAGES_PATH). PACKAGES_PATH is designed to search > source files, doesn't impact build output directory. > > I try Ovmf platform. Its AcpiTables can be

Re: [edk2] TCP4: Failure to Acknowledge due to DPC Dispatch Nesting

2016-05-23 Thread Cohen, Eugene
Adding some maintainers... We are looking forward to a response. Thanks, Eugene > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Friday, May 20, 2016 2:11 PM > To: edk2-devel@lists.01.org > Cc: Vaughn, Gregory (IPG LJ

Re: [edk2] [BaseTools] PACKAGES_PATH issue?

2016-05-23 Thread Gao, Liming
Andrew: The buid output path is always in $(WORKSPACE)\Build directory. It is not related to $(PACKAGES_PATH). PACKAGES_PATH is designed to search source files, doesn't impact build output directory. I try Ovmf platform. Its AcpiTables can be found and be built into FFS. Thanks Liming From:

[edk2] [Patch] NetworkPkg: update code for NULL pointer check.

2016-05-23 Thread Fu Siyuan
This patch updates the HTTP driver to initialize the local variable for NULL and check the NULL pointer before dereference it. Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan