Re: [edk2] Gmail has problem with edk2 mail list?

I'm using GMail and everything works just fine. I don't remember if I got an verification mail, but to test if you're really subscribed you just have to wait for mails which you were't CC'd in. The list is quite active so you don't have to wait for long ;) Thanks Michael On Thu, Sep 29, 2016 at

Re: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

Your patch has updated. But, this covert letter is not. Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Thursday, September 29, 2016 11:29 AM > To: edk2-devel@lists.01.org >

[edk2] [PATCH v2 1/3] MdeModulePkg: Remove ImageDecoderLib and BmpImageDecoderLib

The two libraries are created to support old BootLogoLib to decode the images. Due to the new BootLogoLib starts using HiiImageEx interfaces, the two libraries are not needed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao

[edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

The two libraries are created to support old BootLogoLib to decode the images. Due to the new BootLogoLib starts using HiiImageEx interfaces, the two libraries are not needed. Ruiyu Ni (3): MdeModulePkg/ImageDecoderLib: Retire it due to new BootLogoLib MdeModulePkg/BmpImageDecoderLib: Retire

[edk2] [PATCH v2 3/3] MdeModulePkg/ImageDecoderLib: Retire it due to new BootLogoLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- MdeModulePkg/Include/Library/ImageDecoderLib.h | 76 - .../Library/ImageDecoderLib/ImageDecoderLib.c | 121 -

[edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

The two libraries are created to support old BootLogoLib to decode the images. Due to the new BootLogoLib starts using HiiImageEx interfaces, the two libraries are not needed. Ruiyu Ni (3): MdeModulePkg/ImageDecoderLib: Retire it due to new BootLogoLib MdeModulePkg/BmpImageDecoderLib: Retire

[edk2] [PATCH v2 2/3] MdeModulePkg/BmpImageDecoderLib: Retire it due to new BootLogoLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- .../BmpImageDecoderLib/BmpImageDecoderLib.c| 272 - .../BmpImageDecoderLib/BmpImageDecoderLib.inf | 43

[edk2] Gmail has problem with edk2 mail list?

Hi, I subscribed edk2-devel list use gmail last night, twice. But my gmail has not received the confirmation until this morning. Anyone using gmail is normal with this mail list? -- Dashing Meng ___ edk2-devel mailing list

Re: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

Yes! Thanks for the reminding. V2 will be posted. Regards, Ray From: Gao, Liming Sent: Thursday, September 29, 2016 10:49 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib Do you remove

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

I agree to use the same style of code as what the other functions do. Reviewed-by: Ruiyu Ni >-Original Message- >From: Kinney, Michael D >Sent: Thursday, September 29, 2016 8:38 AM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Ni, Ruiyu

Re: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

Do you remove Include/Library/ImageDecoderLib.h? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Thursday, September 29, 2016 10:42 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/3] Remove ImageDecoderLib and >

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

Ray, That solution sounds good too, but you should update the other functions in the same file the duplicate the device path when that is not needed. The patch I provided just followed the example in the function above. Mike From: Ni, Ruiyu Sent: Wednesday, September 28, 2016 7:36 PM To:

[edk2] [PATCH 1/3] MdeModulePkg/ImageDecoderLib: Retire it due to new BootLogoLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- .../Library/ImageDecoderLib/ImageDecoderLib.c | 121 - .../Library/ImageDecoderLib/ImageDecoderLib.inf| 43

[edk2] [PATCH 3/3] MdeModulePkg: Remove ImageDecoderLib and BmpImageDecoderLib

The two libraries are created to support old BootLogoLib to decode the images. Due to the new BootLogoLib starts using HiiImageEx interfaces, the two libraries are not needed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao

[edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

The two libraries are created to support old BootLogoLib to decode the images. Due to the new BootLogoLib starts using HiiImageEx interfaces, the two libraries are not needed. Ruiyu Ni (3): MdeModulePkg/ImageDecoderLib: Retire it due to new BootLogoLib MdeModulePkg/BmpImageDecoderLib: Retire

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

Mike, How about remove the DuplicateDevicePath and FreePool? -- .../Library/UefiShellDebug1CommandsLib/HexEdit/DiskImage.c| 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/DiskImage.c

Re: [edk2] Miss "IMAGE_FORMAT" type name error when compile EDK2

On Wed, 28 Sep 2016 19:09:12 -0700 Andrew Fish wrote: > > > On Sep 28, 2016, at 6:43 PM, dashing meng wrote: > > > > Sorry for my web mail, it it always top posting. > > > > It seems the update for edk2 repository deleted the defination of type > >

Re: [edk2] [PATCH 37/45] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Hi Mike Yes you are right. This is a work-around for current tool limitation. We can remove such limitation after the tool has solution. I will update the recovery file name to make it more readable. Thank you Yao Jiewen From: Kinney, Michael D Sent: Thursday, September 29, 2016 9:01 AM To:

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

Ray, I agree that the contents of the device path buffer is not changed. is passed into LocateDevicePath() and the value pointed to by is modified. Then the call to FreePool(DupDevicePath) uses a different DupDevicePath value than was returned by DuplicateDevicePath(DevicePath). That

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

Mike, BS.LocateDevicePath() doesn't change the device path content. So I think the Duplication/Free of device path is not needed. Regards, Ray >-Original Message- >From: Kinney, Michael D >Sent: Thursday, September 29, 2016 8:38 AM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben

Re: [edk2] Miss "IMAGE_FORMAT" type name error when compile EDK2

Sorry for my web mail, it it always top posting. It seems the update for edk2 repository deleted the defination of type "IMAGE_FORMAT" in "MdeModulePkg/Include/Protocol/PlatformLogo.h" few days ago. See: https://github.com/tianocore/edk2/commit/e0ac9c8a9bd67ab934bca86504706b5400cde558 Please

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Jiewen, Does the capsule on disk feature provided by this app work? I tried it with the QuarkPlatformPkg capsule and I can get The app to copy the capsule to an EFI System Partition, but The logic after that point looks incomplete. Also, if I clear the Persist and Reset flags on the capsule,

Re: [edk2] [PATCH 37/45] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Jiewen, This DSC/FDF generates a build failure for me from GenFds. I have entered a BaseTools bug into Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=132 There is a workaround to create the file that is missing GenFds can work, so I was able to generate a Capsule Image for FW update

[edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

The HDiskImageSave() function copies a device path using DuplicateDevicePath() and passes that device path to gBS->LocateDevicePath() that changes the value of the device path pointer. When FreePool() is called with the modified device path pointer, the FreePool() service generates an ASSERT()

Re: [edk2] [RFC V2] EDK2 Platform Proposal

> On Sep 28, 2016, at 3:22 PM, Leif Lindholm wrote: > > How would we do about Readme.MD on master? > Should it be something added to a common Readme.MD for all platforms > (sounds like it would expload), or should we simply make it move to > the platform-specific

Re: [edk2] [RFC V2] EDK2 Platform Proposal

Hi Mike, On Thu, Sep 22, 2016 at 08:54:50PM +, Kinney, Michael D wrote: > Hello, > > > > Here is the V2 version of the proposal for the edk2-platforms repo. I'm happy with the proposal in this state, but have a few suggested updates (mostly to clarify that, long term, we expect most

Re: [edk2] [PATCH 00/45] Add capsule update and recovery sample.

Jiewen, I will review the Quark specific changes today. Mike > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, September 28, 2016 1:05 AM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Gao, Liming

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Star, I think the comment should be updated. This updated algorithm only uses the lower 24-bits of the ACPI timer. It is compatible with both 24-bit and 32-bit ACPI timers. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng

Re: [edk2] Miss "IMAGE_FORMAT" type name error when compile EDK2

> On Sep 28, 2016, at 6:01 AM, dashing meng wrote: > > > Hi, > Everyone. > > My machine is a Intel P6200 cpu, no vt-x support, 64bit, Debian 8 64bit OS. > > I am compiling EDK2 with the instruction at: >

[edk2] Miss "IMAGE_FORMAT" type name error when compile EDK2

Hi, Everyone. My machine is a Intel P6200 cpu, no vt-x support, 64bit, Debian 8 64bit OS. I am compiling EDK2 with the instruction at: https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions When "Build Hello World! (and the rest of MdeModulePkg)" by excute "build" command,

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

On 09/28/16 14:48, Star Zeng wrote: > From: "Zeng, Star" > > Clear bits [31:24] when reading ACPI timer count by IoRead32(), > also add comments "Note: The library only supports 24Bits ACPI timer" in INF. > > Cc: Jiewen Yao > Cc: Liming Gao

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Jiewen, Thanks for the Rb, I just send the V2 patch that follows Laszlo's suggestion to use IoBitFieldRead32 (Port, 0, 23), could you help review the patch again? Star -Original Message- From: Yao, Jiewen Sent: Wednesday, September 28, 2016 7:59 PM To: Zeng, Star ;

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Laszlo, I agree that is a better idea, please check the V2 patch. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, September 28, 2016 6:51 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen

[edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

From: "Zeng, Star" Clear bits [31:24] when reading ACPI timer count by IoRead32(), also add comments "Note: The library only supports 24Bits ACPI timer" in INF. Cc: Jiewen Yao Cc: Liming Gao Cc: Laszlo Ersek

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 28, 2016 6:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Gao, Liming > Subject: [PATCH]

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Star, On 09/28/16 12:17, Star Zeng wrote: > Clear bits [31:24] when reading ACPI timer count by IoRead32(), > also add comments "Note: The library only supports 24Bits ACPI timer" in INF. > > Cc: Jiewen Yao > Cc: Liming Gao > Contributed-under:

[edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Clear bits [31:24] when reading ACPI timer count by IoRead32(), also add comments "Note: The library only supports 24Bits ACPI timer" in INF. Cc: Jiewen Yao Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star

Re: [edk2] [PATCH 0/2] Refine HiiImageDecoder.h

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, September 27, 2016 10:18 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Refine HiiImageDecoder.h The patch renames

Re: [edk2] [PATCH v2 00/19] Add HiiImageEx implementations

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, September 26, 2016 5:30 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 00/19] Add HiiImageEx implementations The patch

Re: [edk2] [PATCH 19/45] IntelFrameworkModulePkg/DxeCapsuleLib: Add ProcessCapsules() interface.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Wednesday, September 21, 2016 2:45 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Tian, Feng; Zeng, Star; Kinney, Michael D; Gao, Liming; Zhang, Chao B Subject: [PATCH 19/45]

Re: [edk2] [PATCH 00/45] Add capsule update and recovery sample.

Hi I got reviewed-by for MdeModulePkg/SecurityPkg/UefiCpuPkg/Vlv2DevicePkg. Thanks each package owner. I have not got reviewed-by for QuarkPlatformPkg yet. Can QuarkPlatformPkg owner review the platform update? Or it takes quark owner more time to review QuarkPlatformPkg, I will plan to check