Re: [edk2] [PATCH V4 03/15] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

Here is the status code allocated from OEM region, I plan to use gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule|0x0381|UINT32|0x0100 gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin|0x8001|UINT32|0x0101

Re: [edk2] [Patch] edksetup.bat: make sure BASE_TOOLS_PATH be set correctly

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Wednesday, October 26, 2016 11:32 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] edksetup.bat: make sure BASE_TOOLS_PATH

[edk2] [Patch] edksetup.bat: make sure BASE_TOOLS_PATH be set correctly

Move checkNt32Flag before set BASE_TOOLS_PATH env to make sure it be set Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- edksetup.bat | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [edk2] [PATCH 05/33] CryptoPkg: Fix typos in comments

Thanks. Reviewed-by: Qin Long to CryptoPkg fixes. Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH V4 03/15] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

Jiewen, Are these default values allocated from the OEM extension areas? Or are the allocated from the PI Spec reserved areas? I do not think we should use values reserved for future PI Specifications. I am ok with EDK II defining its own extended status codes. However, the detailed

Re: [edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

Yes, I will do that. ☺ From: Dong, Guo Sent: Wednesday, October 26, 2016 7:56 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Mudusuru, Giri P ; Ma, Maurice Subject: RE: [edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to

Re: [edk2] [PATCH V4 03/15] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

That is good question. I follow the EDKII guideline to add new status code into code. If we need a new status code, which is not defined in PI spec, we will use PCD to avoid conflict. The benefit is that 1) The IBV/OEM implementation may choose to override this value, if the value is

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

That is good idea. I will add more description. From: Kinney, Michael D Sent: Wednesday, October 26, 2016 10:05 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Tian, Feng ; Zeng, Star

Re: [edk2] [PATCH V4 01/15] MdeModulePkg/Include: Add FmpAuthenticationLib header.

Jiewen, I agree. Please just update function description. Mike From: Yao, Jiewen Sent: Tuesday, October 25, 2016 5:51 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star ; Gao, Liming

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Jiewen, Thanks for the details. Can you add some more help information for CapsuleApp so the usage of the flags you keep are clear. I agree that keeping flags that support some unit tests makes sense. Mike From: Yao, Jiewen Sent: Tuesday, October 25, 2016 5:42 PM To: Kinney, Michael D

Re: [edk2] [PATCH V4 03/15] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

Jiewen, Can you explain how you allocated the progress code values for capsule related operations? How do you guarantee these will not conflict with future versions of PI specifications? Also, is there a reason to make these PCDs? If these can be fixed values in extensible value regions of

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Sorry. Fixed a typo in my rely. This UX capsule is already supported in MdeModulePkg\Library\DxeCapsuleLib. Sean also provides feedback to remove BMP handling from this and abstract BMP handle by using a new lib. I think it is a good idea and will follow up on that. From: edk2-devel

Re: [edk2] [Patch] AppPkg: Update email and URL V2.

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, October 26, 2016 1:06 AM To: edk2-devel@lists.01.org Cc: Daryl McDaniel ; Zhu; Zhu, Yonghong

Re: [edk2] [Patch] AppPkg: Update email and URL V2.

Reviewed-by: Daryl McDaniel Daryl McDaniel > -Original Message- > From: Jaben Carsey [mailto:jaben.car...@intel.com] > Sent: Tuesday, October 25, 2016 10:06 AM > To: edk2-devel@lists.01.org > Cc: Daryl McDaniel ; Zhu; Yonghong >

Re: [edk2] [Patch] MdePkg ACPI51: Update GIC version per ACPI 5.1 Errata B

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, October 14, 2016 3:30 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch] MdePkg ACPI51: Update GIC version per ACPI 5.1 Errata B > > Fix issue:

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

Got it. Thanks. I will use {0x0}. From: Zhu, Yonghong Sent: Wednesday, October 26, 2016 9:17 AM To: Yao, Jiewen ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zhang, Chao B ; Gao,

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

The bug 159 is {0} not support, Build tool crash, We should report reasonable error message for {0}. Maybe you BaseTools is not latest which not report error for {0}. Recently I pushed a patch to support PCD value to use expression in the DEC file which may detect the error for {0}. Best

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

I do think {0} is supported. I do not see any error reported if I use {0}. If we do not want to support {0}, I suggest we report an error to the end user. Thank you Yao Jiewen From: Zhu, Yonghong Sent: Wednesday, October 26, 2016 8:56 AM To: Yao, Jiewen ; Kinney, Michael D

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

Per DEC spec, we only support {0x0}, not support {0} and {}. The value in the { } must be a Hex value (start with '0x' or '0X'). I can enhance the error handling to report reasonable error message but not this crash. There have a similar bug in Bugzilla

Re: [edk2] [PATCH 23/33] NetworkPkg: Fix typos in comments

NetworkPkg patch committed d1c85a17fa8623e3fe60a6fe398f01e46d427a96 BestRegards Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan

Re: [edk2] [PATCH V4 01/15] MdeModulePkg/Include: Add FmpAuthenticationLib header.

Hi Mike Let me clarify: The function is used to do the authentication for FMP capsule based upon EFI_FIRMWARE_IMAGE_AUTHENTICATION. This sentence is correct, because the capsule image input should be started by EFI_FIRMWARE_IMAGE_AUTHENTICATION. LastAttemptStatus is the result of capsule

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Comments inline: From: Kinney, Michael D Sent: Wednesday, October 26, 2016 7:26 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Tian, Feng ; Zeng, Star ; Gao, Liming

Re: [edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

Hi Jiewen, Thank you catch this issue. I have sent an updated patch for it. Could you help check it in if there is no other comments? Since I don't have write access. Thanks, Guo -Original Message- From: Yao, Jiewen Sent: Tuesday, October 25, 2016 4:32 PM To: Dong, Guo

Re: [edk2] [PATCH V4 01/15] MdeModulePkg/Include: Add FmpAuthenticationLib header.

Jiewen, I am confused by the description of this API. I refers to the LastAttemptStatus field, but that field is not in EFI_FIRMWARE_IMAGE_AUTHENTICATION structure. Instead, it is in the EFI_FIRMWARE_IMAGE_DESCRIPTOR structure. Is the prototype to this function correct? Can you also update

[edk2] [PATCH v4] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

PciEnumerationComplete might be signaled to FSP in Coreboot. So FSP wrapper driver don't need send it again. Add a PCD to control if a FSP API could be skipped from FspWrapperNotifyDxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

Hi Mike I fixed all according to your suggestion, exception "Is the intended default value {0x0}, or is the intended default value empty {}?" I can only use {0} or {0x0}, but not {}. Build.py crash if I use {}. === build... : error C0DE: Unknown fatal error when

Re: [edk2] [Patch] MdePkg ACPI60: Update MADT Revision per ACPI 6.0 Errata A

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, October 25, 2016 7:34 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch] MdePkg ACPI60: Update MADT Revision per ACPI 6.0 Errata > A > > Fix issue:

Re: [edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

I found the comment section has unreadable char. I think it should be "-". We need update it to be readable asci char. With that change, reviewed-by: jiewen@intel.com > -Original Message- > From: Dong, Guo > Sent: Tuesday, October 25, 2016 11:33 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Hi Jiewen, When I run the CapsuleApp.efi, it shows the following help: CapsuleApp: usage CapsuleApp [-NR] CapsuleApp -S CapsuleApp -C CapsuleApp -P CapsuleApp -E CapsuleApp -G -O CapsuleApp -N -O CapsuleApp -D|-DS Parameter: -NR: No Reset. -S: Dump capsule status.

Re: [edk2] [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

Jiewen, Comments included inline. Mike > -Original Message- > From: Yao, Jiewen > Sent: Saturday, October 22, 2016 7:22 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; > Kinney, Michael > D ; Gao,

Re: [edk2] [PATCH 28/33] QuarkSocPkg: Fix typos in comments

Gary, Thanks for these updates. I made sure the Copyright year was updated to 2016. With that change: Reviewed-by: Michael D Kinney It has been committed at: commit 74c6a1031d36430f99ca7799520f960b4a66e7fe Mike > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 27/33] QuarkPlatformPkg: Fix typos in comments

Gary, Thanks for these updates. I made sure the Copyright year was updated to 2016. With that change: Reviewed-by: Michael D Kinney It has been committed at: commit 65aec00829912662cbfe842ab747d7608fc90553 Mike > -Original Message- > From: Gary Lin

[edk2] [PATCH 2/2] ArmPlatformPkg/BootMonFs: eliminate deprecated string functions

Get rid of functions that are no longer available when defining DISABLE_NEW_DEPRECATED_INTERFACES Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/FileSystem/BootMonFs/BootMonFsDir.c| 8 +++-

[edk2] [PATCH 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

Get rid of functions that are no longer available when defining DISABLE_NEW_DEPRECATED_INTERFACES Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 8

[edk2] [PATCH 0/2] ArmPlatformPkg: remove deprecated string function calls

ArmPlatformPkg no longer has its own .dsc, but we can still clean up some uses of deprecated string functions, so that users of ArmPlatformPkg can define DISABLE_NEW_DEPRECATED_INTERFACES Ard Biesheuvel (2): ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

Re: [edk2] [PATCH 1/5] ArmPkg/ArmDmaLib: add missing DxeServicesTableLib dependency

On 25 October 2016 at 18:46, Leif Lindholm wrote: > No 0/5 for this series. > > But I'll give the series > Reviewed-by: Leif Lindholm > on this patch (unless you insist on having one per patch). > Works for me Thanks, Ard. > On Tue, Oct 25,

Re: [edk2] [PATCH 1/5] ArmPkg/ArmDmaLib: add missing DxeServicesTableLib dependency

No 0/5 for this series. But I'll give the series Reviewed-by: Leif Lindholm on this patch (unless you insist on having one per patch). On Tue, Oct 25, 2016 at 06:10:23PM +0100, Ard Biesheuvel wrote: > This missing dependency has gone unnoticed until now, but it is

Re: [edk2] [PATCH 3/3] BeagleBoardPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

On Tue, Oct 25, 2016 at 05:37:20PM +0100, Ard Biesheuvel wrote: > Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by > default, to prevent deprecated interfaces from being used in core EDK2 > code. > > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 >

Re: [edk2] [PATCH 2/3] BeagleBoardPkg: move to generic BDS

On Tue, Oct 25, 2016 at 05:37:19PM +0100, Ard Biesheuvel wrote: > Drop the ARM BDS and related dependencies, and switch to the generic > BDS instead. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH 1/3] BeagleBoardPkg: remove unused modules

On Tue, Oct 25, 2016 at 05:37:18PM +0100, Ard Biesheuvel wrote: > Commit 0bade1054db7 ("BeagleBoardPkg: Replaced the original DSC/FDF files > by their new versions that use the ARM Platform Framework"), which dates > back to 2011, modified BeagleBoardPkg to replace references to its Sec.inf, >

Re: [edk2] [PATCH] ArmPlatformPkg: remove ARM BDS

On Tue, Oct 25, 2016 at 06:16:58PM +0100, Ard Biesheuvel wrote: > This is no longer used, and does not belong in a reference code base, > so remove it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Unless Ryan screams

Re: [edk2] [tianocore/edk2] edksetup.sh: rework argument parsing and update usage information (44f7942)

Hi Dmitry, On 25 October 2016 at 14:06, Dmitry wrote: > https://github.com/tianocore/edk2/blob/master/edksetup.sh#L149 > ./edksetup.sh: line 149: return: can only `return' from a function or sourced > script We don't use github for bugtracking - reports can be made

[edk2] [PATCH] ArmPlatformPkg: remove ARM BDS

This is no longer used, and does not belong in a reference code base, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Note that the OpenPlatformPkg version of Beagle will still need to be brought in line with the

Re: [edk2] [PATCH 0/3] BeagleBoardPkg: eliminate calls to deprecated functions

On 10/25/16 18:37, Ard Biesheuvel wrote: > Get rid of unused modules and switch to the generic BDS, so we are only > left with code that does not use any deprecated functionality, allowing > us to define DISABLE_NEW_DEPRECATED_INTERFACES > > Ard Biesheuvel (3): > BeagleBoardPkg: remove unused

[edk2] [PATCH 1/5] ArmPkg/ArmDmaLib: add missing DxeServicesTableLib dependency

This missing dependency has gone unnoticed until now, but it is breaking the Omap35xxPkg.dsc build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf | 1 + 1 file changed, 1 insertion(+)

[edk2] [PATCH 5/5] Omap35xxPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 4/5] Omap35xxPkg/Omap35xxPkg.dsc: fix build and add missing modules

Bring Omap35xxPkg.dsc up to date so it covers all modules and builds correctly with the latest toolchains. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Omap35xxPkg/Omap35xxPkg.dsc | 19 +++ 1 file changed,

[edk2] [PATCH 2/5] Omap35xxPkg: remove unused ResetSystemLib implementation

This code is unused so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Omap35xxPkg/Library/ResetSystemLib/ResetSystemLib.c | 90 Omap35xxPkg/Library/ResetSystemLib/ResetSystemLib.inf | 40

[edk2] [PATCH 3/5] Omap35xxPkg/MMCHSDxe: fix device path initializer

Fix the braces in a static device path template definition. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Omap35xxPkg/MMCHSDxe/MMCHS.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[edk2] [Patch] AppPkg: Update email and URL V2.

Cc: Daryl McDaniel CC: Zhu, Yonghong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey --- AppPkg/Applications/Python/Ia32/pyconfig.h | 6 +++---

Re: [edk2] [Patch] AppPkg: Update email and URL.

I will fix copyright and resend. For the package URL, some places has the full linkto python and some didn't. I corrected the RUL, but did not intend to redesign the link target. -Jaben > -Original Message- > From: Zhu, Yonghong > Sent: Monday, October 24, 2016 6:59 PM > To: Carsey,

Re: [edk2] COM port usage in UEFI

> On Oct 25, 2016, at 2:30 AM, GN Keshava wrote: > > Hi all, > > In my UEFI application, I'm using Serial protocol to access COM port. I'm > able to access COM port successfully. > > But I'm confused on how we can get user input regarding which COM port the > user wants

Re: [edk2] [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include

Reviewed-by: Jordan Justen On 2016-10-25 07:38:31, Laszlo Ersek wrote: > XenConsoleSerialPortLib is a BASE type library instance, without being > restricted to UEFI client modules. (For example, the > "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance

[edk2] [PATCH 2/3] BeagleBoardPkg: move to generic BDS

Drop the ARM BDS and related dependencies, and switch to the generic BDS instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/BeagleBoardPkg.dsc | 60 +--- BeagleBoardPkg/BeagleBoardPkg.fdf |

[edk2] [PATCH 1/3] BeagleBoardPkg: remove unused modules

Commit 0bade1054db7 ("BeagleBoardPkg: Replaced the original DSC/FDF files by their new versions that use the ARM Platform Framework"), which dates back to 2011, modified BeagleBoardPkg to replace references to its Sec.inf, Bds.inf and some of its library implementations to refer to versions under

[edk2] [PATCH 3/3] BeagleBoardPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 0/3] BeagleBoardPkg: eliminate calls to deprecated functions

Get rid of unused modules and switch to the generic BDS, so we are only left with code that does not use any deprecated functionality, allowing us to define DISABLE_NEW_DEPRECATED_INTERFACES Ard Biesheuvel (3): BeagleBoardPkg: remove unused modules BeagleBoardPkg: move to generic BDS

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

Thanks Jiewen and Giri! The patch has been updated by all the comments. Thanks, Guo From: Yao, Jiewen Sent: Monday, October 24, 2016 9:55 PM To: Mudusuru, Giri P ; Dong, Guo ; edk2-devel@lists.01.org Cc: Ma, Maurice Subject:

[edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

PciEnumerationComplete might be signaled to FSP in Coreboot. So FSP wrapper driver don't need send it again. Add a PCD to control if a FSP API could be skipped from FspWrapperNotifyDxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong

[edk2] [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include

XenConsoleSerialPortLib is a BASE type library instance, without being restricted to UEFI client modules. (For example, the "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type module.) For such library

Re: [edk2] [PATCH 7/9] EmbeddedPkg/EfiFileLib: eliminate deprecated string function calls

On 10/24/16 19:41, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 8/9] EmbeddedPkg/MmcDxe: eliminate deprecated string function calls

On 10/24/16 19:41, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 6/9] EmbeddedPkg/Ebl: eliminate deprecated string function calls

On 10/24/16 19:41, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include

On Mon, Oct 24, 2016 at 05:06:42PM +0100, Ard Biesheuvel wrote: > Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros > that RVCT does not use or require, given it has its own AsmMacroIoLib.inc > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [PATCH 1/6] ArmPkg: add missing components

On Mon, Oct 24, 2016 at 05:06:41PM +0100, Ard Biesheuvel wrote: > ArmPkg.dsc was a bit out of date, and some modules added over the past > years had not been added to its [Components] section yet. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 10/24/16 19:41, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size

On 10/24/16 19:41, Ard Biesheuvel wrote: > The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, > so add an intermediate UINTN cast to make this code build again on 32 bit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

[edk2] [Patch] MdePkg ACPI60: Update MADT Revision per ACPI 6.0 Errata A

Fix issue: https://bugzilla.tianocore.org/show_bug.cgi?id=94 Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [edk2] [PATCH 0/6] ArmPkg: eliminate calls to deprecated functions

On 24 October 2016 at 17:06, Ard Biesheuvel wrote: > This series prepares ArmPkg for building with the preprocess symbol > DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components > to ArmPkg (#1), fixing broken code or code that relies on deprecated >

Re: [edk2] [PATCH 6/6] ArmPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

On 10/24/16 18:06, Ard Biesheuvel wrote: > Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by > default, to prevent deprecated interfaces from being used in core EDK2 > code. > > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 > Contributed-under: TianoCore

Re: [edk2] [PATCH 4/6] ArmPkg/SemihostFs: eliminate calls to deprecated string functions

On 10/24/16 18:06, Ard Biesheuvel wrote: > Remove calls to deprecated string functions like AsciiStrCpy() and > UnicodeStrToAsciiStr() > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

On 25 October 2016 at 12:08, Ryan Harkin wrote: > On 25 October 2016 at 11:56, Ard Biesheuvel wrote: >> On 25 October 2016 at 11:53, Laszlo Ersek wrote: >>> On 10/24/16 18:06, Ard Biesheuvel wrote: Remove calls to

Re: [edk2] [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

On 25 October 2016 at 11:56, Ard Biesheuvel wrote: > On 25 October 2016 at 11:53, Laszlo Ersek wrote: >> On 10/24/16 18:06, Ard Biesheuvel wrote: >>> Remove calls to deprecated string functions like AsciiStrCpy() and >>> UnicodeStrToAsciiStr() >>>

Re: [edk2] [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

On 25 October 2016 at 11:53, Laszlo Ersek wrote: > On 10/24/16 18:06, Ard Biesheuvel wrote: >> Remove calls to deprecated string functions like AsciiStrCpy() and >> UnicodeStrToAsciiStr() >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard

Re: [edk2] [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

On 10/24/16 18:06, Ard Biesheuvel wrote: > Remove calls to deprecated string functions like AsciiStrCpy() and > UnicodeStrToAsciiStr() > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

Laszlo: Thanks for your report them. I just investigate MdePkg and MdeModulePkg ones. MdePkg BaseLib should be BASE type. It doesn't depend on UEFI. I will clean up it. MdeModulePkg FrameBufferBltLib is designed for UEFI GOP BLT operation. This library instance type should be UEFI_DRIVER.

[edk2] COM port usage in UEFI

Hi all, In my UEFI application, I'm using Serial protocol to access COM port. I'm able to access COM port successfully. But I'm confused on how we can get user input regarding which COM port the user wants to access. *Example, I have already a Windows application for the same, where user

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 10/21/16 23:27, Laszlo Ersek wrote: > This series intends to solve the following BZs: > > -- OvmfPkg: Add > the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC > files > >

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 25 October 2016 at 09:45, Laszlo Ersek wrote: > On 10/25/16 10:26, Laszlo Ersek wrote: >> On 10/24/16 10:04, Ard Biesheuvel wrote: > >>> I tried ArmVirtQemu.dsc in DEBUG mode with RVCTLINUX, and it built fine* >>> >>> Tested-by: Ard Biesheuvel #

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 10/25/16 10:26, Laszlo Ersek wrote: > On 10/24/16 10:04, Ard Biesheuvel wrote: >> I tried ArmVirtQemu.dsc in DEBUG mode with RVCTLINUX, and it built fine* >> >> Tested-by: Ard Biesheuvel # RVCT > > Okay, I'll add this tag to the ArmVirtPkg patches. Actually, I'm

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

On 10/25/16 10:22, Zeng, Star wrote: > In fact, EFI_* codes are a subset of RETURN_* codes, so it seems work to > implement ASSERT_EFI_ERROR() using new ASSERT_RETURN_ERROR(). Let me commit the patch as-is for now, with Mike's review, and let's continue the discussion on the above-suggested code

Re: [edk2] [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces

On 25 October 2016 at 09:25, Laszlo Ersek wrote: > Ard, > > On 10/21/16 23:27, Laszlo Ersek wrote: >> At this point no code in ArmVirtPkg (and apparently no code outside of >> ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, >> so we can disable them in

Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

On 10/24/16 10:04, Ard Biesheuvel wrote: > On 21 October 2016 at 22:27, Laszlo Ersek wrote: >> This series intends to solve the following BZs: >> >> -- OvmfPkg: Add >> the build option "/D

Re: [edk2] [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces

Ard, On 10/21/16 23:27, Laszlo Ersek wrote: > At this point no code in ArmVirtPkg (and apparently no code outside of > ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, > so we can disable them in the common platform DSC include file: > > BaseLib: > - StrCpy > - StrnCpy >

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

In fact, EFI_* codes are a subset of RETURN_* codes, so it seems work to implement ASSERT_EFI_ERROR() using new ASSERT_RETURN_ERROR(). Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Tuesday, October 25, 2016

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

On 10/25/16 01:05, Kinney, Michael D wrote: > Hi Laszlo, > > Sorry for the delay. I was traveling last week. > > I did see this and I have been thinking about it. > I think it does make sense to add this new macro > for libraries of type BASE. I am surprised we did > not run into an issue

Re: [edk2] [Patch] ShellPkg: update ping to use timer service instead of timer arch protocol .

Reviewed-by: Ruiyu Ni > >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu >Siyuan >Sent: Monday, October 17, 2016 2:22 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Ye, Ting ;