Re: [edk2] [patch] MdeModulePkg/DriverSample: Remove the password related codes

2016-11-22 Thread Gao, Liming
Dandan: Please also remove PasswordState usage in MdeModulePkg/DriverSample. It is not used any more. > -Original Message- > From: Bi, Dandan > Sent: Thursday, November 17, 2016 1:38 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric

Re: [edk2] [patch] MdeModulePkg/Xhci: Add 10ms delay before sending SendAddr cmd to dev

2016-11-22 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng Tian Sent: Wednesday, November 23, 2016 9:58 AM To: edk2-devel@lists.01.org Cc: Baraneedharan Anbazhagan ; Zeng, Star

Re: [edk2] [Patch] MdeModulePkg PeiCore: Make SetPeiServicesTablePointer() early in EntryPoint

2016-11-22 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, November 23, 2016 12:51 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zeng, Star

[edk2] [PATCH v7 4/4] MmcDxe: expand to support multiple blocks

2016-11-22 Thread Haojian Zhuang
Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang Tested-by: Ryan Harkin ---

[edk2] [PATCH v7 3/4] PL180: update for indentifying SD

2016-11-22 Thread Haojian Zhuang
When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang Tested-by: Ryan

[edk2] [PATCH v7 2/4] MmcDxe: set iospeed and bus width in SD stack

2016-11-22 Thread Haojian Zhuang
Add more SD commands to support 4-bit bus width & iospeed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang Tested-by: Ryan Harkin --- EmbeddedPkg/Include/Protocol/MmcHost.h | 3 +

[edk2] [PATCH v7 1/4] MmcDxe: add interface to change io width and speed

2016-11-22 Thread Haojian Zhuang
By default, MMC is initialized with 1-bit mode and less than 400KHz bus clock. It causes MMC working inefficiently. Add the interface to change the bus width and speed. Set io bus width on both MMC controller and EXTCSD. Otherwise, it may cause unmatched failure case. And support more timing

[edk2] [PATCH v7 0/4] enhance MMC

2016-11-22 Thread Haojian Zhuang
v7: * Add revision checking. v6: * Reformat the last 5 patches after 4 MMC patches of this series merged. * Squash original #5 and #6 patches together. * Fix according comments. v5: * Remove patch on MediaId. * Squash two PL180 patches together. v4: * Fix PL180 hang in some cases.

[edk2] [PATCH V2] UefiCpuPkg/PiSmmCpu: Correct exception message.

2016-11-22 Thread Jiewen Yao
This patch fixes the first part of https://bugzilla.tianocore.org/show_bug.cgi?id=242 Previously, when SMM exception happens, "stack overflow" is misreported. This patch checked the PF address to see it is stack overflow, or it is caused by SMM page protection. It dumps exception data, PF

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MpInitLib: allow platforms to provide a known CPU count upfront

2016-11-22 Thread Fan, Jeff
Laszlo, I ever submitted one bugzilla for such request at https://bugzilla.tianocore.org/show_bug.cgi?id=116 My point is not to add new PCD and just to use existing PCD PcdCpuMaxLogicalProcessorNumber that supports dynamic type. Platform Peim could update it is platform pei module before

Re: [edk2] [PATCH 2/4] UefiCpuPkg/MpInitLib: fix feature test for Extended Topology CPUID leaf

2016-11-22 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, November 23, 2016 4:26 AM To: edk2-devel-01 Cc: Fan, Jeff Subject: [edk2] [PATCH 2/4] UefiCpuPkg/MpInitLib: fix feature test

Re: [edk2] [PATCH 1/4] UefiCpuPkg/LocalApicLib: fix feature test for Extended Topology CPUID leaf

2016-11-22 Thread Fan, Jeff
Yes. This is a bug to get Initial APIC ID. Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 23, 2016 4:26 AM To: edk2-devel-01 Cc: Fan, Jeff Subject: [PATCH 1/4] UefiCpuPkg/LocalApicLib: fix feature

[edk2] [Patch] MdeModulePkg PeiCore: Make SetPeiServicesTablePointer() early in EntryPoint

2016-11-22 Thread Liming Gao
Make SetPeiServicesTablePointer() earlier than ProcessLibraryConstructorList() so the constructor() function can get the correct pei service table pointer. https://bugzilla.tianocore.org/show_bug.cgi?id=238 Cc: Michael Kinney Cc: Star Zeng

Re: [edk2] [PATCH v2 4/4] OvmfPkg/SmmControl2Dxe: select broadcast SMI if available

2016-11-22 Thread Jordan Justen
On 2016-11-18 05:52:49, Laszlo Ersek wrote: > When writing to IO port 0xB2 (ICH9_APM_CNT), QEMU by default injects an > SMI only on the VCPU that is writing the port. This has exposed corner > cases and strange behavior with edk2 code, which generally expects a > software SMI to affect all CPUs at

Re: [edk2] [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier

2016-11-22 Thread Jordan Justen
On 2016-11-22 18:36:43, Konrad Rzeszutek Wilk wrote: > From Laszlo: > " change the catch-all (*) to GCC5, from GCC44 > - remove the (5.*.*) pattern from GCC49 > - add a branch (with multiple patterns if necessary) for gcc-4.3 and > earlier to exit with an error message / failure (those compiler

Re: [edk2] [Patch] BaseTools: report error for same Guid's Private definition conflict

2016-11-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Saturday, November 19, 2016 5:21 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: report error for same Guid's Private definition >

[edk2] [PATCH] ShellPkg/MV: Fix MV to deny moving parent of current directory

2016-11-22 Thread Ruiyu Ni
From: Chen A Chen When user types "mv -r fs0:\A\ fs1:\" under directory "fs0:\A\B\", MV command should deny such movement. The patch fixes the above issue. It also denies moving current directory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier

2016-11-22 Thread Konrad Rzeszutek Wilk
>From Laszlo: " change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - add a branch (with multiple patterns if necessary) for gcc-4.3 and earlier to exit with an error message / failure (those compiler versions are unsupported)" Bugzilla:

[edk2] [PATCH v2] Compile TianoCore under Fedora Core 25

2016-11-22 Thread Konrad Rzeszutek Wilk
Hey! This patch allows me to compile TianoCore under Fedora Core 25. I've also tested it under some older ancient distros, such as: Ubuntu 16.04.1 (GCC 5.4.0), uses GCC5 Debian 8.6 (GCC 4.9.2), uses GCC49 Fedora Core 13 (GCC 4.4.4), uses GCC44 RHEL6 (GCC 4.4.7), uses GCC44 RHEL5 (GCC 4.1.2), it

[edk2] [PATCH] Vlv2TbltDevicePkg: Update BIOS ID to V0.94.

2016-11-22 Thread lushifex
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/BiosIdD.env| 2 +- Vlv2TbltDevicePkg/BiosIdR.env| 2 +- Vlv2TbltDevicePkg/BiosIdx64D.env | 2 +- Vlv2TbltDevicePkg/BiosIdx64R.env | 2 +- 4 files changed, 4

[edk2] [patch] MdeModulePkg/Xhci: Add 10ms delay before sending SendAddr cmd to dev

2016-11-22 Thread Feng Tian
We send ADDRESS DEVICE CMD in XhcInitializeDeviceSlot(), which will cause XHC issue a USB SET_ADDRESS request to the USB Device. According to USB spec, there should have a 10ms delay before this operation after resetting a given port. But in original code, there is a possible path which may have

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Correct exception message.

2016-11-22 Thread Yao, Jiewen
Yes. You are right. I agree all. Will send out V2 patch. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 23, 2016 5:17 AM To: Yao, Jiewen ; edk2-de...@ml01.01.org Cc: Kinney, Michael D ; Fan, Jeff

Re: [edk2] EXT FS support

2016-11-22 Thread Rod Smith
On 11/22/2016 01:25 PM, Pete Batard wrote: > On 2016.11.22 17:16, Marcin Wojtas wrote: >> There's no GRUB, platform simply boots to the Shell. > > I think there may be some confusion. > > All the drivers we linked you to are pure UEFI drivers. It doesn't > matter if they were a port from GRUB or

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Correct exception message.

2016-11-22 Thread Laszlo Ersek
On 11/22/16 12:47, Jiewen Yao wrote: > This patch fixes the first part of > https://bugzilla.tianocore.org/show_bug.cgi?id=242 > > Previously, when SMM exception happens, "stack overflow" is misreported. > This patch checked the PF address to see it is stack overflow, or > it is caused by SMM

[edk2] [PATCH 4/4] OvmfPkg/PlatformPei: set PcdCpuKnownLogicalProcessorNumber for MpInitLib

2016-11-22 Thread Laszlo Ersek
This setting will allow CpuMpPei and CpuDxe to wait for the initial AP check-ins exactly as long as necessary. It is safe to set PcdCpuKnownLogicalProcessorNumber in OvmfPkg/PlatformPei. OvmfPkg/PlatformPei installs the permanent PEI RAM, producing gEfiPeiMemoryDiscoveredPpiGuid, and

[edk2] [PATCH 2/4] UefiCpuPkg/MpInitLib: fix feature test for Extended Topology CPUID leaf

2016-11-22 Thread Laszlo Ersek
According to the Intel SDM (325462-060US / September 2016), > INPUT EAX = 0BH: Returns Extended Topology Information > > [...] Software must detect the presence of CPUID leaf 0BH by verifying > (a) the highest leaf index supported by CPUID is >= 0BH, and > (b) CPUID.0BH:EBX[15:0] reports a

[edk2] [PATCH 3/4] UefiCpuPkg/MpInitLib: allow platforms to provide a known CPU count upfront

2016-11-22 Thread Laszlo Ersek
On QEMU/KVM, the VCPU topology for a guest is specified dynamically. It can be a low number or a high number. Waiting for PcdCpuApInitTimeOutInMicroSeconds during the initial AP collection is impractical, because in a VM, the time needed for an AP to wake up can vary widely: - if the APs report

[edk2] [PATCH 1/4] UefiCpuPkg/LocalApicLib: fix feature test for Extended Topology CPUID leaf

2016-11-22 Thread Laszlo Ersek
According to the Intel SDM (325462-060US / September 2016), > INPUT EAX = 0BH: Returns Extended Topology Information > > [...] Software must detect the presence of CPUID leaf 0BH by verifying > (a) the highest leaf index supported by CPUID is >= 0BH, and > (b) CPUID.0BH:EBX[15:0] reports a

[edk2] [PATCH 0/4] UefiCpuPkg, OvmfPkg: multiprocessing fixes and improvements

2016-11-22 Thread Laszlo Ersek
Patches 1 and 2 fix several instances of the same CPUID-related bug in UefiCpuPkg (BaseXApicLib, BaseXApicX2ApicLib, MpInitLib/Ia32, MpInitLib/X64). Patches 3 and 4 are independent from the bugfix, but they relate nonetheless to multiprocessing, so I'm including them in the same series. They

Re: [edk2] EXT FS support

2016-11-22 Thread Pete Batard
On 2016.11.22 17:16, Marcin Wojtas wrote: There's no GRUB, platform simply boots to the Shell. I think there may be some confusion. All the drivers we linked you to are pure UEFI drivers. It doesn't matter if they were a port from GRUB or something else, the code was converted to work as a

Re: [edk2] EXT FS support

2016-11-22 Thread Pete Batard
Hi Rebecca, On 2016.11.22 16:41, Rebecca Cran wrote: Have you seen the UEFI filesystem drivers from the rEFInd project, at https://sourceforge.net/p/refind/code/ci/master/tree/filesystems/ ? I did. But I had some concerns over the licensing at the time (which I shared with Rod Smith) and

Re: [edk2] tianocore.org site broken

2016-11-22 Thread Jarlstrom, Laurie
Seems to be back up now. Maybe another DNS glitch thanks, Laurie   laurie.jarlst...@intel.com Intel SSG/STO/EBP (503) 712-9395 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rebecca Cran Sent: Tuesday, November 22, 2016 8:56 AM To:

Re: [edk2] EXT FS support

2016-11-22 Thread Marcin Wojtas
Thank you all, I also found this: https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/FileSystems/VBoxFsDxe/ I'll specify more my needs. I use ARMv8 platform on top of the newest OpenPlatformPackage (linaro/master) in order to build and work as a part of EDK2 tianocore/master. There's no

Re: [edk2] [PATCH 0/3] Remove the ArmPkg LinuxLoader

2016-11-22 Thread Ryan Harkin
On 21 November 2016 at 17:28, Ryan Harkin wrote: > On 21 November 2016 at 12:29, Ard Biesheuvel > wrote: >> On 21 November 2016 at 12:28, Ard Biesheuvel >> wrote: >>> The LinuxLoader application is a deprecated

Re: [edk2] EXT FS support

2016-11-22 Thread Michael Zimmermann
I wouldn't call this a stable implementation atm but I've ported all filesystems supported by the linux kernel(ntfs, ext2/3/4, f2fs, ...) including write support to UEFI using the LKL(Linux Kernel Library) project. https://github.com/efidroid/uefi_apps_LKL Thanks Michael On Tue, Nov 22, 2016 at

Re: [edk2] [PATCH 1/3] EmbeddedPkg/AndroidFastboot: drop dependency on the LinuxLoader

2016-11-22 Thread Ryan Harkin
On 21 November 2016 at 12:28, Ard Biesheuvel wrote: > When booting the kernel via Fastboot, invoke the kernel image directly > rather than passing it to the LinuxLoader app. This requires the kernel > image to be built with UEFI stub support. > > Contributed-under:

Re: [edk2] OvmfPkg: VM crashed trying to write to RO memory from CommonInterruptEntry

2016-11-22 Thread Laszlo Ersek
On 11/22/16 14:58, Evgeny Yakovlev wrote: > Wow, that is more than i expected :) > >> I wonder if you started to see this issue very recently. > Very recently, however we use a pretty old OVMF build, circa 2015 Ugh. Please update OVMF first... A whole lot of things has changed in edk2 in this

[edk2] tianocore.org site broken

2016-11-22 Thread Rebecca Cran
It looks like the tianocore site is broken: http://tianocore.org and http://tianocore.org/edk2 displays 404 pages, while http://www.tianocore.org/udk/udk2015/# has missing images etc. -- Rebecca ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] EXT FS support

2016-11-22 Thread Rebecca Cran
On 11/22/16 9:19 AM, Pete Batard wrote: Hi Marcin, I can't speak for EDK2 integration plans, but as far as side-projects are concerned, I have been porting the various GRUB *read-only* file systems into standalone UEFI drivers. This includes an ext2/3/4 driver if you are interested (and you can

Re: [edk2] EXT FS support

2016-11-22 Thread Rebecca Cran
On 11/22/16 8:25 AM, Marcin Wojtas wrote: Hello everyone, Is there any plan of adding EXT filesystem support to EDK2? If not officially is there a chance that it exists on some old branch, or in any side project? The rEFInd boot manager (http://www.rodsbooks.com/refind) has drivers for

Re: [edk2] EXT FS support

2016-11-22 Thread Pete Batard
Hi Marcin, I can't speak for EDK2 integration plans, but as far as side-projects are concerned, I have been porting the various GRUB *read-only* file systems into standalone UEFI drivers. This includes an ext2/3/4 driver if you are interested (and you can live without write support). Please

[edk2] EXT FS support

2016-11-22 Thread Marcin Wojtas
Hello everyone, Is there any plan of adding EXT filesystem support to EDK2? If not officially is there a chance that it exists on some old branch, or in any side project? I'd be very grateful for any information. Best regards, Marcin ___ edk2-devel

Re: [edk2] OvmfPkg: VM crashed trying to write to RO memory from CommonInterruptEntry

2016-11-22 Thread Evgeny Yakovlev
Wow, that is more than i expected :) > I wonder if you started to see this issue very recently. Very recently, however we use a pretty old OVMF build, circa 2015 > OVMF debug log Sorry, we hadn't had it enabled when VM crashed and these crashes are very rare. We will try to capture it when it

Re: [edk2] OvmfPkg: VM crashed trying to write to RO memory from CommonInterruptEntry

2016-11-22 Thread Laszlo Ersek
Hello Evgeny, On 11/22/16 13:57, Evgeny Yakovlev wrote: > We are running windows UEFI-based VMs on QEMU/KVM with OvmfPkg. > > Very rarely we are experiencing a crash when VM tries to write to RO memory > very early during UEFI boot process. > > Crash happens when VM tries to execute this code

Re: [edk2] [Patch] MdeModulePkg/DxeNetLib: Allow the IPv4/prefix case when AsciiStrToIp4

2016-11-22 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Friday, November 18, 2016 3:40 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Zhang, Lubo

[edk2] OvmfPkg: VM crashed trying to write to RO memory from CommonInterruptEntry

2016-11-22 Thread Evgeny Yakovlev
We are running windows UEFI-based VMs on QEMU/KVM with OvmfPkg. Very rarely we are experiencing a crash when VM tries to write to RO memory very early during UEFI boot process. Crash happens when VM tries to execute this code in interrupt handler:

[edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Correct exception message.

2016-11-22 Thread Jiewen Yao
This patch fixes the first part of https://bugzilla.tianocore.org/show_bug.cgi?id=242 Previously, when SMM exception happens, "stack overflow" is misreported. This patch checked the PF address to see it is stack overflow, or it is caused by SMM page protection. Cc: Laszlo Ersek

Re: [edk2] [PATCH v6 1/4] MmcDxe: add interface to change io width and speed

2016-11-22 Thread Ard Biesheuvel
Hello Haojian, On 22 November 2016 at 07:50, Haojian Zhuang wrote: > By default, MMC is initialized with 1-bit mode and less than 400KHz bus > clock. It causes MMC working inefficiently. > > Add the interface to change the bus width and speed. > > Set io bus width on

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Return the selectable menu correctly

2016-11-22 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Tuesday, November 22, 2016 11:15 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/DisplayEngine: Return the selectable menu > correctly > > When

Re: [edk2] [PATCH v2 1/4] UefiCpuPkg/PiSmmCpuDxeSmm: dynamic PcdCpuSmmApSyncTimeout, PcdCpuSmmSyncMode

2016-11-22 Thread Laszlo Ersek
On 11/22/16 09:06, Laszlo Ersek wrote: > On 11/22/16 08:20, Fan, Jeff wrote: >> Reviewed-by: Jeff Fan > > Thank Jeff! This was supposed to be "Thank you, Jeff". Not making much progress on the "getting enough sleep" front. :/ Laszlo > I committed this patch in isolation

Re: [edk2] [PATCH v2 1/4] UefiCpuPkg/PiSmmCpuDxeSmm: dynamic PcdCpuSmmApSyncTimeout, PcdCpuSmmSyncMode

2016-11-22 Thread Laszlo Ersek
On 11/22/16 08:20, Fan, Jeff wrote: > Reviewed-by: Jeff Fan Thank Jeff! I committed this patch in isolation (b43dd22981b7), because I think it has value without the OvmfPkg changes too. Plus, I think the OvmfPkg changes might take longer to get into the tree, and I wouldn't