Re: [edk2] [PATCH] BaseTools/GenFw: disregard payload in PE debug directory entry size

Ard and Laszlo: Thanks for your quick fix. For my patch, I think it only impacts VS tool chain. So, I don't verify GCC tool chain. Sorry for it. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]

Re: [edk2] [PATCH v2] UefiCpuPkg: ApicLib

Leo, Could you please separate the clean-up code into a separate patch? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan, Jeff > Sent: Thursday, July 6, 2017 9:28 AM > To: Leo Duran ; edk2-devel@lists.01.org

Re: [edk2] [Patch 0/4] Update code to follow spec definition.

Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Thursday, July 06, 2017 9:30 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/4] Update code to follow spec definition. Update

[edk2] [Patch 1/4] MdePkg MpServices: Update return status to follow spec.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jeff Fan --- MdePkg/Include/Ppi/MpServices.h | 4 ++-- MdePkg/Include/Protocol/MpService.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [Patch 3/4] UefiCpuPkg CpuMpPei: Update return status to follow spec.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 2 +- UefiCpuPkg/CpuMpPei/CpuMpPei.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [Patch 0/4] Update code to follow spec definition.

Update return status code for SwitchBSP function to follow spec. Eric Dong (4): MdePkg MpServices: Update return status to follow spec. UefiCpuPkg CpuDxe: Update return status to follow spec. UefiCpuPkg CpuMpPei: Update return status to follow spec. UefiCpuPkg MpInitLib: Update return

[edk2] [Patch 2/4] UefiCpuPkg CpuDxe: Update return status to follow spec.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jeff Fan --- UefiCpuPkg/CpuDxe/CpuMp.c | 2 +- UefiCpuPkg/CpuDxe/CpuMp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c

[edk2] [Patch 4/4] UefiCpuPkg MpInitLib: Update return status to follow spec.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jeff Fan --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c

Re: [edk2] [PATCH v2] UefiCpuPkg: ApicLib

Leo, How AMD public spec dos define the manner of sending startup IPI to Aps? Which chapter is it defined in AMD public spec? Does AMD public spec indicate the second startup IPI is not required? Thanks! Jeff -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Sunday,

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

On 07/06/17 00:31, Brijesh Singh wrote: > Hi Jordan and Laszlo, > > Ping. > > It has been a while, Do you have any further feedbacks on this series ? > If you want then I can rebase the patches before you commit into > upstream repos. >From my side, refreshing the v7 series (posted on

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

Hi Jordan and Laszlo, Ping. It has been a while, Do you have any further feedbacks on this series ? If you want then I can rebase the patches before you commit into upstream repos. -Brijesh On 05/26/2017 09:43 AM, Brijesh Singh wrote: The patch series provides support for AMD's new Secure

Re: [edk2] [PATCH v2 0/8] OvmfPkg: recognize an extended TSEG when QEMU offers it

On 07/04/17 18:56, Laszlo Ersek wrote: > This is version 2 of the series posted previously at > . > > Version 2 is a rewrite from scratch based on Jordan's feedback for v1 > and the subsequent discussion. > > Repo:

Re: [edk2] [PATCH v2 0/2] OvmfPkg: refresh -D E1000_ENABLE (Intel proprietary driver for e1000)

On 07/04/17 12:00, Laszlo Ersek wrote: > Version 2 of the series previously posted at > . > > In this version, LMFA references in the commit message of patch #1 have > been replaced with Liming's explanation from the mailing list.

Re: [edk2] [PATCH] BaseTools/GenFw: disregard payload in PE debug directory entry size

On 07/05/17 20:33, Ard Biesheuvel wrote: > Currently, the PE/COFF conversion routines in GenFw add a so-called > NB10 CodeView debug record to the image, and update the associated > directory entry in the PE/COFF optional header to contain its relative > virtual address (RVA) and size. > >

[edk2] [PATCH] BaseTools/GenFw: disregard payload in PE debug directory entry size

Currently, the PE/COFF conversion routines in GenFw add a so-called NB10 CodeView debug record to the image, and update the associated directory entry in the PE/COFF optional header to contain its relative virtual address (RVA) and size. However, there are two levels of indirection at work here:

Re: [edk2] [PATCH v2 0/8] OvmfPkg: recognize an extended TSEG when QEMU offers it

On 07/05/17 19:31, Jordan Justen wrote: > On 2017-07-04 09:56:21, Laszlo Ersek wrote: >> This is version 2 of the series posted previously at >> . >> >> Version 2 is a rewrite from scratch based on Jordan's feedback for v1 >> and the

Re: [edk2] [PATCH 1/2] OvmfPkg: disable build-time relocation for DXEFV modules

On 07/05/17 19:48, Jordan Justen wrote: > On 2017-06-28 20:32:54, Gao, Liming wrote: >> Laszlo: >> LMFA feature doesn't do PE image rebase at build time. Only XIP >> module needs to be rebased at build time. LMFA feature will >> specify the loaded memory address for each PE image. At build

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 07/05/17 19:37, Ard Biesheuvel wrote: > On 5 July 2017 at 18:33, Laszlo Ersek wrote: >> On 07/05/17 18:45, Ard Biesheuvel wrote: >>> On 5 July 2017 at 17:42, Laszlo Ersek wrote: GNU Binutils produce a PE debug directory with one >>> >>> This sentence

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 07/05/17 19:33, Ard Biesheuvel wrote: > On 5 July 2017 at 18:28, Laszlo Ersek wrote: >> On 07/05/17 18:45, Ard Biesheuvel wrote: >>> On 5 July 2017 at 17:42, Laszlo Ersek wrote: GNU Binutils produce a PE debug directory with one >>> >>> This sentence

Re: [edk2] [PATCH 1/2] OvmfPkg: disable build-time relocation for DXEFV modules

On 2017-06-28 20:32:54, Gao, Liming wrote: > Laszlo: > LMFA feature doesn't do PE image rebase at build time. Only XIP > module needs to be rebased at build time. LMFA feature will > specify the loaded memory address for each PE image. At build > time, build tool records the memory address

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 5 July 2017 at 18:33, Laszlo Ersek wrote: > On 07/05/17 18:45, Ard Biesheuvel wrote: >> On 5 July 2017 at 17:42, Laszlo Ersek wrote: >>> GNU Binutils produce a PE debug directory with one >> >> This sentence already confuses me. This crash is reproducible

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 07/05/17 18:45, Ard Biesheuvel wrote: > On 5 July 2017 at 17:42, Laszlo Ersek wrote: >> GNU Binutils produce a PE debug directory with one > > This sentence already confuses me. This crash is reproducible on ARM, > but the ARM toolchains are strictly ELF based, and all

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 5 July 2017 at 18:28, Laszlo Ersek wrote: > On 07/05/17 18:45, Ard Biesheuvel wrote: >> On 5 July 2017 at 17:42, Laszlo Ersek wrote: >>> GNU Binutils produce a PE debug directory with one >> >> This sentence already confuses me. This crash is reproducible

Re: [edk2] [PATCH v2 0/8] OvmfPkg: recognize an extended TSEG when QEMU offers it

On 2017-07-04 09:56:21, Laszlo Ersek wrote: > This is version 2 of the series posted previously at > . > > Version 2 is a rewrite from scratch based on Jordan's feedback for v1 > and the subsequent discussion. > > Repo:

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 07/05/17 18:45, Ard Biesheuvel wrote: > On 5 July 2017 at 17:42, Laszlo Ersek wrote: >> GNU Binutils produce a PE debug directory with one > > This sentence already confuses me. This crash is reproducible on ARM, > but the ARM toolchains are strictly ELF based, and all

Re: [edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

On 5 July 2017 at 17:42, Laszlo Ersek wrote: > GNU Binutils produce a PE debug directory with one This sentence already confuses me. This crash is reproducible on ARM, but the ARM toolchains are strictly ELF based, and all PE/COFF data structures are created by GenFw itself,

[edk2] [PATCH] BaseTools/GenFw: work around GNU Binutils bug wrt. DebugDirectoryEntrySize

GNU Binutils produce a PE debug directory with one EFI_IMAGE_DEBUG_DIRECTORY_ENTRY: - the Type field of the entry is EFI_IMAGE_DEBUG_TYPE_CODEVIEW, - the FileOffset field of the entry points right past the entry itself, - the data structure placed at FileOffset is a CV_INFO_PDB20 structure, with

Re: [edk2] [platforms: PATCH v2 10/10] Platform/Marvell: ComPhyLib: Add support for SATA ports on CP110 slave

On Wed, Jul 05, 2017 at 12:02:12AM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Add support for COMPHY_TYPE_SATA2 and COMPHY_TYPE_SATA3, which map > to the SATA ports on the second CP110's AHCI controller. > > Contributed-under: TianoCore Contribution

Re: [edk2] [platforms: PATCH v2 09/10] Platform/Marvell: ComPhyLib: Use COMPHY_ prefix in macros

On Wed, Jul 05, 2017 at 12:02:11AM +0200, Marcin Wojtas wrote: > This patch renames macros for speed, type and polarity from > 'PHY_' to 'COMPHY_' (Common PHY), so that to avoid confusion > with network PHY's definitions (NETPHY_). > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH v2] ArmPlatformPkg: Support different PL011 reg offset

On Tue, Jul 04, 2017 at 11:43:38PM +0800, Jun Nie wrote: > ZTE/SanChip version pl011 has different reg offset and bit offset > for some registers. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie > --- > ArmPlatformPkg/ArmPlatformPkg.dec

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 5 July 2017 at 16:07, Laszlo Ersek wrote: > On 07/05/17 17:01, Ard Biesheuvel wrote: >> On 5 July 2017 at 15:25, Laszlo Ersek wrote: >>> On 07/05/17 15:46, Ard Biesheuvel wrote: On 5 July 2017 at 14:46, Ard Biesheuvel

Re: [edk2] [PATCH v2] ArmPlatformPkg: convert VExpress ResetSystemLib to ResetSystemLib

On Wed, Jul 05, 2017 at 12:20:14PM +0100, Ryan Harkin wrote: > On 4 July 2017 at 18:27, Ard Biesheuvel wrote: > > On 4 July 2017 at 18:11, Leif Lindholm wrote: > >> Since we're in the process of migrating all of the VExpress platforms > >> to

Re: [edk2] [Patch] BaseTools: Update GenFw to clear unused debug entry generated by VS tool chain

I understand it now. The article at was of great help. On 07/05/17 15:29, Laszlo Ersek wrote: > On 07/05/17 14:42, Laszlo Ersek wrote: >> On 07/03/17 07:21, Liming Gao wrote: >>> @@ -2886,11 +2891,23 @@ Returns: >>> >>>if

Re: [edk2] [PATCH v5] EmbeddedPkg/MmcDxe: Align the ExtCSD buffer

On Tue, Jul 04, 2017 at 11:43:16PM +0800, Jun Nie wrote: > ExtCSD structure may be read via DMA. So align it to > page to avoid data corruption. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 07/05/17 17:01, Ard Biesheuvel wrote: > On 5 July 2017 at 15:25, Laszlo Ersek wrote: >> On 07/05/17 15:46, Ard Biesheuvel wrote: >>> On 5 July 2017 at 14:46, Ard Biesheuvel wrote: On 5 July 2017 at 14:43, Laszlo Ersek

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 5 July 2017 at 15:25, Laszlo Ersek wrote: > On 07/05/17 15:46, Ard Biesheuvel wrote: >> On 5 July 2017 at 14:46, Ard Biesheuvel wrote: >>> On 5 July 2017 at 14:43, Laszlo Ersek wrote: On 07/05/17 15:04, Ard Biesheuvel

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 07/05/17 15:46, Ard Biesheuvel wrote: > On 5 July 2017 at 14:46, Ard Biesheuvel wrote: >> On 5 July 2017 at 14:43, Laszlo Ersek wrote: >>> On 07/05/17 15:04, Ard Biesheuvel wrote: Commit 7b1dc6c569a 'ArmVirtPkg: switch to generic

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 5 July 2017 at 14:46, Ard Biesheuvel wrote: > On 5 July 2017 at 14:43, Laszlo Ersek wrote: >> On 07/05/17 15:04, Ard Biesheuvel wrote: >>> Commit 7b1dc6c569a 'ArmVirtPkg: switch to generic ResetSystemRuntimeDxe' >>> replaced all references in

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 5 July 2017 at 14:43, Laszlo Ersek wrote: > On 07/05/17 15:04, Ard Biesheuvel wrote: >> Commit 7b1dc6c569a 'ArmVirtPkg: switch to generic ResetSystemRuntimeDxe' >> replaced all references in ArmVirtPkg to the deprecated ResetRuntimeDxe >> from EmbeddedPkg with the well

[edk2] [platforms: PATCH] Platform/Marvell/Armada: Remove status code support

Switching to the generic ResetSystemRuntimeDxe introduces dependency on the library class ReportStatusCodeLib, which is harmful to be called in the runtime from OS, resulting in crashes. Safely switch to the NULL implementation, beacause status codes are unused on Armada platforms.

Re: [edk2] [PATCH] ArmVirtPkg: remove status code support

On 07/05/17 15:04, Ard Biesheuvel wrote: > Commit 7b1dc6c569a 'ArmVirtPkg: switch to generic ResetSystemRuntimeDxe' > replaced all references in ArmVirtPkg to the deprecated ResetRuntimeDxe > from EmbeddedPkg with the well maintained generic alternative that lives > in MdeModulePkg. > > However,

Re: [edk2] [Patch] BaseTools: Update GenFw to clear unused debug entry generated by VS tool chain

Many thanks for tracking this down Laszlo - we'd stumbled over it ourselves this morning. Liming, Mike, Andrew: this currently makes the BaseTools unusable with gcc toolchains. Can we revert this commit until this has been resolved? Best Regards, Leif On Wed, Jul 05, 2017 at 02:42:15PM +0200,

Re: [edk2] [Patch] BaseTools: Update GenFw to clear unused debug entry generated by VS tool chain

On 07/05/17 14:42, Laszlo Ersek wrote: > Hi Liming, > > Gerd's Jenkins CI reported a GenFw segfault, with this patch applied. > > I can reproduce the segfault locally. This is the command line: > >> GenFw \ >> -e DXE_RUNTIME_DRIVER \ >> -o >>

[edk2] [PATCH] ArmVirtPkg: remove status code support

Commit 7b1dc6c569a 'ArmVirtPkg: switch to generic ResetSystemRuntimeDxe' replaced all references in ArmVirtPkg to the deprecated ResetRuntimeDxe from EmbeddedPkg with the well maintained generic alternative that lives in MdeModulePkg. However, as it turns out, the generic driver has a dependency

Re: [edk2] writing EDK compatible application.

On 07/04/2017 04:10 PM, Laszlo Ersek wrote: > On 07/04/17 19:20, Amit kumar wrote: >> >> HI, >> >> I have written a code (say helloworld program ) using edk2 framework, named >> the output efi file as BOOTx64.efi and placed it on a removable media in >> EFI/BOOT/ directory so that the

Re: [edk2] [Patch] BaseTools: Update GenFw to clear unused debug entry generated by VS tool chain

Hi Liming, Gerd's Jenkins CI reported a GenFw segfault, with this patch applied. I can reproduce the segfault locally. This is the command line: > GenFw \ > -e DXE_RUNTIME_DRIVER \ > -o >

Re: [edk2] writing EDK compatible application.

Laszlo, Andrew, Marvin Thank you very much for your suggestions and for sharing information. It really did help a lot. Thanks and Regards Amit From: Laszlo Ersek Sent: Wednesday, July 5, 2017 1:40:49 AM To: Amit kumar;

Re: [edk2] [PATCH v2] ArmPlatformPkg: convert VExpress ResetSystemLib to ResetSystemLib

On 4 July 2017 at 18:27, Ard Biesheuvel wrote: > On 4 July 2017 at 18:11, Leif Lindholm wrote: >> Since we're in the process of migrating all of the VExpress platforms >> to MdeModulePkg ResetSystemRuntimeDxe, convert VExpress ResetSystemLib

[edk2] SCT test on EFI_BIS_PROTOCOL

Hi experts, For one of the SCT test, EFI_BIS_PROTOCOL was needed. But I've tried to find out which driver is installing this protocol. But I find no instance of this. Please provide your comments on this. Thank you Naveen ___ edk2-devel mailing list

[edk2] [PATCH] MdeModulePkg/DxeCore: Avoid accessing non-owned memory

The patch fixes two kinds of issues in DxeCore that accesses memory which might be freed or owned by other modules. The existing bugs don't cause functionality issue. 1. CoreValidateHandle() checks whether the handle is valid by validating its signature. The proper way is to check whether

[edk2] [PATCH v2 1/2] EmbeddedPkg/DwEmmcDxe: limit max clock for platform

Some boards may have max clock limitation. Add a Pcd to notify driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 4 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf | 1 +

[edk2] [PATCH v2 2/2] EmbeddedPkg/DwEmmc: Adjust FIFO threshold

Adjust FIFO threshold according to FIFO depth. Skip the adjustment if we do not have FIFO depth info. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h | 6

Re: [edk2] [PATCH 0/3] Disk Information Protocol for SD/MMC devices

Reviewed-by: Star Zeng to the patch series. -Original Message- From: Wu, Hao A Sent: Wednesday, July 5, 2017 1:05 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ruiyu ; Zeng, Star Subject: [PATCH

Re: [edk2] [Patch] MdePkg: Declare _ReturnAddress() in Base.h for MSFT tool chain

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, July 5, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D Subject: [edk2] [Patch]