Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

Heyi, If you check the comments below in TerminalConIn.c: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c#L1319 TerminalDxe driver needs to determine whether user wants to press ESC alone, or press "ESC [ V" for F10 (PCANSI terminal). So

Re: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW

Mike, I am a bit confused about mapping 0x18 to upper arrow. I remembered that in old days, pressing ALT+18 in DOS window can generate upper arrow. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael D Kinney > Sent:

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

Cc Terminal expert Ray to see if any comments on this. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Wednesday, November 8, 2017 3:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject:

[edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

Hi folks, We found ESC key responded fairly slow on serial port terminal, and we think it might be caused by the code in UnicodeToEfiKey in TerminalConIn.c:     if (UnicodeChar == ESC) {   TerminalDevice->InputState = INPUT_STATE_ESC;     }     if (UnicodeChar == CSI) {  

[edk2] [PATCH v2 1/2] MdePkg/Btt.h: Add Block Translation Table definitions

BTT definitions are defined in UEFI spec 2.7, to defines a layout and set of rules for doing block I/O that provide powerfail write atomicity of a single block in NVDIMM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Liming Gao

[edk2] [PATCH v2 0/2] Add NVDIMM related spec definitions

v2: 1. Create Btt.h in Include/Guid directory per Liming's comments. 2. Change the GUID C name to match macro name. Ruiyu Ni (2): MdePkg/Btt.h: Add Block Translation Table definitions MdePkg/NvdimmLabel.h: Add NVDIMM_LABEL protocol definition MdePkg/Include/Guid/Btt.h | 228

[edk2] [PATCH v2 2/2] MdePkg/NvdimmLabel.h: Add NVDIMM_LABEL protocol definition

NVDIMM_LABEL protocol is defined in UEFI 2.7 spec, to provide services that allow management of labels contained in a Label Storage Area in NVDIMM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Liming Gao ---

Re: [edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Leo Duran [mailto:leo.du...@amd.com] > Sent: Wednesday, November 1, 2017 1:55 AM > To: edk2-devel@lists.01.org > Cc: Leo Duran ; Ni, Ruiyu > Subject: [PATCH 1/2]

Re: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW

Reviewed-by: Star Zeng Cc Ray to see if any comments. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael D Kinney Sent: Wednesday, November 8, 2017 12:24 PM To: edk2-devel@lists.01.org Cc: Dong, Eric

Re: [edk2] GRUB issue on device priority

On 2017/11/7 23:14, Vladimir 'phcoder' Serbinenko wrote: On Tue, Nov 7, 2017, 15:23 Haojian Zhuang > wrote: Hi all, It seems there's a device priority issue in GRUB. Please use mailing list for grub, not just messaging

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, November 07, 2017 11:25 PM > To: Vabhav Sharma > Cc: edk2-devel@lists.01.org; ruiyu...@intel.com; jaben.car...@intel.com; > ard.biesheu...@linaro.org;

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

Thanks, Heyi 在 11/8/2017 12:53 PM, Zeng, Star 写道: Just pushed at 710d9e69fae6753a1a826aa18dd37bcadd3e0c3e. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, November 7, 2017 5:33 PM To: Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

Just pushed at 710d9e69fae6753a1a826aa18dd37bcadd3e0c3e. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, November 7, 2017 5:33 PM To: Ard Biesheuvel Cc: Ni, Ruiyu

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Make sense. Thanks for the comment. > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, November 08, 2017 12:42 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Jian, Can you add more comments to explain why changing the capabilities of GCD entry? The background is clear by checking the Bugzilla. But it would be great to know the issue by just reading the code. Thanks/Ray > -Original Message- > From: edk2-devel

[edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW

https://bugzilla.tianocore.org/show_bug.cgi?id=761 When a TerminalType is set to PCANSI, characters in the range 0x00 to 0x1F are control characters. The mapping table for PCANSI maps TRIANGLE glyphs, ARROW_UP glyph, and ARROW_DOWN glyph into this control character range and that causes no

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

https://bugzilla.tianocore.org/show_bug.cgi?id=763 is submitted to track this. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, November 7, 2017 8:55 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen

Re: [edk2] [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

Fine, https://bugzilla.tianocore.org/show_bug.cgi?id=762 is submitted. Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Wednesday, November 8, 2017 10:46 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Dong, Eric

Re: [edk2] [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

Hi Star, I agree the issues you mentioned. But they're already there before this patch. I'd suggest to file a new bug tracker for them instead of fixing them in this one. Thanks, Jian > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 08, 2017 10:38 AM > To: Wang, Jian

Re: [edk2] [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

In FrontPageCustomizedUiSupport.c, suggest to use "(CurrentSize + UI_HII_DRIVER_LIST_SIZE)" instead of "(Count + UI_HII_DRIVER_LIST_SIZE)" to be consistent with the following code "CurrentSize += UI_HII_DRIVER_LIST_SIZE". Same comment to BootMaintenanceManagerCustomizedUiSupport.c In HiiLib.c,

Re: [edk2] [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Jian J Sent: Wednesday, November 8, 2017 10:12 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Bi, Dandan Subject: [PATCH v3 3/3]

[edk2] Why do we use -g option of gcc even for RELEASE build?

Hi folks, From gcc manual, -g option seems to produce debugging information. In tools_def.template, -g is included in GCC_ALL_CC_FLAGS, so it will also be enabled for RELEASE build with gcc tool chain. Any special reason to do that? Thanks and regards, Heyi

[edk2] [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool

> v3: > No update > v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory

[edk2] [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

>v3: > a. Add ASSERT for returned pointer > b. Correct DestMax parameter in calling StrCpyS > c. Fix coding style >v2: > a. Use ReallocatePool to replace AllocateCopyPool wherever applicable. AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer"

[edk2] [PATCH v3 0/3] Fix misuses of AllocateCopyPool

> v3: > a. Add necessary ASSERT > b. Correct StrCpyS parameter > c. Coding style clean-up > v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated

[edk2] [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool

> v3: >No updates. > v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE

Thanks, Heyi 在 11/7/2017 9:30 PM, Ard Biesheuvel 写道: On 7 November 2017 at 13:29, Leif Lindholm wrote: On Tue, Nov 07, 2017 at 01:22:19PM +, Ard Biesheuvel wrote: On 7 November 2017 at 12:56, Heyi Guo wrote: From: Peicong Li

Re: [edk2] [Patch 0/2] Add missed Depex Protocol/Ppi.

Hi Laszlo, Agree with you, I'm not aware the consume protocol/Ppi code is in the library till now. I will discard the changes. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 8, 2017 2:18 AM > To: Dong, Eric

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 08, 2017 1:14 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2]

Re: [edk2] [PATCH V2] MdeModulePkg SerialDxe: Handle Timeout change more robustly

oops, forgot to write down my only comment: On 11/07/17 19:27, Laszlo Ersek wrote: > On 11/07/17 02:36, Star Zeng wrote: >> https://lists.01.org/pipermail/edk2-devel/2017-October/016479.html >> reported "Xen Console input very slow in recent UEFI" that appears >> after

Re: [edk2] [PATCH V2] MdeModulePkg SerialDxe: Handle Timeout change more robustly

On 11/07/17 02:36, Star Zeng wrote: > https://lists.01.org/pipermail/edk2-devel/2017-October/016479.html > reported "Xen Console input very slow in recent UEFI" that appears > after 4cf3f37c87ba1f9d58072444bd735e40e4779e70 "MdeModulePkg > SerialDxe: Process timeout consistently in SerialRead". >

Re: [edk2] [Patch 0/2] Add missed Depex Protocol/Ppi.

Hi Eric, On 11/06/17 13:26, Eric Dong wrote: > The Protocol/Ppi used in the drivers but the it not add them > in the dependence section, it may cause driver assert. > This patch series add the missed Protocol/Ppi. > > Eric Dong (2): > UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol.

Re: [edk2] [PATCH v2] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

On 7 November 2017 at 18:09, Laszlo Ersek wrote: > On 11/05/17 17:29, Ard Biesheuvel wrote: >> On 5 November 2017 at 16:27, Ard Biesheuvel >> wrote: >>> On 5 November 2017 at 05:52, Leif Lindholm wrote: On Fri, Nov

Re: [edk2] [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2.

2017-11-07 18:21 GMT+01:00 Leif Lindholm : > On Fri, Nov 03, 2017 at 06:57:09PM +0100, Marcin Wojtas wrote: >> Hi, >> >> I submit corrected version of the Armada SPI improvements >> after the first round of review. There were no significant changes >> comparing to v1,

Re: [edk2] [PATCH v2] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

On 11/05/17 17:29, Ard Biesheuvel wrote: > On 5 November 2017 at 16:27, Ard Biesheuvel wrote: >> On 5 November 2017 at 05:52, Leif Lindholm wrote: >>> On Fri, Nov 03, 2017 at 11:33:52AM +, Ard Biesheuvel wrote: DEBUG builds of PEI

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

On Fri, Nov 03, 2017 at 07:56:32PM +0530, Vabhav wrote: > Issue: > when file open is failed, assert was seen due to freeing 0 size page > > Reason: > DataSize is remain zero if error is reported in ShellOpenFileByName > > Fix: > Update DataSize as soon as FileSize is available > >

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

On 11/03/17 09:28, Ruiyu Ni wrote: > The original code enables some BITs in PCI attributes in Start(), > but wrongly to disable these BITs in Stop(). > > The correct behavior is to save the original PCI attributes before > enables some BITs in Start(), and restore to original value > in Stop(). >

Re: [edk2] [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2.

On Fri, Nov 03, 2017 at 06:57:09PM +0100, Marcin Wojtas wrote: > Hi, > > I submit corrected version of the Armada SPI improvements > after the first round of review. There were no significant changes > comparing to v1, please check the changelog below for the details. > > Patches are available

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

sorry about the late response On 11/03/17 01:57, Jian J Wang wrote: >> v2 >> a. Fix an issue which will cause setting capability failure if size is >> smaller >>than a page. > > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Handle Timeout change more robustly

Hi Star, On 07/11/17 01:39, Zeng, Star wrote: I agree it could be more rigorous to compare against the original parameters. Please check the V2 patch at https://lists.01.org/pipermail/edk2-devel/2017-November/016968.html. Julien, Please help take the test on your case with the V2 patch.

Re: [edk2] [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

2017-11-07 16:50 GMT+01:00 Leif Lindholm : > On Tue, Nov 07, 2017 at 04:45:19PM +0100, Marcin Wojtas wrote: >> Hi Leif, >> >> 2017-11-07 16:37 GMT+01:00 Leif Lindholm : >> > On Fri, Nov 03, 2017 at 06:55:17PM +0100, Marcin Wojtas wrote: >> >> The

Re: [edk2] [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

On Tue, Nov 07, 2017 at 04:45:19PM +0100, Marcin Wojtas wrote: > Hi Leif, > > 2017-11-07 16:37 GMT+01:00 Leif Lindholm : > > On Fri, Nov 03, 2017 at 06:55:17PM +0100, Marcin Wojtas wrote: > >> The SPI NOR flash drivers which base on ArmPlatformPkg's > >> NorFlashDxe

Re: [edk2] [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

Hi Leif, 2017-11-07 16:37 GMT+01:00 Leif Lindholm : > On Fri, Nov 03, 2017 at 06:55:17PM +0100, Marcin Wojtas wrote: >> The SPI NOR flash drivers which base on ArmPlatformPkg's >> NorFlashDxe usually make use of static declarations of the >> flash instances with their

Re: [edk2] [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

On Fri, Nov 03, 2017 at 06:55:17PM +0100, Marcin Wojtas wrote: > The SPI NOR flash drivers which base on ArmPlatformPkg's > NorFlashDxe usually make use of static declarations of the > flash instances with their type and parameters. As a result > it implies hardcoding the exact way of flash

Re: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, November 06, 2017 11:35 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject:

[edk2] GRUB issue on device priority

Hi all, It seems there's a device priority issue in GRUB. All block io handles are linked into the list in edk2, and GRUB could fetch it. Then GRUB creates its own ascending on HD priority. add_device(): for (p = devices; *p; p = &((*p)->next)) { ret = grub_efi_compare_device_paths

Re: [edk2] [Help] UEFI boot KVM4T vm hang On TianoCore

On 11/07/17 03:39, Hangaohuai wrote: > Hi, Laszlo Ersek; > Thanks for your reply. > > I have trying to shoot this trouble: > > 1. edk get the MtrrValidBitsMask by "AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, > , NULL, NULL, NULL); "(0x8008) > 2. Cpuid(0x8008) is held in kvm struct

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE

On 7 November 2017 at 13:29, Leif Lindholm wrote: > On Tue, Nov 07, 2017 at 01:22:19PM +, Ard Biesheuvel wrote: >> On 7 November 2017 at 12:56, Heyi Guo wrote: >> > From: Peicong Li >> > >> > Flash region needs to be set

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE

On Tue, Nov 07, 2017 at 01:22:19PM +, Ard Biesheuvel wrote: > On 7 November 2017 at 12:56, Heyi Guo wrote: > > From: Peicong Li > > > > Flash region needs to be set as cacheable (write back) to increase > > performance, if PEI is still XIP on flash

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE

On 7 November 2017 at 12:56, Heyi Guo wrote: > From: Peicong Li > > Flash region needs to be set as cacheable (write back) to increase > performance, if PEI is still XIP on flash or DXE FV is decompressed > from flash FV. However some ARM platforms do

[edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute

V1 changes upon RFC version: 1. Rename NONSHARE to NONSHAREABLE per review comments. 2. Place these two uncommon attributes after normal WRITE_BACK attributes to imply they should not be used by default. 3. Add warnning comments. Peicong Li (1): ArmPkg/ArmMmuLib: Add new attribute

[edk2] [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE

From: Peicong Li Flash region needs to be set as cacheable (write back) to increase performance, if PEI is still XIP on flash or DXE FV is decompressed from flash FV. However some ARM platforms do not support to set flash as inner shareable since flash is not normal DDR

Re: [edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

在 11/7/2017 7:25 PM, Ard Biesheuvel 写道: On 7 November 2017 at 11:23, Leif Lindholm wrote: On Tue, Nov 07, 2017 at 11:08:39AM +, Ard Biesheuvel wrote: On 7 November 2017 at 11:05, Heyi Guo wrote: From: Peicong Li

Re: [edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

On Tue, Nov 07, 2017 at 11:25:16AM +, Ard Biesheuvel wrote: > >> I'd prefer the name > >> ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE but other than > >> that, this looks sensible to me. Leif? > > > > And the same for NONSECURE, yes. > > With that modification, this sounds like

Re: [edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

On 7 November 2017 at 11:23, Leif Lindholm wrote: > On Tue, Nov 07, 2017 at 11:08:39AM +, Ard Biesheuvel wrote: >> On 7 November 2017 at 11:05, Heyi Guo wrote: >> > From: Peicong Li >> > >> > Flash region needs to be set

Re: [edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

On Tue, Nov 07, 2017 at 11:08:39AM +, Ard Biesheuvel wrote: > On 7 November 2017 at 11:05, Heyi Guo wrote: > > From: Peicong Li > > > > Flash region needs to be set as cacheable (write back) to increase > > performance, if PEI is still XIP on flash

Re: [edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

On 7 November 2017 at 11:05, Heyi Guo wrote: > From: Peicong Li > > Flash region needs to be set as cacheable (write back) to increase > performance, if PEI is still XIP on flash or DXE FV is decompressed > from flash FV. However some ARM platforms do

[edk2] [RFC] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHARE

From: Peicong Li Flash region needs to be set as cacheable (write back) to increase performance, if PEI is still XIP on flash or DXE FV is decompressed from flash FV. However some ARM platforms do not support to set flash as inner shareable since flash is not normal DDR

Re: [edk2] Build error in StdLib with VS 2015 compiler

It works Fine. Are you going to check in this changes, could you please let us know the plan? -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, November 06, 2017 6:59 PM To: Karunakar P; 'Tim Lewis'; 'edk2-devel@lists.01.org' Cc: Ye, Ting; Fu, Siyuan; Wu,

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

Hi Ray, We had Ard's R-B already; could you help to commit it? Thanks and regards, Heyi 在 10/30/2017 4:14 PM, Ard Biesheuvel 写道: On 30 October 2017 at 05:47, Heyi Guo wrote: For PciIoPciRead interface, memory prior to Buffer would be written with zeros if Offset was

[edk2] [PATCH 10/10] Compilation : Add the fdf, dsc and dec files.

The firware device, description and declaration files. Build script and Environment setup script. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Env.cshrc | 75 +

[edk2] [PATCH 09/10] SocLib : Add support for initialization of peripherals

Add SocInit function that initializes peripherals and print board and soc information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Include/Bitops.h | 179 +++

[edk2] [PATCH 07/10] Platform/NXP : Add support for DS1307 RTC library

Real time clock Apis on top of I2C Apis Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Library/Ds1307RtcLib/Ds1307Rtc.h | 40 Platform/NXP/Library/Ds1307RtcLib/Ds1307RtcLib.c | 226

[edk2] [PATCH 08/10] Platform/NXP: Add support for ArmPlatformLib

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- .../Library/PlatformLib/ArmPlatformLib.c | 105 .../Library/PlatformLib/ArmPlatformLib.inf | 70

[edk2] [PATCH 04/10] Platform/NXP : Add support for Watchdog driver

Installs watchdog timer arch protocol Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Drivers/WatchDog/WatchDog.c | 386 ++ Platform/NXP/Drivers/WatchDog/WatchDog.h | 37 +++

[edk2] [PATCH 03/10] Platform/NXP: Add support for Big Endian Mmio APIs

This library add supports for BE read/write and other MMIO helper function. In this data swapped after reading from MMIO and before write using MMIO. It can be used by any module with BE address space. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal

[edk2] [PATCH 06/10] Platform/NXP: Add support for I2c operations library

I2C bus initialization and I2c read/write APIs added. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Include/Library/I2c.h | 125 Platform/NXP/Library/I2cLib/I2cLib.c | 549

[edk2] [PATCH 01/10] Platform/NXP: Library to provide helper functions.

UtilsLib provide helper functions which will be needed by NXP SoCs Library and Drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Include/Library/Utils.h| 137

[edk2] [PATCH 00/10] edk2-platforms/Platform/NXP

Hi, Following patches will add support of NXP SoCs in edk2-platforms. Our directory structure will be: edk2-platforms/ |-- Platform | |-- NXP | | |-- build.sh | | |-- Drivers | | |-- Env.cshrc | | |-- Include | | | `-- Library | | | `-- Drivers | | |-- Library

[edk2] [PATCH 05/10] Platform/NXP : Add support for DUART library

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Library/DUartPortLib/DUart.h | 128 Platform/NXP/Library/DUartPortLib/DUartPortLib.c | 334 +

[edk2] [PATCH 02/10] Platform/NXP: Add support for system reset library

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- .../NXP/Library/ResetSystemLib/ResetSystemLib.c| 96 ++ .../NXP/Library/ResetSystemLib/ResetSystemLib.inf | 33 2 files changed, 129

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

Some minor comments. 1. How about update structure field name 'OriginalAttribute' to be 'OriginalAttributes'? 2. The comments below in Stop() need to be updated accordingly. // // Get supported PCI attributes // 3. Add the bugzilla link to the commit log. With that fixed, Reviewed-by:

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

This patch can fix the Bug 405 issue (https://bugzilla.tianocore.org/show_bug.cgi?id=405). Thank you! Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 7, 2017 1:36 PM > To: Laszlo Ersek

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Got it. That is better. Agree. I think we can check in the real C code update at first. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Tuesday, November 7, 2017 3:58 PM > To: Yao, Jiewen ; Song, BinX ; >