[edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=779 For the API EfiShellOpenRootByHandle(): The return status of the call to SimpleFileSystem->OpenVolume should be checked. It is possible that there is a media change in the device (like CD/DVD ROM). In such case, the volume root opened

[edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: Avoid possible loss track of allocated buffer

In function FindFileEntry(): Instead of using the function parameter 'FileEntry', use a local variable to store the buffer allocated for disk read operation. For the below calling stack: UdfOpenVolume() -> FindRootDirectory() -> FindFileEntry() In FindFileEntry(), the call to

[edk2] [PATCH 0/2] Refine UDF related codes

The series will do the following refinements: a. Merge the discovery of the El Torito feature on CD/DVD media into the detect of UDF; b. Avoid possible loss track of the allocated buffer pointer in UdfDxe. Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Star Zeng

[edk2] [PATCH 1/2] MdeModulePkg/PartitionDxe: Merge the discovery of ElTorito into UDF

In order to create all of the children (El Torito standard and UDF) for a CD/DVD media in an entry of the PartitionDriverBindingStart(), this commit merges the discovery of the El Torito feature (PartitionInstallElToritoChildHandles) into function PartitionInstallUdfChildHandles. Cc: Paulo

Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix UDF fs access on certain CD/DVD medias

Hi Paulo, Sorry for the delayed response. The patch is good to me: Reviewed-by: Hao Wu Hi Ray, Do you have any other comment on this? Best Regards, Hao Wu > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, October 13, 2017

[edk2] [Patch] BaseTools: Fix the bug to collect source files per build rule family

when collect source files list we should also consider build rule family. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file

Re: [edk2] [PATCH 01/10] Platform/NXP: Library to provide helper functions.

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, November 13, 2017 6:44 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.com; edk2- > de...@lists.01.org; Udit Kumar

Re: [edk2] [PATCH 07/10] Platform/NXP : Add support for DS1307 RTC library

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 6:13 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Benson FAB B

Add code for Benson Glacier FAB B. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../BensonGlacier/BoardInitPostMem/BoardGpios.h| 6 +- .../BensonGlacier/BoardInitPostMem/BoardInit.c | 2 -

Re: [edk2] [PATCH 06/10] Platform/NXP: Add support for I2c operations library

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 6:06 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

Re: [edk2] [PATCH 04/10] Platform/NXP : Add support for Watchdog driver

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 5:53 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

Re: [edk2] [PATCH 02/10] Platform/NXP: Add support for system reset library

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 5:40 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

Re: [edk2] [PATCH 01/10] Platform/NXP: Library to provide helper functions.

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 5:36 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

Re: [edk2] [PATCH 05/10] Platform/NXP : Add support for DUART library

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 5:59 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

Re: [edk2] [PATCH 03/10] Platform/NXP: Add support for Big Endian Mmio APIs

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 13, 2017 5:56 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; Kinney, Michael D > ;

[edk2] [PATCH v6 4/7] MdeModulePkg/DxeIpl: Enable paging for heap guard

Heap guard feature needs paging to work properly. 64-bit BIOS uses PcdDxeIplBuildPageTables to control the page table setup. 32-bit BIOS has to check heap guard feature to decide enabling paging or not. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao

[edk2] [PATCH v6 7/7] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

> v5 > a. Remove lib and pcd no longer needed from PiSmmCore.inf > v4 > a. According to Ray's feedback, change the name of new protocol definitions from EFI_ to EDKII_. > b. Coding style cleanup > v3 > According to Jiewen's feedback, use new added protocol >

[edk2] [PATCH v6 2/7] MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions

> v5 > a. Remove EFI wording for SMM memory attribute protocol. > b. Change parameter modifier from IN to OUT The new protocol gEdkiiSmmMemoryAttributeProtocolGuid is intended for PiSmmCore to be able to change memory page attributes for the sake of heap guard feature. This protocol provides

[edk2] [PATCH v6 5/7] MdeModulePkg/DxeCore: Implement heap guard feature for UEFI

> v6 > Add sanity check and comments for the use of heap guard and memory > protection because heap guard might overwrite memory attributes set > by memory protection. > v4 > Coding style cleanup > v3 > Fix build error with GCC toolchain > v2 > According to Eric's feedback: > a. Remove local

[edk2] [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug message

Heap guard feature will frequently update page attributes. The debug message in CpuDxe driver will slow down the boot performance noticeably. Changing the debug level to DEBUG_POOL and DEBUG_PAGE to reduce the message output for normal debug configuration. Cc: Eric Dong Cc:

[edk2] [PATCH v6 6/7] UefiCpuPkg/PiSmmCpuDxeSmm: Add SmmMemoryAttribute protocol

> v5 > a. Change parameter modifier from IN to OUT. > b. Add ASSERT to make sure static paging and heap guard are not enabled at >the same time. > v4 > a. According to Ray's feedback, change the definition name prefix from EFI_ >to EDKII_ > b. Coding style cleanup > c. Add more comments

[edk2] [PATCH v6 0/7] Implement heap guard feature

> Patch V6 changes: > Add sanity check and comments for the use of heap guard and memory > protection because heap guard might overwrite memory attributes set > by memory protection. > Patch V5 changes: > a. Remove EFI from comment for SMM memory attribute protocol. > b. Change parameter modifier

[edk2] [PATCH v6 1/7] MdeModulePkg/MdeModulePkg.dec, .uni: Add Protocol, PCDs and string tokens

>v4: > No content change but move this patch to be the first one Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Suggested-by: Ayellet Wolman Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] edk2 occur Data abort: Alignment fault on ARM64

On 2017/11/11 22:14, Shannon Zhao wrote: > Hi Ard, > > On 2017/11/11 19:55, Ard Biesheuvel wrote: >> > On 11 November 2017 at 11:48, Shannon Zhao >> > wrote: >> > Hi, >> > >> > I'm using UDK2017(commit is eea98ee UefiCpuPkg/MpLib: fix potential >>

[edk2] [PATCH] MdeModulePkg/DxeCore: Remove redundant code in Tpl.c

(MdeModulePkg\Core\Dxe\Event\Tpl.c) line 120-122 - 120 if (OldTpl >= TPL_HIGH_LEVEL && NewTpl < TPL_HIGH_LEVEL) { 121gEfiCurrentTpl = TPL_HIGH_LEVEL; 122 } -

Re: [edk2] EDK2 build issues

I add my comments. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Aaron > Durbin > Sent: Tuesday, November 14, 2017 1:38 AM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] EDK2 build issues > >

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Star, I may drop this patch. The range check is valid, but may want to change to an error condition instead of forcing to 0 if out of range. I just found that this device is returning different values for the max LUN. I saw examples today of a single LUN device returning 4. This appears to

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Ok, Reviewed-by: Star Zeng to this patch. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, November 14, 2017 3:54 AM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Dong, Eric

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

That is fine. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, November 14, 2017 1:08 AM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Dong, Eric

Re: [edk2] [Patch] QuarkPlatformPkg/PlatformBootManagerLib: Update boot mode handling

Reviewed-by: Steele, Kelly -Original Message- From: Kinney, Michael D Sent: November 08, 2017 14:48 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Yao, Jiewen Subject: [Patch]

Re: [edk2] [Patch] QuarkPlatformPkg/Readme.md: Fix markdown format issue

Reviewed-by: Steele, Kelly -Original Message- From: Kinney, Michael D Sent: November 08, 2017 15:59 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Yao, Jiewen Subject: [Patch] QuarkPlatformPkg/Readme.md: Fix

Re: [edk2] stdlib broken strncasecmp.c

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Zimmermann > Sent: Monday, November 13, 2017 11:58 AM > To: Laszlo Ersek > Cc: edk2 developers list > Subject: Re: [edk2] stdlib broken

Re: [edk2] [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack

On 11/13/17 20:02, Jordan Justen wrote: > On 2017-11-13 10:36:45, Laszlo Ersek wrote: >> On 11/13/17 19:25, Jordan Justen wrote: >>> On 2017-11-10 07:49:06, Laszlo Ersek wrote: diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntry.nasm index

Re: [edk2] stdlib broken strncasecmp.c

> I've been subscribed to edk2-devel (wherever it lived whenever) since > approx. April 2012. So, I checked all my yearly archives, and the only > year where the search expression "df7729 patch" returns at least one hit > is 2013. Please don't judge the project's development process from a > four

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Star, The specific USB mass storage device that demonstrated this issue has a Protocol of 0x00 (CBI), and the PEI phase USB recovery seems to only support a Protocol of 0x50 (BOT). So I am not able to reproduce the issue in PEI recovery path. >From code review, the PEI request sense API

Re: [edk2] [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack

On 2017-11-13 10:36:45, Laszlo Ersek wrote: > On 11/13/17 19:25, Jordan Justen wrote: > > On 2017-11-10 07:49:06, Laszlo Ersek wrote: > >> diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm > >> b/OvmfPkg/Sec/Ia32/SecEntry.nasm > >> index 54d074e621f6..1d426fafa888 100644 > >> ---

Re: [edk2] [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack

On 11/13/17 19:25, Jordan Justen wrote: > On 2017-11-10 07:49:06, Laszlo Ersek wrote: >> diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntry.nasm >> index 54d074e621f6..1d426fafa888 100644 >> --- a/OvmfPkg/Sec/Ia32/SecEntry.nasm >> +++ b/OvmfPkg/Sec/Ia32/SecEntry.nasm >> @@

Re: [edk2] [PATCH 1/4] OvmfPkg/Sec/Ia32: free up EAX for other uses while setting up the stack

On 11/13/17 19:08, Jordan Justen wrote: > On 2017-11-10 07:49:05, Laszlo Ersek wrote: >> Currently EAX is used as an intermediary in setting ESP to >> SEC_TOP_OF_STACK, and in passing SEC_TOP_OF_STACK to >> SecCoreStartupWithStack() as the "TopOfCurrentStack" argument. >> >> In a later patch we'll

Re: [edk2] [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack

On 2017-11-10 07:49:06, Laszlo Ersek wrote: > diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntry.nasm > index 54d074e621f6..1d426fafa888 100644 > --- a/OvmfPkg/Sec/Ia32/SecEntry.nasm > +++ b/OvmfPkg/Sec/Ia32/SecEntry.nasm > @@ -29,6 +29,7 @@ extern

Re: [edk2] [PATCH 1/4] OvmfPkg/Sec/Ia32: free up EAX for other uses while setting up the stack

On 2017-11-10 07:49:05, Laszlo Ersek wrote: > Currently EAX is used as an intermediary in setting ESP to > SEC_TOP_OF_STACK, and in passing SEC_TOP_OF_STACK to > SecCoreStartupWithStack() as the "TopOfCurrentStack" argument. > > In a later patch we'll use EAX differently, so replace it with EBX

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 2017-11-13 05:09:03, Laszlo Ersek wrote: > given that I'm opposed to calling any library functions before we reach > the ProcessLibraryConstructorList() call lower down in > SecCoreStartupWithStack(), I cannot agree to calling SetJump() either. Good point. -Jordan

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 2017-11-13 04:34:05, Laszlo Ersek wrote: > AsmReadSp() is IPF only (the BaseLib class header says so, and the tree > agrees). > > AsmReadEsp() and AsmReadRsp() do not exist in BaseLib, and they would > only be implementable for x86. I think platform-dependent library > *interfaces* don't

Re: [edk2] EDK2 build issues

On Sun, Nov 12, 2017 at 7:15 PM, Gao, Liming wrote: > Yes. BaseTools needs some environments. Before build BaseTools, we need to > call edkset.sh to setup them. > > 1. BaseTools Soure tools are compiled in serial instead of parallel. And, > VfrCompiler depends on Anltr

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Star, I do not recall the exact value I saw. However, the spec states that one byte is returned with the max LUN value. It does not state that the byte is composed of bitfields with the lower bits being the max LUN, so I prefer the value check instead if the and mask. Thanks, Mike >

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Star, No. I have not evaluated the PEI use case. I will test that and provide an updated patch if needed. Thanks, Mike > -Original Message- > From: Zeng, Star > Sent: Monday, November 13, 2017 1:22 AM > To: Kinney, Michael D ; edk2- > de...@lists.01.org >

Re: [edk2] [PATCH] StdLib/BsdSocketLib: Remove unused variables

On 11/13/17 16:40, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > And pushed. Thank you both! I closed as RESOLVED/FIXED. Cheers Laszlo >> -Original Message- >> From: edk2-devel

Re: [edk2] [PATCH] StdLib/BsdSocketLib: Remove unused variables

Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Monday, November 13, 2017 5:27 AM > To: Thiebaud Weksteen ; edk2-devel@lists.01.org; >

Re: [edk2] [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB

On Mon, Nov 13, 2017 at 02:04:57PM +, Ard Biesheuvel wrote: > On 13 November 2017 at 12:23, Heyi Guo wrote: > > From: Ming Huang > > > > If uncacheable attribute is included in memory resource HOB, > > GCD spaces will also have EFI_MEMORY_UC

Re: [edk2] Enabling TPM support in ovmf & hang during qemu boot

I can not add memorydiscovered dependency for tcgpei. We do have use case to unit Tpm before memory. By design, tcgconfig peim is a platform module. Ovmf can create its own one and add dependency there. As such, tcgpei depends on tcgconfigpei, and later can depend on memory. thank you! Yao,

Re: [edk2] [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB

On 13 November 2017 at 12:23, Heyi Guo wrote: > From: Ming Huang > > If uncacheable attribute is included in memory resource HOB, > GCD spaces will also have EFI_MEMORY_UC capability, > then NonCoherentPciIoAllocateBuffer of

Re: [edk2] [PATCH v3 1/3] EmbeddedPkg/RealTimeClockRuntimeDxe: move common functionality into core

On 13 November 2017 at 12:03, Leif Lindholm wrote: > On Fri, Nov 10, 2017 at 08:09:23AM +, Ard Biesheuvel wrote: >> RealTimeClockRuntimeDxe defers the hardware/platform specific handling >> of reading/setting the hardware clock to RealTimeClockLib, but for >> unknown

Re: [edk2] stdlib broken strncasecmp.c

Hi, On 11/10/17 20:09, David F. wrote: > I would submit a patch but over the years of fixes and enhancements, > they don't go anywhere. Then a couple years later someone does a > half-baked fix and I have to run merge resolution on svn. I've been subscribed to edk2-devel (wherever it lived

Re: [edk2] [PATCH] StdLib/BsdSocketLib: Remove unused variables

Jaben, Daryl, can you please review this patch? Thiebaud: best CC the package maintainers from Maintainers.txt on patches. Thanks! Laszlo On 10/26/17 11:58, Thiebaud Weksteen wrote: > TianoCore BZ#677 > > Remove unused variables and turn nsdispatch macro into a function. This > is not what is

Re: [edk2] [PATCH 01/10] Platform/NXP: Library to provide helper functions.

On Tue, Nov 07, 2017 at 08:12:07PM +0530, Meenakshi Aggarwal wrote: > UtilsLib provide helper functions which will be needed > by NXP SoCs Library and Drivers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 11/13/17 13:34, Laszlo Ersek wrote: > I guess I could live with BASE_LIBRARY_JUMP_BUFFER. Actually: > More specific comments: > >> diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c >> index f7fec3d8c0..077f7d6563 100644 >> --- a/OvmfPkg/Sec/SecMain.c >> +++ b/OvmfPkg/Sec/SecMain.c

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On 13 November 2017 at 12:42, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 12:19 +, Ard Biesheuvel wrote: >> On 13 November 2017 at 12:15, Supreeth Venkatesh >> wrote: >> > >> > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel

Re: [edk2] [PATCH 07/10] Platform/NXP : Add support for DS1307 RTC library

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > Real time clock Apis on top of I2C Apis > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On Mon, 2017-11-13 at 12:19 +, Ard Biesheuvel wrote: > On 13 November 2017 at 12:15, Supreeth Venkatesh > wrote: > > > > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: > > > > > > On 13 November 2017 at 11:40, Supreeth Venkatesh > > >

Re: [edk2] [PATCH 06/10] Platform/NXP: Add support for I2c operations library

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > I2C bus initialization and I2c read/write APIs added. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 11/13/17 11:09, Ard Biesheuvel wrote: > On 13 November 2017 at 09:08, Jordan Justen > wrote: >> On 2017-11-12 02:58:37, Ard Biesheuvel wrote: >>> On 11 November 2017 at 22:04, Jordan Justen >>> wrote: On 2017-11-11 12:38:21, Jordan

Re: [edk2] [PATCH 05/10] Platform/NXP : Add support for DUART library

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/Library/DUartPortLib/DUart.h | 128 >

Re: [edk2] [PATCH 03/10] Platform/NXP: Add support for Big Endian Mmio APIs

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > This library add supports for BE read/write and other > MMIO helper function. > In this data swapped after reading from MMIO and before > write using MMIO. > It can be used by any module with BE address space. >

[edk2] [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB

From: Ming Huang If uncacheable attribute is included in memory resource HOB, GCD spaces will also have EFI_MEMORY_UC capability, then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe module will allocate DMA buffer of EFI_MEMORY_UC type, which will cause

[edk2] [PATCH edk2-non-osi v3] Update D03/D05 MemoryInit.efi binary for bug 3419

https://bugs.linaro.org/show_bug.cgi?id=3061 For fix this bug,the function PciIoPciRead of NonDiscoverablePciDeviceDxe should be modified also. Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: rp-osi-bug-v3 Ming Huang (1): Hisilicon D0x: Remove

Re: [edk2] [PATCH 04/10] Platform/NXP : Add support for Watchdog driver

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > Installs watchdog timer arch protocol > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/Drivers/WatchDog/WatchDog.c

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On 13 November 2017 at 12:15, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: >> On 13 November 2017 at 11:40, Supreeth Venkatesh >> wrote: >> > >> > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: > On 13 November 2017 at 11:40, Supreeth Venkatesh > wrote: > > > > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: > > > > > > On 25 October 2017 at 17:32, Supreeth Venkatesh > > >

Re: [edk2] [PATCH 02/10] Platform/NXP: Add support for system reset library

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > .../NXP/Library/ResetSystemLib/ResetSystemLib.c| 96 > ++

Re: [edk2] [PATCH 01/10] Platform/NXP: Library to provide helper functions.

On 7 November 2017 at 14:42, Meenakshi Aggarwal wrote: > UtilsLib provide helper functions which will be needed > by NXP SoCs Library and Drivers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal

Re: [edk2] [PATCH v3 1/3] EmbeddedPkg/RealTimeClockRuntimeDxe: move common functionality into core

On Fri, Nov 10, 2017 at 08:09:23AM +, Ard Biesheuvel wrote: > RealTimeClockRuntimeDxe defers the hardware/platform specific handling > of reading/setting the hardware clock to RealTimeClockLib, but for > unknown reasons, it also defers common functionality such as input > validation and

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On 13 November 2017 at 11:40, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: >> On 25 October 2017 at 17:32, Supreeth Venkatesh >> wrote: >> > >> > PI v1.5 Specification Volume 4 defines Management Mode

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: > On 25 October 2017 at 17:32, Supreeth Venkatesh > wrote: > > > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface > > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides

Re: [edk2] Enabling TPM support in ovmf & hang during qemu boot

On 11/12/17 20:09, Marc-André Lureau wrote: > Hi, > > I use the attached patch to build OVMF with TPM support. > > Even without any TPM device configured (with the following qemu > command line) the VM hangs early: > > qemu-system-x86_64 -enable-kvm -m 1024 -global > isa-debugcon.iobase=0x402

Re: [edk2] [PATCH v2 1/3] ArmPkg: Add PCDs needed for MM communication driver.

On Mon, 2017-11-13 at 10:17 +, Ard Biesheuvel wrote: > On 25 October 2017 at 17:32, Supreeth Venkatesh > wrote: > > > > This patch defines PCDs to describe the base address and size of > > communication buffer between normal world (uefi) and standalone MM > >

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

On 25 October 2017 at 17:32, Supreeth Venkatesh wrote: > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI >

Re: [edk2] [PATCH v2 1/3] ArmPkg: Add PCDs needed for MM communication driver.

On 25 October 2017 at 17:32, Supreeth Venkatesh wrote: > This patch defines PCDs to describe the base address and size of > communication buffer between normal world (uefi) and standalone MM > environment in the secure world. > > Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-non-osi v2] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB

On 10 November 2017 at 07:31, Ming Huang wrote: Please do something about the name/email address. These should be in sync. > If uncacheable attribute is included in memory resource HOB, > GCD spaces will also have EFI_MEMORY_UC capability, > then

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 13 November 2017 at 09:08, Jordan Justen wrote: > On 2017-11-12 02:58:37, Ard Biesheuvel wrote: >> On 11 November 2017 at 22:04, Jordan Justen >> wrote: >> > On 2017-11-11 12:38:21, Jordan Justen wrote: >> >> On 2017-11-10 07:49:04,

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Mike, Just curious about what is the value returned for MaxLun in the case you met before this patch? Could *MaxLun &= USB_BOT_MAX_LUN work? Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, November 13, 2017 5:45 PM To: Kinney, Michael D ;

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Reviewed-by: Star Zeng How about also adding the compatibility info(now in commit log) to the code comments? For example, +// +// If MaxLun is larger than the maximum LUN value (0x0f) supported by the +// USB Mass Storage Class Bulk-Only Transport Spec, then

[edk2] [staging/Customized-Secure-Boot] Sync Customized-Secure-Boot From edk2/master

Hi The Customized-Secure-Boot branch is behind EDK2 master, and there are build errors when building it with latest basetools. Can you please sync the branch from EDK2 master? Thanks, Cinnamon Shia ___ edk2-devel mailing list

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Mike, Have you evaluated whether the code in PeiUsbRequestSense() of PeiAtapi.c also needs to be updated? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Thursday, November 9, 2017 6:03 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

On 2017-11-12 02:58:37, Ard Biesheuvel wrote: > On 11 November 2017 at 22:04, Jordan Justen wrote: > > On 2017-11-11 12:38:21, Jordan Justen wrote: > >> On 2017-11-10 07:49:04, Laszlo Ersek wrote: > >> > The first three patches enable the PEI_CORE to report OVMF's temp