Re: [edk2] [PATCH v1 1/1] BaseTools: dont make temporary dict

2018-04-08 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 06, 2018 7:14 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: dont make temporary dict just make the key list directly Cc

Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* pcd max size from component section

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:58 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the bug for VOID* pcd max size from >component secti

Re: [edk2] [Patch] BaseTools: Fix a bug for Size incorrect of Void* Fixatbuild Pcd

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:58 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix a bug for Size incorrect of Void* >Fixatbuild Pcd >

Re: [edk2] [Patch] BaseTools: Fix size override issue for Void* Patchable pcd

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:58 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix size override issue for Void* Patchable >pcd > >when

Re: [edk2] [Patch] BaseTools: Fix a bug for VOID* type Fixatbuild Pcd in Library

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, March 23, 2018 1:57 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix a bug for VOID* type Fixatbuild Pcd in >Library > >T

Re: [edk2] [Patch] BaseTools: Fix two cases that use GUID CName as PCD Value

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, March 28, 2018 8:43 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix two cases that use GUID CName as PCD >Value > >1.

Re: [edk2] [Patch] BaseTools: Pcds in [Components] are not display correct in the report

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcds in [Components] are not display >correct in the re

Re: [edk2] [Patch] BaseTools: Pcd not used info should not in Module PCD section

2018-04-08 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcd not used info should not in Module >PCD section > >

[edk2] [PATCH] BaseTools: Parse PCD GUID name in FILE statement issue

2018-04-08 Thread Yonghong Zhu
From: Yunhua Feng FDF format as below: FILE APPLICATION = PCD(PcdToken.PcdCName) { } when parse PCD, need get all PCDs from Platform and Packages, use self.BuildObject[self.Platform, Arch] get some modules is wrong. so use self.BuildObject[self.Platform, Arch, TargetName, ToolChainTag] get all m

Re: [edk2] [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO

2018-04-08 Thread Chiu, Chasel
Thanks! Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Wednesday, April 4, 2018 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Chiu, Chasel ; Chan, Amy ; Chaganty, Rangasai V Subject: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg

Re: [edk2] [RFC 1/4] FmpDevicePkg: Add package, library classes, and PCDs

2018-04-08 Thread Zeng, Star
Since PcdFmpDeviceBuildTimeLowestSupportedVersion is defined to support only FixedAtBuild and PatchableInModule, it is definitely for build time. Do we really need "BuildTime" keyword in the PCD name PcdFmpDeviceBuildTimeLowestSupportedVersion? Thanks, Star -Original Message- From: edk2

Re: [edk2] [RFC 0/4] Add FmpDevicePkg

2018-04-08 Thread Zeng, Star
Curious about which tool to generate the FMP_PAYLOAD_HEADER? BaseTools needs to be updated? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, April 5, 2018 8:29 AM To: Yao, Jiewen ; edk2-devel@lists.01

Re: [edk2] [PATCH v1 0/3] BaseTools: refactor and cleanup

2018-04-08 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, April 05, 2018 4:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/3] BaseTools: refactor and cleanup

Re: [edk2] [PATCH v1 2/2] BaseTools: Remove unneeded files

2018-04-08 Thread Zhu, Yonghong
Hi Jaben, 1. the BaseTools/Source/Python/Makefile also need remove those .py files, otherwise it would cause freeze binary failure. 2. EdkIIWorkspaceBuild.py use some function in those .py files, but in fact the EdkIIWorkspaceBuild.py also can be removed, so how about in your V2 patch also remo

Re: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

2018-04-08 Thread Zhu, Yonghong
The patches are good to me. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 6:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/5] B