[edk2] [Patch 2/3] SecurityPkg/TcgStorageOpalLib: Add supports for pyrite 2.0 spec.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- SecurityPkg/Include/Library/TcgStorageOpalLib.h| 41 ++ .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 426 ++--- .../TcgStorageOpalLib/TcgStorageOpalLib.inf

[edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver.

Eanble the pyrite 2.0 devices for opal driver. Eric Dong (3): MdePkg: Add Feature definitions add in pyrite 2.0 spec. SecurityPkg/TcgStorageOpalLib: Add supports for pyrite 2.0 spec. SecurityPkg/OpalPassword: Add support for pyrite 2.0 devices.

[edk2] [Patch 3/3] SecurityPkg/OpalPassword: Add support for pyrite 2.0 devices.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 60 ++-- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.h | 9 +++ SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c| 84

[edk2] [Patch 1/3] MdePkg: Add Feature definitions add in pyrite 2.0 spec.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- MdePkg/Include/IndustryStandard/TcgStorageCore.h | 2 + MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 54 2 files changed, 56 insertions(+) diff --git

Re: [edk2] Set "db" variable in secure boot setup mode still requires generating PKCS#7?

Hi, David, Yes, in Setup / Custom mode, no need to generate the AuthData for verification. It's good enough to create the AUTH_2 descriptor / headers without CertData as the parameter for SetVariable() call. Do you mean this code snippet can succeed to enroll KEK, but fail to enroll DB data?

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Fix format of ReadMe.MD

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Platform/ReadMe.MD | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/ReadMe.MD b/Platform/ReadMe.MD index b0341a5..814eaa2 100644 --- a/Platform/ReadMe.MD +++

Re: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function

Hi Thomas, Thanks for your patches. We just finished internal verification of them. Reviewed-by: Eric Dong and pushed them. Thanks, Eric -Original Message- From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] Sent: Saturday, April 21, 2018 12:00 AM To: Bi, Dandan

Re: [edk2] [PATCH 1/1] MdeModulePkg/Sd: append CMD12 for multiple blocks

Hi Haojian, Sorry for the delayed response. As far as I know, we enabled the auto CMD12 feature within: SdMmcExecTrb(), MdeModulePkg\Bus\Pci\SdMmcPciHcDxe\SdMmcPciHci.c // // Only SD memory card needs to use AUTO CMD12 feature. // if (Private->Slot[Trb->Slot].CardType ==

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

The GcdAllocateType are EfiGcdAllocateMaxAddress*, the MaxAddress comes from input BaseAddress parameter. The original code logic is correct according to PI spec. PI Spec: If GcdAllocateType is EfiGcdAllocateMaxAddressSearchBottomUp, then the GCD memory space map is searched from the lowest

Re: [edk2] [PATCH v2 edk-platforms 4/4] Platform/Hisilicon/HiKey: enable virtual keyboard

On Thu, Mar 08, 2018 at 09:30:56PM +0800, Haojian Zhuang wrote: > Enable virtual keyboard driver on HiKey platform. The platform > driver reads pattern from memory or GPIO pin. When the value > is matched, it simulates a key value that is used to adjust > the sequence of boot options. The

Re: [edk2] [PATCH v2 edk-platforms 2/4] Platform/Hisilicon/HiKey960: enable virtual keyboard

On Thu, Mar 08, 2018 at 09:30:04PM +0800, Haojian Zhuang wrote: > Enable virtual keyboard on HiKey960 platform. The platform > driver read pattern from memory or GPIO pin. When the value > is matched, it simulates a hotkey that is used to adjust > sequence of boot options. This patch looks like

Re: [edk2] Incorrect Author on patch

On 5/2/2018 7:40 AM, Laszlo Ersek wrote: On 05/02/18 14:46, Evan Lloyd wrote: I can well understand why it would be useful to use Gerrit as a means of reviewing a patch - actually a brilliant idea, (actually, *not* a brilliant idea, but that's just my opinion :) ) *Please* not Gerrit.

[edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

Some processors require resource list sorted in ascending order. Cc: Ruiyu Ni Cc: Vladimir Olovyannikov Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik ---

[edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

When BottomUp search is used the MaxAddress is incorrectly chosen to be the BaseAddress instead of the EndAddress. Cc: Ruiyu Ni Cc: Vladimir Olovyannikov Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik

[edk2] [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming

From: Alexei Fedorov ARM Generic Interrupt Controller is incorrectly named as "ARM General Interrupt Controller" in ArmJuno.dsc, ArmVExpress-CTA15-A7.dsc and ArmVExpress-FVP-AArch64.dsc. This patch corrects the comment by changing "General" to "Generic".

Re: [edk2] Set "db" variable in secure boot setup mode still requires generating PKCS#7?

This Intel mobo didn't like? This is the code snippet that builds it: // calc size of header (with no certdata) and crt file data to add size_t authhdrsize; size_t siglisthdrsize; if (applyrawdata) { authhdrsize=0; siglisthdrsize=0; } else {

Re: [edk2] [PATCH v2 edk-platforms 3/4] Platform/Hisilicon/HiKey: add gpio platform driver

(Reviewing near-identical patches out of order.) On Thu, Mar 08, 2018 at 09:30:28PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey platform. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under:

Re: [edk2] Incorrect Author on patch

Evan: I agree this is a mistake in edk2 project. We mix the operation in edk2 project and our internal project. We will double check the patch and avoid such case happen again. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

On Thu, Mar 08, 2018 at 09:29:50PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey960 platform. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] Incorrect Author on patch

On 05/02/18 14:46, Evan Lloyd wrote: > One obvious way of precluding this sort of problem would be to move to > using the pull request mechanism on GitHub, rather than requiring > maintainers to play with upstreaming local patches. In my opinion: - *git* pull requests: yes, - *github* pull

Re: [edk2] Incorrect Author on patch

One obvious way of precluding this sort of problem would be to move to using the pull request mechanism on GitHub, rather than requiring maintainers to play with upstreaming local patches. I can well understand why it would be useful to use Gerrit as a means of reviewing a patch - actually a

Re: [edk2] Set "db" variable in secure boot setup mode still requires generating PKCS#7?

On 05/01/18 23:13, David F. wrote: > Hi, > > Had a fairly simple task of wanting to install the latest MS .crt > files for KEK, and their two files for the "db" (the Windows CA and > UEFI CA) in a system placed in setup/custom mode. However, even > though it seemed to take the KEK, it never took

Re: [edk2] [PATCH edk2-platforms] Platform/Socionext/DeveloperBox: reduce default timeout to 5 seconds

On 1 May 2018 at 14:28, Leif Lindholm wrote: > On Tue, May 01, 2018 at 01:35:40PM +0200, Ard Biesheuvel wrote: >> The default timeout value for the delay during which the splash screen >> is shown and the BDS menu can be entered is still at 30 seconds, which >> is rather

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name

On 1 May 2018 at 19:55, Leif Lindholm wrote: > On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote: >> Rename the variable holding the Styx PPTT table to mStyxPpttTable. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard

Re: [edk2] [PATCH v2] MdeModulePkg/ConPlatform: Support short-form USB device path

Since the checking of MSG_USB_DP and HW_PCCARD_DP is removed on purpose, we'd better to add commit message for that. :) With that, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when polling

Another minor comment below. There are three lines added with no code, I guess they are added accidently. It is better to remove them. + + + Thanks, Star -Original Message- From: Zeng, Star Sent: Wednesday, May 2, 2018 2:39 PM To: Ni, Ruiyu ;

[edk2] [PATCH v2] MdeModulePkg/ConPlatform: Support short-form USB device path

Today's implementation does an exact device path match to check whether the device path of a console is in ConIn/ConOut/ErrOut. But that doesn't work for the USB keyboard. Because when a platform have multiple USB port, ConIn needs to carry all device paths corresponding to each port. Even worse,

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, April 26, 2018 3:05 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Kinney, Michael D > ; Zeng, Star > Subject:

Re: [edk2] [PATCH v2 19/27] BaseTools: Replace Binary File type strings with predefined constant

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 12:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v2

Re: [edk2] [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 22/27] BaseTools: remove redundant if comparison

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 14/27] BaseTools: Define and use a set for common list

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v3 16/27] BaseTools: Replace EDK Component strings with predefined constant

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 10:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v3

Re: [edk2] [PATCH v2 11/27] BaseTools: Workspace/MetaFileParser - refactor dicts

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 10:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v2

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when polling

Reviewed-by: Star Zeng if it is updated. :) Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Wednesday, May 2, 2018 2:37 PM To: Zeng, Star ; 'edk2-devel@lists.01.org' Cc: Chiu, Chasel