Re: [edk2] [PATCH edk2-platforms v1 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-03 Thread Ming
在 27/06/2018 15:20, Ard Biesheuvel 写道: > On 27 June 2018 at 09:04, Ming Huang wrote: >> The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early. >> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >> gDS->SetMemorySpaceAttributes is invoked by several drivers. >> >> Add

Re: [edk2] reg: IP6 based Static IP Configuration in ISCSI

2018-07-03 Thread Ye, Ting
Hi Siva, No, it is not correct. In iSCSI UI, if you choose IP6 mode, you still have chance to use static address. Just NOT click the checkbox of "Enable DHCP". Thanks, Ting -Original Message- From: Sivaraman Nainar [mailto:sivaram...@amiindia.co.in] Sent: Wednesday, July 4, 2018 2:32

Re: [edk2] reg: IP6 based Static IP Configuration in ISCSI

2018-07-03 Thread Sivaraman Nainar
Ting, Let me clarify in detail. When we have IP4 mode selection in ISCSI we can set both Initiator and Target with Static Addresses. But if we choose the IP6 mode by default no setup options available to choose static and it take DHCP as default. In this case even if we configure IP6 using I

Re: [edk2] [PATCH v4 1/9] MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot

2018-07-03 Thread Wang, Sunny (HPS SW)
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Wednesday, July 04, 2018 9:51 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Michael Turner ; Wang, Sunny (HPS SW) Subject: [PATCH v4 1/9] MdeModulePkg/PlatformBootManager:

Re: [edk2] [PATCH v4 9/9] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()

2018-07-03 Thread Wang, Sunny (HPS SW)
Looks good to me. This is clearer. Reviewed-by: Sunny Wang -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Wednesday, July 04, 2018 9:51 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Michael Turner ; Wang, Sunny (HPS SW) Subject: [PATCH v4 9/9] MdeModulePkg/BdsD

Re: [edk2] [PATCH v4 8/9] MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging"

2018-07-03 Thread Wang, Sunny (HPS SW)
Looks good to me. This is clearer. Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, July 04, 2018 9:51 AM To: edk2-devel@lists.01.org Cc: Eric Dong Subject: [edk2] [PATCH v4 8/9] MdeModulePkg/BdsD

Re: [edk2] report an issue about edk2 iscsi

2018-07-03 Thread Ye, Ting
Hi Robin, Since you configured the attempt as following: Set: Connection retry count: 5, connection establishing timeout to [5000] iSCSI driver will try to connect to iSCSI target in 6 times, each time it uses 5 seconds as the timeout value. So you need hold > 30 seconds in your case. Tha

Re: [edk2] [PATCH v2] MdePkg/BaseLib: Add bit field population calculating methods

2018-07-03 Thread Gao, Liming
Tom: There are two issues here. 1) BitFieldHammingWeight32 should be replaced by BitFieldCountOnes32. 2) edk2 coding style requires the local variable is declared first, then assign the value to it. Don't assign the value in its declaration. Thanks Liming >-Original Message- >From: T

Re: [edk2] gRT->SetVariable ACCESS DENIED error

2018-07-03 Thread Andrew Fish
Toan, gEfiGlobalVariableGuid means it is defined in section 3.3, Globally Defined Variables, in the UEFI Spec: Identifies the level of hardware error record persistence support implemented by the platform. This variable is only modified by firmware and is read-only to the OS. As you see it is

[edk2] [Patch] BaseTools: enable FixedAtBuild (VOID*) PCD use in the [DEPEX] section

2018-07-03 Thread Yonghong Zhu
From: Yunhua Feng The PCD item used in INF [Depex] section must be defined as FixedAtBuild type and VOID* datum type, and the size of the PCD must be 16 bytes. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=443 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Ag

Re: [edk2] [patch] MdeModulePkg/SmmCorePerformanceLib: Update mPerformanceLength

2018-07-03 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Dandan Bi >Sent: Monday, July 02, 2018 1:30 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming >Subject: [edk2] [patch] MdeModulePkg/SmmCorePerformanceLib: Upda

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Avoid calling PEI services from AP

2018-07-03 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ruiyu > Sent: Monday, July 2, 2018 2:02 PM > To: edk2-devel@lists.01.org > Cc: Jeff Fan ; Dong, Eric ; > Yao, Jiewen ; Fish Andrew ; Laszlo > Ersek > Subject: [PATCH] UefiCpuPkg/MpInitLib: Avoid calling PEI services from AP > > Tod

[edk2] report an issue about edk2 iscsi

2018-07-03 Thread xujiawu
Hello, edk2-devel, I want to report a issue about edk2 iscsi: Set timeout to 5S and copy a big file from iscsi HDD, disconnect Lan cable >>5S then connect again, the big file still copy successfully. BIOS: the latest EDK2 Test steps: 1.Power on and press Hotkey to bios setup, in

Re: [edk2] [Patch v3] NetworkPkg/HttpDxe: Fix the bug when parsing HTTP(S) message body.

2018-07-03 Thread Wu, Jiaxin
Great, thanks the verification. /Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, July 4, 2018 10:14 AM > To: Wu, Jiaxin > Cc: edk2-devel@lists.01.org; Ye, Ting ; Fu, Siyuan > > Subject: Re: [edk2] [Patch v3] NetworkPkg/HttpDxe: Fix the bug when > p

Re: [edk2] [Patch v3] NetworkPkg/HttpDxe: Fix the bug when parsing HTTP(S) message body.

2018-07-03 Thread Gary Lin
On Wed, Jul 04, 2018 at 08:40:52AM +0800, Jiaxin Wu wrote: > *v2: Resolve the conflict commit. > > *v3: Fixed the failure if BodyLength in HTTP token is less than the received > size of HTTPS message. > > HttpBodyParserCallback function is to parse the HTTP(S) message body so as to > confirm whet

Re: [edk2] reg: IP6 based Static IP Configuration in ISCSI

2018-07-03 Thread Ye, Ting
Hi Siva, We don't have such plan as I known. For IPv6, we leave it to IP6 driver to perform source address selection to best match the iSCSI target address. You could use ifconfig6 to set static IP6 address before you configure iSCSI. Thanks, Ting -Original Message- From: edk2-devel [

[edk2] [PATCH v2 1/1] MdeModulePkg/Variable: Check EFI_MEMORY_RUNTIME attribute before setting it

2018-07-03 Thread Brijesh Singh
Set the EFI_MEMORY_RUNTIME attribute in FtwNotificationEvent() only if the attribute is not already present. This will ensure that the attributes set by the platform drivers (e.g Ovmf pflash) is not lost. Cc: Dong Eric Cc: Justen Jordan L Cc: Zeng Star Cc: Laszlo Ersek Contributed-under: Tiano

Re: [edk2] [PATCH v4 0/9] Add platform hook for ultimate boot failure.

2018-07-03 Thread Ni, Ruiyu
On 7/4/2018 9:50 AM, Ruiyu Ni wrote: v4: 1. adds missing PlatformBootManagerLib instances modification for platform ArmPkg and ArmVirtPkg. 2. Remove single quote in #1/9 3. Wrap the long comments in #3/9 Ruiyu Ni (9): MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUna

[edk2] [PATCH v4 8/9] MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging"

2018-07-03 Thread Ruiyu Ni
Commit d1de487dd2e77f4741abcbd71d19a8c93971fda0 "MdeModulePkg/BdsDxe: fall back to a Boot Manager Menu loop before hanging" changed BDS core to fall back to UI loop when no bootable option can be launched. Now since PlatformBootManagerUnableToBoot() is added, the commit can be reverted. Contribut

[edk2] [PATCH v4 9/9] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()

2018-07-03 Thread Ruiyu Ni
When no boot option can be launched, BDS core calls PlatformBootManagerUnableToBoot() to let platform BdsDxe handle it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek Cc: Sean Brogan Cc: Michael Turner Cc: Sunny Wang --- MdeModulePkg

[edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Leif Lindholm Cc: Ard Biesheuvel --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/PlatformBootManagerLi

[edk2] [PATCH v4 7/9] ArmVirtPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Julien Grall --- .../Library/PlatformBootManagerLib/PlatformBm.c| 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/Libr

[edk2] [PATCH v4 1/9] MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
The patch adds a new API PlatformBootManagerUnableToBoot() to PlatformBootManagerLib. The new API is provided by platform bds library and is called when no boot option could be launched. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Sean Brogan Cc: Michael T

[edk2] [PATCH v4 3/9] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Reviewed-by: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 61 +- 1 file changed, 60 insertions

[edk2] [PATCH v4 2/9] CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Maurice Ma Cc: Prince Agyeman Reviewed-by: Benjamin You --- .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/Coreboo

[edk2] [PATCH v4 4/9] Nt32Pkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Reviewed-by: Hao A Wu --- .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformB

[edk2] [PATCH v4 5/9] QuarkPlatform/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Michael D Kinney Cc: Kelly Steele --- .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/QuarkPlatformPkg/Library/Platf

[edk2] [PATCH v4 0/9] Add platform hook for ultimate boot failure.

2018-07-03 Thread Ruiyu Ni
v4: 1. adds missing PlatformBootManagerLib instances modification for platform ArmPkg and ArmVirtPkg. 2. Remove single quote in #1/9 3. Wrap the long comments in #3/9 Ruiyu Ni (9): MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot CorebootPayload/PlatformBDS: Imp

Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.

2018-07-03 Thread Ni, Ruiyu
On 7/4/2018 9:08 AM, Ni, Ruiyu wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 3, 2018 11:53 PM To: Ni, Ruiyu Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address) ; Ard Biesheuvel ; Wei, David ; Guo, Mang Subject: Re: [edk2] [PATCH v

Re: [edk2] [PATCH v3 3/7] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Ni, Ruiyu
On 7/3/2018 11:37 PM, Laszlo Ersek wrote: On 07/03/18 08:37, Ruiyu Ni wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall --- .../Library/PlatformBootManagerLib/Bd

Re: [edk2] gRT->SetVariable ACCESS DENIED error

2018-07-03 Thread Toan Le manh
Hi Andrew, I'm trying to set some variables to NVRAM at the beginning of BDS phase. For example, this function returned EFI_ACCESS_DENIED Status = gRT->SetVariable ( L"HwErrRecSupport", &gEfiGlobalVariableGuid, EFI_VARIABLE_BOOTSERVIC

Re: [edk2] [PATCH v3 4/7] Nt32Pkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, July 03, 2018 2:38 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v3 4/7] Nt32Pkg/PlatformBDS: Implement > PlatformBootManagerUnableToBoot > > Contributed-under: TianoCor

Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.

2018-07-03 Thread Ni, Ruiyu
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 3, 2018 11:53 PM > To: Ni, Ruiyu > Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address) > ; Ard Biesheuvel ; Wei, > David ; Guo, Mang > Subject: Re: [edk2] [PATCH v3 0/7] Add platform hook

[edk2] [Patch v3] NetworkPkg/HttpDxe: Fix the bug when parsing HTTP(S) message body.

2018-07-03 Thread Jiaxin Wu
*v2: Resolve the conflict commit. *v3: Fixed the failure if BodyLength in HTTP token is less than the received size of HTTPS message. HttpBodyParserCallback function is to parse the HTTP(S) message body so as to confirm whether there is the next message header. But it doesn't record the parsing m

Re: [edk2] [patch V2 8/9] SecurityPkg: Use new added Perf macros

2018-07-03 Thread Zhang, Chao B
HI Dandan : That patch is good to me. Reviewed-by: Chao Zhang -Original Message- From: Bi, Dandan Sent: Friday, June 22, 2018 4:56 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhang, Chao B Subject: [patch V2 8/9] SecurityPkg: Use new added Perf macros Replace old Perf macros wi

Re: [edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable CapCRBIdleBypass support

2018-07-03 Thread Zhang, Chao B
Hi Gary: It is caused by code merge. Tks for notification. We have fixed it. From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, June 27, 2018 4:19 PM To: Zhang, Chao B Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Long, Qin Subject: Re: [edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable

Re: [edk2] [PATCH v3 2/7] CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot

2018-07-03 Thread You, Benjamin
Reviewed-by: Benjamin You > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, July 3, 2018 2:38 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin > Subject: [PATCH v3 2/7] CorebootPayload/PlatformBDS: Impl > PlatformBootManagerUnableToBoot > > Co

Re: [edk2] GPT Partitions on RAID Disks

2018-07-03 Thread Andrew Fish
> On Jul 3, 2018, at 10:12 AM, Robinson, Herbie > wrote: > > Background: > > I have been tasked with implementing UEFI boot in our VOS operating system. > We've been using GPT partitions for more than 15 years, but only within our > own OS... We haven't had to interact with any other sof

Re: [edk2] [PATCH edk2-platforms v2 3/3] Readme.md: Add instructions to build in a Windows Environment

2018-07-03 Thread Evan Lloyd
Reviewed-by: Evan Lloyd Leif - would it make sense/be acceptable to add a GNU make.exe image to edk2-non-osi? Evan > -Original Message- > From: Leif Lindholm > Sent: 03 July 2018 11:24 > To: Chris Co > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Michael D Kinney ; Evan Lloyd >

[edk2] GPT Partitions on RAID Disks

2018-07-03 Thread Robinson, Herbie
Background: I have been tasked with implementing UEFI boot in our VOS operating system. We've been using GPT partitions for more than 15 years, but only within our own OS... We haven't had to interact with any other software before this. We have a fault tolerant OS; so, all disks are RAID1 (

Re: [edk2] gRT->SetVariable ACCESS DENIED error

2018-07-03 Thread Andrew Fish
Toan, What arguments did you pass to gRT->SetVariable()? What implementation did you test on? In general there are "wiggle words" in the UEFI Spec that make it legal to return other error codes. Back in the day when NOR FLASH was expensive and EFI was size constrained we did not want to have

[edk2] [PATCH 1/1] MdeModulePkg/DisplayEngineDxe: Fix small InitializeDisplayEngine leak

2018-07-03 Thread Thomas Palmer
After calling RegisterHotKey, the allocated memory in NewString should be freed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Unive

[edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Fix small LoadOptionToVariable leak

2018-07-03 Thread Thomas Palmer
After calling SetVariable, the allocated memory in Variable should be freed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- .../Library/UefiBootManagerLib/BmLoadOption.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-)

Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.

2018-07-03 Thread Laszlo Ersek
Hi Ray, On 07/03/18 08:37, Ruiyu Ni wrote: > Ruiyu Ni (7): > MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot > CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot > OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot > Nt32Pkg/PlatformBDS: Imp

Re: [edk2] [PATCH v3 3/7] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot

2018-07-03 Thread Laszlo Ersek
On 07/03/18 08:37, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 61 > ++

[edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

2018-07-03 Thread Thomas Palmer
When cleaning the PciIoDevice, also free the BusNumberRange Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDevice

Re: [edk2] [PATCH v3 7/7] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()

2018-07-03 Thread Laszlo Ersek
On 07/03/18 08:37, Ruiyu Ni wrote: > When no boot option can be launched, BDS core calls > PlatformBootManagerUnableToBoot() to let platform BdsDxe handle it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Laszlo Ersek > Cc: Sean Brogan > Cc: Michael

Re: [edk2] [PATCH v3 6/7] MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging"

2018-07-03 Thread Laszlo Ersek
On 07/03/18 08:37, Ruiyu Ni wrote: > Commit d1de487dd2e77f4741abcbd71d19a8c93971fda0 > "MdeModulePkg/BdsDxe: fall back to a Boot Manager Menu loop before > hanging" > changed BDS core to fall back to UI loop when no bootable option > can be launched. > Now since PlatformBootManagerUnableToBoot() i

Re: [edk2] [PATCH v3 1/7] MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot

2018-07-03 Thread Laszlo Ersek
On 07/03/18 08:37, Ruiyu Ni wrote: > The patch adds a new API PlatformBootManagerUnableToBoot()' (1) Unbalanced single quote ('). > to PlatformBootManagerLib. > The new API is provided by platform bds library and is called when > no boot option could be launched. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 2/2] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Runtime Data as MMIO when SEV is active

2018-07-03 Thread Laszlo Ersek
Hi Brijesh, On 07/03/18 05:11, Brijesh Singh wrote: > When SEV is active, the flash memory range is mapped as unencrypted by > AmdSevDxe. Mark the flash memory range with EfiGcdMemoryTypeMemoryMappedIo > so that OS maps this memory range as unencrypted. > > Cc: Justen Jordan L > Cc: Laszlo Ersek

[edk2] [PATCH v2] MdePkg/BaseLib: Add bit field population calculating methods

2018-07-03 Thread Tomas Pilar (tpilar)
Add 32-bit and 64-bit functions that count number of set bits in a bit field using a divide-and-count method. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar Cc: Liming Gao Cc: Michael D Kinney --- MdePkg/Include/Library/BaseLib.h | 56 ++

Re: [edk2] [PATCH 6/6] ArmPkg: Extra action to update permissions for S-ELO MM Image.

2018-07-03 Thread Leif Lindholm
On Tue, Jul 03, 2018 at 03:25:15PM +0530, Supreeth Venkatesh wrote: > The Standalone MM drivers runs in S-EL0 in AArch64 on ARM Standard > Platforms and is deployed during SEC phase. The memory allocated to the > Standalone MM drivers should be marked as RO+X. > > During PE/COFF Image section pars

Re: [edk2] [PATCH 4/6] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-07-03 Thread Leif Lindholm
On Tue, Jul 03, 2018 at 03:25:13PM +0530, Supreeth Venkatesh wrote: > The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard > Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its > architectural context including the initial translation tables for the > S-EL1/EL0 tr

Re: [edk2] [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-07-03 Thread Leif Lindholm
On Tue, Jul 03, 2018 at 03:25:11PM +0530, Supreeth Venkatesh wrote: > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI > handlers inside of MM. >

Re: [edk2] [PATCH] MdePkg/BaseLib: Add bit field Hamming weight calculation methods

2018-07-03 Thread Gao, Liming
Tom: I think CountOnes is easy to be understood. How about two APIs CountOnes32() and CountOnes64()? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tomas > Pilar (tpilar) > Sent: Tuesday, July 3, 2018 5:48 PM > To: Evan Lloyd

Re: [edk2] [PATCH 1/6] ArmPkg: Add PCDs needed for MM communication driver.

2018-07-03 Thread Leif Lindholm
On Tue, Jul 03, 2018 at 03:25:10PM +0530, Supreeth Venkatesh wrote: > This patch defines PCDs to describe the base address and size of > communication buffer between normal world (uefi) and standalone MM > environment in the secure world. Please add a cover-letter when sending more than individual

Re: [edk2] [PATCH] BaseTools/AutoGen: Update header file for MM modules.

2018-07-03 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, July 3, 2018 6:01 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] BaseTools/AutoGen: Update header fil

Re: [edk2] [PATCH 3/6] ArmPkg/Include: Add MM interface SVC return codes.

2018-07-03 Thread Leif Lindholm
On Tue, Jul 03, 2018 at 03:25:12PM +0530, Supreeth Venkatesh wrote: > This patch adds the Management Mode(MM) - Secure Partition > Manager(SPM) SVC return codes. > > Also, It corrects SVC ID for retrieving SPM version information. That sounds unrelated. And looking at it, worthy of a longer expla

[edk2] reg: IP6 based Static IP Configuration in ISCSI

2018-07-03 Thread Sivaraman Nainar
Hello, At present in the ISCSI configuration we are able to specify the Static IP configuration for IP4 protocol. Is there any plan to support IP6 static IP configuration in ISCSI Configuration? -Siva ___ edk2-devel mailing list edk2-devel@lists.01.or

Re: [edk2] [PATCH edk2-platforms v2 3/3] Readme.md: Add instructions to build in a Windows Environment

2018-07-03 Thread Leif Lindholm
Hi Christopher, Patches 1-2 Reviewed-by: Leif Lindholm Pushed as 5ed298efba..df5cbc93b8 - thanks! In general, I'm happy enough with the below that I might just push that as well, but I will give others a chance to pipe up. (Adding Evan to cc.) I have one comment below. On Tue, Jul 03, 2018 at

[edk2] [PATCH] BaseTools/AutoGen: Update header file for MM modules.

2018-07-03 Thread Supreeth Venkatesh
This patch corrects the Module Type Header file for Management Mode(MM) as specified in PI v1.6 Specification. Also, it updates parameter for auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 0/1] BaseTools changes for Management Mode modules

2018-07-03 Thread Supreeth Venkatesh
The following patch makes changes in AutoGen scripts for Management Mode related code. Note: This patch series needs to be applied after applying Standalone Management Mode core interface support for aarch64 platforms[1] and ArmPkg related changes for StandaloneMM package[2] [1] - https://lists.0

[edk2] [PATCH 5/6] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.

2018-07-03 Thread Supreeth Venkatesh
This patch adds the definitions, sources, packages and library classes needed to compile and link MMU Library suitable for use in S-EL0. Currently, this is used only during the Standalone MM Core initialization and hence defined as MM_CORE_STANDALONE Module. Contributed-under: TianoCore Contribut

[edk2] [PATCH 1/6] ArmPkg: Add PCDs needed for MM communication driver.

2018-07-03 Thread Supreeth Venkatesh
This patch defines PCDs to describe the base address and size of communication buffer between normal world (uefi) and standalone MM environment in the secure world. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Achin Gupta Signed-off-by: Supreeth Venkatesh Cc: Leif Lindh

[edk2] [PATCH 6/6] ArmPkg: Extra action to update permissions for S-ELO MM Image.

2018-07-03 Thread Supreeth Venkatesh
The Standalone MM drivers runs in S-EL0 in AArch64 on ARM Standard Platforms and is deployed during SEC phase. The memory allocated to the Standalone MM drivers should be marked as RO+X. During PE/COFF Image section parsing, this patch implements extra action "UpdatePeCoffPermissions" to request t

[edk2] [PATCH 4/6] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-07-03 Thread Supreeth Venkatesh
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its architectural context including the initial translation tables for the S-EL1/EL0 translation regime. The MM environment will still request ARM TF to change the

[edk2] [PATCH 0/6] ArmPkg related changes for StandaloneMM package

2018-07-03 Thread Supreeth Venkatesh
The following patch series adds support for Management Mode related changes for aarch64 based platforms. Note: This patch series needs to be applied after applying Standalone Management Mode core interface support for aarch64 platforms[1] [1] - https://lists.01.org/pipermail/edk2-devel/2018-July/

[edk2] [PATCH 3/6] ArmPkg/Include: Add MM interface SVC return codes.

2018-07-03 Thread Supreeth Venkatesh
This patch adds the Management Mode(MM) - Secure Partition Manager(SPM) SVC return codes. Also, It corrects SVC ID for retrieving SPM version information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Achin Gupta Signed-off-by: Supreeth Venkatesh Cc: Leif Lindholm Cc:

[edk2] [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-07-03 Thread Supreeth Venkatesh
PI v1.5 Specification Volume 4 defines Management Mode Core Interface and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a means of communicating between drivers outside of MM and MMI handlers inside of MM. This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE runtime driver f

Re: [edk2] [PATCH edk2-platforms v1 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-03 Thread Ming
在 27/06/2018 15:20, Ard Biesheuvel 写道: > On 27 June 2018 at 09:04, Ming Huang wrote: >> The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early. >> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >> gDS->SetMemorySpaceAttributes is invoked by several drivers. >> >> Add

Re: [edk2] [PATCH] MdePkg/BaseLib: Add bit field Hamming weight calculation methods

2018-07-03 Thread Tomas Pilar (tpilar)
Thanks for suggestions. The answer to your comments is that I copied the look and feel of the other bitfield functions. The extra assert is mentioned in the documentation for the other bitfield functions even though it just follows from the other two asserts - for clarity I suppose. I agree th

[edk2] [PATCH 10/10] StandaloneMmPkg: Describe the declaration and definition files.

2018-07-03 Thread Supreeth Venkatesh
This patch describes the package declarations and definitions for creating standalone management mode image with core/foundation and drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Cc: Jiewen Yao

[edk2] [PATCH 06/10] StandaloneMmPkg: MM driver entry point library.

2018-07-03 Thread Supreeth Venkatesh
This patch implements module entry point library for Standalone management mode (MM) Drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Cc: Jiewen Yao Cc: Achin Gupta --- .../Include/Library/Stan

[edk2] [PATCH 08/10] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-07-03 Thread Supreeth Venkatesh
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms and is initialised during the SEC phase. ARM Trusted firmware in EL3 is responsible for initialising the architectural context for S-EL0 and loading the Standalone MM image. The memory allocated to this image is marked

[edk2] [PATCH 09/10] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.

2018-07-03 Thread Supreeth Venkatesh
This patch adds a simple CPU driver that exports the EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone MM Foundation entry point. It preserves the existing notification mechanism for the configuration protocol. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-

[edk2] [PATCH 05/10] StandaloneMmPkg/HobLib: Add HOB Library for management mode.

2018-07-03 Thread Supreeth Venkatesh
The Standalone MM environment is initialized during the SEC phase on ARM Standard Platforms. The MM Core driver implements an entry point module which is architecture specific and runs prior to the generic core driver code. The former creates a Hob list that the latter consumes. This happens in the

[edk2] [PATCH 04/10] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.

2018-07-03 Thread Supreeth Venkatesh
This patch implements management mode memory allocation services. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Cc: Jiewen Yao Cc: Achin Gupta --- StandaloneMmPkg/Include/Guid/MmCoreData.h |

[edk2] [PATCH 03/10] StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check library.

2018-07-03 Thread Supreeth Venkatesh
MM memory check library library implementation. This library consumes MM_ACCESS_PROTOCOL to get MMRAM information. In order to use this library instance, the platform should produce all MMRAM range via MM_ACCESS_PROTOCOL, including the range for firmware (like MM Core and MM driver) and/or specific

[edk2] [PATCH 01/10] StandaloneMmPkg: Delete StandaloneMmPkg file.

2018-07-03 Thread Supreeth Venkatesh
This patch deletes "StandaloneMmPkg" which was created as a file intially. This patch enables creation of "StandaloneMmPkg" as a folder. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Cc: Jiewen Yao Cc:

[edk2] [PATCH 02/10] StandaloneMmPkg/FvLib: Add a common FV Library for management mode.

2018-07-03 Thread Supreeth Venkatesh
This patch implements a firmware volume library that can be used by the Standalone management mode core module to parse the firmware volume. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Cc: Jiewen Yao

[edk2] [PATCH 00/10] Standalone Management Mode Core Interface for AARCH64 Platforms

2018-07-03 Thread Supreeth Venkatesh
The following patch series adds StandaloneMM core interface for aarch64 platforms. Following earlier comments from Jeiwen [1], the patch series has been split into three parts and this series handles StandaloneMMPkg related changes. [1] - https://lists.01.org/pipermail/edk2-devel/2018-June/026211.

[edk2] gRT->SetVariable ACCESS DENIED error

2018-07-03 Thread Toan Le manh
Dear all, I'm facing the Status EFI_ACCESS_DENIED when using gRT->SetVariable() method. There is no description of this returned status for SetVariable() in UEFI spec. Have you ever faced this type of error? Could you please give me any idea on how this happen? Sorry for any inconvenience, I'm ne