On 9/6/2018 11:27 AM, Heinrich Schuchardt wrote:
Hello Ruiyu,
currently I am struggling a bit with interpreting the UEFI spec
concerning the EFI_SIMPLE_TEXT_INPUT_PROTOCOL.
In UEFI spec 2.7. chapter 12.1.2 ConsoleIn Definition there is this
sentence:
"Only the control characters defined in
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Monday, September 03, 2018 3:53 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] FDF Spec: Extend exclamation statement's keyword to case-
>insensitive
>
>This
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, September 03, 2018 3:52 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D ; Shaw, Kevin W
>; Gao, Liming
>Subject: [edk2] [Patch] Build
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Monday, September 03, 2018 3:53 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] DSC Spec: Extend exclamation statement's keyword to case-
>insensitive
>
>This
Hello Ruiyu,
currently I am struggling a bit with interpreting the UEFI spec
concerning the EFI_SIMPLE_TEXT_INPUT_PROTOCOL.
In UEFI spec 2.7. chapter 12.1.2 ConsoleIn Definition there is this
sentence:
"Only the control characters defined in Table 100 have meaning in the
Unicode input or output
Thanks for the comments. It will be fixed.
Regards,
Jian
From: Dong, Eric
Sent: Thursday, September 06, 2018 9:46 AM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Ni, Ruiyu ; Yao,
Jiewen ; Zeng, Star ; Ware, Ryan R
Subject: RE: [PATCH 4/4] UefiCpuPkg/CpuMpPei: support stack
On 9/6/2018 3:47 AM, Andrew Fish wrote:
Laszlo,
gEfiMemoryTypeInformationGuid is an edk2/MdeModulePkg concept used to
give the DXE Core hints on how to reduce fragmentation in the memory
map. Typically there is code in PEI that creates a HOB and may consume a
variable written by the BDS.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/Attribute.py | 28
1 file changed, 28 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/Attribute.py
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:44 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 15/37] FatBinPkg: Removing ipf which is no longer supported
> from
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:44 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 16/37] FatPkg: Removing ipf which is no longer supported
> from
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:45 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 25/37] OptionRomPkg: Removing ipf which is no longer
> supported
Hi Jian,
Below code has ECC issue, please check with ECC tool to fix all ECC issues.
/**
Initializes MP and exceptions handlers.
@retval EFI_SUCCESS MP was successfully initialized.
@retval others Error occurred in MP initialization.
Reviewed-by: Eric Dong
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> Sent: Monday, September 3, 2018 11:16 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric ; Yao,
> Jiewen ; Laszlo Ersek ; Zeng,
> Star
> Subject: [edk2] [PATCH 2/4]
Thanks for the quick following up. :)
Reviewed-by: Star Zeng
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, September 6, 2018 3:45 AM
To: edk2-devel-01
Cc: Ni, Ruiyu ; Zeng, Star
Subject: [edk2] [PATCH]
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Wednesday, September 05, 2018 10:52 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [Patch] BaseTools: Fix
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Thursday, September 06, 2018 6:26 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming
Subject: [PATCH v1 1/1] BaseTools/GenFds: remove function without callers
Cc: Yonghong
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 17 -
1 file changed, 17 deletions(-)
diff --git
Update GenFdsGlobalVariable GetAlignment to support G.
replace use of local function in Region with updated shared function.
Cc: Yonghong Zhu
Cc: Liming Gao
Cc: Bob C Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
But that is the line Leif wants to remove... the library from the components
section. Looks just like MdePkg to me... what is different?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Andrew Fish
> Sent: Wednesday, September 05,
On 09/05/18 19:25, Leif Lindholm wrote:
> Hi all,
>
> (This is partly a summary of discussions that have been held on IRC
> and offline, with Alex Graf and Mike Kinney.)
>
> The UEFI Shell, as produced by the contents of ShellPkg, is needed for
> running the UEFI SCT. This has never been
Jaben,
Sorry to test compile a library just list the library in the [Components]
section of the DSC file. MdePkg/MdePkg.dsc is an example of this.
Thanks,
Andrew Fish
> On Sep 5, 2018, at 11:23 AM, Carsey, Jaben wrote:
>
> Aha. So that is very different from a non NULL library when listed
Aha. So that is very different from a non NULL library when listed in the
components section. The goal is to test compile the library but not use I
think. Is there any way to do that?
Jaben
On Sep 5, 2018, at 11:21 AM, Andrew Fish
mailto:af...@apple.com>> wrote:
On Sep 5, 2018, at 11:05
> On Sep 5, 2018, at 11:05 AM, Carsey, Jaben wrote:
>
> But a NULL lib listed in components section shouldn’t be linked in to
> anything...
>
Jaben,
A NULL library class means force it to be linked in.
ShellPkg/ShellPkg.dsc:70: # [LibraryClasses.ARM] and NULL mean link this
library
But a NULL lib listed in components section shouldn’t be linked in to
anything...
Unless is listed below with the shell INF also, it just test compiles it...
Or so I thought.
On Sep 5, 2018, at 11:04 AM, Andrew Fish
mailto:af...@apple.com>> wrote:
On Sep 5, 2018, at 10:30 AM, Carsey, Jaben
> On Sep 5, 2018, at 10:30 AM, Carsey, Jaben wrote:
>
> How does removing a lib from the components section affect the shell binary
> output?
>
> Is the asset at compile time?
Jaben,
The issue is likely with the HOB lib constructor in the Shell iASSERTing.
Leif's example platform
On Wed, Sep 05, 2018 at 05:30:23PM +, Carsey, Jaben wrote:
> How does removing a lib from the components section affect the shell binary
> output?
Maybe it doesn't and I'm barking up the wrong tree? Unfortunately,
the only thing that means is we don't have a trivial workaround.
/
Leif
How does removing a lib from the components section affect the shell binary
output?
Is the asset at compile time?
Jaben
> On Sep 5, 2018, at 10:26 AM, Leif Lindholm wrote:
>
> Hi all,
>
> (This is partly a summary of discussions that have been held on IRC
> and offline, with Alex Graf and
Hi all,
(This is partly a summary of discussions that have been held on IRC
and offline, with Alex Graf and Mike Kinney.)
The UEFI Shell, as produced by the contents of ShellPkg, is needed for
running the UEFI SCT. This has never been problematic before - but now
we are starting to run SCT on
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, September 05, 2018 12:21 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Carsey, Jaben
> ; Zhu, Yonghong
> Subject: [patch] BaseTools/PatchCheck.py: Fix error when run with Python3
> Importance:
In V2, Remove GetImageReadFunction(), directly use PeiImageRead().
The copy PeiImageReadForShadow function doesn't improve the boot performance.
This patch removes this copy logic to simplify the code logic.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
Hi Star,
On 09/05/18 11:55, Zeng, Star wrote:
> I agree to commit this patch first. Reviewed-by: Star Zeng
> to this patch.
>
> To further enhance with an abstracted function, how about like below?
>
> BOOLEAN
> EhcIsDebugPortInUse (
> IN CONST USB2_HC_DEV *Ehc,
> IN UINT8
On 09/05/18 12:55, Shi, Steven wrote:
>> Steven, can you confirm the patch fixes the issue you saw?
> Yes. The patch fixes my issue in
> https://bugzilla.tianocore.org/show_bug.cgi?id=1129 .
Thanks! I've added your Tested-by.
Pushed as commit c3d5d800d775.
I'll follow up with the
> Steven, can you confirm the patch fixes the issue you saw?
Yes. The patch fixes my issue in
https://bugzilla.tianocore.org/show_bug.cgi?id=1129 .
Thanks
Steven Shi
___
edk2-devel mailing list
edk2-devel@lists.01.org
Add the handle of PCD_DATABASE_INIT and PCD_DATABASE_UNINIT
for Boolean type pcd.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
1 file changed, 1
Hi Liming,
The code removed is about copying PeiImageReadForShadow, but not PeiImageRead.
How about updating the title and commit log a little?
And I suggest eliminating GetImageReadFunction() further in this patch and move
" ImageContext->ImageRead = PeiImageRead; " into
On 09/05/18 11:55, Zeng, Star wrote:
> I agree to commit this patch first. Reviewed-by: Star Zeng
> to this patch.
Thanks!
Steven, can you confirm the patch fixes the issue you saw?
> To further enhance with an abstracted function, how about like below?
>
> BOOLEAN
> EhcIsDebugPortInUse (
>
After offline discussion with Jiewen and Ray, we agree to follow S1 that will
make the consumer easier for single ACPI table case.
I will update patches and send new V2 series.
Thanks for all the feedbacks.
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, September 3, 2018 2:33 PM
I agree to commit this patch first. Reviewed-by: Star Zeng
to this patch.
To further enhance with an abstracted function, how about like below?
BOOLEAN
EhcIsDebugPortInUse (
IN CONST USB2_HC_DEV *Ehc,
IN UINT8 *PortNumber OPTIONAL
)
Thanks,
Star
-Original Message-
From:
Hi all,
I have an EFI Shell tool which uses EDK 1.05 and TCL 8.3 sources. This tool
accepts user commands to display PCI-E adapter information and to upgrade
firmware on it. I recently ported it to UDK2017. I am using VS2012x86
toolchain to build the tool.
When I run the binary from EFI Shell,
On 09/05/18 08:22, Eric Dong wrote:
> Fix trailing white spaces and invalid line ending issue.
>
> Cc: Dandan Bi
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1145
Currently run PatchCheck.py with Python3 will meet
following error:
.
File "PatchCheck.py", line 554, in run_git
return Result[0].decode('utf-8', 'ignore') if Result[0] and
Result[0].find("fatal")!=0 else None
TypeError: a bytes-like
Hi,
I will take a look into this series.
It might take me some time for the review, please help to ping this mail
thread if there is no response from me in 2 weeks. Sorry for the possible
delay.
Also, cc Ard in the list to see if he has any comment on this. As Ard is
the contributor of the
Fix trailing white spaces and invalid line ending issue.
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h
43 matches
Mail list logo
