Re: [edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix flaw in BBTestCreateEventEx_Func_Sub3

2019-03-08 Thread Jin, Eric
Supreeth, Thank for the comment and add buffer layout description in committed code for better readable. Thanks. Best Regards Eric -Original Message- From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com] Sent: Friday, March 8, 2019 5:25 AM To: Jin, Eric ;

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Andrew Fish via edk2-devel
> On Mar 8, 2019, at 7:08 AM, Laszlo Ersek wrote: > > On 03/08/19 15:13, Yao, Jiewen wrote: >> I guess the historic reason is that AP and BSP share same GDT before. As >> such, the GDT need to be below 4G, to let AP switch from real mode to >> protected mode. >> We don't get issue, because

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-08 Thread Andrew Fish via edk2-devel
> On Mar 8, 2019, at 4:07 PM, Kinney, Michael D > wrote: > > Jiewen, > > There are not many of those functions and they can be on speed paths. > > I do not recommend converting them to only NASM. > > I do recommend we add comments to NASM files and C files with include > assembly that

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-08 Thread Kinney, Michael D
Jiewen, There are not many of those functions and they can be on speed paths. I do not recommend converting them to only NASM. I do recommend we add comments to NASM files and C files with include assembly that state that updates to one require updates to the others. Mike From: Yao, Jiewen

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Richardson, Brian
I made some minor changes to the wiki to better emphasize the stable tag releases. https://github.com/tianocore/tianocore.github.io/wiki https://github.com/tianocore/tianocore.github.io/wiki/EDK-II Thank you all for the work on the latest release. --- Brian Richardson -- Director, Firmware

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

2019-03-08 Thread Laszlo Ersek
On 03/08/19 03:14, Rebecca Cran via edk2-devel wrote: > The current servers listed appear to be unusable. I suspect most > people will get correct DNS servers via DHCP, but the defaults > should work for anyone. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Rebecca

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-03-08 Thread Laszlo Ersek
On 02/27/19 22:21, Laszlo Ersek wrote: > The current language for "Package Reviewer" only vaguely hints that > Package Reviewers should be able to provide guidance and directions. > Make this more obvious. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Liming Gao > Cc:

[edk2] [edk2-announce] EDK II Stable Tag release edk2-stable201903 completed

2019-03-08 Thread Gao, Liming
Hi, all The tag edk2-stable201903 has been created. https://github.com/tianocore/edk2/releases/tag/edk2-stable201903 git clone -b edk2-stable201903 https://github.com/tianocore/edk2.git The tag edk2-stable201903 has been added into the main EDK II Wiki page.

Re: [edk2] [edk2-announce] EDK II Stable Tag edk2-stable201903 will be created based on commit 89910a

2019-03-08 Thread Laszlo Ersek
On 03/08/19 16:48, Gao, Liming wrote: > Hi, all Sorry for a little late announce. I wait for some time to > collect the feedback on the CEV fix. There is no rejection on CVE > fix. So, I add it to this tag release. I will create > edk2-stable201903 based on current edk2 trunk (commit 89910a >

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Gao, Liming
Laszlo: Thanks for your suggestion. There is no other. I have update Wiki page to delay 12 hour for this stable tag. I have pushed this CVE fix. I will create the stable tag quickly and send another announcement. Thanks Liming > -Original Message- > From: Laszlo Ersek

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Gao, Liming
Laszlo: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes is designed to include the change in this stable tag. After the stable tag is created, the contents will be moved to tag notes. This wiki will be clear. All things in

[edk2] [edk2-announce] EDK II Stable Tag edk2-stable201903 will be created based on commit 89910a

2019-03-08 Thread Gao, Liming
Hi, all Sorry for a little late announce. I wait for some time to collect the feedback on the CEV fix. There is no rejection on CVE fix. So, I add it to this tag release. I will create edk2-stable201903 based on current edk2 trunk (commit 89910a MdeModulePkg/HiiImage: Fix stack overflow when

[edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-08 Thread Ard Biesheuvel
Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: - add a resolution for ExtractGuidedSectionLib - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable - update the resolution of StandaloneMmDriverEntryPoint Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms 2/2] Platform/Socionext/DeveloperBox: align with upstream StandaloneMmPkg changes

2019-03-08 Thread Ard Biesheuvel
Bring DeveloperBox in line with EDK2 core changes to StandaloneMmPkg: - switch from BaseExtractGuidedSectionLib to PrePiExtractGuidedSectionLib - include a NULL library class resolution for VariableMmDependency Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Laszlo Ersek
On 03/08/19 15:30, Tian, Hot wrote: > For this specific question from Laszlo, I do not have strong recommendation. > Liming/Laszlo can work out a recommendation. > But looking at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II, > I do have recommendation to make UDK less prominent

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Laszlo Ersek
On 03/08/19 15:13, Yao, Jiewen wrote: > I guess the historic reason is that AP and BSP share same GDT before. As > such, the GDT need to be below 4G, to let AP switch from real mode to > protected mode. > We don't get issue, because Runtime memory is in BIN, and most platform > allocates BIN

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Tian, Hot
For this specific question from Laszlo, I do not have strong recommendation. Liming/Laszlo can work out a recommendation. But looking at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II, I do have recommendation to make UDK less prominent (e.g. remove "UDK Releases" section) as

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Richardson, Brian
Hot: it looks like we need to revise the wiki page so the stable tag & release notes links are more prominent. Any recommendations on changes? Thanks ... br --- Brian Richardson -- Director, Firmware Ecosystem Development brian.richard...@intel.com -- @intel_brian (Twitter & WeChat)

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Yao, Jiewen
I guess the historic reason is that AP and BSP share same GDT before. As such, the GDT need to be below 4G, to let AP switch from real mode to protected mode. We don't get issue, because Runtime memory is in BIN, and most platform allocates BIN under 4G. Some thought: 1) I am think we not sure

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Tian, Hot
I guess https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes is also for future release notes. Seems it's not listed on https://github.com/tianocore/tianocore.github.io/wiki/EDK-II. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Tian, Hot
Hi Laszlo, You can find the permanent release notes on https://github.com/tianocore/tianocore.github.io/wiki/EDK-II: Under Stable Tags session: https://github.com/tianocore/edk2/releases/tag/edk2-stable201811 https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning is for

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Laszlo Ersek
On 03/08/19 09:52, Laszlo Ersek wrote: > On 03/08/19 07:41, Gao, Liming wrote: >> This is to fix the security issue. I agree it is an import bug fix. I am OK >> to push it for edk2-stable201903 tag > > Me too. > > If we had stable *branches* (as opposed to just stable tags), then we > wouldn't

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Wang, Jian J
> On 03/08/19 10:07, Wang, Jian J wrote: > > Pushed at c2c4b919caa297fbe83f02b897c125b87eb1fd58 > > > > Regards, > > Jian > > (I didn't ignore the fixup patch, I was just busy with something else.) > I know you won't. Just someone was pushing me behind... Jian > Thanks for this! > Laszlo

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Laszlo Ersek
On 03/08/19 10:07, Wang, Jian J wrote: > Pushed at c2c4b919caa297fbe83f02b897c125b87eb1fd58 > > Regards, > Jian (I didn't ignore the fixup patch, I was just busy with something else.) Thanks for this! Laszlo ___ edk2-devel mailing list

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

2019-03-08 Thread Laszlo Ersek
On 03/08/19 03:14, Rebecca Cran via edk2-devel wrote: > The current servers listed appear to be unusable. I suspect most > people will get correct DNS servers via DHCP, but the defaults > should work for anyone. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Rebecca

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Wang, Jian J
Pushed at c2c4b919caa297fbe83f02b897c125b87eb1fd58 Regards, Jian > -Original Message- > From: Zhang, Chao B > Sent: Friday, March 08, 2019 4:58 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > zh...@ml01.01.org > Subject: RE: [edk2] [PATCH]

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Laszlo Ersek
Hi Liming, On 03/01/19 09:57, Gao, Liming wrote: > Hi, all > Today, we enter into Hard Feature Freeze phase until edk2-stable201903 tag > is created at 2019-03-08. In this phase, there is no feature to be pushed. > The bug fix is still allowed. I meant to ask you about permanent links to

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Zhang, Chao B
HI Jian: Tks for the fix. Reviewed-by: Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Friday, March 8, 2019 4:56 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen ; Zhang, Chao B ;

[edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Jian J Wang
The BOM was introduced by commit 6c05b958df532345a35b418b05effcf7fd51fc4e accidentally. Cc: Yao Jiewen Cc: Zhang, Chao B Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

2019-03-08 Thread Zhang, Chao B
HI Laszlo: Thanks for catching this. Sorry about the inconvenience. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, March 8, 2019 4:02 PM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Gao, Liming Subject: Re: [edk2] [Patch]

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Laszlo Ersek
On 03/08/19 07:41, Gao, Liming wrote: > This is to fix the security issue. I agree it is an import bug fix. I am OK > to push it for edk2-stable201903 tag Me too. If we had stable *branches* (as opposed to just stable tags), then we wouldn't have to delay the stable tag (the release) -- we'd

Re: [edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

2019-03-08 Thread Laszlo Ersek
On 03/08/19 03:56, Zhang, Chao B wrote: > Cc: Yao Jiewen > Cc: Jian Wang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhang, Chao B > --- > Maintainers.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Laszlo Ersek
Hi Andrew, On 03/07/19 23:37, Andrew Fish via edk2-devel wrote: > I'm trying to understand why gdtPtr.Base is casting to (UINT32)? > 1) gdtPtr.Base is a a UINTN > 2) It is legal for AllocateRuntimePool() to return an address > 4GB > > It seems like the code should just cast to (UINTN)? > > >